[{"id":1525,"web_url":"https://patchwork.libcamera.org/comment/1525/","msgid":"<20190428120007.GB12066@pendragon.ideasonboard.com>","date":"2019-04-28T12:00:07","subject":"Re: [libcamera-devel] [PATCH] Documentation: Drop install directive\n\tfor Doxyfile","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Sun, Apr 28, 2019 at 01:57:00PM +0200, Niklas Söderlund wrote:\n> Building the documentation reports warnings,\n> \n> WARNING: Project targetting '>= 0.40' but tried to use feature introduced in '0.50.0': install arg in configure_file\n> WARNING: Project specifies a minimum meson_version '>= 0.40' but uses features which were added in newer versions:\n>  * 0.50.0: {'install arg in configure_file'}\n> \n> Due to the usage of the directive configure_file { install: false } in\n> Documentation/meason.build which is introduced in meson 0.50. As we do\n> not wish to install the Doxyfile no install_dir is set so there is no\n> need to explicitly state that it should not be installed. Silence the\n> warning by dropping the install directive.\n> \n> Fixes: 53c4d4c34fc49b95 (\"Documentation: Generate source code documentation using Doxygen\")\n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  Documentation/meson.build | 3 +--\n>  1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/Documentation/meson.build b/Documentation/meson.build\n> index 73da25b848cc0bf3..12a99307c741537e 100644\n> --- a/Documentation/meson.build\n> +++ b/Documentation/meson.build\n> @@ -14,8 +14,7 @@ if doxygen.found()\n>  \n>      doxyfile = configure_file(input: 'Doxyfile.in',\n>                                output: 'Doxyfile',\n> -                              configuration: cdata,\n> -                              install: false)\n> +                              configuration: cdata)\n>  \n>      custom_target('doxygen',\n>                    input: [","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7739F600EC\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Apr 2019 14:00:19 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(net-37-182-44-227.cust.vodafonedsl.it [37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E80A82D1;\n\tSun, 28 Apr 2019 14:00:18 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556452819;\n\tbh=96mHiVkoGqEhu7J/d15iQrntY1dvCy1e08rYnOCHSrw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=T8sXYbXPzFFab9GsIu7IsevnWPzSzMsT2pSECqoPu4yGBGe9tITL9oy4vEobhn3xc\n\tKcJNf5VR84I+o3bdOy2/gdK+ujd0IFs4P3Bj/prN3CMU8pAcEnBI3bJI69N/GRDamL\n\t78W+j4lAz+q82Eog1nSR0UYNXwaz4dnI/66xtobs=","Date":"Sun, 28 Apr 2019 15:00:07 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Niklas =?utf-8?q?S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190428120007.GB12066@pendragon.ideasonboard.com>","References":"<20190428115700.21551-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190428115700.21551-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] Documentation: Drop install directive\n\tfor Doxyfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 28 Apr 2019 12:00:19 -0000"}},{"id":1526,"web_url":"https://patchwork.libcamera.org/comment/1526/","msgid":"<20190428124153.GJ16573@bigcity.dyn.berto.se>","date":"2019-04-28T12:41:53","subject":"Re: [libcamera-devel] [PATCH] Documentation: Drop install directive\n\tfor Doxyfile","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Pushed to master.\n\nOn 2019-04-28 13:57:00 +0200, Niklas Söderlund wrote:\n> Building the documentation reports warnings,\n> \n> WARNING: Project targetting '>= 0.40' but tried to use feature introduced in '0.50.0': install arg in configure_file\n> WARNING: Project specifies a minimum meson_version '>= 0.40' but uses features which were added in newer versions:\n>  * 0.50.0: {'install arg in configure_file'}\n> \n> Due to the usage of the directive configure_file { install: false } in\n> Documentation/meason.build which is introduced in meson 0.50. As we do\n> not wish to install the Doxyfile no install_dir is set so there is no\n> need to explicitly state that it should not be installed. Silence the\n> warning by dropping the install directive.\n> \n> Fixes: 53c4d4c34fc49b95 (\"Documentation: Generate source code documentation using Doxygen\")\n> Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n> ---\n>  Documentation/meson.build | 3 +--\n>  1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/Documentation/meson.build b/Documentation/meson.build\n> index 73da25b848cc0bf3..12a99307c741537e 100644\n> --- a/Documentation/meson.build\n> +++ b/Documentation/meson.build\n> @@ -14,8 +14,7 @@ if doxygen.found()\n>  \n>      doxyfile = configure_file(input: 'Doxyfile.in',\n>                                output: 'Doxyfile',\n> -                              configuration: cdata,\n> -                              install: false)\n> +                              configuration: cdata)\n>  \n>      custom_target('doxygen',\n>                    input: [\n> -- \n> 2.21.0\n>","headers":{"Return-Path":"<niklas.soderlund@ragnatech.se>","Received":["from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DDC9600EA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Apr 2019 14:41:56 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id t11so5733524lfl.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 28 Apr 2019 05:41:56 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\td5sm1251542lfn.36.2019.04.28.05.41.53\n\tfor <libcamera-devel@lists.libcamera.org>\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 28 Apr 2019 05:41:54 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=6mz+unu5cEKxCnprwEOaFji6ocxCi3ME77q1GE/j1Yc=;\n\tb=gQNSMnEPxB5RIUiYw+j3C+3OcFf1ISSx0N6xUYA1R8NSTvq3ALniVP5/FC2Jc6Rd2D\n\tlhErWoEMBp2NMa++8Yc2XI77u6LyK3t5vCN0/0zWm5deJ741KkeesmTvSIPpY6PkvryC\n\thhVrUud8ER3m10Wn7FRZAZYyoLJvvegJ6KGJAU+eXsVvtbN0qEnRzX7vU4Q30R6N5uTo\n\tnNicrSpxohsEcKJA0vlhgDDAbnAMQPkWBW9uDQWibO05AednpnadkLUxvr9U6YFRU1Yx\n\tyFobTEcFzd2eOUhb6pLVvQcnOnohbXnN0xTnJ8U9KFGfs3yWxflCCTo+bLOB/0/rbWUx\n\tf2Bg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=6mz+unu5cEKxCnprwEOaFji6ocxCi3ME77q1GE/j1Yc=;\n\tb=ZjHKaGZHH4AyWnCofFI6wIv/hVIY4ix8X54J8bi7y+uRulzICobORESK2awihzSJSb\n\t2UCZFrJtv2hvYzqAxK3cvSC3YzIKgRGJo/dPhfFztUBrH8bqVUmwC/nDAaNcjznXZJMy\n\tI4xn4mTAp43zUXWKw5C16oJHtrLJzhUSrfi4GW9C0Bn+RaHCWGm0i3+I1AvoJaJoL9Zm\n\tcVloMtBgkHfjFVcqKh2YO5o0d/hkp491D4zPsMjYOClXecQGqjvz8sH77RDzu8bsl2xg\n\tHcRkSF3UTyvNDH9TFevqUE0SxT5+X6roKsjvFiyhYaK0OA/9niV2sBs734yClY3Nf3l6\n\tR+Jw==","X-Gm-Message-State":"APjAAAXB+3B/T8SiH9ayqqLhLS5G0ngVcbCCMnuGCKFzP8RSRO8N+lXg\n\tuJZvrQPgla2E9I026yyK5J8AxBfV3p4=","X-Google-Smtp-Source":"APXvYqyo7+dsM2pe5sih3X9/F5PpSQSqGP1XRC91Qj+cWWUVT5mFokCm15eEKGbk5cGAeuHZGjqBUA==","X-Received":"by 2002:a19:f50f:: with SMTP id\n\tj15mr30749592lfb.135.1556455315455; \n\tSun, 28 Apr 2019 05:41:55 -0700 (PDT)","Date":"Sun, 28 Apr 2019 14:41:53 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190428124153.GJ16573@bigcity.dyn.berto.se>","References":"<20190428115700.21551-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190428115700.21551-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH] Documentation: Drop install directive\n\tfor Doxyfile","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sun, 28 Apr 2019 12:41:56 -0000"}}]