[{"id":15153,"web_url":"https://patchwork.libcamera.org/comment/15153/","msgid":"<24fcc2c5-373a-5238-1f1e-5371809567c6@ideasonboard.com>","date":"2021-02-12T15:36:36","subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi JM,\n\nOn 09/02/2021 15:03, Jean-Michel Hautbois wrote:\n> Setting a default EXPOSURE and ANALOGUE_GAIN makes sense for the first\n> frame but there is no need to force it for all frames.\n> It will be called later by the 3A algorithms.\n> \n> Signed-off-by: Jean-Michel Hautbois \n> ---\n> src/ipa/ipu3/ipu3.cpp | 3 ---\n> 1 file changed, 3 deletions(-)\n> \n> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> index b11b03ef..ae7e8c0b 100644\n> --- a/src/ipa/ipu3/ipu3.cpp\n> +++ b/src/ipa/ipu3/ipu3.cpp\n> @@ -188,9 +188,6 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n> \top.operation = IPU3_IPA_ACTION_PARAM_FILLED;\n> \n> \tqueueFrameAction.emit(frame, op);\n> -\n> -\t/* \\todo Calculate new values for exposure_ and gain_. */\n> -\tsetControls(frame);\n\nDoes this leave the setControls() function unused? I wonder if it should\nbe removed in that case.\n\nI hear that this patch is anticipated to be able to stop the exposure\nbeing set to max, without any means of setting it so I'm not opposed to\nthis going in as a fix anyway.\n\nEspecially as this will all change soon enough with your other work on top.\n\nReviewed-by: Kieran Bingham \n\n> }\n> \n> void IPAIPU3::parseStatistics(unsigned int frame,\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C3C3BD162\n\tfor ;\n\tFri, 12 Feb 2021 15:36:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91D1463790;\n\tFri, 12 Feb 2021 16:36:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3ADB863781\n\tfor ;\n\tFri, 12 Feb 2021 16:36:40 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B035471;\n\tFri, 12 Feb 2021 16:36:39 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FPGlDPcj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613144199;\n\tbh=dgD0UoPkRTMuRuaXqCONPnKulrjx5KiBRfeBezUpYqw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=FPGlDPcjJUupYdIqCjC7HJs9oYaZT9PSMD6IEzmdefbED2PqTWwvE7qmNdmSwcxuM\n\t+ItF5yZYL8I2F0ej2o/BZysd6uN1q9Y/grm7+sif9Os0tQ+VhY/tN5WYKi9hlUZtgK\n\t1tmGwPIyhPJGtCkdZ62qyaR/ysUkXSJ6ydqe3m+w=","To":"Jean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210209150335.26773-1-jeanmichel.hautbois@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<24fcc2c5-373a-5238-1f1e-5371809567c6@ideasonboard.com>","Date":"Fri, 12 Feb 2021 15:36:36 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210209150335.26773-1-jeanmichel.hautbois@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15154,"web_url":"https://patchwork.libcamera.org/comment/15154/","msgid":"","date":"2021-02-12T15:48:37","subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Feb 12, 2021 at 03:36:36PM +0000, Kieran Bingham wrote:\n> On 09/02/2021 15:03, Jean-Michel Hautbois wrote:\n> > Setting a default EXPOSURE and ANALOGUE_GAIN makes sense for the first\n> > frame but there is no need to force it for all frames.\n> > It will be called later by the 3A algorithms.\n> > \n> > Signed-off-by: Jean-Michel Hautbois \n> > ---\n> > src/ipa/ipu3/ipu3.cpp | 3 ---\n> > 1 file changed, 3 deletions(-)\n> > \n> > diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> > index b11b03ef..ae7e8c0b 100644\n> > --- a/src/ipa/ipu3/ipu3.cpp\n> > +++ b/src/ipa/ipu3/ipu3.cpp\n> > @@ -188,9 +188,6 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n> > \top.operation = IPU3_IPA_ACTION_PARAM_FILLED;\n> > \n> > \tqueueFrameAction.emit(frame, op);\n> > -\n> > -\t/* \\todo Calculate new values for exposure_ and gain_. */\n> > -\tsetControls(frame);\n> \n> Does this leave the setControls() function unused? I wonder if it should\n> be removed in that case.\n> \n> I hear that this patch is anticipated to be able to stop the exposure\n> being set to max, without any means of setting it so I'm not opposed to\n> this going in as a fix anyway.\n> \n> Especially as this will all change soon enough with your other work on top.\n\nDepending on how \"soon\" that would be, we could also implement support\nfor controls::Exposure right away, so that it could be set from\napplications. This shouldn't take long, but we would however need to\nalso implement support for controls in qcam and cam, and that part is a\nbigger piece of work. Probably not the priority right now, so this patch\nshould be fine.\n\n> Reviewed-by: Kieran Bingham \n> \n> > }\n> > \n> > void IPAIPU3::parseStatistics(unsigned int frame,\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE638BD160\n\tfor ;\n\tFri, 12 Feb 2021 15:49:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3123C63794;\n\tFri, 12 Feb 2021 16:49:05 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D773163781\n\tfor ;\n\tFri, 12 Feb 2021 16:49:03 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3DBA371;\n\tFri, 12 Feb 2021 16:49:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KKoCV7c3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613144943;\n\tbh=2rSUHszFxDfAl+g3Hc1GHCenlsuLZ6hSCxoAoADz/f8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=KKoCV7c3FICw7Ugkfr1JCFx+rVjESlqLJKFRvR0UzOr9hrhcW3L4dkh4Xcm76TN30\n\teqMCtuRfsyxikg9melZTQfi/RanRF1ZG4BX8bQ2IJ3srcZX94hPlm0XVPJ1tKVWQyD\n\t4WvG/Z3xYMDDtAAPrBVsOOa1fvWitm2K0NrnDt6M=","Date":"Fri, 12 Feb 2021 17:48:37 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210209150335.26773-1-jeanmichel.hautbois@ideasonboard.com>\n\t<24fcc2c5-373a-5238-1f1e-5371809567c6@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<24fcc2c5-373a-5238-1f1e-5371809567c6@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15155,"web_url":"https://patchwork.libcamera.org/comment/15155/","msgid":"","date":"2021-02-12T15:59:01","subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Kieran,\n\nOn 12/02/2021 16:36, Kieran Bingham wrote:\n> Hi JM,\n> \n> On 09/02/2021 15:03, Jean-Michel Hautbois wrote:\n>> Setting a default EXPOSURE and ANALOGUE_GAIN makes sense for the first\n>> frame but there is no need to force it for all frames.\n>> It will be called later by the 3A algorithms.\n>>\n>> Signed-off-by: Jean-Michel Hautbois \n>> ---\n>> src/ipa/ipu3/ipu3.cpp | 3 ---\n>> 1 file changed, 3 deletions(-)\n>>\n>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>> index b11b03ef..ae7e8c0b 100644\n>> --- a/src/ipa/ipu3/ipu3.cpp\n>> +++ b/src/ipa/ipu3/ipu3.cpp\n>> @@ -188,9 +188,6 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n>> \top.operation = IPU3_IPA_ACTION_PARAM_FILLED;\n>> \n>> \tqueueFrameAction.emit(frame, op);\n>> -\n>> -\t/* \\todo Calculate new values for exposure_ and gain_. */\n>> -\tsetControls(frame);\n> \n> Does this leave the setControls() function unused? I wonder if it should\n> be removed in that case.\n\nIt is still called at configure()...\n\n> I hear that this patch is anticipated to be able to stop the exposure\n> being set to max, without any means of setting it so I'm not opposed to\n> this going in as a fix anyway.\n\nWell, Laurent pointed that we could implement support for\ncontrols::Exposure and it would definitely be better, but I can't find\nenough time for it this week :-/.\n\n> Especially as this will all change soon enough with your other work on top.\n> \n> Reviewed-by: Kieran Bingham \n> \n>> }\n>> \n>> void IPAIPU3::parseStatistics(unsigned int frame,\n>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48BC9BD162\n\tfor ;\n\tFri, 12 Feb 2021 15:59:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C28AD63792;\n\tFri, 12 Feb 2021 16:59:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 868E663781\n\tfor ;\n\tFri, 12 Feb 2021 16:59:02 +0100 (CET)","from [IPv6:2a01:e0a:169:7140:4c8b:e37:8e78:b4b6] (unknown\n\t[IPv6:2a01:e0a:169:7140:4c8b:e37:8e78:b4b6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B4BD71;\n\tFri, 12 Feb 2021 16:59:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EKUsjcWg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613145542;\n\tbh=rd5RgpbkKpRDKfzJ2kO2Gre5bYYciExjya1noKv0SRg=;\n\th=Subject:To:References:From:Date:In-Reply-To:From;\n\tb=EKUsjcWgc+RXjJjjZlGDPNczucxWrG3yLF1D0aD85KysrXBejlM+x5lqyJ9OHizXK\n\tp8xIqqX7C+fJUMdU4ev/laMkydNqOD32dnsA7GcwRRDhmozesOvHiVdhSpkX7I2+a7\n\ty+p9EvDz4GOua6mRGtAXpPMyyhzuUIcRUzljh2jE=","To":"kieran.bingham@ideasonboard.com,\n\tJean-Michel Hautbois ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210209150335.26773-1-jeanmichel.hautbois@ideasonboard.com>\n\t<24fcc2c5-373a-5238-1f1e-5371809567c6@ideasonboard.com>","From":"Jean-Michel Hautbois ","Message-ID":"","Date":"Fri, 12 Feb 2021 16:59:01 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.6.1","MIME-Version":"1.0","In-Reply-To":"<24fcc2c5-373a-5238-1f1e-5371809567c6@ideasonboard.com>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15157,"web_url":"https://patchwork.libcamera.org/comment/15157/","msgid":"","date":"2021-02-12T16:50:53","subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nOn Fri, Feb 12, 2021 at 04:59:01PM +0100, Jean-Michel Hautbois wrote:\n> On 12/02/2021 16:36, Kieran Bingham wrote:\n> > On 09/02/2021 15:03, Jean-Michel Hautbois wrote:\n> >> Setting a default EXPOSURE and ANALOGUE_GAIN makes sense for the first\n> >> frame but there is no need to force it for all frames.\n> >> It will be called later by the 3A algorithms.\n> >>\n> >> Signed-off-by: Jean-Michel Hautbois \n> >> ---\n> >> src/ipa/ipu3/ipu3.cpp | 3 ---\n> >> 1 file changed, 3 deletions(-)\n> >>\n> >> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n> >> index b11b03ef..ae7e8c0b 100644\n> >> --- a/src/ipa/ipu3/ipu3.cpp\n> >> +++ b/src/ipa/ipu3/ipu3.cpp\n> >> @@ -188,9 +188,6 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n> >> \top.operation = IPU3_IPA_ACTION_PARAM_FILLED;\n> >> \n> >> \tqueueFrameAction.emit(frame, op);\n> >> -\n> >> -\t/* \\todo Calculate new values for exposure_ and gain_. */\n> >> -\tsetControls(frame);\n> > \n> > Does this leave the setControls() function unused? I wonder if it should\n> > be removed in that case.\n> \n> It is still called at configure()...\n> \n> > I hear that this patch is anticipated to be able to stop the exposure\n> > being set to max, without any means of setting it so I'm not opposed to\n> > this going in as a fix anyway.\n> \n> Well, Laurent pointed that we could implement support for\n> controls::Exposure and it would definitely be better, but I can't find\n> enough time for it this week :-/.\n\nFor the record, I'm fine with this patch as a very short term interim\nmeasure.\n\n> > Especially as this will all change soon enough with your other work on top.\n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> >> }\n> >> \n> >> void IPAIPU3::parseStatistics(unsigned int frame,\n> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0904DBD162\n\tfor ;\n\tFri, 12 Feb 2021 16:51:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 63EA463796;\n\tFri, 12 Feb 2021 17:51:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B3D9963781\n\tfor ;\n\tFri, 12 Feb 2021 17:51:19 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 09EFF71;\n\tFri, 12 Feb 2021 17:51:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C1lG3/zD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613148679;\n\tbh=KzgjD1Aj0opUpTeN+a1Sk1l1UowQmRHlqS0q1j03S5Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=C1lG3/zDZGKdKHp0waFeWJfL5Y2uyg+dGf98BItUvc42989bDf5tgAMoSz0+dy7tU\n\tpQhrez9DAE4VCvjD2c3xgdH46Nlh2dpZSsyOXZfP77hNC+mmlcrCCiDo+JBMtnqZNt\n\tVFnsDkDywE7eku+uytMHSqoSzrg/mPL2AsLSjTfI=","Date":"Fri, 12 Feb 2021 18:50:53 +0200","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210209150335.26773-1-jeanmichel.hautbois@ideasonboard.com>\n\t<24fcc2c5-373a-5238-1f1e-5371809567c6@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15158,"web_url":"https://patchwork.libcamera.org/comment/15158/","msgid":"","date":"2021-02-12T17:06:06","subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 12/02/2021 17:50, Laurent Pinchart wrote:\n> Hi Jean-Michel,\n> \n> On Fri, Feb 12, 2021 at 04:59:01PM +0100, Jean-Michel Hautbois wrote:\n>> On 12/02/2021 16:36, Kieran Bingham wrote:\n>>> On 09/02/2021 15:03, Jean-Michel Hautbois wrote:\n>>>> Setting a default EXPOSURE and ANALOGUE_GAIN makes sense for the first\n>>>> frame but there is no need to force it for all frames.\n>>>> It will be called later by the 3A algorithms.\n>>>>\n>>>> Signed-off-by: Jean-Michel Hautbois \n>>>> ---\n>>>> src/ipa/ipu3/ipu3.cpp | 3 ---\n>>>> 1 file changed, 3 deletions(-)\n>>>>\n>>>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>>>> index b11b03ef..ae7e8c0b 100644\n>>>> --- a/src/ipa/ipu3/ipu3.cpp\n>>>> +++ b/src/ipa/ipu3/ipu3.cpp\n>>>> @@ -188,9 +188,6 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n>>>> \top.operation = IPU3_IPA_ACTION_PARAM_FILLED;\n>>>> \n>>>> \tqueueFrameAction.emit(frame, op);\n>>>> -\n>>>> -\t/* \\todo Calculate new values for exposure_ and gain_. */\n>>>> -\tsetControls(frame);\n>>>\n>>> Does this leave the setControls() function unused? I wonder if it should\n>>> be removed in that case.\n>>\n>> It is still called at configure()...\n>>\n>>> I hear that this patch is anticipated to be able to stop the exposure\n>>> being set to max, without any means of setting it so I'm not opposed to\n>>> this going in as a fix anyway.\n>>\n>> Well, Laurent pointed that we could implement support for\n>> controls::Exposure and it would definitely be better, but I can't find\n>> enough time for it this week :-/.\n> \n> For the record, I'm fine with this patch as a very short term interim\n> measure.\n\nI can push a v2 with a default value instead of the max value if you\nprefer too ?","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9EBBCBD160\n\tfor ;\n\tFri, 12 Feb 2021 17:06:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CA7A63799;\n\tFri, 12 Feb 2021 18:06:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6039463781\n\tfor ;\n\tFri, 12 Feb 2021 18:06:07 +0100 (CET)","from [IPv6:2a01:e0a:169:7140:4c8b:e37:8e78:b4b6] (unknown\n\t[IPv6:2a01:e0a:169:7140:4c8b:e37:8e78:b4b6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6A2571;\n\tFri, 12 Feb 2021 18:06:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l46+DcCN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613149566;\n\tbh=effW0UkMIMhZV0tGSPXARJ2ZPuFFzrP4utZg1X9+jOE=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=l46+DcCNxcVZTsbTfetZDbwNORGfSsN+qKedrYjQd7WqsI1ykv1in6vKI0cS+fmh8\n\tWmgdztFeKNLZuRPBHR58KDw9b8G8c7uIFZ9HOC4QIsNFJJeE+lA1OuKoDRSOZZ1VXY\n\tVPXgnhPN48xIO33SnrSmp2ku64GjxaDuRqZEdj/Q=","To":"Laurent Pinchart ,\n\tJean-Michel Hautbois ","References":"<20210209150335.26773-1-jeanmichel.hautbois@ideasonboard.com>\n\t<24fcc2c5-373a-5238-1f1e-5371809567c6@ideasonboard.com>\n\t\n\t","From":"Jean-Michel Hautbois ","Message-ID":"","Date":"Fri, 12 Feb 2021 18:06:06 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.6.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15159,"web_url":"https://patchwork.libcamera.org/comment/15159/","msgid":"<9406ab90-74de-a5e6-3dcc-c46a76eae425@ideasonboard.com>","date":"2021-02-12T17:06:04","subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 12/02/2021 16:50, Laurent Pinchart wrote:\n> Hi Jean-Michel,\n> \n> On Fri, Feb 12, 2021 at 04:59:01PM +0100, Jean-Michel Hautbois wrote:\n>> On 12/02/2021 16:36, Kieran Bingham wrote:\n>>> On 09/02/2021 15:03, Jean-Michel Hautbois wrote:\n>>>> Setting a default EXPOSURE and ANALOGUE_GAIN makes sense for the first\n>>>> frame but there is no need to force it for all frames.\n>>>> It will be called later by the 3A algorithms.\n>>>>\n>>>> Signed-off-by: Jean-Michel Hautbois \n>>>> ---\n>>>> src/ipa/ipu3/ipu3.cpp | 3 ---\n>>>> 1 file changed, 3 deletions(-)\n>>>>\n>>>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp\n>>>> index b11b03ef..ae7e8c0b 100644\n>>>> --- a/src/ipa/ipu3/ipu3.cpp\n>>>> +++ b/src/ipa/ipu3/ipu3.cpp\n>>>> @@ -188,9 +188,6 @@ void IPAIPU3::fillParams(unsigned int frame, ipu3_uapi_params *params)\n>>>> \top.operation = IPU3_IPA_ACTION_PARAM_FILLED;\n>>>> \n>>>> \tqueueFrameAction.emit(frame, op);\n>>>> -\n>>>> -\t/* \\todo Calculate new values for exposure_ and gain_. */\n>>>> -\tsetControls(frame);\n>>>\n>>> Does this leave the setControls() function unused? I wonder if it should\n>>> be removed in that case.\n>>\n>> It is still called at configure()...\n>>\n>>> I hear that this patch is anticipated to be able to stop the exposure\n>>> being set to max, without any means of setting it so I'm not opposed to\n>>> this going in as a fix anyway.\n>>\n>> Well, Laurent pointed that we could implement support for\n>> controls::Exposure and it would definitely be better, but I can't find\n>> enough time for it this week :-/.\n> \n> For the record, I'm fine with this patch as a very short term interim\n> measure.\n\nI'll push this soon then, as even when we have IPA patches posted on\ntop, we'll expect more time for review cycles etc, so this can fill the\ngap for a couple of weeks, as I'm aware it may be affecting current\ndevelopers working on sensor drivers attached to the IPU3.\n\n--\nKieran\n\n\n>>> Especially as this will all change soon enough with your other work on top.\n>>>\n>>> Reviewed-by: Kieran Bingham \n>>>\n>>>> }\n>>>> \n>>>> void IPAIPU3::parseStatistics(unsigned int frame,\n>>>>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D51E8BD160\n\tfor ;\n\tFri, 12 Feb 2021 17:06:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A26366379C;\n\tFri, 12 Feb 2021 18:06:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DFD0D63781\n\tfor ;\n\tFri, 12 Feb 2021 18:06:07 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5FBCAA49;\n\tFri, 12 Feb 2021 18:06:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WuXOf32j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613149567;\n\tbh=Jep9plIb9TEuHFZqqi9l2Sr99imWJ9P+jolFj3T8QxY=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=WuXOf32jB2VyxraelrZdJrjqeSR3IYwGiwWE6a58kd15HJHVGazU0wMuI2CNmyf0R\n\twXrrGnnvl6HK35emxIrEyTNBAXtq/ogmj5BztqApc6zpZUubsU9zx0phTmwHwNYYCc\n\tIFZNf0j7hutTrR4sN1VDNrhJZSUy0Uy/b40vdSq4=","To":"Laurent Pinchart ,\n\tJean-Michel Hautbois ","References":"<20210209150335.26773-1-jeanmichel.hautbois@ideasonboard.com>\n\t<24fcc2c5-373a-5238-1f1e-5371809567c6@ideasonboard.com>\n\t\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<9406ab90-74de-a5e6-3dcc-c46a76eae425@ideasonboard.com>","Date":"Fri, 12 Feb 2021 17:06:04 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] ipa: ipu3: Don't call SetControls for\n\teach frame","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]