[{"id":15086,"web_url":"https://patchwork.libcamera.org/comment/15086/","msgid":"<20210210174302.4qladnz3kynhcvfp@uno.localdomain>","date":"2021-02-10T17:43:02","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Jean-Michel\n\nOn Tue, Feb 09, 2021 at 03:52:44PM +0100, Jean-Michel Hautbois wrote:\n> In order to get the stats back, the imgu subdev needs to have the\n> V4L2_CID_INTEL_IPU3_MODE control set.\n> Set it to video mode by default to get the stats at each frame.\n>\n> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n> ---\n>  src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n>  1 file changed, 1 insertion(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 61f7bf43..104cb532 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -552,8 +552,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n>  \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n>  \tControlList ctrls(imgu->imgu_->controls());\n>  \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n> -\t\t  static_cast<int32_t>(vfCfg ? IPU3PipeModeVideo :\n> -\t\t\t\t       IPU3PipeModeStillCapture));\n> +\t\t  static_cast<int32_t>(IPU3PipeModeVideo));\n\nI'm not opposed to this, and know we got to know what effect the pipe\nmode has, at least on statistics generation.\n\nI wonder what other features the StillCapture mode provides.\nCould you record with a todo that the usage of the pipe mode has to be\nclarified ?\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nThanks\n  j\n>  \tret = imgu->imgu_->setControls(&ctrls);\n>  \tif (ret) {\n>  \t\tLOG(IPU3, Error) << \"Unable to set pipe_mode control\";\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FDF3BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Feb 2021 17:42:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B120E61630;\n\tWed, 10 Feb 2021 18:42:39 +0100 (CET)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6B051602FE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Feb 2021 18:42:38 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D7962E0004;\n\tWed, 10 Feb 2021 17:42:37 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 10 Feb 2021 18:43:02 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","Message-ID":"<20210210174302.4qladnz3kynhcvfp@uno.localdomain>","References":"<20210209145244.25408-1-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210209145244.25408-1-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":15087,"web_url":"https://patchwork.libcamera.org/comment/15087/","msgid":"<b4fa3471-0cb9-3f1c-678a-c41afdb50c12@ideasonboard.com>","date":"2021-02-10T19:48:15","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Jacopo !\n\nOn 10/02/2021 18:43, Jacopo Mondi wrote:\n> Hi Jean-Michel\n> \n> On Tue, Feb 09, 2021 at 03:52:44PM +0100, Jean-Michel Hautbois wrote:\n>> In order to get the stats back, the imgu subdev needs to have the\n>> V4L2_CID_INTEL_IPU3_MODE control set.\n>> Set it to video mode by default to get the stats at each frame.\n>>\n>> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n>> ---\n>>  src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n>>  1 file changed, 1 insertion(+), 2 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> index 61f7bf43..104cb532 100644\n>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>> @@ -552,8 +552,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n>>  \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n>>  \tControlList ctrls(imgu->imgu_->controls());\n>>  \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n>> -\t\t  static_cast<int32_t>(vfCfg ? IPU3PipeModeVideo :\n>> -\t\t\t\t       IPU3PipeModeStillCapture));\n>> +\t\t  static_cast<int32_t>(IPU3PipeModeVideo));\n> \n> I'm not opposed to this, and know we got to know what effect the pipe\n> mode has, at least on statistics generation.\n> \n> I wonder what other features the StillCapture mode provides.\n> Could you record with a todo that the usage of the pipe mode has to be\n> clarified ?\n\nI don't know if we can know more than what is already in the kernel\ndocumentation ?\nhttps://linuxtv.org/downloads/v4l-dvb-apis/admin-guide/ipu3.html#running-mode-and-firmware-binary-selection\n\nI can add a TODO, in a v2 ?\n\n> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>\nThanks for that ;-).\n\n> \n> Thanks\n>   j\n>>  \tret = imgu->imgu_->setControls(&ctrls);\n>>  \tif (ret) {\n>>  \t\tLOG(IPU3, Error) << \"Unable to set pipe_mode control\";\n>> --\n>> 2.27.0\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9EF92BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 10 Feb 2021 19:48:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E04FA61634;\n\tWed, 10 Feb 2021 20:48:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A98B0602FE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 10 Feb 2021 20:48:16 +0100 (CET)","from [IPv6:2a01:e0a:169:7140:f474:9b0d:16d1:1514] (unknown\n\t[IPv6:2a01:e0a:169:7140:f474:9b0d:16d1:1514])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 43562DD;\n\tWed, 10 Feb 2021 20:48:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hYW4QjuY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612986496;\n\tbh=LgtzLEC7/Pu0mhu7BAgBZL0AWbiQEucd7JZ9bbgpPSM=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=hYW4QjuYg/nBn6NFu5ofxutsPRJIHKB2EU4KwG/T7+zVsLFH38737RYHrsjuqF/64\n\t1s5ns9+jq9zwAN/JauLzd6C0GXLwLk2qWohecQLmnPQwfh6SKPyGEMiZ5204QbpQvd\n\t+nCePS1RPk+p6Il6DS2uEACIh/4KftysM5Gz4Xmc=","To":"Jacopo Mondi <jacopo@jmondi.org>,\n\tJean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","References":"<20210209145244.25408-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210210174302.4qladnz3kynhcvfp@uno.localdomain>","From":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","Message-ID":"<b4fa3471-0cb9-3f1c-678a-c41afdb50c12@ideasonboard.com>","Date":"Wed, 10 Feb 2021 20:48:15 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.6.1","MIME-Version":"1.0","In-Reply-To":"<20210210174302.4qladnz3kynhcvfp@uno.localdomain>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":15142,"web_url":"https://patchwork.libcamera.org/comment/15142/","msgid":"<20210212125428.ob4kzqug7bkdevat@uno.localdomain>","date":"2021-02-12T12:54:28","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Jean-Michel\n\nOn Wed, Feb 10, 2021 at 08:48:15PM +0100, Jean-Michel Hautbois wrote:\n> Hi Jacopo !\n>\n> On 10/02/2021 18:43, Jacopo Mondi wrote:\n> > Hi Jean-Michel\n> >\n> > On Tue, Feb 09, 2021 at 03:52:44PM +0100, Jean-Michel Hautbois wrote:\n> >> In order to get the stats back, the imgu subdev needs to have the\n> >> V4L2_CID_INTEL_IPU3_MODE control set.\n> >> Set it to video mode by default to get the stats at each frame.\n> >>\n> >> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n> >> ---\n> >>  src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n> >>  1 file changed, 1 insertion(+), 2 deletions(-)\n> >>\n> >> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> >> index 61f7bf43..104cb532 100644\n> >> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> >> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> >> @@ -552,8 +552,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n> >>  \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n> >>  \tControlList ctrls(imgu->imgu_->controls());\n> >>  \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n> >> -\t\t  static_cast<int32_t>(vfCfg ? IPU3PipeModeVideo :\n> >> -\t\t\t\t       IPU3PipeModeStillCapture));\n> >> +\t\t  static_cast<int32_t>(IPU3PipeModeVideo));\n> >\n> > I'm not opposed to this, and know we got to know what effect the pipe\n> > mode has, at least on statistics generation.\n> >\n> > I wonder what other features the StillCapture mode provides.\n> > Could you record with a todo that the usage of the pipe mode has to be\n> > clarified ?\n>\n> I don't know if we can know more than what is already in the kernel\n> documentation ?\n> https://linuxtv.org/downloads/v4l-dvb-apis/admin-guide/ipu3.html#running-mode-and-firmware-binary-selection\n>\n> I can add a TODO, in a v2 ?\n\nYes please, I still think we might want to use the StilCapture mode\nfor, no surprise, still capture of raw frames, which, if I'm not\nmistaken should not involve the IPA and for which we don't need\nstatistics.\n\nIf my understanding is correct, something along the lines of:\n/*\n * \\todo Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n * generated and re-consider if 'Still Capture' should be used for\n * high quality RAW capture operations that do not involve the IPA.\n */\n\n?\n\nThanks\n  j\n\n>\n> > Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n> Thanks for that ;-).\n>\n> >\n> > Thanks\n> >   j\n> >>  \tret = imgu->imgu_->setControls(&ctrls);\n> >>  \tif (ret) {\n> >>  \t\tLOG(IPU3, Error) << \"Unable to set pipe_mode control\";\n> >> --\n> >> 2.27.0\n> >>\n> >> _______________________________________________\n> >> libcamera-devel mailing list\n> >> libcamera-devel@lists.libcamera.org\n> >> https://lists.libcamera.org/listinfo/libcamera-devel\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n> >","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C6E7BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Feb 2021 12:54:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 246CE63779;\n\tFri, 12 Feb 2021 13:54:06 +0100 (CET)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 140A963772\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Feb 2021 13:54:05 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 8D5AF100004;\n\tFri, 12 Feb 2021 12:54:04 +0000 (UTC)"],"Date":"Fri, 12 Feb 2021 13:54:28 +0100","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","Message-ID":"<20210212125428.ob4kzqug7bkdevat@uno.localdomain>","References":"<20210209145244.25408-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210210174302.4qladnz3kynhcvfp@uno.localdomain>\n\t<b4fa3471-0cb9-3f1c-678a-c41afdb50c12@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<b4fa3471-0cb9-3f1c-678a-c41afdb50c12@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":15143,"web_url":"https://patchwork.libcamera.org/comment/15143/","msgid":"<8f2f3c17-2f9c-532f-d54b-b198faed8cea@ideasonboard.com>","date":"2021-02-12T13:14:38","subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 12/02/2021 13:54, Jacopo Mondi wrote:\n> Hi Jean-Michel\n> \n> On Wed, Feb 10, 2021 at 08:48:15PM +0100, Jean-Michel Hautbois wrote:\n>> Hi Jacopo !\n>>\n>> On 10/02/2021 18:43, Jacopo Mondi wrote:\n>>> Hi Jean-Michel\n>>>\n>>> On Tue, Feb 09, 2021 at 03:52:44PM +0100, Jean-Michel Hautbois wrote:\n>>>> In order to get the stats back, the imgu subdev needs to have the\n>>>> V4L2_CID_INTEL_IPU3_MODE control set.\n>>>> Set it to video mode by default to get the stats at each frame.\n>>>>\n>>>> Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>\n>>>> ---\n>>>>  src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n>>>>  1 file changed, 1 insertion(+), 2 deletions(-)\n>>>>\n>>>> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>>> index 61f7bf43..104cb532 100644\n>>>> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>>> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n>>>> @@ -552,8 +552,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n>>>>  \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n>>>>  \tControlList ctrls(imgu->imgu_->controls());\n>>>>  \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n>>>> -\t\t  static_cast<int32_t>(vfCfg ? IPU3PipeModeVideo :\n>>>> -\t\t\t\t       IPU3PipeModeStillCapture));\n>>>> +\t\t  static_cast<int32_t>(IPU3PipeModeVideo));\n>>>\n>>> I'm not opposed to this, and know we got to know what effect the pipe\n>>> mode has, at least on statistics generation.\n>>>\n>>> I wonder what other features the StillCapture mode provides.\n>>> Could you record with a todo that the usage of the pipe mode has to be\n>>> clarified ?\n>>\n>> I don't know if we can know more than what is already in the kernel\n>> documentation ?\n>> https://linuxtv.org/downloads/v4l-dvb-apis/admin-guide/ipu3.html#running-mode-and-firmware-binary-selection\n>>\n>> I can add a TODO, in a v2 ?\n> \n> Yes please, I still think we might want to use the StilCapture mode\n> for, no surprise, still capture of raw frames, which, if I'm not\n> mistaken should not involve the IPA and for which we don't need\n> statistics.\n> \n> If my understanding is correct, something along the lines of:\n> /*\n>  * \\todo Set the ImgU pipe mode to 'Video' unconditionally to have statistics\n>  * generated and re-consider if 'Still Capture' should be used for\n>  * high quality RAW capture operations that do not involve the IPA.\n>  */\n\nSounds great, v2 in a short time :-)\n\nThanks !\nJM","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5E688BD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Feb 2021 13:14:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D444363780;\n\tFri, 12 Feb 2021 14:14:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0B7CF63772\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Feb 2021 14:14:39 +0100 (CET)","from [IPv6:2a01:e0a:169:7140:4c8b:e37:8e78:b4b6] (unknown\n\t[IPv6:2a01:e0a:169:7140:4c8b:e37:8e78:b4b6])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C5028B5;\n\tFri, 12 Feb 2021 14:14:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eS++weX3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613135678;\n\tbh=J3rlreZ6Vq/+yugALiN2PimKVmvHvAjPPQWz0d/P+IE=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=eS++weX3FNLiIwqpzHondIaqkv0ZRzaPAUDB/PVFryQZwBWJGKKlBS3fXAkhb0Gff\n\trdSN/EYRJAkssELa5otVLS9y5uxzXCqF57ygq3ivJbdSiaBDJHpK+4Qa40zJK0ycZ+\n\t57NFfm4YcQyvWhvreWQ6wGRRENgNiHrT+sx2e+T0=","To":"Jacopo Mondi <jacopo@jmondi.org>,\n\tJean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","References":"<20210209145244.25408-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210210174302.4qladnz3kynhcvfp@uno.localdomain>\n\t<b4fa3471-0cb9-3f1c-678a-c41afdb50c12@ideasonboard.com>\n\t<20210212125428.ob4kzqug7bkdevat@uno.localdomain>","From":"Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>","Message-ID":"<8f2f3c17-2f9c-532f-d54b-b198faed8cea@ideasonboard.com>","Date":"Fri, 12 Feb 2021 14:14:38 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.6.1","MIME-Version":"1.0","In-Reply-To":"<20210212125428.ob4kzqug7bkdevat@uno.localdomain>","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]