{"id":11203,"url":"https://patchwork.libcamera.org/api/patches/11203/?format=json","web_url":"https://patchwork.libcamera.org/patch/11203/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210209145244.25408-1-jeanmichel.hautbois@ideasonboard.com>","date":"2021-02-09T14:52:44","name":"[libcamera-devel] libcamera: ipu3: set V4L2_CID_INTEL_IPU3_MODE","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"dfad9504f5113f9fa4e6788230c5f78f85fe2010","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/?format=json","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11203/mbox/","series":[{"id":1671,"url":"https://patchwork.libcamera.org/api/series/1671/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1671","date":"2021-02-09T14:52:44","name":"[libcamera-devel] libcamera: ipu3: set V4L2_CID_INTEL_IPU3_MODE","version":1,"mbox":"https://patchwork.libcamera.org/series/1671/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11203/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11203/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5F187BD160\n\tfor ;\n\tTue, 9 Feb 2021 14:52:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D272261628;\n\tTue, 9 Feb 2021 15:52:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7AB460D16\n\tfor ;\n\tTue, 9 Feb 2021 15:52:46 +0100 (CET)","from localhost.localdomain (unknown\n\t[IPv6:2a01:e0a:169:7140:4d26:9423:a9d1:8c4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E1B2BC0;\n\tTue, 9 Feb 2021 15:52:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YCZIaTUq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612882366;\n\tbh=L7wJeXkt0U5nDMPGriN6XMNPSLDV+n9zT/WG+OOye7w=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=YCZIaTUq0VGK0Ao4UTemCR6GaES+NPb9h7PX6oOWrVX00PG5m0+sJu565HAyJzedU\n\t6a5DPECUl706X1t3uPwv0sQaaIUYnmMB8g4hBPg4qTkYK92O0uEhD1IrsMToxVglo9\n\t24c2B4mMnLJlEL2gku8WrU/fOp21SoHbHbxsZWKg=","From":"Jean-Michel Hautbois ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 9 Feb 2021 15:52:44 +0100","Message-Id":"<20210209145244.25408-1-jeanmichel.hautbois@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] libcamera: ipu3: set\n\tV4L2_CID_INTEL_IPU3_MODE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In order to get the stats back, the imgu subdev needs to have the\nV4L2_CID_INTEL_IPU3_MODE control set.\nSet it to video mode by default to get the stats at each frame.\n\nSigned-off-by: Jean-Michel Hautbois \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 61f7bf43..104cb532 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -552,8 +552,7 @@ int PipelineHandlerIPU3::configure(Camera *camera, CameraConfiguration *c)\n \t/* Apply the \"pipe_mode\" control to the ImgU subdevice. */\n \tControlList ctrls(imgu->imgu_->controls());\n \tctrls.set(V4L2_CID_IPU3_PIPE_MODE,\n-\t\t static_cast(vfCfg ? IPU3PipeModeVideo :\n-\t\t\t\t IPU3PipeModeStillCapture));\n+\t\t static_cast(IPU3PipeModeVideo));\n \tret = imgu->imgu_->setControls(&ctrls);\n \tif (ret) {\n \t\tLOG(IPU3, Error) << \"Unable to set pipe_mode control\";\n","prefixes":["libcamera-devel"]}