[{"id":15055,"web_url":"https://patchwork.libcamera.org/comment/15055/","msgid":"","date":"2021-02-08T15:48:06","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: Remove atomic\n\tvariable from Algorithm class","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Mon, Feb 08, 2021 at 09:40:35AM +0000, David Plowman wrote:\n> Pause() and Resume() are only called synchronously so paused_ does not\n> need to be atomic.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/algorithm.hpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/algorithm.hpp b/src/ipa/raspberrypi/controller/algorithm.hpp\n> index e9b040c7..5123c87b 100644\n> --- a/src/ipa/raspberrypi/controller/algorithm.hpp\n> +++ b/src/ipa/raspberrypi/controller/algorithm.hpp\n> @@ -12,7 +12,6 @@\n> #include \n> #include \n> #include \n> -#include \n> \n> #include \"controller.hpp\"\n> \n> @@ -46,7 +45,7 @@ public:\n> \n> private:\n> \tController *controller_;\n> -\tstd::atomic paused_;\n> +\tbool paused_;\n> };\n> \n> // This code is for automatic registration of Front End algorithms with the","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6148FBD162\n\tfor ;\n\tMon, 8 Feb 2021 15:48:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D15EC60D33;\n\tMon, 8 Feb 2021 16:48:32 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0492860D24\n\tfor ;\n\tMon, 8 Feb 2021 16:48:32 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 66BE13D7;\n\tMon, 8 Feb 2021 16:48:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gtNF/UA2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612799311;\n\tbh=7L2z938B8RRAsq5pIS1v4u65YHgeaZzcFzrcrQjmi8c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gtNF/UA2pRC+9/qA7ut5ox4V5Fdy753hbe/S7qRFOrzOe1KSh5lERDN/NplW2cXaa\n\t9c2iQ1sw/gVAI7HFC0Nbb/Swlrv7YWQ4adMhAlMK5vcsBRr9rJGTTl1+abw4nCsO4F\n\t74SPGKS+zmiMhG4h2l8FH/be5qyY0H7rdHh2Z5k4=","Date":"Mon, 8 Feb 2021 17:48:06 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20210208094036.6846-1-david.plowman@raspberrypi.com>\n\t<20210208094036.6846-2-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210208094036.6846-2-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: raspberrypi: Remove atomic\n\tvariable from Algorithm class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]