{"id":11184,"url":"https://patchwork.libcamera.org/api/patches/11184/?format=json","web_url":"https://patchwork.libcamera.org/patch/11184/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210208094036.6846-2-david.plowman@raspberrypi.com>","date":"2021-02-08T09:40:35","name":"[libcamera-devel,1/2] ipa: raspberrypi: Remove atomic variable from Algorithm class","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a762d3c124484b1abd6d69d6e299b04dcd14f22b","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11184/mbox/","series":[{"id":1663,"url":"https://patchwork.libcamera.org/api/series/1663/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1663","date":"2021-02-08T09:40:34","name":"Raspberry Pi IPA maintenance (final part)","version":1,"mbox":"https://patchwork.libcamera.org/series/1663/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11184/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11184/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 309CCBD162\n\tfor ;\n\tMon, 8 Feb 2021 09:40:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F328060D17;\n\tMon, 8 Feb 2021 10:40:45 +0100 (CET)","from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 79E6D60CC3\n\tfor ;\n\tMon, 8 Feb 2021 10:40:43 +0100 (CET)","by mail-wm1-x334.google.com with SMTP id m1so12621812wml.2\n\tfor ;\n\tMon, 08 Feb 2021 01:40:43 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tc18sm43070920wmk.0.2021.02.08.01.40.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 08 Feb 2021 01:40:42 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"X3vpCpRE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=7R3Q8LT+xg7ciIO4DlfEJAoENK+poAjC0mayY7ox/zk=;\n\tb=X3vpCpREVwLIyLdh6WgfGbvTjiU1fZr78Zi+L0vhkHNU6r5jrkj344xamja4JjpN39\n\t7P8Sx88ZSrB6+QlCvBFG2/uTOcyeQ0mHVnqh+IaIzE7ZXUiYQIKzz5oabgwopoO2gQpd\n\tkxPBbjxXZdiTWYtKIrfkC5LYCVdZt5rBfp5EPWqANb8d3iT/oyXUgoNTEq6jEndG5Lza\n\tZpcuYUpV1X3CT8V4j7z6hVYyf2DuSWf2qkwK5WBPNK597qn+stcH9Qr772ZjfouEzUd8\n\tiQpYUqHDCIA61O6wEqGFNnwg4hC6CbvH4dpkffR9NCE55Ss4ysIl6gSHY4pFTGFgY5Ov\n\tRTYg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=7R3Q8LT+xg7ciIO4DlfEJAoENK+poAjC0mayY7ox/zk=;\n\tb=bb6xxuNLAKw/S87bB/eio8FeCdIJwL2hi++iooXMhCGATgtPAIBVzzKZK51h8EX3VL\n\t+YmXlWXVndFV/CVByiF3hb8ZxAMuoqRsQ+BC3MBYYatJac8jr0Ww7MF4YBfpRm1AReSB\n\tOzckkHCpWDSfstu9X+P+FyNV0Exkj6T5MCeuw00G/IstQI774ar0Iy7g+D1rD7mFAl/y\n\tyTa53Sgy+vmrBtCP3f6Obxvm9pVZyU/JByi0KFS3HpqdA/9AUolmMvuPA9W+w3zQz5Po\n\tMbJ5aRV/BbZQzoEXhxAitb2AaajMwqNcOF7tmJMUc1EVu1lRjUjxZ/TGCe5t04c5FK9c\n\tTtEw==","X-Gm-Message-State":"AOAM533Amaor0mk821WKMid6mYOX3vwX/sT8ZcQ2Hqf6uTL9Lu+IPiw8\n\tsBxUrpPLOdFKjn5/YV20fleW6k7hcn3PXRgR","X-Google-Smtp-Source":"ABdhPJyqdUdkAgvoAKl6yrv6gPi7ZtJoqpVwLcZuiaaKgHDaNs0f/eVBvXHYCNQ+2KKJDaQAr5u52w==","X-Received":"by 2002:a1c:a546:: with SMTP id\n\to67mr13832482wme.151.1612777242835; \n\tMon, 08 Feb 2021 01:40:42 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 8 Feb 2021 09:40:35 +0000","Message-Id":"<20210208094036.6846-2-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20210208094036.6846-1-david.plowman@raspberrypi.com>","References":"<20210208094036.6846-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/2] ipa: raspberrypi: Remove atomic\n\tvariable from Algorithm class","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Pause() and Resume() are only called synchronously so paused_ does not\nneed to be atomic.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/controller/algorithm.hpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/algorithm.hpp b/src/ipa/raspberrypi/controller/algorithm.hpp\nindex e9b040c7..5123c87b 100644\n--- a/src/ipa/raspberrypi/controller/algorithm.hpp\n+++ b/src/ipa/raspberrypi/controller/algorithm.hpp\n@@ -12,7 +12,6 @@\n #include \n #include \n #include \n-#include \n \n #include \"controller.hpp\"\n \n@@ -46,7 +45,7 @@ public:\n \n private:\n \tController *controller_;\n-\tstd::atomic paused_;\n+\tbool paused_;\n };\n \n // This code is for automatic registration of Front End algorithms with the\n","prefixes":["libcamera-devel","1/2"]}