[{"id":1517,"web_url":"https://patchwork.libcamera.org/comment/1517/","msgid":"<20190427012808.GE5054@pendragon.ideasonboard.com>","date":"2019-04-27T01:28:08","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Prefix V4L2\n\tdirection in log messages","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Sat, Apr 27, 2019 at 03:25:09AM +0200, Kieran Bingham wrote:\n> The V4L2Device will use the same deviceNode for two directions in the\n> case of an M2M device.\n> \n> Add the direction to identify the queue direction on each instance.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n>  src/libcamera/v4l2_device.cpp | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\n> index a6e9ca247828..a21944160253 100644\n> --- a/src/libcamera/v4l2_device.cpp\n> +++ b/src/libcamera/v4l2_device.cpp\n> @@ -415,7 +415,7 @@ void V4L2Device::close()\n>  \n>  std::string V4L2Device::logPrefix() const\n>  {\n> -\treturn deviceNode_;\n> +\treturn deviceNode_ + (V4L2_TYPE_IS_OUTPUT(bufferType_) ? \"[out]\" : \"[cap]\");\n>  }\n>  \n>  /**","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEC0760B1B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 27 Apr 2019 03:28:19 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(net-37-182-44-227.cust.vodafonedsl.it [37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3E9355F;\n\tSat, 27 Apr 2019 03:28:19 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556328499;\n\tbh=/FKsXTNWxgHGMj1kUMQ5IN73RbD9tHZlcJF/JPUS+bM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=SKGFazTKBh+nln5gRpLWMR47WBKBq0YGCw/YoYnolcZkGH4/CB9kY3Msqf+MV4DsC\n\tYRKnS9BDLgWPsSCCy5GnNVOQZ34osUiOT1STRscSOYbMVr0e4gpSiBEZRuWFwnm2lx\n\tt5E0/t2dvVk5Ul9OMvL4nHL0y5N2tNkWGnmeEYO8=","Date":"Sat, 27 Apr 2019 04:28:08 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Message-ID":"<20190427012808.GE5054@pendragon.ideasonboard.com>","References":"<20190427012509.32153-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190427012509.32153-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_device: Prefix V4L2\n\tdirection in log messages","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Sat, 27 Apr 2019 01:28:20 -0000"}}]