{"id":11170,"url":"https://patchwork.libcamera.org/api/patches/11170/?format=json","web_url":"https://patchwork.libcamera.org/patch/11170/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210204232613.494121-9-niklas.soderlund@ragnatech.se>","date":"2021-02-04T23:26:10","name":"[libcamera-devel,v4,08/11] libcamera: ipu3: imgu: Allocate buffers for stats and param","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"536ad7224a69f3653cb6cc759c8d6447138bd9db","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11170/mbox/","series":[{"id":1656,"url":"https://patchwork.libcamera.org/api/series/1656/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1656","date":"2021-02-04T23:26:02","name":"libcamera: ipu3: Attach to an skeleton IPA","version":4,"mbox":"https://patchwork.libcamera.org/series/1656/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11170/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11170/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F3D9BD162\n\tfor ;\n\tThu, 4 Feb 2021 23:27:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1AB61614A4;\n\tFri, 5 Feb 2021 00:27:16 +0100 (CET)","from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F9D9614B3\n\tfor ;\n\tFri, 5 Feb 2021 00:27:13 +0100 (CET)","from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de\n\t[79.202.36.88])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 822e4869-6740-11eb-b73f-0050569116f7;\n\tFri, 05 Feb 2021 00:27:12 +0100 (CET)"],"X-Halon-ID":"822e4869-6740-11eb-b73f-0050569116f7","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 5 Feb 2021 00:26:10 +0100","Message-Id":"<20210204232613.494121-9-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.30.0","In-Reply-To":"<20210204232613.494121-1-niklas.soderlund@ragnatech.se>","References":"<20210204232613.494121-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 08/11] libcamera: ipu3: imgu: Allocate\n\tbuffers for stats and param","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Instead of preparing for buffer importing allocate buffers that can be\nused by an IPA.\n\nSigned-off-by: Niklas Söderlund \nReviewed-by: Jacopo Mondi \nReviewed-by: Laurent Pinchart \n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 14 +++++---------\n src/libcamera/pipeline/ipu3/imgu.h | 3 +++\n 2 files changed, 8 insertions(+), 9 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex c861022060c82dde..d5cf05b0c421e006 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -552,20 +552,13 @@ int ImgUDevice::allocateBuffers(unsigned int bufferCount)\n \t\treturn ret;\n \t}\n \n-\tret = param_->importBuffers(bufferCount);\n+\tret = param_->allocateBuffers(bufferCount, ¶mBuffers_);\n \tif (ret < 0) {\n \t\tLOG(IPU3, Error) << \"Failed to allocate ImgU param buffers\";\n \t\tgoto error;\n \t}\n \n-\t/*\n-\t * The kernel fails to start if buffers are not either imported or\n-\t * allocated for the statistics video device. As statistics buffers are\n-\t * not yet used by the pipeline import buffers to save memory.\n-\t *\n-\t * \\todo To be revised when we'll actually use the stat node.\n-\t */\n-\tret = stat_->importBuffers(bufferCount);\n+\tret = stat_->allocateBuffers(bufferCount, &statBuffers_);\n \tif (ret < 0) {\n \t\tLOG(IPU3, Error) << \"Failed to allocate ImgU stat buffers\";\n \t\tgoto error;\n@@ -603,6 +596,9 @@ void ImgUDevice::freeBuffers()\n {\n \tint ret;\n \n+\tparamBuffers_.clear();\n+\tstatBuffers_.clear();\n+\n \tret = output_->releaseBuffers();\n \tif (ret)\n \t\tLOG(IPU3, Error) << \"Failed to release ImgU output buffers\";\ndiff --git a/src/libcamera/pipeline/ipu3/imgu.h b/src/libcamera/pipeline/ipu3/imgu.h\nindex 4a1896e2bbb41842..9d491511608730a9 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.h\n+++ b/src/libcamera/pipeline/ipu3/imgu.h\n@@ -76,6 +76,9 @@ public:\n \tstd::unique_ptr viewfinder_;\n \tstd::unique_ptr stat_;\n \n+\tstd::vector> paramBuffers_;\n+\tstd::vector> statBuffers_;\n+\n private:\n \tstatic constexpr unsigned int PAD_INPUT = 0;\n \tstatic constexpr unsigned int PAD_PARAM = 1;\n","prefixes":["libcamera-devel","v4","08/11"]}