[{"id":1524,"web_url":"https://patchwork.libcamera.org/comment/1524/","msgid":"<20190428103117.GI16573@bigcity.dyn.berto.se>","date":"2019-04-28T10:31:17","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Log proposed\n\tconfiguration in streamConfiguration()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-04-26 18:05:37 +0300, Laurent Pinchart wrote:\n> The IPU3 and RKISP1 pipeline handlers log the camera configuration they\n> propose in their streamConfiguration() methods. Other pipeline handlers\n> are expected to log similar information, move it to the Camera class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/camera.cpp | 15 ++++++++++++++-\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ----\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 --\n> 3 files changed, 14 insertions(+), 7 deletions(-)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 655996f26224..a3c3945cf62d 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -546,7 +546,20 @@ Camera::streamConfiguration(const std::vector &usages)\n> \tif (disconnected_ || !usages.size() || usages.size() > streams_.size())\n> \t\treturn CameraConfiguration();\n> \n> -\treturn pipe_->streamConfiguration(this, usages);\n> +\tCameraConfiguration config = pipe_->streamConfiguration(this, usages);\n> +\n> +\tstd::ostringstream msg(\"streams configuration:\");\n> +\tunsigned int index = 0;\n> +\n> +\tfor (Stream *stream : config) {\n> +\t\tconst StreamConfiguration &cfg = config[stream];\n> +\t\tmsg << \" (\" << index << \") \" << cfg.toString();\n> +\t\tindex++;\n> +\t}\n> +\n> +\tLOG(Camera, Debug) << msg.str();\n> +\n> +\treturn config;\n> }\n> \n> /**\n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 97a309207621..fbb37498ca8a 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -316,10 +316,6 @@ PipelineHandlerIPU3::streamConfiguration(Camera *camera,\n> \t\tstreamConfig.bufferCount = IPU3_BUFFER_COUNT;\n> \n> \t\tcameraConfig[stream] = streamConfig;\n> -\n> -\t\tLOG(IPU3, Debug)\n> -\t\t\t<< \"Stream '\" << stream->name_ << \"' format set to \"\n> -\t\t\t<< streamConfig.toString();\n> \t}\n> \n> \treturn cameraConfig;\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index d21c6266c6ba..9a63a68b81dd 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -124,8 +124,6 @@ CameraConfiguration PipelineHandlerRkISP1::streamConfiguration(Camera *camera,\n> \n> \tconfigs[&data->stream_] = config;\n> \n> -\tLOG(RkISP1, Debug) << \"Stream format set to \" << config.toString();\n> -\n> \treturn configs;\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1F7A4600EA\n\tfor ;\n\tSun, 28 Apr 2019 12:31:20 +0200 (CEST)","by mail-lj1-x22b.google.com with SMTP id z26so6795596ljj.2\n\tfor ;\n\tSun, 28 Apr 2019 03:31:20 -0700 (PDT)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tv4sm6362505ljv.4.2019.04.28.03.31.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tSun, 28 Apr 2019 03:31:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=VsUkzXttcMBErjaUcUDtKY1THRpEL+wrlW95nLVs4d4=;\n\tb=PLQmX9w6jCFgxph5hP/zSFtGEFDhABfdtfLYvSBmAxm/ie0ypUGDdnZvvUKgy7g4YT\n\tTzlShD/CSDWMO8Y2pWVMU45VhiXG9/4wWljep+CviKdAYCdJjDraCFRJfJG4IHz5ELRE\n\tdCZGbUJn3RsrrO23wgVfEBxue37HinQ6m+ZXPPCbZv8J4vBZIF1QMekWO+OSMMfKpuWK\n\tQKHIRKm/fvwYK//wCrpvA7bf70d2uQpa9SEdr7bKuPMqVVjWpgyRoJxkvdq0i9n2kArS\n\t+dG0uOUMewSr5NKiIqsNY6zD6HvfasJMZtB/zfn/GwcBDbGyRVtRT63IOb9q+vAiWWjl\n\tqFoA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=VsUkzXttcMBErjaUcUDtKY1THRpEL+wrlW95nLVs4d4=;\n\tb=HWul4vFlzbZkFe2V1B8HL6gk9Q5NldKg/SQqH08SlESFwHtkMK/jhoD2tjSHEkQabn\n\t0YoMkyLX4iqTpZlELVDcV0OLtqG7HeBXLxLl4CV9oM7G4lEOBPi8xY59uIh3f89RDwdy\n\tbb8t7vVYg/sT5nzuO7RJw4iAbMeiNRAfhxYi0Ebmqd1IM+FHX3sPEBV6wLkx5bwGkHnv\n\tGfbsIQEMagGQadlIKK/xe2325ZAz3Jvfx8ez33xSjDMCxO49RqOfARnefmCnuUNDFxwO\n\tlQfKd6S8e1sYA6+3L6ACvpmFxUl0gnUhZw7KrD+F5uMEAmSU7sz+jMsjJSO3xxbbIOhO\n\twupw==","X-Gm-Message-State":"APjAAAU0uMmFP0kAD95dpQWtvWWwzbey6l/1WInuKLqnDzXnMaddfn8D\n\tPtOsELHPUs7x6Aimy2n5Aq33EXt+r5k=","X-Google-Smtp-Source":"APXvYqzZYja6iDEQecRON6FsKrfgUm27oMWgNMkRbcZ9hx0NFOKzkafplYbDn6B04YLnVLaca8KMbg==","X-Received":"by 2002:a2e:8090:: with SMTP id\n\ti16mr4349378ljg.135.1556447479443; \n\tSun, 28 Apr 2019 03:31:19 -0700 (PDT)","Date":"Sun, 28 Apr 2019 12:31:17 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190428103117.GI16573@bigcity.dyn.berto.se>","References":"<20190426150537.18848-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190426150537.18848-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.11.3 (2019-02-01)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Log proposed\n\tconfiguration in streamConfiguration()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 28 Apr 2019 10:31:20 -0000"}}]