[{"id":14976,"web_url":"https://patchwork.libcamera.org/comment/14976/","msgid":"","date":"2021-02-04T17:01:30","subject":"Re: [libcamera-devel] [PATCH v3 1/2] android: camera_device: Fix\n\twrong comment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Feb 04, 2021 at 05:22:43PM +0100, Jacopo Mondi wrote:\n> Fix a wrong comment.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index a50b0ebfe60e..70170e243d06 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -714,7 +714,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> \t * entries.\n> \t *\n> -\t * Each stream configuration entry requires 52 bytes:\n> +\t * Each stream configuration entry requires 48 bytes:\n> \t * 4 32bits integers for ANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS\n> \t * 4 64bits integers for ANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS\n> \t */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 624BEBD160\n\tfor ;\n\tThu, 4 Feb 2021 17:01:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D856C6144E;\n\tThu, 4 Feb 2021 18:01:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C6E861430\n\tfor ;\n\tThu, 4 Feb 2021 18:01:53 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 93B63510;\n\tThu, 4 Feb 2021 18:01:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ml1+0xTN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612458112;\n\tbh=lCZYGjVFDUBVIbZuPyFRLEThWDidTqk8Ca7EpHwrJCQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ml1+0xTNUNXHTV6L8lIjtH5FBQhkw+rBqH2dq9WCpHdWlsf5wB49XaLXz5PZZd4p2\n\tLUiFMG6Ve+ZLMH/a6jyeSszAkMUgYKK2QPKxx8NtiPBBeYRKbDDOw4tBA9JjmIGPJW\n\tmv0O2vcK3TI8b5QJVeqzO/Ww2CAYxgYfd+ik68lQ=","Date":"Thu, 4 Feb 2021 19:01:30 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210204162244.53630-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210204162244.53630-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v3 1/2] android: camera_device: Fix\n\twrong comment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]