[{"id":15039,"web_url":"https://patchwork.libcamera.org/comment/15039/","msgid":"","date":"2021-02-07T14:08:02","subject":"Re: [libcamera-devel] [PATCH 5/7] ipa: raspberrypi: noise: Remove\n\tunnecessary atomic variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Thu, Feb 04, 2021 at 09:34:55AM +0000, David Plowman wrote:\n> mode_factor_ does not need to be atomic - it is set by SwitchMode()\n> which runs synchronously.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/rpi/noise.hpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/noise.hpp b/src/ipa/raspberrypi/controller/rpi/noise.hpp\n> index 6f6e0be9..1c9de5c8 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/noise.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/noise.hpp\n> @@ -26,7 +26,7 @@ private:\n> \t// the noise profile for analogue gain of 1.0\n> \tdouble reference_constant_;\n> \tdouble reference_slope_;\n> -\tstd::atomic mode_factor_;\n> +\tdouble mode_factor_;\n> };\n> \n> } // namespace RPiController","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FE38BD160\n\tfor ;\n\tSun, 7 Feb 2021 14:08:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2607601B5;\n\tSun, 7 Feb 2021 15:08:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A8A48601AB\n\tfor ;\n\tSun, 7 Feb 2021 15:08:25 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B5F2F3;\n\tSun, 7 Feb 2021 15:08:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"igRv8zTR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612706905;\n\tbh=hBtRJxm0TXIxEXtrU79c4ULnLccDj0RIERTdtonAnuo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=igRv8zTRqewdrxEMrnoF2+5Wox23g+gcKtcyVxwLjuwiQKAMtXmXtu/ztw7yeDKiR\n\tSA2RXf1QASOIlitTF4G05Vfb94t6wm+O4fE5Kv4EkEFi2QLBx74s2L7Lyj8Z16yACS\n\tzAUNS71zilWaiUPDF3t8Bo1eLDp25VqcVYGqUcKM=","Date":"Sun, 7 Feb 2021 16:08:02 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20210204093457.6879-1-david.plowman@raspberrypi.com>\n\t<20210204093457.6879-6-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210204093457.6879-6-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 5/7] ipa: raspberrypi: noise: Remove\n\tunnecessary atomic variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]