[{"id":15037,"web_url":"https://patchwork.libcamera.org/comment/15037/","msgid":"","date":"2021-02-07T14:05:39","subject":"Re: [libcamera-devel] [PATCH 3/7] ipa: raspberrypi: ccm: Remove\n\tunnecessary atomic variable","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Thu, Feb 04, 2021 at 09:34:53AM +0000, David Plowman wrote:\n> SetSaturation() gets called synchronously so there is no need for\n> saturation_ to be atomic.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/rpi/ccm.hpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/ccm.hpp b/src/ipa/raspberrypi/controller/rpi/ccm.hpp\n> index fcf077e7..330ed51f 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/ccm.hpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/ccm.hpp\n> @@ -7,7 +7,6 @@\n> #pragma once\n> \n> #include \n> -#include \n> \n> #include \"../ccm_algorithm.hpp\"\n> #include \"../pwl.hpp\"\n> @@ -70,7 +69,7 @@ public:\n> \n> private:\n> \tCcmConfig config_;\n> -\tstd::atomic saturation_;\n> +\tdouble saturation_;\n> };\n> \n> } // namespace RPiController","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C5A4BD162\n\tfor ;\n\tSun, 7 Feb 2021 14:06:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CEE1E601B1;\n\tSun, 7 Feb 2021 15:06:03 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D52B6601AB\n\tfor ;\n\tSun, 7 Feb 2021 15:06:02 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 62A89F3;\n\tSun, 7 Feb 2021 15:06:02 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LzgH0Rlk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612706762;\n\tbh=Ok1X+zSmIuwDDH2TVf3JI7pl+wIaSMUs6MFi59NwVXA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LzgH0Rlk/2SpwzqMvIKZiqvNo2LWXrK/KfJh7PPnQa5Bpm52svVZr9xG9KTomJHx7\n\tIgF6E/1MC3Z1EDYMMVl0phI4HnKucrUuOvPU7L/ttFQBOz8rTuRMWFbfUyC+/DDBjC\n\tRIJnD9KiKs9sS5lTav8pIJuxpzGd546aaWsiSoec=","Date":"Sun, 7 Feb 2021 16:05:39 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20210204093457.6879-1-david.plowman@raspberrypi.com>\n\t<20210204093457.6879-4-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210204093457.6879-4-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 3/7] ipa: raspberrypi: ccm: Remove\n\tunnecessary atomic variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]