[{"id":14949,"web_url":"https://patchwork.libcamera.org/comment/14949/","msgid":"","date":"2021-02-04T08:53:55","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: geometry: Mark const\n\tfunctions with __nodiscard","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2021-02-04 05:59:51 +0200, Laurent Pinchart wrote:\n> Geometry classes generally have two sets of functions, one that operates\n> on the object and modifies it (e.g. Rectangle::scaleBy()), and one that\n> performs the same operations by instead return a modified copy of the\n> object, leaving the original untouched (e.g.Rectangle::scaledBy()). As\n> the names are close, they can easily be mistaken, with the const version\n> used instead of the in-place version.\n> \n> To catch these errors at compile time, mark the const versions with\n> __nodiscard, as there is no use case for calling them without using the\n> result of the call.\n> \n> Signed-off-by: Laurent Pinchart \n\nNeat.\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/geometry.h | 29 ++++++++++++++++-------------\n> 1 file changed, 16 insertions(+), 13 deletions(-)\n> \n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index 2f3a82e2afc3..fdd1b4678074 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -11,6 +11,8 @@\n> #include \n> #include \n> \n> +#include \n> +\n> namespace libcamera {\n> \n> class Rectangle;\n> @@ -92,8 +94,8 @@ public:\n> \t\treturn *this;\n> \t}\n> \n> -\tconstexpr Size alignedDownTo(unsigned int hAlignment,\n> -\t\t\t\t unsigned int vAlignment) const\n> +\t__nodiscard constexpr Size alignedDownTo(unsigned int hAlignment,\n> +\t\t\t\t\t\t unsigned int vAlignment) const\n> \t{\n> \t\treturn {\n> \t\t\twidth / hAlignment * hAlignment,\n> @@ -101,8 +103,8 @@ public:\n> \t\t};\n> \t}\n> \n> -\tconstexpr Size alignedUpTo(unsigned int hAlignment,\n> -\t\t\t\t unsigned int vAlignment) const\n> +\t__nodiscard constexpr Size alignedUpTo(unsigned int hAlignment,\n> +\t\t\t\t\t unsigned int vAlignment) const\n> \t{\n> \t\treturn {\n> \t\t\t(width + hAlignment - 1) / hAlignment * hAlignment,\n> @@ -110,7 +112,7 @@ public:\n> \t\t};\n> \t}\n> \n> -\tconstexpr Size boundedTo(const Size &bound) const\n> +\t__nodiscard constexpr Size boundedTo(const Size &bound) const\n> \t{\n> \t\treturn {\n> \t\t\tstd::min(width, bound.width),\n> @@ -118,7 +120,7 @@ public:\n> \t\t};\n> \t}\n> \n> -\tconstexpr Size expandedTo(const Size &expand) const\n> +\t__nodiscard constexpr Size expandedTo(const Size &expand) const\n> \t{\n> \t\treturn {\n> \t\t\tstd::max(width, expand.width),\n> @@ -126,10 +128,10 @@ public:\n> \t\t};\n> \t}\n> \n> -\tSize boundedToAspectRatio(const Size &ratio) const;\n> -\tSize expandedToAspectRatio(const Size &ratio) const;\n> +\t__nodiscard Size boundedToAspectRatio(const Size &ratio) const;\n> +\t__nodiscard Size expandedToAspectRatio(const Size &ratio) const;\n> \n> -\tRectangle centeredTo(const Point ¢er) const;\n> +\t__nodiscard Rectangle centeredTo(const Point ¢er) const;\n> \n> \tSize operator*(float factor) const;\n> \tSize operator/(float factor) const;\n> @@ -247,10 +249,11 @@ public:\n> \tRectangle &scaleBy(const Size &numerator, const Size &denominator);\n> \tRectangle &translateBy(const Point &point);\n> \n> -\tRectangle boundedTo(const Rectangle &bound) const;\n> -\tRectangle enclosedIn(const Rectangle &boundary) const;\n> -\tRectangle scaledBy(const Size &numerator, const Size &denominator) const;\n> -\tRectangle translatedBy(const Point &point) const;\n> +\t__nodiscard Rectangle boundedTo(const Rectangle &bound) const;\n> +\t__nodiscard Rectangle enclosedIn(const Rectangle &boundary) const;\n> +\t__nodiscard Rectangle scaledBy(const Size &numerator,\n> +\t\t\t\t const Size &denominator) const;\n> +\t__nodiscard Rectangle translatedBy(const Point &point) const;\n> };\n> \n> bool operator==(const Rectangle &lhs, const Rectangle &rhs);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E2482BD162\n\tfor ;\n\tThu, 4 Feb 2021 08:53:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5E92F613FB;\n\tThu, 4 Feb 2021 09:53:59 +0100 (CET)","from mail-lf1-x135.google.com (mail-lf1-x135.google.com\n\t[IPv6:2a00:1450:4864:20::135])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB9BF60107\n\tfor ;\n\tThu, 4 Feb 2021 09:53:57 +0100 (CET)","by mail-lf1-x135.google.com with SMTP id d3so3333666lfg.10\n\tfor ;\n\tThu, 04 Feb 2021 00:53:57 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tq17sm520658lfu.108.2021.02.04.00.53.56\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 00:53:56 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Yq98yCao\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=xXD8Xe9OT3LGKbS0y69o1QFNcUHspq4AYhJ1RdmCJ6M=;\n\tb=Yq98yCaobUqdiXZ/JhQYSybM51eNmW6cRSChSYaOsx2+KdS1cDRSdl0n9VwkD5Tshu\n\tAaIO1cflriTAspyTLD2ChraKOfZdJTfviXMfVBzPW/F35ffMRzUr59mUpiAHuj5LRY3Q\n\t9EL01dhde31hfhTTWl1HZG7kfJq9ECkrOC5gYqjKL7LY7Cwl+ik1DmGj/5gPCoAkHXPz\n\tKVbP5dI4jcDbUQlYMPE4F/NaQpoDl6oLKGOkNblOh8/E0HVZlwg08FnzjYFnE7n6vYMl\n\tHGRRBPQ5/Gzrjy9TBgZYI1vnRHDVFmY5lkrkfxeHdnoS5TiIShR9EeNdtciXnLoGzzUj\n\txrLg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=xXD8Xe9OT3LGKbS0y69o1QFNcUHspq4AYhJ1RdmCJ6M=;\n\tb=Vhx7Lz28FOrBpgl99aI1vZCkRmZXlqSY/1YibisKzDREmfr1yyMJxFFpTm1/fMA0zU\n\tL3vJatYp+mOYVuRrZrnvCa487+RXku5X7VkFj7Y5RYB7RfL9ZBJEFVJ6vCjhGKoaZcpj\n\tRfPc/YfWIphaLhNFRCh7qB9mJsVH4M0EkVy/bL4C/pYrpNQYWkJjBmqO4sFBbAkGoz/s\n\tS1ravh978Rui1XzQYl864RSe6FSTI/F9yDj1vDvhV+CxfVdF3YrQIPDkiYd/n8ltZIo8\n\tg139WRC0NL0orPkvSaQtKIUFk97e0kR81ws0bQy/BxZa26gHrisABt01EQf7+uX8Ab2R\n\tOPyA==","X-Gm-Message-State":"AOAM531RxAvJ8e+KNvDOnWKajqCdeUXSD8SXlQ7/2jhAgy0Z3TufKWVJ\n\t2ek6nDEUBcB/7VFX4DWXmbc1rA==","X-Google-Smtp-Source":"ABdhPJzqP8wQHRTqMpOptMfSZLuNYImCTF+DHxQpb4BqYAFR6qIpPSa7HKlys5Df5P28iliugRNEyQ==","X-Received":"by 2002:a05:6512:214a:: with SMTP id\n\ts10mr3915785lfr.225.1612428837099; \n\tThu, 04 Feb 2021 00:53:57 -0800 (PST)","Date":"Thu, 4 Feb 2021 09:53:55 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210204035951.23751-1-laurent.pinchart@ideasonboard.com>\n\t<20210204035951.23751-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210204035951.23751-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: geometry: Mark const\n\tfunctions with __nodiscard","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14968,"web_url":"https://patchwork.libcamera.org/comment/14968/","msgid":"<7aa1f18d-7baa-c955-2ae7-e6059cb34cac@ideasonboard.com>","date":"2021-02-04T14:39:41","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: geometry: Mark const\n\tfunctions with __nodiscard","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 04/02/2021 03:59, Laurent Pinchart wrote:\n> Geometry classes generally have two sets of functions, one that operates\n> on the object and modifies it (e.g. Rectangle::scaleBy()), and one that\n> performs the same operations by instead return a modified copy of the\n> object, leaving the original untouched (e.g.Rectangle::scaledBy()). As\n> the names are close, they can easily be mistaken, with the const version\n> used instead of the in-place version.\n> \n> To catch these errors at compile time, mark the const versions with\n> __nodiscard, as there is no use case for calling them without using the\n> result of the call.\n> \n> Signed-off-by: Laurent Pinchart \n\nGetting the compiler to tell us when things are wrong early is always a\nwin in my book:\n\nReviewed-by: Kieran Bingham \n\nWith this, there is an existing usage of [[nodiscard]] in android/jpeg.\nI think it makes sense to keep the usage/style consistent, but that's\nnot a change to go into this patch - so I've sent a separate patch in\nreply to this thread. Please pick it and apply with these if you feel\nit's appropriate and correct.\n\n--\nKieran\n\n\n\n> ---\n> include/libcamera/geometry.h | 29 ++++++++++++++++-------------\n> 1 file changed, 16 insertions(+), 13 deletions(-)\n> \n> diff --git a/include/libcamera/geometry.h b/include/libcamera/geometry.h\n> index 2f3a82e2afc3..fdd1b4678074 100644\n> --- a/include/libcamera/geometry.h\n> +++ b/include/libcamera/geometry.h\n> @@ -11,6 +11,8 @@\n> #include \n> #include \n> \n> +#include \n> +\n> namespace libcamera {\n> \n> class Rectangle;\n> @@ -92,8 +94,8 @@ public:\n> \t\treturn *this;\n> \t}\n> \n> -\tconstexpr Size alignedDownTo(unsigned int hAlignment,\n> -\t\t\t\t unsigned int vAlignment) const\n> +\t__nodiscard constexpr Size alignedDownTo(unsigned int hAlignment,\n> +\t\t\t\t\t\t unsigned int vAlignment) const\n> \t{\n> \t\treturn {\n> \t\t\twidth / hAlignment * hAlignment,\n> @@ -101,8 +103,8 @@ public:\n> \t\t};\n> \t}\n> \n> -\tconstexpr Size alignedUpTo(unsigned int hAlignment,\n> -\t\t\t\t unsigned int vAlignment) const\n> +\t__nodiscard constexpr Size alignedUpTo(unsigned int hAlignment,\n> +\t\t\t\t\t unsigned int vAlignment) const\n> \t{\n> \t\treturn {\n> \t\t\t(width + hAlignment - 1) / hAlignment * hAlignment,\n> @@ -110,7 +112,7 @@ public:\n> \t\t};\n> \t}\n> \n> -\tconstexpr Size boundedTo(const Size &bound) const\n> +\t__nodiscard constexpr Size boundedTo(const Size &bound) const\n> \t{\n> \t\treturn {\n> \t\t\tstd::min(width, bound.width),\n> @@ -118,7 +120,7 @@ public:\n> \t\t};\n> \t}\n> \n> -\tconstexpr Size expandedTo(const Size &expand) const\n> +\t__nodiscard constexpr Size expandedTo(const Size &expand) const\n> \t{\n> \t\treturn {\n> \t\t\tstd::max(width, expand.width),\n> @@ -126,10 +128,10 @@ public:\n> \t\t};\n> \t}\n> \n> -\tSize boundedToAspectRatio(const Size &ratio) const;\n> -\tSize expandedToAspectRatio(const Size &ratio) const;\n> +\t__nodiscard Size boundedToAspectRatio(const Size &ratio) const;\n> +\t__nodiscard Size expandedToAspectRatio(const Size &ratio) const;\n> \n> -\tRectangle centeredTo(const Point ¢er) const;\n> +\t__nodiscard Rectangle centeredTo(const Point ¢er) const;\n> \n> \tSize operator*(float factor) const;\n> \tSize operator/(float factor) const;\n> @@ -247,10 +249,11 @@ public:\n> \tRectangle &scaleBy(const Size &numerator, const Size &denominator);\n> \tRectangle &translateBy(const Point &point);\n> \n> -\tRectangle boundedTo(const Rectangle &bound) const;\n> -\tRectangle enclosedIn(const Rectangle &boundary) const;\n> -\tRectangle scaledBy(const Size &numerator, const Size &denominator) const;\n> -\tRectangle translatedBy(const Point &point) const;\n> +\t__nodiscard Rectangle boundedTo(const Rectangle &bound) const;\n> +\t__nodiscard Rectangle enclosedIn(const Rectangle &boundary) const;\n> +\t__nodiscard Rectangle scaledBy(const Size &numerator,\n> +\t\t\t\t const Size &denominator) const;\n> +\t__nodiscard Rectangle translatedBy(const Point &point) const;\n> };\n> \n> bool operator==(const Rectangle &lhs, const Rectangle &rhs);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 100EEBD162\n\tfor ;\n\tThu, 4 Feb 2021 14:39:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97C1561428;\n\tThu, 4 Feb 2021 15:39:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E135F60305\n\tfor ;\n\tThu, 4 Feb 2021 15:39:44 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5FE99440;\n\tThu, 4 Feb 2021 15:39:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I5Gk9qEJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612449584;\n\tbh=qq4q8gIr2ic1CS/AQ/wVbC3EoffG2gvx+8TeqUSkQmk=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=I5Gk9qEJN6/ZZUoepGyBicu9DFqZCbcgiiXnkKnVW7vfx+K70K/XCXDqcWIwGjJNy\n\t8JfMMw8htHhGZKfnga+EDt77eOLBdBlBg0SDmUUaC62/C6C0W2K1L1P66+MWii7TBJ\n\t6gTpC/YHdVS08uRFfzQCLzUWHrDVDgm10XdCNpSg=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210204035951.23751-1-laurent.pinchart@ideasonboard.com>\n\t<20210204035951.23751-2-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7aa1f18d-7baa-c955-2ae7-e6059cb34cac@ideasonboard.com>","Date":"Thu, 4 Feb 2021 14:39:41 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210204035951.23751-2-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: geometry: Mark const\n\tfunctions with __nodiscard","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]