[{"id":14964,"web_url":"https://patchwork.libcamera.org/comment/14964/","msgid":"<YBv+lMg17Z/gB/5N@oden.dyn.berto.se>","date":"2021-02-04T14:03:00","subject":"Re: [libcamera-devel] [PATCH v4 1/2] subprojects: Add libyuv and\n\tbuilt if -Dandroid=enabled","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Honda-san,\n\nThanks for your work.\n\nOn 2021-02-04 01:27:30 +0000, Hirokazu Honda wrote:\n> Android HAL adaptation layer may need image processing, for\n> example, scaling and format conversion. Libyuv is a general image\n> processing. This adds libyuv to subprojects, so that it is forked\n> locally and can be used with Android HAL implementation code.\n> \n> Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  README.rst              |  2 +-\n>  meson.build             |  2 +-\n>  src/android/meson.build | 17 +++++++++++++++++\n>  subprojects/.gitignore  |  1 +\n>  subprojects/libyuv.wrap |  4 ++++\n>  5 files changed, 24 insertions(+), 2 deletions(-)\n>  create mode 100644 subprojects/.gitignore\n>  create mode 100644 subprojects/libyuv.wrap\n> \n> diff --git a/README.rst b/README.rst\n> index 251291b7..08bfd5ad 100644\n> --- a/README.rst\n> +++ b/README.rst\n> @@ -47,7 +47,7 @@ A C++ toolchain: [required]\n>  \tEither {g++, clang}\n> \n>  Meson Build system: [required]\n> -        meson (>= 0.51) ninja-build pkg-config\n> +        meson (>= 0.55) ninja-build pkg-config\n> \n>          If your distribution doesn't provide a recent enough version of meson,\n>          you can install or upgrade it using pip3.\n> diff --git a/meson.build b/meson.build\n> index 743cb1d2..be77191d 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -1,7 +1,7 @@\n>  # SPDX-License-Identifier: CC0-1.0\n> \n>  project('libcamera', 'c', 'cpp',\n> -    meson_version : '>= 0.53',\n> +    meson_version : '>= 0.55',\n\nI know this patch is already merged, but bumping meson version over \nv0.54.3 breaks my CrOS build environment for Soraka based on R89 (and \nI'm told R90 also ships with meson v0.54.3). I understand the need to \nmove to meson v0.55, I'm just curious if you know of a build environment \nI can switch to.\n\n>      version : '0.0.0',\n>      default_options : [\n>          'werror=true',\n> diff --git a/src/android/meson.build b/src/android/meson.build\n> index 3d4d3be4..7619517a 100644\n> --- a/src/android/meson.build\n> +++ b/src/android/meson.build\n> @@ -14,6 +14,23 @@ foreach dep : android_deps\n>      endif\n>  endforeach\n> \n> +if android_enabled\n> +    cmake = import('cmake')\n> +\n> +    libyuv_vars = cmake.subproject_options()\n> +    libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n> +    libyuv_vars.set_override_option('cpp_std', 'c++17')\n> +    libyuv_vars.append_compile_args('cpp',\n> +         '-Wno-sign-compare',\n> +         '-Wno-unused-variable',\n> +         '-Wno-unused-parameter')\n> +    libyuv_vars.append_link_args('-ljpeg')\n> +    libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> +    libyuv_dep = libyuv.dependency('yuv')\n> +\n> +    android_deps += [ libyuv_dep, ]\n> +endif\n> +\n>  android_hal_sources = files([\n>      'camera3_hal.cpp',\n>      'camera_hal_manager.cpp',\n> diff --git a/subprojects/.gitignore b/subprojects/.gitignore\n> new file mode 100644\n> index 00000000..410b8bd6\n> --- /dev/null\n> +++ b/subprojects/.gitignore\n> @@ -0,0 +1 @@\n> +/libyuv\n> \\ No newline at end of file\n> diff --git a/subprojects/libyuv.wrap b/subprojects/libyuv.wrap\n> new file mode 100644\n> index 00000000..8ba51fa0\n> --- /dev/null\n> +++ b/subprojects/libyuv.wrap\n> @@ -0,0 +1,4 @@\n> +[wrap-git]\n> +directory = libyuv\n> +url = https://chromium.googlesource.com/libyuv/libyuv.git\n> +revision = 93b1b332cd60b56ab90aea14182755e379c28a80\n> --\n> 2.30.0.365.g02bc693789-goog\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 359FABD162\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  4 Feb 2021 14:03:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id AD17361411;\n\tThu,  4 Feb 2021 15:03:05 +0100 (CET)","from mail-lf1-x135.google.com (mail-lf1-x135.google.com\n\t[IPv6:2a00:1450:4864:20::135])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4666360305\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  4 Feb 2021 15:03:04 +0100 (CET)","by mail-lf1-x135.google.com with SMTP id q12so4605724lfo.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 04 Feb 2021 06:03:04 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tb1sm613184lfq.203.2021.02.04.06.03.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 06:03:02 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"iolN9+q0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Qd/aSwB9obr9xOYbjcls1X/FfDT1KGDfOi3mCDrVJeo=;\n\tb=iolN9+q0USWZUFYAUMj2m6MepbT3Kf4+ECtVQ9FdJowPg0+/fFOFXzk7XA9WZkeW8s\n\thIY0jwDviZKNXB9t2ZGhjDyNW0oYg58ubQTIeFE82G+ViAM/nOwkaF0v2LLa8Sw1k8qw\n\t+kX1wB6DkxaT2ZErf5WbruZC478KpLQiGygocZg/XfnhLcc6Yqff7gRui550TcBOAMZq\n\tfoF+kKL/UHny43iakxNDkfAFOmLagyBkaPo8IkJAYFzScd1x+wnBkP5M7JkTEW1OuWkx\n\tlfpTtTlFSrb4hlPYNeB5hlvzv3YYz/yeRodYUjRI7Od7AgLnGZIKfbUmOijDFvsRxA8/\n\tpZuw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Qd/aSwB9obr9xOYbjcls1X/FfDT1KGDfOi3mCDrVJeo=;\n\tb=hkKrU4QH+w+95mIrUV5V1PcvZd1REunfnbEDHNtKBE7a2Hj/p97OAv4u+oBcT47laL\n\tMHrH2mbmpx9QE8fqvnK+FEtJi8Iys96oXNz4SBzRaOF+hTNtLV803RAl5aU83HC+qPAC\n\t04YJEOmluhCVsjPyMIAT32WySOG1boH8L/vniF43/IQk/Tgy/Kxym/eBnfctyDxncAn2\n\taHiuuhit8OAr8j+Do7MjibPmg1bhYvd9qjovZ4bNJfcvoZ1JHX9AM1yAwPlbnElKhF7C\n\tFvh5yUg6w6SveIBnAucPC0UtLTU/mX4yqHEcUyDDOmKTlE+OXjeGwzqenZK9x/J23sSu\n\tlBig==","X-Gm-Message-State":"AOAM531Rm7xgjky2JHFZcdNknOe0s0kSlWQCo1hyetsRvGSkpk9RUiyU\n\tGv9b18jns5V896o/mYn6Zh9dRw==","X-Google-Smtp-Source":"ABdhPJyIJIdtzVh1yrhVEJAs8+p+trmtR4XyPRW+5jB8EUVnmhX3oKEJ8qC07rHwbfPQLioAjAplNg==","X-Received":"by 2002:a19:c70c:: with SMTP id\n\tx12mr4705213lff.222.1612447383516; \n\tThu, 04 Feb 2021 06:03:03 -0800 (PST)","Date":"Thu, 4 Feb 2021 15:03:00 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Hirokazu Honda <hiroh@chromium.org>","Message-ID":"<YBv+lMg17Z/gB/5N@oden.dyn.berto.se>","References":"<20210204012731.1942112-1-hiroh@chromium.org>\n\t<20210204012731.1942112-2-hiroh@chromium.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210204012731.1942112-2-hiroh@chromium.org>","Subject":"Re: [libcamera-devel] [PATCH v4 1/2] subprojects: Add libyuv and\n\tbuilt if -Dandroid=enabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":15014,"web_url":"https://patchwork.libcamera.org/comment/15014/","msgid":"<CAO5uPHN7Mgr_pkTyB_i+BOm0kBzKVT3VG0wEuyjemUdi-zEjcg@mail.gmail.com>","date":"2021-02-04T23:03:19","subject":"Re: [libcamera-devel] [PATCH v4 1/2] subprojects: Add libyuv and\n\tbuilt if -Dandroid=enabled","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"Hi Niklas,\n\nOn Thu, Feb 4, 2021 at 11:03 PM Niklas Söderlund\n<niklas.soderlund@ragnatech.se> wrote:\n>\n> Hi Honda-san,\n>\n> Thanks for your work.\n>\n> On 2021-02-04 01:27:30 +0000, Hirokazu Honda wrote:\n> > Android HAL adaptation layer may need image processing, for\n> > example, scaling and format conversion. Libyuv is a general image\n> > processing. This adds libyuv to subprojects, so that it is forked\n> > locally and can be used with Android HAL implementation code.\n> >\n> > Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > ---\n> >  README.rst              |  2 +-\n> >  meson.build             |  2 +-\n> >  src/android/meson.build | 17 +++++++++++++++++\n> >  subprojects/.gitignore  |  1 +\n> >  subprojects/libyuv.wrap |  4 ++++\n> >  5 files changed, 24 insertions(+), 2 deletions(-)\n> >  create mode 100644 subprojects/.gitignore\n> >  create mode 100644 subprojects/libyuv.wrap\n> >\n> > diff --git a/README.rst b/README.rst\n> > index 251291b7..08bfd5ad 100644\n> > --- a/README.rst\n> > +++ b/README.rst\n> > @@ -47,7 +47,7 @@ A C++ toolchain: [required]\n> >       Either {g++, clang}\n> >\n> >  Meson Build system: [required]\n> > -        meson (>= 0.51) ninja-build pkg-config\n> > +        meson (>= 0.55) ninja-build pkg-config\n> >\n> >          If your distribution doesn't provide a recent enough version of meson,\n> >          you can install or upgrade it using pip3.\n> > diff --git a/meson.build b/meson.build\n> > index 743cb1d2..be77191d 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -1,7 +1,7 @@\n> >  # SPDX-License-Identifier: CC0-1.0\n> >\n> >  project('libcamera', 'c', 'cpp',\n> > -    meson_version : '>= 0.53',\n> > +    meson_version : '>= 0.55',\n>\n> I know this patch is already merged, but bumping meson version over\n> v0.54.3 breaks my CrOS build environment for Soraka based on R89 (and\n> I'm told R90 also ships with meson v0.54.3). I understand the need to\n> move to meson v0.55, I'm just curious if you know of a build environment\n> I can switch to.\n>\n\nI faced the same issue.\nThe meson command in ChromeOS chroot is the same as\nportage-stable/dev-util/meson. [1]\nIt is 0.55.3. It thus shouldn't matter.\nThe meson command is not upreved unless `./update_chroot` doesn't run.\nThe command is hooked to run by some command (e.g. setup_board).\nOf course, you can run manually  `./update_chroot`.\nHope it is helpful for you.\n\n[1] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/third_party/portage-stable/dev-util/meson/\n\nThanks,\n-Hiro\n\n> >      version : '0.0.0',\n> >      default_options : [\n> >          'werror=true',\n> > diff --git a/src/android/meson.build b/src/android/meson.build\n> > index 3d4d3be4..7619517a 100644\n> > --- a/src/android/meson.build\n> > +++ b/src/android/meson.build\n> > @@ -14,6 +14,23 @@ foreach dep : android_deps\n> >      endif\n> >  endforeach\n> >\n> > +if android_enabled\n> > +    cmake = import('cmake')\n> > +\n> > +    libyuv_vars = cmake.subproject_options()\n> > +    libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n> > +    libyuv_vars.set_override_option('cpp_std', 'c++17')\n> > +    libyuv_vars.append_compile_args('cpp',\n> > +         '-Wno-sign-compare',\n> > +         '-Wno-unused-variable',\n> > +         '-Wno-unused-parameter')\n> > +    libyuv_vars.append_link_args('-ljpeg')\n> > +    libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> > +    libyuv_dep = libyuv.dependency('yuv')\n> > +\n> > +    android_deps += [ libyuv_dep, ]\n> > +endif\n> > +\n> >  android_hal_sources = files([\n> >      'camera3_hal.cpp',\n> >      'camera_hal_manager.cpp',\n> > diff --git a/subprojects/.gitignore b/subprojects/.gitignore\n> > new file mode 100644\n> > index 00000000..410b8bd6\n> > --- /dev/null\n> > +++ b/subprojects/.gitignore\n> > @@ -0,0 +1 @@\n> > +/libyuv\n> > \\ No newline at end of file\n> > diff --git a/subprojects/libyuv.wrap b/subprojects/libyuv.wrap\n> > new file mode 100644\n> > index 00000000..8ba51fa0\n> > --- /dev/null\n> > +++ b/subprojects/libyuv.wrap\n> > @@ -0,0 +1,4 @@\n> > +[wrap-git]\n> > +directory = libyuv\n> > +url = https://chromium.googlesource.com/libyuv/libyuv.git\n> > +revision = 93b1b332cd60b56ab90aea14182755e379c28a80\n> > --\n> > 2.30.0.365.g02bc693789-goog\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7C77ABD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  4 Feb 2021 23:03:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DEE7861496;\n\tFri,  5 Feb 2021 00:03:32 +0100 (CET)","from mail-yb1-xb33.google.com (mail-yb1-xb33.google.com\n\t[IPv6:2607:f8b0:4864:20::b33])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AB156613D4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Feb 2021 00:03:30 +0100 (CET)","by mail-yb1-xb33.google.com with SMTP id j84so4922510ybg.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 04 Feb 2021 15:03:30 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"AJRaW0gu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=lPFLj/eDrMPPb7MOHjtrzYK0LD2H7G3EFqwrCd4C168=;\n\tb=AJRaW0gu6XnG87KzvvqFZqgWKIa4LuEFO+28lF2QK+8KxYY+lE41cQ/82oy4OFyViE\n\tawAUc2jzT/9bOP3C7Lv4780m/fGrARTXLfAeR0gjf0o+9HjeAAvBFVSoVdu1MhJMSIIE\n\tchsoPYMqspgfzjWHpSmhFlE6+g+14W7h9MB+0=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=lPFLj/eDrMPPb7MOHjtrzYK0LD2H7G3EFqwrCd4C168=;\n\tb=eVDBCFbRcPnP/3jZJCImzwMLlAjwwfFG8I+mtRswnB9DchjWVV0I1gcl549o+vkby7\n\tD2d7jmp9PxUxp6bi5Ccm8f0NfaoiQjPKuGsBOW7t6eYxU5vejIO2oGlMqy32ksi+bQSv\n\t1cqOtqI/OtSlmIX27fcKR71Ip1I/EJIBr5PlIk5/yhfeWAvC1YBwOGUA/J9BaO/WhYrX\n\tqsy4YuhWsxm2uOGF0m2G9uScv+xRI3aYR5faT0WPCUFqSIqI/HZJkohL+khLganp5kWu\n\tp9tuRbrgJV8W1KDV6FX0ZdLfElOg8yWSwDGEt5naOkAi+PrYQVC5+c0clkORjE+bJ5UP\n\tr+FQ==","X-Gm-Message-State":"AOAM5320G1nLoEGtmFKbDHq2xMXh1HChf4K4X5Q28zWlRrScE4I6iNPM\n\tlem+pwAAgor+WCwtFmBoymYmmnfWTY4XUMZEgpWV3ubSUREeAfMt","X-Google-Smtp-Source":"ABdhPJypwNKqW6cn6su7xSYFThu3SuVpnDi777EII9WvmFBKGQCdkY1iCldUuNzBGKL+qbSlCqsgBkL7qVBXx+lkjRs=","X-Received":"by 2002:a25:55c5:: with SMTP id\n\tj188mr2038713ybb.455.1612479809358; \n\tThu, 04 Feb 2021 15:03:29 -0800 (PST)","MIME-Version":"1.0","References":"<20210204012731.1942112-1-hiroh@chromium.org>\n\t<20210204012731.1942112-2-hiroh@chromium.org>\n\t<YBv+lMg17Z/gB/5N@oden.dyn.berto.se>","In-Reply-To":"<YBv+lMg17Z/gB/5N@oden.dyn.berto.se>","From":"Hirokazu Honda <hiroh@chromium.org>","Date":"Fri, 5 Feb 2021 08:03:19 +0900","Message-ID":"<CAO5uPHN7Mgr_pkTyB_i+BOm0kBzKVT3VG0wEuyjemUdi-zEjcg@mail.gmail.com>","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v4 1/2] subprojects: Add libyuv and\n\tbuilt if -Dandroid=enabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":15018,"web_url":"https://patchwork.libcamera.org/comment/15018/","msgid":"<YByHbikClBU4hoAz@oden.dyn.berto.se>","date":"2021-02-04T23:46:54","subject":"Re: [libcamera-devel] [PATCH v4 1/2] subprojects: Add libyuv and\n\tbuilt if -Dandroid=enabled","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Honda-san,\n\nThanks for your reply.\n\nOn 2021-02-05 08:03:19 +0900, Hirokazu Honda wrote:\n> Hi Niklas,\n> \n> On Thu, Feb 4, 2021 at 11:03 PM Niklas Söderlund\n> <niklas.soderlund@ragnatech.se> wrote:\n> >\n> > Hi Honda-san,\n> >\n> > Thanks for your work.\n> >\n> > On 2021-02-04 01:27:30 +0000, Hirokazu Honda wrote:\n> > > Android HAL adaptation layer may need image processing, for\n> > > example, scaling and format conversion. Libyuv is a general image\n> > > processing. This adds libyuv to subprojects, so that it is forked\n> > > locally and can be used with Android HAL implementation code.\n> > >\n> > > Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > > ---\n> > >  README.rst              |  2 +-\n> > >  meson.build             |  2 +-\n> > >  src/android/meson.build | 17 +++++++++++++++++\n> > >  subprojects/.gitignore  |  1 +\n> > >  subprojects/libyuv.wrap |  4 ++++\n> > >  5 files changed, 24 insertions(+), 2 deletions(-)\n> > >  create mode 100644 subprojects/.gitignore\n> > >  create mode 100644 subprojects/libyuv.wrap\n> > >\n> > > diff --git a/README.rst b/README.rst\n> > > index 251291b7..08bfd5ad 100644\n> > > --- a/README.rst\n> > > +++ b/README.rst\n> > > @@ -47,7 +47,7 @@ A C++ toolchain: [required]\n> > >       Either {g++, clang}\n> > >\n> > >  Meson Build system: [required]\n> > > -        meson (>= 0.51) ninja-build pkg-config\n> > > +        meson (>= 0.55) ninja-build pkg-config\n> > >\n> > >          If your distribution doesn't provide a recent enough version of meson,\n> > >          you can install or upgrade it using pip3.\n> > > diff --git a/meson.build b/meson.build\n> > > index 743cb1d2..be77191d 100644\n> > > --- a/meson.build\n> > > +++ b/meson.build\n> > > @@ -1,7 +1,7 @@\n> > >  # SPDX-License-Identifier: CC0-1.0\n> > >\n> > >  project('libcamera', 'c', 'cpp',\n> > > -    meson_version : '>= 0.53',\n> > > +    meson_version : '>= 0.55',\n> >\n> > I know this patch is already merged, but bumping meson version over\n> > v0.54.3 breaks my CrOS build environment for Soraka based on R89 (and\n> > I'm told R90 also ships with meson v0.54.3). I understand the need to\n> > move to meson v0.55, I'm just curious if you know of a build environment\n> > I can switch to.\n> >\n> \n> I faced the same issue.\n> The meson command in ChromeOS chroot is the same as\n> portage-stable/dev-util/meson. [1]\n> It is 0.55.3. It thus shouldn't matter.\n> The meson command is not upreved unless `./update_chroot` doesn't run.\n> The command is hooked to run by some command (e.g. setup_board).\n> Of course, you can run manually  `./update_chroot`.\n> Hope it is helpful for you.\n\nThanks for this suggestion, I tried to run update_chroot and it update \nsome components of my chroot (gcc and gdb) but not meson. Unfortunately \nI don't have the log from the first run as I restarted the chroot to \ncheck if that would help. Here is the output if I try in my now \nup-to-date chroot.\n\n  (cr) ((5e00a24744cba80c...)) neg@neg-cros ~/trunk/src/scripts $ ./update_chroot \n  00:37:38 INFO    : Updating chroot\n  00:37:38 INFO    : Clearing shadow utils lockfiles under /\n  00:37:38 INFO    : Updating cross-compilers\n  00:37:38: INFO: Determining required toolchain updates...\n  00:37:39: INFO: Nothing to update!\n  00:37:39 INFO    : Bootstrapping depot_tools\n  00:37:57 INFO    : Rebuilding Portage cache\n  00:37:59 INFO    : Updating the SDK\n  \n  These are the packages that would be merged, in order:\n  \n  Calculating dependencies... done!\n  \n  Total: 0 packages, Size of downloads: 0 KiB\n  \n  Nothing to merge; quitting.\n  \n  \n  These are the packages that would be merged, in order:\n  \n  Calculating dependencies... done!\n  \n  Total: 0 packages, Size of downloads: 0 KiB\n  \n  Nothing to merge; quitting.\n  \n  Scanning Configuration files...\n  Exiting: Nothing left to do; exiting. :)\n  00:38:30 INFO    : Running 'eclean -d packages' to clean up stale binpkgs\n   * Building file list for packages cleaning...\n   * Your packages directory was already clean.\n  00:38:31 INFO    : Elapsed time (update_chroot): 0m54s\n  (cr) ((5e00a24744cba80c...)) neg@neg-cros ~/trunk/src/scripts $ meson --version\n  0.54.2\n\nAre there some other trick I can use to update meson in the chroot?\n\n> \n> [1] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/third_party/portage-stable/dev-util/meson/\n> \n> Thanks,\n> -Hiro\n> \n> > >      version : '0.0.0',\n> > >      default_options : [\n> > >          'werror=true',\n> > > diff --git a/src/android/meson.build b/src/android/meson.build\n> > > index 3d4d3be4..7619517a 100644\n> > > --- a/src/android/meson.build\n> > > +++ b/src/android/meson.build\n> > > @@ -14,6 +14,23 @@ foreach dep : android_deps\n> > >      endif\n> > >  endforeach\n> > >\n> > > +if android_enabled\n> > > +    cmake = import('cmake')\n> > > +\n> > > +    libyuv_vars = cmake.subproject_options()\n> > > +    libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n> > > +    libyuv_vars.set_override_option('cpp_std', 'c++17')\n> > > +    libyuv_vars.append_compile_args('cpp',\n> > > +         '-Wno-sign-compare',\n> > > +         '-Wno-unused-variable',\n> > > +         '-Wno-unused-parameter')\n> > > +    libyuv_vars.append_link_args('-ljpeg')\n> > > +    libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> > > +    libyuv_dep = libyuv.dependency('yuv')\n> > > +\n> > > +    android_deps += [ libyuv_dep, ]\n> > > +endif\n> > > +\n> > >  android_hal_sources = files([\n> > >      'camera3_hal.cpp',\n> > >      'camera_hal_manager.cpp',\n> > > diff --git a/subprojects/.gitignore b/subprojects/.gitignore\n> > > new file mode 100644\n> > > index 00000000..410b8bd6\n> > > --- /dev/null\n> > > +++ b/subprojects/.gitignore\n> > > @@ -0,0 +1 @@\n> > > +/libyuv\n> > > \\ No newline at end of file\n> > > diff --git a/subprojects/libyuv.wrap b/subprojects/libyuv.wrap\n> > > new file mode 100644\n> > > index 00000000..8ba51fa0\n> > > --- /dev/null\n> > > +++ b/subprojects/libyuv.wrap\n> > > @@ -0,0 +1,4 @@\n> > > +[wrap-git]\n> > > +directory = libyuv\n> > > +url = https://chromium.googlesource.com/libyuv/libyuv.git\n> > > +revision = 93b1b332cd60b56ab90aea14182755e379c28a80\n> > > --\n> > > 2.30.0.365.g02bc693789-goog\n> > > _______________________________________________\n> > > libcamera-devel mailing list\n> > > libcamera-devel@lists.libcamera.org\n> > > https://lists.libcamera.org/listinfo/libcamera-devel\n> >\n> > --\n> > Regards,\n> > Niklas Söderlund","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 711E3BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  4 Feb 2021 23:46:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D3D60614A2;\n\tFri,  5 Feb 2021 00:46:58 +0100 (CET)","from mail-lj1-x234.google.com (mail-lj1-x234.google.com\n\t[IPv6:2a00:1450:4864:20::234])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A47B6149B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Feb 2021 00:46:57 +0100 (CET)","by mail-lj1-x234.google.com with SMTP id a17so5603987ljq.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 04 Feb 2021 15:46:57 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\td28sm778994lfn.15.2021.02.04.15.46.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 15:46:55 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"r6Zungac\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=kEA1508tbVXkiiVvlV+HLspYTFqjawpOKPiJ46oWZGg=;\n\tb=r6ZungaciwramT7keyIkl0e+L7sQa7kpfO68kmLmSRhddUVKaOtgbZ7/vkcfa66h2W\n\ta8pLScFwlFfl9N3DjJ37wngBbG/3LW9gs/ve0y3JeVHDgShc1ZGrzy4WQbjF9N1vGBak\n\t86FrT2HoM4OEaumXFLS1g9aUCvPi9vgz1u7m5uBaektbXNAv8Ji4RAONWqBU4w12WHIv\n\tfgNx/bOxj24b+JQ4mWEeZEpFK4NvBIlGZqAbMrihiRu6fQ2/mmWTOt6/Bm66eA5SwhY0\n\tJLRRhGzSywc/fC5RgdC1o/3IsLBzdlsajAi2JnRylGuqnvLO+VSZR1G3TUYMaVrCbzmB\n\tNSdg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=kEA1508tbVXkiiVvlV+HLspYTFqjawpOKPiJ46oWZGg=;\n\tb=KQVgq+6XIZkVAGdHO49/lMOTa2dcx+VZSjU/DAFNX4qq3UDMrZn/OB8xS+PQfEWKeW\n\tVlMG9ij7HDTRnA/rtnagmXfVYQOdNLuEzNSx8GYUjSzAGQVXWadA+2GT0AVqB3hQlh3Y\n\tAidkW9Br9/slICB+vFzffJBBrahxZr2Xt2Mvmj00viFQPAamIUa5N0fJszUHPJo/NtXZ\n\tYR3lXMKmEPZtYWW64UpNmB9X9yWxIf68FEEoXPjwoSD83wpZaZVG91CmCf4KFH7b8ZIf\n\t4ppJQmEdTTMYW/c/QRZC1Jnb9b5viGoOt993DH0Ej+o8rVsbPK/prN3bbqGrhmslaLPI\n\tbnxQ==","X-Gm-Message-State":"AOAM532//aupsrtDJhZ7fqZDuYzq+YqGa0ee4KW7yovY1f6Nj8+Fumm8\n\tesFCtvAUfcbNSqD9xtRAa8PhFUCYk3j0Trze","X-Google-Smtp-Source":"ABdhPJyJ/GpHVZj+NY/+LufRudzjQwR967b1LTIAax8yoH6k4fBCX+4dLY57qG5lGZ6rE14/VnR4nw==","X-Received":"by 2002:a2e:9f4e:: with SMTP id\n\tv14mr1006006ljk.497.1612482416401; \n\tThu, 04 Feb 2021 15:46:56 -0800 (PST)","Date":"Fri, 5 Feb 2021 00:46:54 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= <niklas.soderlund@ragnatech.se>","To":"Hirokazu Honda <hiroh@chromium.org>","Message-ID":"<YByHbikClBU4hoAz@oden.dyn.berto.se>","References":"<20210204012731.1942112-1-hiroh@chromium.org>\n\t<20210204012731.1942112-2-hiroh@chromium.org>\n\t<YBv+lMg17Z/gB/5N@oden.dyn.berto.se>\n\t<CAO5uPHN7Mgr_pkTyB_i+BOm0kBzKVT3VG0wEuyjemUdi-zEjcg@mail.gmail.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<CAO5uPHN7Mgr_pkTyB_i+BOm0kBzKVT3VG0wEuyjemUdi-zEjcg@mail.gmail.com>","Subject":"Re: [libcamera-devel] [PATCH v4 1/2] subprojects: Add libyuv and\n\tbuilt if -Dandroid=enabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":15020,"web_url":"https://patchwork.libcamera.org/comment/15020/","msgid":"<CAO5uPHMtzJYqwrjC30Xkz6=H9FnxOdS4tjKDDfSfBmgGfAXtXw@mail.gmail.com>","date":"2021-02-05T00:17:00","subject":"Re: [libcamera-devel] [PATCH v4 1/2] subprojects: Add libyuv and\n\tbuilt if -Dandroid=enabled","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"content":"On Fri, Feb 5, 2021 at 8:46 AM Niklas Söderlund\n<niklas.soderlund@ragnatech.se> wrote:\n>\n> Hi Honda-san,\n>\n> Thanks for your reply.\n>\n> On 2021-02-05 08:03:19 +0900, Hirokazu Honda wrote:\n> > Hi Niklas,\n> >\n> > On Thu, Feb 4, 2021 at 11:03 PM Niklas Söderlund\n> > <niklas.soderlund@ragnatech.se> wrote:\n> > >\n> > > Hi Honda-san,\n> > >\n> > > Thanks for your work.\n> > >\n> > > On 2021-02-04 01:27:30 +0000, Hirokazu Honda wrote:\n> > > > Android HAL adaptation layer may need image processing, for\n> > > > example, scaling and format conversion. Libyuv is a general image\n> > > > processing. This adds libyuv to subprojects, so that it is forked\n> > > > locally and can be used with Android HAL implementation code.\n> > > >\n> > > > Signed-off-by: Hirokazu Honda <hiroh@chromium.org>\n> > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> > > > ---\n> > > >  README.rst              |  2 +-\n> > > >  meson.build             |  2 +-\n> > > >  src/android/meson.build | 17 +++++++++++++++++\n> > > >  subprojects/.gitignore  |  1 +\n> > > >  subprojects/libyuv.wrap |  4 ++++\n> > > >  5 files changed, 24 insertions(+), 2 deletions(-)\n> > > >  create mode 100644 subprojects/.gitignore\n> > > >  create mode 100644 subprojects/libyuv.wrap\n> > > >\n> > > > diff --git a/README.rst b/README.rst\n> > > > index 251291b7..08bfd5ad 100644\n> > > > --- a/README.rst\n> > > > +++ b/README.rst\n> > > > @@ -47,7 +47,7 @@ A C++ toolchain: [required]\n> > > >       Either {g++, clang}\n> > > >\n> > > >  Meson Build system: [required]\n> > > > -        meson (>= 0.51) ninja-build pkg-config\n> > > > +        meson (>= 0.55) ninja-build pkg-config\n> > > >\n> > > >          If your distribution doesn't provide a recent enough version of meson,\n> > > >          you can install or upgrade it using pip3.\n> > > > diff --git a/meson.build b/meson.build\n> > > > index 743cb1d2..be77191d 100644\n> > > > --- a/meson.build\n> > > > +++ b/meson.build\n> > > > @@ -1,7 +1,7 @@\n> > > >  # SPDX-License-Identifier: CC0-1.0\n> > > >\n> > > >  project('libcamera', 'c', 'cpp',\n> > > > -    meson_version : '>= 0.53',\n> > > > +    meson_version : '>= 0.55',\n> > >\n> > > I know this patch is already merged, but bumping meson version over\n> > > v0.54.3 breaks my CrOS build environment for Soraka based on R89 (and\n> > > I'm told R90 also ships with meson v0.54.3). I understand the need to\n> > > move to meson v0.55, I'm just curious if you know of a build environment\n> > > I can switch to.\n> > >\n> >\n> > I faced the same issue.\n> > The meson command in ChromeOS chroot is the same as\n> > portage-stable/dev-util/meson. [1]\n> > It is 0.55.3. It thus shouldn't matter.\n> > The meson command is not upreved unless `./update_chroot` doesn't run.\n> > The command is hooked to run by some command (e.g. setup_board).\n> > Of course, you can run manually  `./update_chroot`.\n> > Hope it is helpful for you.\n>\n> Thanks for this suggestion, I tried to run update_chroot and it update\n> some components of my chroot (gcc and gdb) but not meson. Unfortunately\n> I don't have the log from the first run as I restarted the chroot to\n> check if that would help. Here is the output if I try in my now\n> up-to-date chroot.\n>\n>   (cr) ((5e00a24744cba80c...)) neg@neg-cros ~/trunk/src/scripts $ ./update_chroot\n>   00:37:38 INFO    : Updating chroot\n>   00:37:38 INFO    : Clearing shadow utils lockfiles under /\n>   00:37:38 INFO    : Updating cross-compilers\n>   00:37:38: INFO: Determining required toolchain updates...\n>   00:37:39: INFO: Nothing to update!\n>   00:37:39 INFO    : Bootstrapping depot_tools\n>   00:37:57 INFO    : Rebuilding Portage cache\n>   00:37:59 INFO    : Updating the SDK\n>\n>   These are the packages that would be merged, in order:\n>\n>   Calculating dependencies... done!\n>\n>   Total: 0 packages, Size of downloads: 0 KiB\n>\n>   Nothing to merge; quitting.\n>\n>\n>   These are the packages that would be merged, in order:\n>\n>   Calculating dependencies... done!\n>\n>   Total: 0 packages, Size of downloads: 0 KiB\n>\n>   Nothing to merge; quitting.\n>\n>   Scanning Configuration files...\n>   Exiting: Nothing left to do; exiting. :)\n>   00:38:30 INFO    : Running 'eclean -d packages' to clean up stale binpkgs\n>    * Building file list for packages cleaning...\n>    * Your packages directory was already clean.\n>   00:38:31 INFO    : Elapsed time (update_chroot): 0m54s\n>   (cr) ((5e00a24744cba80c...)) neg@neg-cros ~/trunk/src/scripts $ meson --version\n>   0.54.2\n>\n> Are there some other trick I can use to update meson in the chroot?\n>\n\nNiklas told me this issue was resolved by updating ChromiumOS repository. :)\n\n-Hiro\n> >\n> > [1] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/third_party/portage-stable/dev-util/meson/\n> >\n> > Thanks,\n> > -Hiro\n> >\n> > > >      version : '0.0.0',\n> > > >      default_options : [\n> > > >          'werror=true',\n> > > > diff --git a/src/android/meson.build b/src/android/meson.build\n> > > > index 3d4d3be4..7619517a 100644\n> > > > --- a/src/android/meson.build\n> > > > +++ b/src/android/meson.build\n> > > > @@ -14,6 +14,23 @@ foreach dep : android_deps\n> > > >      endif\n> > > >  endforeach\n> > > >\n> > > > +if android_enabled\n> > > > +    cmake = import('cmake')\n> > > > +\n> > > > +    libyuv_vars = cmake.subproject_options()\n> > > > +    libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n> > > > +    libyuv_vars.set_override_option('cpp_std', 'c++17')\n> > > > +    libyuv_vars.append_compile_args('cpp',\n> > > > +         '-Wno-sign-compare',\n> > > > +         '-Wno-unused-variable',\n> > > > +         '-Wno-unused-parameter')\n> > > > +    libyuv_vars.append_link_args('-ljpeg')\n> > > > +    libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n> > > > +    libyuv_dep = libyuv.dependency('yuv')\n> > > > +\n> > > > +    android_deps += [ libyuv_dep, ]\n> > > > +endif\n> > > > +\n> > > >  android_hal_sources = files([\n> > > >      'camera3_hal.cpp',\n> > > >      'camera_hal_manager.cpp',\n> > > > diff --git a/subprojects/.gitignore b/subprojects/.gitignore\n> > > > new file mode 100644\n> > > > index 00000000..410b8bd6\n> > > > --- /dev/null\n> > > > +++ b/subprojects/.gitignore\n> > > > @@ -0,0 +1 @@\n> > > > +/libyuv\n> > > > \\ No newline at end of file\n> > > > diff --git a/subprojects/libyuv.wrap b/subprojects/libyuv.wrap\n> > > > new file mode 100644\n> > > > index 00000000..8ba51fa0\n> > > > --- /dev/null\n> > > > +++ b/subprojects/libyuv.wrap\n> > > > @@ -0,0 +1,4 @@\n> > > > +[wrap-git]\n> > > > +directory = libyuv\n> > > > +url = https://chromium.googlesource.com/libyuv/libyuv.git\n> > > > +revision = 93b1b332cd60b56ab90aea14182755e379c28a80\n> > > > --\n> > > > 2.30.0.365.g02bc693789-goog\n> > > > _______________________________________________\n> > > > libcamera-devel mailing list\n> > > > libcamera-devel@lists.libcamera.org\n> > > > https://lists.libcamera.org/listinfo/libcamera-devel\n> > >\n> > > --\n> > > Regards,\n> > > Niklas Söderlund\n>\n> --\n> Regards,\n> Niklas Söderlund","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B6227BD160\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  5 Feb 2021 00:17:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 48A1060301;\n\tFri,  5 Feb 2021 01:17:12 +0100 (CET)","from mail-ej1-x635.google.com (mail-ej1-x635.google.com\n\t[IPv6:2a00:1450:4864:20::635])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A19C060301\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  5 Feb 2021 01:17:10 +0100 (CET)","by mail-ej1-x635.google.com with SMTP id b9so8707112ejy.12\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 04 Feb 2021 16:17:10 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"E4uFWlu1\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc:content-transfer-encoding;\n\tbh=bzJqr7pXuL1/h6j0r1SFXN7Eu1dYV6tNAvWAa0N6ktU=;\n\tb=E4uFWlu1EnWB5hIvtosSSCM5yT1LkZOFTic2M/GAMPKe416p7HdMOPLCIzCvW38KcR\n\tP+PZ5m7hjn1nkw9KBjFmyyJpTp7RxxRkCWgDMjG+ErAkvpbq9Y2y25TeXjeXBtQ9pHge\n\tE2xU938b+WmaMqX0acTZmA5mQf5OY1meYQMdc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc:content-transfer-encoding;\n\tbh=bzJqr7pXuL1/h6j0r1SFXN7Eu1dYV6tNAvWAa0N6ktU=;\n\tb=kAzkXrPMQ4EgJCnTA4O5FVYnjmhf7ZbK/cJesrUuySAkyvZQdcQqc+fOCDdVrnSVRi\n\tMKjpgQL8DEdT6QD/5YM4vxdTBzskyKDO8+nqtN5r2IPDOX0DwYkLyVAZFtRQvAZRNotC\n\typHcNOEg7XxtrSLlNMHpldGxv2YYRYyHfw3gczCdXKJtLl803bFY1kx3Ihg57IlFHseM\n\t13p72G8kp6bRborJ8hj7VO1qGVWaUT4DsqYB06i/gfKxpucSQfteg+axXCmtuGNDdjlU\n\tbSPZLIYOXVI3/iILjCXWERqJ5bYsa0nc4XgQpPcMCI+NsEAHm66a45POQ8DZkMPjsz/V\n\t/uAg==","X-Gm-Message-State":"AOAM531FmJe/+WtApqxYMqCqiTzHuAG/6sxNah7PXt9owP/jk+KBWtxA\n\tGaIsz6kueKI0mHe3uO9HWAlzyw64Gh8a1AQecgNLAA==","X-Google-Smtp-Source":"ABdhPJwvOeHQBpTZ3MV53xmJ3GN7RjdhEf2CxnX7ouy2fIeRRPHzpmh3qdg7cr7MDujuI8FsulSfP55RX0ZhTb+A98g=","X-Received":"by 2002:a17:906:7c4b:: with SMTP id\n\tg11mr1502315ejp.475.1612484230254; \n\tThu, 04 Feb 2021 16:17:10 -0800 (PST)","MIME-Version":"1.0","References":"<20210204012731.1942112-1-hiroh@chromium.org>\n\t<20210204012731.1942112-2-hiroh@chromium.org>\n\t<YBv+lMg17Z/gB/5N@oden.dyn.berto.se>\n\t<CAO5uPHN7Mgr_pkTyB_i+BOm0kBzKVT3VG0wEuyjemUdi-zEjcg@mail.gmail.com>\n\t<YByHbikClBU4hoAz@oden.dyn.berto.se>","In-Reply-To":"<YByHbikClBU4hoAz@oden.dyn.berto.se>","From":"Hirokazu Honda <hiroh@chromium.org>","Date":"Fri, 5 Feb 2021 09:17:00 +0900","Message-ID":"<CAO5uPHMtzJYqwrjC30Xkz6=H9FnxOdS4tjKDDfSfBmgGfAXtXw@mail.gmail.com>","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v4 1/2] subprojects: Add libyuv and\n\tbuilt if -Dandroid=enabled","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Cc":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]