[{"id":14958,"web_url":"https://patchwork.libcamera.org/comment/14958/","msgid":"","date":"2021-02-04T09:43:31","subject":"Re: [libcamera-devel] [PATCH 7/7] android: camera_device: Report\n\tHOT_PIXEL_MAP_MODE as OFF","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2021-02-03 17:26:00 +0100, Jacopo Mondi wrote:\n> The CaptureResultTest#testCameraCaptureResultAllKeys enforces the\n> presence of the ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE result\n> metadata.\n> \n> Report ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE_OFF as the Camera HAL\n> does not support the generation of an hot pixel correction map.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 2b065d57febb..df5e295656d7 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -708,7 +708,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * Currently: 53 entries, 846 bytes of static metadata\n> \t */\n> \tuint32_t numEntries = 53;\n> -\tuint32_t byteSize = 858;\n> +\tuint32_t byteSize = 862;\n> \n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -1285,6 +1285,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_SENSOR_TIMESTAMP,\n> \t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> \t\tANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n> +\t\tANDROID_STATISTICS_HOT_PIXEL_MAP_MODE,\n> \t\tANDROID_STATISTICS_SCENE_FLICKER,\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_RESULT_KEYS,\n> @@ -1966,7 +1967,7 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \t * Total bytes for JPEG metadata: 82\n> \t */\n> \tstd::unique_ptr resultMetadata =\n> -\t\tstd::make_unique(43, 165);\n> +\t\tstd::make_unique(44, 166);\n> \tif (!resultMetadata->isValid()) {\n> \t\tLOG(HAL, Error) << \"Failed to allocate static metadata\";\n> \t\treturn nullptr;\n> @@ -2073,6 +2074,10 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \tresultMetadata->addEntry(ANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n> \t\t\t\t &value, 1);\n> \n> +\tvalue = ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE_OFF;\n> +\tresultMetadata->addEntry(ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE,\n> +\t\t\t\t &value, 1);\n> +\n> \tvalue = ANDROID_STATISTICS_SCENE_FLICKER_NONE;\n> \tresultMetadata->addEntry(ANDROID_STATISTICS_SCENE_FLICKER,\n> \t\t\t\t &value, 1);\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7946ABD162\n\tfor ;\n\tThu, 4 Feb 2021 09:43:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46BE961419;\n\tThu, 4 Feb 2021 10:43:34 +0100 (CET)","from mail-ed1-x532.google.com (mail-ed1-x532.google.com\n\t[IPv6:2a00:1450:4864:20::532])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E741F61402\n\tfor ;\n\tThu, 4 Feb 2021 10:43:32 +0100 (CET)","by mail-ed1-x532.google.com with SMTP id i5so3285573edu.10\n\tfor ;\n\tThu, 04 Feb 2021 01:43:32 -0800 (PST)","from localhost (p4fca2458.dip0.t-ipconnect.de. [79.202.36.88])\n\tby smtp.gmail.com with ESMTPSA id\n\tf22sm2211429eje.34.2021.02.04.01.43.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 01:43:32 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"STX2LgWy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=e6Eg2REchStKH1QDKMOOPOkv+3qIS3r6t0OephrYg18=;\n\tb=STX2LgWy8tBCrkB/lrFaDkl1zkSQSnRueJmwOceYRS/Cjsb4Aw/P5e7n8cX+dcI49K\n\tlEi8Lwmcqjczzw8Qj8ZSjqAREkmITHTqBwjjs/0yEOsBRVG1xukqcQii0Vf2IjXpo14q\n\tZmieocLRahNZkMy871GFdnNXUr0S8J7oBATmWQVHLYmsOKZJdOAZGfmqVpQzY43fJ3Od\n\tW1xV7JN2vDQINUtktWqcXvLThmv0jgBVzRb+bs6T/SqFlrHG3KkM1P7PH0JZCajldvUa\n\t++rkrFsB+4Himz3w1dCgvOKN1oHi5fTdJRwJJE+RrOOOumuiWH7iVqLIWUpRfbcvXqZ8\n\tCx/g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=e6Eg2REchStKH1QDKMOOPOkv+3qIS3r6t0OephrYg18=;\n\tb=S52wvhh/lO5YBYhHmVKxatlnBd6yzzKAzEvew7+sA2I25yjtdkGChUNOJzbESnuGDX\n\tMUiPJzM8DaF0PtCBYyu2iyHS0vsJjnuIIBERXZURQ51VSLyiUuYrT22bZRrj0U4PSRlT\n\t3f4t3E79vmwOk4bcWSzu9HeoZHUFNHI+59B2VgJh7y9kTnDJRuVSrCJcbGWHMu9AXTjX\n\tfRlGj19Z42XIAvTKPxs5wUssMyH6SIhVPzuI3bYdlucC4EooYxHM2U6H2lRPl5zLEQQ4\n\tq3wBQPo0Byo8cj6ZaX2ajMwZ4iMIYN3JAKM3L4l1gSd4w31mEwrrM+MJ+7PHJcwnl65c\n\t8TEg==","X-Gm-Message-State":"AOAM530bLagdVjwIBh2h+059dENt/iQCU4QJrd+4pISQD7u+J0+Amca3\n\tqerh2EVvaJPrDPjhdQd3gdj7uQ==","X-Google-Smtp-Source":"ABdhPJzlbt7AHD0V8RWqTA8JX9I663cgSgwROStS7ey2K9mi76NU84eI48OKslQ+yAsKQxQ9m8ZDEw==","X-Received":"by 2002:a05:6402:1155:: with SMTP id\n\tg21mr7039673edw.279.1612431812682; \n\tThu, 04 Feb 2021 01:43:32 -0800 (PST)","Date":"Thu, 4 Feb 2021 10:43:31 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210203162600.206297-1-jacopo@jmondi.org>\n\t<20210203162600.206297-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203162600.206297-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 7/7] android: camera_device: Report\n\tHOT_PIXEL_MAP_MODE as OFF","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15006,"web_url":"https://patchwork.libcamera.org/comment/15006/","msgid":"","date":"2021-02-04T22:13:11","subject":"Re: [libcamera-devel] [PATCH 7/7] android: camera_device: Report\n\tHOT_PIXEL_MAP_MODE as OFF","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Feb 03, 2021 at 05:26:00PM +0100, Jacopo Mondi wrote:\n> The CaptureResultTest#testCameraCaptureResultAllKeys enforces the\n> presence of the ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE result\n> metadata.\n> \n> Report ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE_OFF as the Camera HAL\n> does not support the generation of an hot pixel correction map.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 2b065d57febb..df5e295656d7 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -708,7 +708,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * Currently: 53 entries, 846 bytes of static metadata\n> \t */\n> \tuint32_t numEntries = 53;\n> -\tuint32_t byteSize = 858;\n> +\tuint32_t byteSize = 862;\n> \n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -1285,6 +1285,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_SENSOR_TIMESTAMP,\n> \t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> \t\tANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n> +\t\tANDROID_STATISTICS_HOT_PIXEL_MAP_MODE,\n> \t\tANDROID_STATISTICS_SCENE_FLICKER,\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_RESULT_KEYS,\n> @@ -1966,7 +1967,7 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \t * Total bytes for JPEG metadata: 82\n> \t */\n> \tstd::unique_ptr resultMetadata =\n> -\t\tstd::make_unique(43, 165);\n> +\t\tstd::make_unique(44, 166);\n> \tif (!resultMetadata->isValid()) {\n> \t\tLOG(HAL, Error) << \"Failed to allocate static metadata\";\n> \t\treturn nullptr;\n> @@ -2073,6 +2074,10 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \tresultMetadata->addEntry(ANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n> \t\t\t\t &value, 1);\n> \n> +\tvalue = ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE_OFF;\n> +\tresultMetadata->addEntry(ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE,\n> +\t\t\t\t &value, 1);\n> +\n> \tvalue = ANDROID_STATISTICS_SCENE_FLICKER_NONE;\n> \tresultMetadata->addEntry(ANDROID_STATISTICS_SCENE_FLICKER,\n> \t\t\t\t &value, 1);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 287E3BD160\n\tfor ;\n\tThu, 4 Feb 2021 22:13:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC08461481;\n\tThu, 4 Feb 2021 23:13:35 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E0F1561430\n\tfor ;\n\tThu, 4 Feb 2021 23:13:33 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7BD2945D;\n\tThu, 4 Feb 2021 23:13:33 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gcsukKH4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612476813;\n\tbh=x9WZRAsQozn6mM99f+FITvdOS9Op5+GTpf85Mbk5Nsc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gcsukKH4Y46cLb24iQbHG7Rh8oWFgOwrYNfauxtexyyRtGaqt8xwUsNUlBqjKBBKl\n\t1ntZLIq8ZCds3urlcJdVMlo8MlgOkYIHzrCGiNzfnGwf6lsJwlchoNm9ECgWFr6Tw9\n\t3onPMCYUbgfV2iOnJQ8qOsvKSp+89nbXyTuo6FBY=","Date":"Fri, 5 Feb 2021 00:13:11 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210203162600.206297-1-jacopo@jmondi.org>\n\t<20210203162600.206297-8-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203162600.206297-8-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 7/7] android: camera_device: Report\n\tHOT_PIXEL_MAP_MODE as OFF","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]