[{"id":14957,"web_url":"https://patchwork.libcamera.org/comment/14957/","msgid":"","date":"2021-02-04T09:42:29","subject":"Re: [libcamera-devel] [PATCH 6/7] android: camera_device: Report\n\tsensor test pattern mode","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-02-03 17:25:59 +0100, Jacopo Mondi wrote:\n> The CaptureResultTest#testCameraCaptureResultAllKeys enforces the\n> presence of the ANDROID_SENSOR_TEST_PATTERN_MODE result metadata.\n> \n> Report the only supported value of ANDROID_SENSOR_TEST_PATTERN_MODE_OFF.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index fdda43e9b4af..2b065d57febb 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -708,7 +708,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * Currently: 53 entries, 846 bytes of static metadata\n> \t */\n> \tuint32_t numEntries = 53;\n> -\tuint32_t byteSize = 854;\n> +\tuint32_t byteSize = 858;\n> \n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -1281,6 +1281,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_SCALER_CROP_REGION,\n> \t\tANDROID_SENSOR_EXPOSURE_TIME,\n> \t\tANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> +\t\tANDROID_SENSOR_TEST_PATTERN_MODE,\n> \t\tANDROID_SENSOR_TIMESTAMP,\n> \t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> \t\tANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n> @@ -1965,7 +1966,7 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \t * Total bytes for JPEG metadata: 82\n> \t */\n> \tstd::unique_ptr resultMetadata =\n> -\t\tstd::make_unique(42, 161);\n> +\t\tstd::make_unique(43, 165);\n> \tif (!resultMetadata->isValid()) {\n> \t\tLOG(HAL, Error) << \"Failed to allocate static metadata\";\n> \t\treturn nullptr;\n> @@ -2058,6 +2059,10 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \tresultMetadata->addEntry(ANDROID_LENS_OPTICAL_STABILIZATION_MODE,\n> \t\t\t\t &value, 1);\n> \n> +\tvalue32 = ANDROID_SENSOR_TEST_PATTERN_MODE_OFF;\n> +\tresultMetadata->addEntry(ANDROID_SENSOR_TEST_PATTERN_MODE,\n> +\t\t\t\t &value32, 1);\n> +\n> \tresultMetadata->addEntry(ANDROID_SENSOR_TIMESTAMP, ×tamp, 1);\n> \n> \tvalue = ANDROID_STATISTICS_FACE_DETECT_MODE_OFF;\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DC725BD162\n\tfor ;\n\tThu, 4 Feb 2021 09:42:32 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A816361409;\n\tThu, 4 Feb 2021 10:42:32 +0100 (CET)","from mail-ej1-x634.google.com (mail-ej1-x634.google.com\n\t[IPv6:2a00:1450:4864:20::634])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 606E861402\n\tfor ;\n\tThu, 4 Feb 2021 10:42:31 +0100 (CET)","by mail-ej1-x634.google.com with SMTP id r12so4186990ejb.9\n\tfor ;\n\tThu, 04 Feb 2021 01:42:31 -0800 (PST)","from localhost (p4fca2458.dip0.t-ipconnect.de. [79.202.36.88])\n\tby smtp.gmail.com with ESMTPSA id\n\tm10sm2148741edi.54.2021.02.04.01.42.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 01:42:30 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"2GpoPUqz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=az3rWWGrzVSqmkJ3oAJi5xnDoyPFnbWYeMzXdeecuCY=;\n\tb=2GpoPUqzlk+v6n5EYHXAa2w2Ldbr1JbYmnt9Gr20flLewj5DPmNWd3qF1urXGgENRJ\n\tBcO4DcUBsX8ZEImT5LTIqOJmE7c/aP0ILKCO7Xq6Zd+eDZ/mZvdaiyvtfRPZ+ocKxS4m\n\twZ5f3WMzuCnDwiWfIZfy/V8cq7/RMG2xdJrCuF4M2rW0E1Fcsp4dWcY8UtKAt3D3Mcfs\n\tvwZzJdOKTXAtRswjdb9wbESIMutw/e8B91nhnj59RxAHSj0v/r/aVGWSH3Fuz0uHDQNy\n\tS5YzS49VCiMvK0Ra8dWBSFz+LV5/zrgZaqQhw+/qyYKBOBWf22ZhkCNejUuRsavNEEml\n\tu1ag==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=az3rWWGrzVSqmkJ3oAJi5xnDoyPFnbWYeMzXdeecuCY=;\n\tb=cUnSJYqBJJQI4hI8RuAz1b1cK+XsP9vq5KbSv7WNAPoMDGGhBdSczXQ2WtnYjDXOue\n\tsZ77u0f484g0feehc38na36OtcQbVU6LA4OP4I482jjaEH8RzJBO4PBUPOu1F7Tvfy4p\n\tnzAQs5ScY3vJsu30z9QqFWZa1PdgtjbRtzq5V42uCI7FZCZpw3xNQqLxHEEIrk7qofvX\n\tpClWq0lfWn/274xDeAx2SZ0PhIpZnCZ9ot48cmCp/ehqkngi9a/nzHYvAJpxTnAgvATD\n\t36IpWtWfRoO4jkrFo4MjKy0F83eBQHGdMciP9lx3Xtay3Lgh2lj3mszFoFomSHoHpgGL\n\trW3w==","X-Gm-Message-State":"AOAM531LCioRZUDlzZPKq6u6DbFAYEmgDLD8eAEtOQs7FU2n+8FdiPnF\n\tdMv1JuzV5sy9tvaY2bJp+LdFhr2DAXW2wP/a","X-Google-Smtp-Source":"ABdhPJyWNo9g48kO6DbrAMEOp7sYNl7HXkKtYtkIQGBRdOsAlyRAvyZ2Laexu2haH/L/gUedll1Urw==","X-Received":"by 2002:a17:906:cf86:: with SMTP id\n\tum6mr7491339ejb.426.1612431751126; \n\tThu, 04 Feb 2021 01:42:31 -0800 (PST)","Date":"Thu, 4 Feb 2021 10:42:29 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210203162600.206297-1-jacopo@jmondi.org>\n\t<20210203162600.206297-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203162600.206297-7-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 6/7] android: camera_device: Report\n\tsensor test pattern mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15005,"web_url":"https://patchwork.libcamera.org/comment/15005/","msgid":"","date":"2021-02-04T22:12:31","subject":"Re: [libcamera-devel] [PATCH 6/7] android: camera_device: Report\n\tsensor test pattern mode","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Feb 03, 2021 at 05:25:59PM +0100, Jacopo Mondi wrote:\n> The CaptureResultTest#testCameraCaptureResultAllKeys enforces the\n> presence of the ANDROID_SENSOR_TEST_PATTERN_MODE result metadata.\n> \n> Report the only supported value of ANDROID_SENSOR_TEST_PATTERN_MODE_OFF.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index fdda43e9b4af..2b065d57febb 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -708,7 +708,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * Currently: 53 entries, 846 bytes of static metadata\n> \t */\n> \tuint32_t numEntries = 53;\n> -\tuint32_t byteSize = 854;\n> +\tuint32_t byteSize = 858;\n> \n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -1281,6 +1281,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_SCALER_CROP_REGION,\n> \t\tANDROID_SENSOR_EXPOSURE_TIME,\n> \t\tANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> +\t\tANDROID_SENSOR_TEST_PATTERN_MODE,\n> \t\tANDROID_SENSOR_TIMESTAMP,\n> \t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> \t\tANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n> @@ -1965,7 +1966,7 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \t * Total bytes for JPEG metadata: 82\n> \t */\n> \tstd::unique_ptr resultMetadata =\n> -\t\tstd::make_unique(42, 161);\n> +\t\tstd::make_unique(43, 165);\n> \tif (!resultMetadata->isValid()) {\n> \t\tLOG(HAL, Error) << \"Failed to allocate static metadata\";\n> \t\treturn nullptr;\n> @@ -2058,6 +2059,10 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \tresultMetadata->addEntry(ANDROID_LENS_OPTICAL_STABILIZATION_MODE,\n> \t\t\t\t &value, 1);\n> \n> +\tvalue32 = ANDROID_SENSOR_TEST_PATTERN_MODE_OFF;\n> +\tresultMetadata->addEntry(ANDROID_SENSOR_TEST_PATTERN_MODE,\n> +\t\t\t\t &value32, 1);\n> +\n> \tresultMetadata->addEntry(ANDROID_SENSOR_TIMESTAMP, ×tamp, 1);\n> \n> \tvalue = ANDROID_STATISTICS_FACE_DETECT_MODE_OFF;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7D27BD160\n\tfor ;\n\tThu, 4 Feb 2021 22:12:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76A8961481;\n\tThu, 4 Feb 2021 23:12:56 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CBF5561430\n\tfor ;\n\tThu, 4 Feb 2021 23:12:54 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5B7FB45D;\n\tThu, 4 Feb 2021 23:12:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cSu6H3bD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612476774;\n\tbh=Gq117n07YVWfYjlqem8hKrVP89gH6jhcW4Wwxan4TW0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cSu6H3bDgfdbYN3p8njGslu9aum9z8+lK3nvGIwGkyUFNR8/qm34eQfU5zFaiZpbi\n\tymzYgvTot5Jr38pJQlxHWS/MEtgZzYrKi49DbZIUae0332B7B33KM0A/liS3hxnt8a\n\tuXX6qxieuLeibeBnhP9APiS9DcDjeTHZhIgbjXE0=","Date":"Fri, 5 Feb 2021 00:12:31 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210203162600.206297-1-jacopo@jmondi.org>\n\t<20210203162600.206297-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203162600.206297-7-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 6/7] android: camera_device: Report\n\tsensor test pattern mode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]