[{"id":14954,"web_url":"https://patchwork.libcamera.org/comment/14954/","msgid":"","date":"2021-02-04T09:27:07","subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_device: Report\n\tAF_MODE_OFF in template","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-02-03 17:25:57 +0100, Jacopo Mondi wrote:\n> The CaptureResultTest#testCameraCaptureResultAllKeys CTS test\n> enforces the presence of the auto focus mode in the preview\n> request template.\n> \n> Add the only supported mode AF_MODE_OFF in the generated template.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 27f6ec109da9..fdda43e9b4af 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1306,7 +1306,7 @@ CameraMetadata *CameraDevice::requestTemplatePreview()\n> \t * \\todo Keep this in sync with the actual number of entries.\n> \t * Currently: 20 entries, 35 bytes\n> \t */\n> -\tCameraMetadata *requestTemplate = new CameraMetadata(20, 35);\n> +\tCameraMetadata *requestTemplate = new CameraMetadata(21, 36);\n> \tif (!requestTemplate->isValid()) {\n> \t\tdelete requestTemplate;\n> \t\treturn nullptr;\n> @@ -1339,6 +1339,9 @@ CameraMetadata *CameraDevice::requestTemplatePreview()\n> \trequestTemplate->addEntry(ANDROID_CONTROL_AE_ANTIBANDING_MODE,\n> \t\t\t\t &aeAntibandingMode, 1);\n> \n> +\tuint8_t afMode = ANDROID_CONTROL_AF_MODE_OFF;\n> +\trequestTemplate->addEntry(ANDROID_CONTROL_AF_MODE, &afMode, 1);\n> +\n> \tuint8_t afTrigger = ANDROID_CONTROL_AF_TRIGGER_IDLE;\n> \trequestTemplate->addEntry(ANDROID_CONTROL_AF_TRIGGER,\n> \t\t\t\t &afTrigger, 1);\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A0CCFBD160\n\tfor ;\n\tThu, 4 Feb 2021 09:27:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6D32E61400;\n\tThu, 4 Feb 2021 10:27:11 +0100 (CET)","from mail-ej1-x633.google.com (mail-ej1-x633.google.com\n\t[IPv6:2a00:1450:4864:20::633])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D63D60107\n\tfor ;\n\tThu, 4 Feb 2021 10:27:09 +0100 (CET)","by mail-ej1-x633.google.com with SMTP id i8so4129063ejc.7\n\tfor ;\n\tThu, 04 Feb 2021 01:27:09 -0800 (PST)","from localhost (p4fca2458.dip0.t-ipconnect.de. [79.202.36.88])\n\tby smtp.gmail.com with ESMTPSA id\n\tdi27sm309686edb.21.2021.02.04.01.27.08\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 01:27:08 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"d3bkOIOo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=nyH2Ls2zpcnAb7jVF8DBn3u/grzxB19GVmd0UXCy3EU=;\n\tb=d3bkOIOoR0uLb6RlGlja5nAcdtwX8IOd1YlB5o5mxl1srEXfOAz/KDotkSLBuwYby4\n\tzArBp8UrfHVlWtZTLX4Fyq7VmvCSQw4zf02lf4LLfocwWaRzwAWNrydnvS3VWQ1G4qM8\n\ttPfz1OFxUZKlH4qMiPtN+t4ZcrazL1cEOryiOuVXLJq7ls4pTC/bxm2Abm3zn54IqLcJ\n\tSH8dyVEL0L4eUo8bQShRWAq8kUE8nCkjN/I2Nv+hcwYYWMyH+8rOcqT8NWLoJdK8YwoA\n\tZ5/GnOe3TWjSLH2vpfZLYn/bHFcp5K15SyfA/ObgVV1l1E4d9wrNvgFGDyxlCbnpSA12\n\t4W0w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=nyH2Ls2zpcnAb7jVF8DBn3u/grzxB19GVmd0UXCy3EU=;\n\tb=HgYo7xilO0JzAvClkmrYRntv0HYEjJuOfDrJ+DYULYiSGxMgo+S6xI/wcNYpjtZvtS\n\t0glABy1pbxvXNt/uyqeCCBbKtmdW+sscNhkmaXvRquZe0vCvMOxXsndF4iwe40ElA/yW\n\tKOAIJTmg7A+G5vFnvjIBrqgHXLGVxsTtdvzf40k+cdxkEx/1pWwrCz1cbWtL81d9xG6c\n\tWVpNVvuq34y/eiMtPJaH8PD9VpowB3ri8+OKvvXp9sMPEkUO6oXExB6bROMHq7id6JLY\n\tAiLLO9yJnoFg56qtJw6RKFsmeZJIuKYWswhElw6S6aIXsUk86+NikgNdVAduiGw7tkQ6\n\tKOgg==","X-Gm-Message-State":"AOAM530plSiaXum0mmnhow0iqlK/axHVP1JmVhDtVpRZ9tMqP5bzOzay\n\t8c4j5QyHbT3KUyq6uGS+T5vpgBx+Z/nkZzPO","X-Google-Smtp-Source":"ABdhPJy+4sh6rqftuclwMvsbiArQ3rsPg14s4XgWcIBNtlL/CNEjugJnV4UjnnGccSQ+gzkZi1JhoQ==","X-Received":"by 2002:a17:906:39d0:: with SMTP id\n\ti16mr7130166eje.18.1612430829099; \n\tThu, 04 Feb 2021 01:27:09 -0800 (PST)","Date":"Thu, 4 Feb 2021 10:27:07 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210203162600.206297-1-jacopo@jmondi.org>\n\t<20210203162600.206297-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203162600.206297-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_device: Report\n\tAF_MODE_OFF in template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14955,"web_url":"https://patchwork.libcamera.org/comment/14955/","msgid":"","date":"2021-02-04T09:29:58","subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_device: Report\n\tAF_MODE_OFF in template","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-02-03 17:25:57 +0100, Jacopo Mondi wrote:\n> The CaptureResultTest#testCameraCaptureResultAllKeys CTS test\n> enforces the presence of the auto focus mode in the preview\n> request template.\n> \n> Add the only supported mode AF_MODE_OFF in the generated template.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 27f6ec109da9..fdda43e9b4af 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1306,7 +1306,7 @@ CameraMetadata *CameraDevice::requestTemplatePreview()\n> \t * \\todo Keep this in sync with the actual number of entries.\n> \t * Currently: 20 entries, 35 bytes\n> \t */\n> -\tCameraMetadata *requestTemplate = new CameraMetadata(20, 35);\n> +\tCameraMetadata *requestTemplate = new CameraMetadata(21, 36);\n> \tif (!requestTemplate->isValid()) {\n> \t\tdelete requestTemplate;\n> \t\treturn nullptr;\n> @@ -1339,6 +1339,9 @@ CameraMetadata *CameraDevice::requestTemplatePreview()\n> \trequestTemplate->addEntry(ANDROID_CONTROL_AE_ANTIBANDING_MODE,\n> \t\t\t\t &aeAntibandingMode, 1);\n> \n> +\tuint8_t afMode = ANDROID_CONTROL_AF_MODE_OFF;\n> +\trequestTemplate->addEntry(ANDROID_CONTROL_AF_MODE, &afMode, 1);\n> +\n> \tuint8_t afTrigger = ANDROID_CONTROL_AF_TRIGGER_IDLE;\n> \trequestTemplate->addEntry(ANDROID_CONTROL_AF_TRIGGER,\n> \t\t\t\t &afTrigger, 1);\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 741E1BD160\n\tfor ;\n\tThu, 4 Feb 2021 09:30:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0352861402;\n\tThu, 4 Feb 2021 10:30:01 +0100 (CET)","from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com\n\t[IPv6:2a00:1450:4864:20::62a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 434EC60107\n\tfor ;\n\tThu, 4 Feb 2021 10:30:00 +0100 (CET)","by mail-ej1-x62a.google.com with SMTP id sa23so4226259ejb.0\n\tfor ;\n\tThu, 04 Feb 2021 01:30:00 -0800 (PST)","from localhost (p4fca2458.dip0.t-ipconnect.de. [79.202.36.88])\n\tby smtp.gmail.com with ESMTPSA id\n\to13sm2228615ejb.10.2021.02.04.01.29.59\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 01:29:59 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"WY89l5nl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=nyH2Ls2zpcnAb7jVF8DBn3u/grzxB19GVmd0UXCy3EU=;\n\tb=WY89l5nlWYBqxAeJGZgCnxI/vBRaGjqdfPBhl0akSzyXQ98Q8d+xeM9/dwPBTPUdUf\n\tV4nRrmTTb1DVQT0w+u9zCB/tOWYMyc0g7xque8MdJJFFoGFImWyezPR3U/FwhVzIUGnT\n\t4T2ukcUd9a0/tTrTKrBBvEJHPM9lmEFcGtHd6bb8Jlp1S0MPYZjIJAbBcY2TCdICeIBt\n\td7BPIpZwuEqWDJRfs6ZETgw3yujTymktxz1sqfDijh4c7z410Lqb96yeJh15g8dHQ5Jn\n\tjotJ4p6s7hYWnd/SlT6WjErdzuSUSI9kWzdQBTfU6ejE6Sn1cLfeJeUYB/57EcNkn7+t\n\tnrKw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=nyH2Ls2zpcnAb7jVF8DBn3u/grzxB19GVmd0UXCy3EU=;\n\tb=sTPndOZGA5XjbtpIfZeEChAowGwLFvpnO4OOLffVPE8x6EcYtB3wYelNU+QNSq/EKR\n\tpYH9d4pRk5AdNx5sdzZme0l1+4AojcWQ6T5OrwlK/HBJ2Z3dq4x9i9/iv6hM9xb+jxsK\n\ts2FaxHLrE0iaL5y+F5eRQcSMrDf1jJYwA94GKXq8Nw6wI4YQO+nZ26s1jX0W3TEB9nts\n\tgEv3kOZ4UDxULHlzEqD28xH1qnZ6qvFbi/U47yzEyK5S0E1HeEgCKJG+weI927x7cTQx\n\tAZj8bobI6bZZkULJMHrMzP/RV2W4USeUSaSO17O6GrU4/qK6A3RtwCjOKcH3N89GSdWX\n\tEWaw==","X-Gm-Message-State":"AOAM533/cig40xTT73vfzxISZb/eMKT6PNZ4Ty2SmXNJ9YBczg8qPVZg\n\tguHOLZ8avi670q5S7vtXoZxEvw==","X-Google-Smtp-Source":"ABdhPJyEpuVel3PofcbVpEjfPlIrOCva/lRB7CBIpBHdn7zrXYpm96dy4E1mM1SNWE7SizxauvKOiw==","X-Received":"by 2002:a17:906:4707:: with SMTP id\n\ty7mr7079490ejq.445.1612430999928; \n\tThu, 04 Feb 2021 01:29:59 -0800 (PST)","Date":"Thu, 4 Feb 2021 10:29:58 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210203162600.206297-1-jacopo@jmondi.org>\n\t<20210203162600.206297-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203162600.206297-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_device: Report\n\tAF_MODE_OFF in template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15004,"web_url":"https://patchwork.libcamera.org/comment/15004/","msgid":"","date":"2021-02-04T22:11:54","subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_device: Report\n\tAF_MODE_OFF in template","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Feb 03, 2021 at 05:25:57PM +0100, Jacopo Mondi wrote:\n> The CaptureResultTest#testCameraCaptureResultAllKeys CTS test\n> enforces the presence of the auto focus mode in the preview\n> request template.\n> \n> Add the only supported mode AF_MODE_OFF in the generated template.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 27f6ec109da9..fdda43e9b4af 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1306,7 +1306,7 @@ CameraMetadata *CameraDevice::requestTemplatePreview()\n> \t * \\todo Keep this in sync with the actual number of entries.\n> \t * Currently: 20 entries, 35 bytes\n> \t */\n> -\tCameraMetadata *requestTemplate = new CameraMetadata(20, 35);\n> +\tCameraMetadata *requestTemplate = new CameraMetadata(21, 36);\n> \tif (!requestTemplate->isValid()) {\n> \t\tdelete requestTemplate;\n> \t\treturn nullptr;\n> @@ -1339,6 +1339,9 @@ CameraMetadata *CameraDevice::requestTemplatePreview()\n> \trequestTemplate->addEntry(ANDROID_CONTROL_AE_ANTIBANDING_MODE,\n> \t\t\t\t &aeAntibandingMode, 1);\n> \n> +\tuint8_t afMode = ANDROID_CONTROL_AF_MODE_OFF;\n> +\trequestTemplate->addEntry(ANDROID_CONTROL_AF_MODE, &afMode, 1);\n> +\n> \tuint8_t afTrigger = ANDROID_CONTROL_AF_TRIGGER_IDLE;\n> \trequestTemplate->addEntry(ANDROID_CONTROL_AF_TRIGGER,\n> \t\t\t\t &afTrigger, 1);","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3368BBD160\n\tfor ;\n\tThu, 4 Feb 2021 22:12:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1DE461481;\n\tThu, 4 Feb 2021 23:12:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E05B61430\n\tfor ;\n\tThu, 4 Feb 2021 23:12:19 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 908A845D;\n\tThu, 4 Feb 2021 23:12:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zt8bPI8x\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612476738;\n\tbh=aifitdLS+2y2vdFahgbUyeiaT83Gmp3AfS9pyrHXBSs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Zt8bPI8xLhVPLrPBXLb2cX/qhaoYeoFo4Vn/ysDrmacq2BkiPvXvX+yMxo2T6Stn9\n\tvG5s5tHHkGSmLzSS+QiH+OfuDZcwaOuTpIqf2Bq/+wI7WJxxEpe2/0xM6mWHvCnBSu\n\tvJAt3Bv1H1BfUUQu87iu1HKVxXS4VecLHE/5nUx8=","Date":"Fri, 5 Feb 2021 00:11:54 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210203162600.206297-1-jacopo@jmondi.org>\n\t<20210203162600.206297-5-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203162600.206297-5-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 4/7] android: camera_device: Report\n\tAF_MODE_OFF in template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]