[{"id":14953,"web_url":"https://patchwork.libcamera.org/comment/14953/","msgid":"","date":"2021-02-04T09:26:29","subject":"Re: [libcamera-devel] [PATCH 3/7] android: camera_device: Use\n\tAF_MODE_OFF in scene override","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your patch.\n\nOn 2021-02-03 17:25:56 +0100, Jacopo Mondi wrote:\n> The camera HAL does currently list AF_MODE_OFF as the only supported\n> auto-focus mode in the ANDROID_CONTROL_AF_AVAILABLE_MODES static\n> metadata. For this reason reporting AF_MODE_AUTO as scene override\n> is wrong.\n> \n> At the moment scene override is disabled in the Camera HAL, but this\n> is worth a fix nonetheless.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index cdc75b949206..27f6ec109da9 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -852,7 +852,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstd::vector sceneModesOverride = {\n> \t\tANDROID_CONTROL_AE_MODE_ON,\n> \t\tANDROID_CONTROL_AWB_MODE_AUTO,\n> -\t\tANDROID_CONTROL_AF_MODE_AUTO,\n> +\t\tANDROID_CONTROL_AF_MODE_OFF,\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_CONTROL_SCENE_MODE_OVERRIDES,\n> \t\t\t\t sceneModesOverride.data(),\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 36662BD162\n\tfor ;\n\tThu, 4 Feb 2021 09:26:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0459E60107;\n\tThu, 4 Feb 2021 10:26:33 +0100 (CET)","from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com\n\t[IPv6:2a00:1450:4864:20::52a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1604B60107\n\tfor ;\n\tThu, 4 Feb 2021 10:26:31 +0100 (CET)","by mail-ed1-x52a.google.com with SMTP id y8so3264899ede.6\n\tfor ;\n\tThu, 04 Feb 2021 01:26:31 -0800 (PST)","from localhost (p4fca2458.dip0.t-ipconnect.de. [79.202.36.88])\n\tby smtp.gmail.com with ESMTPSA id\n\tv9sm2176406ejd.92.2021.02.04.01.26.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 01:26:30 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"gFM2Tlb7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=TWXN1t+DKVHjfqAyiK/KFNJLIoHS0mnrvi+mhw9eEDM=;\n\tb=gFM2Tlb7FMVf94UXv+63ruRhA8WadQxIJrMQ4F/EMB3Dk7NAp2GlzxZItF7J4zKgOq\n\tkrI8gJXZK3TmKCZWnGp3wYQBmOLItDciDxHv3fw58QsoB9vYKaX0Xvxi9DYQnePJngt2\n\tyajmG3420aSYZBU6WIl+msKxAHlJaoIVB7YBfZj/vRH84kc58rpmNuwxhO6gjSCxzQQ2\n\tRnVVz/Qr9weOAkRbEQdVMC1ub/7blzmSpRs/tG1ZRvUrCgeHjYxlwFsndJL5r6H8XgFR\n\tMKsNB2Dq5A8UNXJ2MepPrHmifI0FNV1FTsANNS2qMfWyGwY6VKKSVZsWQnh3+nVBSF8j\n\thM0g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=TWXN1t+DKVHjfqAyiK/KFNJLIoHS0mnrvi+mhw9eEDM=;\n\tb=PVwm1AjePuJUDTlpVNBRA+7Kx1f2u6lxoZYc5XxieOy7wexoQhm9GsMJQhSsgv7HqF\n\t8gXti5qXpKdjsgxb/J+8ZKcKXVxTcDKB/4ptck7EeeE73PqAkAxL+zq76T5wM81tt9eo\n\tO4PydU4EtqSZUuEWGkzlLqLAxj0KMfeuujkcdKtrdQiRAvDIOUxt0VM911exaieqtvPa\n\tJ+XiLKU5RaXUvZPyQkiG2HbsJwFRbcU7s5DU1QrPJo1WhmbG7TCEinztgbYPAdEu5mx5\n\tzahwFQKzwkAEBykQtnCkUx9n8KhBWeEra8ppx3+ErbZ8wnf+Qg/qpOuKF89Tmo3nLF4W\n\t9Duw==","X-Gm-Message-State":"AOAM531Vqm0ZqOncCa4N7Vo4rQztMdIjds+B7M9oyxBMZp5dWmgs+D+5\n\t4gnlNIl8XioCY4VbnlS1h7pQbg==","X-Google-Smtp-Source":"ABdhPJwjbuXrjA3j9RNSTwH1U9uj4ufW4tInOTItolWMf418yV0t/SkmEkZ8QhP0H+XOlTbpbyMhFw==","X-Received":"by 2002:a05:6402:3582:: with SMTP id\n\ty2mr7112881edc.345.1612430790703; \n\tThu, 04 Feb 2021 01:26:30 -0800 (PST)","Date":"Thu, 4 Feb 2021 10:26:29 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210203162600.206297-1-jacopo@jmondi.org>\n\t<20210203162600.206297-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203162600.206297-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 3/7] android: camera_device: Use\n\tAF_MODE_OFF in scene override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15003,"web_url":"https://patchwork.libcamera.org/comment/15003/","msgid":"","date":"2021-02-04T22:11:14","subject":"Re: [libcamera-devel] [PATCH 3/7] android: camera_device: Use\n\tAF_MODE_OFF in scene override","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Feb 03, 2021 at 05:25:56PM +0100, Jacopo Mondi wrote:\n> The camera HAL does currently list AF_MODE_OFF as the only supported\n> auto-focus mode in the ANDROID_CONTROL_AF_AVAILABLE_MODES static\n> metadata. For this reason reporting AF_MODE_AUTO as scene override\n> is wrong.\n> \n> At the moment scene override is disabled in the Camera HAL, but this\n> is worth a fix nonetheless.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index cdc75b949206..27f6ec109da9 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -852,7 +852,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstd::vector sceneModesOverride = {\n> \t\tANDROID_CONTROL_AE_MODE_ON,\n> \t\tANDROID_CONTROL_AWB_MODE_AUTO,\n> -\t\tANDROID_CONTROL_AF_MODE_AUTO,\n> +\t\tANDROID_CONTROL_AF_MODE_OFF,\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_CONTROL_SCENE_MODE_OVERRIDES,\n> \t\t\t\t sceneModesOverride.data(),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AC633BD162\n\tfor ;\n\tThu, 4 Feb 2021 22:11:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A04A61481;\n\tThu, 4 Feb 2021 23:11:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68E3B61430\n\tfor ;\n\tThu, 4 Feb 2021 23:11:37 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E9D8C45D;\n\tThu, 4 Feb 2021 23:11:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I3bkNIcr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612476697;\n\tbh=miqu/vC628OCLqB5L3axdAgCQvghagXDDCdvoWYSV8M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=I3bkNIcr3+lyYQoO5Isy0t5Wh5uNIAaxIxG9uZAM1MjxLCQHr+DzYvEm02OS49O98\n\t2uSRGdL4WLv99yaiCVRuaef2f7kKmD4f2KHNH9r1vwj76vwmiwu3fzGHg6o+CB9v/h\n\tuh2YNRK5sasuRLz1EjV8g7TeUjAMHii+FYZJXdMA=","Date":"Fri, 5 Feb 2021 00:11:14 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210203162600.206297-1-jacopo@jmondi.org>\n\t<20210203162600.206297-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203162600.206297-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 3/7] android: camera_device: Use\n\tAF_MODE_OFF in scene override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]