[{"id":14952,"web_url":"https://patchwork.libcamera.org/comment/14952/","msgid":"","date":"2021-02-04T09:25:51","subject":"Re: [libcamera-devel] [PATCH 2/7] android: camera_device: Report\n\tAE_EXPOSURE_COMPENSATION","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-02-03 17:25:55 +0100, Jacopo Mondi wrote:\n> The CaptureResultTest#testCameraCaptureResultAllKeys enforces the\n> presence of the ANDROID_CONTROL_AE_EXPOSURE_COMPENSATION result\n> metadata.\n> \n> Report 0 as the current value for\n> ANDROID_CONTROL_AE_EXPOSURE_COMPENSATION in the result metadata\n> pack.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 02908beb867e..cdc75b949206 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -708,7 +708,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * Currently: 53 entries, 846 bytes of static metadata\n> \t */\n> \tuint32_t numEntries = 53;\n> -\tuint32_t byteSize = 850;\n> +\tuint32_t byteSize = 854;\n> \n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -1245,6 +1245,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstd::vector availableResultKeys = {\n> \t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE,\n> \t\tANDROID_CONTROL_AE_ANTIBANDING_MODE,\n> +\t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> \t\tANDROID_CONTROL_AE_LOCK,\n> \t\tANDROID_CONTROL_AE_MODE,\n> \t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> @@ -1961,7 +1962,7 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \t * Total bytes for JPEG metadata: 82\n> \t */\n> \tstd::unique_ptr resultMetadata =\n> -\t\tstd::make_unique(41, 157);\n> +\t\tstd::make_unique(42, 161);\n> \tif (!resultMetadata->isValid()) {\n> \t\tLOG(HAL, Error) << \"Failed to allocate static metadata\";\n> \t\treturn nullptr;\n> @@ -1980,6 +1981,10 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \tvalue = ANDROID_CONTROL_AE_ANTIBANDING_MODE_OFF;\n> \tresultMetadata->addEntry(ANDROID_CONTROL_AE_ANTIBANDING_MODE, &value, 1);\n> \n> +\tint32_t value32 = 0;\n> +\tresultMetadata->addEntry(ANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> +\t\t\t\t &value32, 1);\n> +\n> \tvalue = ANDROID_CONTROL_AE_LOCK_OFF;\n> \tresultMetadata->addEntry(ANDROID_CONTROL_AE_LOCK, &value, 1);\n> \n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2894BD162\n\tfor ;\n\tThu, 4 Feb 2021 09:25:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E9F4613FF;\n\tThu, 4 Feb 2021 10:25:54 +0100 (CET)","from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com\n\t[IPv6:2a00:1450:4864:20::62a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49C2F60107\n\tfor ;\n\tThu, 4 Feb 2021 10:25:53 +0100 (CET)","by mail-ej1-x62a.google.com with SMTP id w1so4070297ejf.11\n\tfor ;\n\tThu, 04 Feb 2021 01:25:53 -0800 (PST)","from localhost (p4fca2458.dip0.t-ipconnect.de. [79.202.36.88])\n\tby smtp.gmail.com with ESMTPSA id\n\tq1sm2185549eji.101.2021.02.04.01.25.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 01:25:52 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"VloHtljM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=dLhwZxiDR4gFymlIlvGiGAFjFUTNEZ/wDWGv/kh3IJM=;\n\tb=VloHtljM11+SpyOhhTZiDo35/3fViYh3fGUqtvyByC45+hMP0an/CtBMWiLFAhl2K2\n\tWGm/Sw04/VNGs8z/Z8L2YdvsMyUQsgpo5yY+Dz1sZMJjwe6Om2Ki2DIYbXQiVmWDsM1X\n\ty1lc5K5hgP/cOD4axo+3YypYg5ygjYFCuUDnDDQ5SbsFhEKQS1AF/9bsH/vwCZeXBPx6\n\tL3+Tg82nB8jQtHq9Kb0AIqsrOCGo3So5fc+lq1JdG99NKZoJg4fvKUeaALAkxVgEoAbA\n\tVT4pAKA9a/lcU+OZWOQa4uGA5JUPaupm6ElvZiyI15Mab+xOTjk8rRzl+59XznnW8xfx\n\tOxLw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=dLhwZxiDR4gFymlIlvGiGAFjFUTNEZ/wDWGv/kh3IJM=;\n\tb=hfluUkN9tm62GL6hkpmmKxQv8w+0gWTt9+AOaqAqcAJO6OzVYdN5xlksIDJiGcnJLa\n\t8K7OFNrzklWnKrkBUvyddFInJQL8o85jlJCvmzLT9pb4GSErmLajnq8hZ71N5hBqazHb\n\t8+JtOeKatRVBx1OLIhbm4BqOpQcuc8U9p9Kedl1uPvLcsqNHtXCKsmwFWFsgFKtelOVD\n\tVeN1KBJnd5b5zyj9XBJkXcpwS3CK6K1G6q4RFVTRNTzyQ/7gIXoBBPlEImAUoxlTN49B\n\tCzoa9rEwW/Pgl84gurjVNYZsjHPF6K7Hh3BhdJ37lKqiqvDk5A5g3YcxKGHVX2JMcaqX\n\t6Ehg==","X-Gm-Message-State":"AOAM530SwPoNnGed9Z9eRsHzw04Vt6SYG/GI8tlaW7z5m0AJuQk0YqSK\n\tvSEN7+I3QCn/FVuF23IzIoOAkg==","X-Google-Smtp-Source":"ABdhPJzWuFV9SNVEtrFyT6ec8QNavOzQ2WHReYruiqFgQglkySwnZGbJXZVGuDVSLJORNTRS+PTRow==","X-Received":"by 2002:a17:906:b84d:: with SMTP id\n\tga13mr7051464ejb.112.1612430752866; \n\tThu, 04 Feb 2021 01:25:52 -0800 (PST)","Date":"Thu, 4 Feb 2021 10:25:51 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210203162600.206297-1-jacopo@jmondi.org>\n\t<20210203162600.206297-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203162600.206297-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/7] android: camera_device: Report\n\tAE_EXPOSURE_COMPENSATION","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15002,"web_url":"https://patchwork.libcamera.org/comment/15002/","msgid":"","date":"2021-02-04T22:10:25","subject":"Re: [libcamera-devel] [PATCH 2/7] android: camera_device: Report\n\tAE_EXPOSURE_COMPENSATION","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Wed, Feb 03, 2021 at 05:25:55PM +0100, Jacopo Mondi wrote:\n> The CaptureResultTest#testCameraCaptureResultAllKeys enforces the\n> presence of the ANDROID_CONTROL_AE_EXPOSURE_COMPENSATION result\n> metadata.\n> \n> Report 0 as the current value for\n> ANDROID_CONTROL_AE_EXPOSURE_COMPENSATION in the result metadata\n> pack.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/android/camera_device.cpp | 9 +++++++--\n> 1 file changed, 7 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 02908beb867e..cdc75b949206 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -708,7 +708,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> \t * Currently: 53 entries, 846 bytes of static metadata\n> \t */\n> \tuint32_t numEntries = 53;\n> -\tuint32_t byteSize = 850;\n> +\tuint32_t byteSize = 854;\n> \n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -1245,6 +1245,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \tstd::vector availableResultKeys = {\n> \t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE,\n> \t\tANDROID_CONTROL_AE_ANTIBANDING_MODE,\n> +\t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> \t\tANDROID_CONTROL_AE_LOCK,\n> \t\tANDROID_CONTROL_AE_MODE,\n> \t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> @@ -1961,7 +1962,7 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \t * Total bytes for JPEG metadata: 82\n> \t */\n> \tstd::unique_ptr resultMetadata =\n> -\t\tstd::make_unique(41, 157);\n> +\t\tstd::make_unique(42, 161);\n> \tif (!resultMetadata->isValid()) {\n> \t\tLOG(HAL, Error) << \"Failed to allocate static metadata\";\n> \t\treturn nullptr;\n> @@ -1980,6 +1981,10 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \tvalue = ANDROID_CONTROL_AE_ANTIBANDING_MODE_OFF;\n> \tresultMetadata->addEntry(ANDROID_CONTROL_AE_ANTIBANDING_MODE, &value, 1);\n> \n> +\tint32_t value32 = 0;\n> +\tresultMetadata->addEntry(ANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> +\t\t\t\t &value32, 1);\n> +\n> \tvalue = ANDROID_CONTROL_AE_LOCK_OFF;\n> \tresultMetadata->addEntry(ANDROID_CONTROL_AE_LOCK, &value, 1);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1442DBD162\n\tfor ;\n\tThu, 4 Feb 2021 22:10:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D666261483;\n\tThu, 4 Feb 2021 23:10:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75F7B61430\n\tfor ;\n\tThu, 4 Feb 2021 23:10:48 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0399D45D;\n\tThu, 4 Feb 2021 23:10:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m2Dc6NIJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612476648;\n\tbh=Qw5CYKN7zqvY0wlHPjC4kEtvgfs2s8vVcMZPOlls/UY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=m2Dc6NIJDpAV6HNikQI42BmS157tVYYv65SvwdBjfxdiWorMkEsFo4EEWbjdVdgUt\n\trqlJlicFnWD+o2ZNpj3AtYNsCurVa82TbnBFJVi5bMSxnSDIDmD9b/c5PXjVjjPVzs\n\tSZ/fUZCc0fOJPDXf4K3mjgWvsHpdI9i8Ha1yOEqI=","Date":"Fri, 5 Feb 2021 00:10:25 +0200","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210203162600.206297-1-jacopo@jmondi.org>\n\t<20210203162600.206297-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203162600.206297-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/7] android: camera_device: Report\n\tAE_EXPOSURE_COMPENSATION","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]