[{"id":14937,"web_url":"https://patchwork.libcamera.org/comment/14937/","msgid":"","date":"2021-02-03T23:17:40","subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: remove\n\tconfusing memory MMAP assignment before QUERYBUF","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Helen,\n\nThank you for the patch.\n\nOn Wed, Feb 03, 2021 at 11:29:55AM -0300, Helen Koike wrote:\n> QUERYBUF doesn't require the memory field to be pre-filled.\n> Also, V4L2VideoDevice::createBuffer uses dmabuf file descriptors, thus\n> using V4L2_MEMORY_MMAP makes things confusing, so remove it.\n> \n> Signed-off-by: Helen Koike \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_videodevice.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\n> index a9509bff..c77e1aff 100644\n> --- a/src/libcamera/v4l2_videodevice.cpp\n> +++ b/src/libcamera/v4l2_videodevice.cpp\n> @@ -1255,7 +1255,6 @@ std::unique_ptr V4L2VideoDevice::createBuffer(unsigned int index)\n> \n> \tbuf.index = index;\n> \tbuf.type = bufferType_;\n> -\tbuf.memory = V4L2_MEMORY_MMAP;\n> \tbuf.length = std::size(v4l2Planes);\n> \tbuf.m.planes = v4l2Planes;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB128BD161\n\tfor ;\n\tWed, 3 Feb 2021 23:18:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 68D1F613E0;\n\tThu, 4 Feb 2021 00:18:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 70EC160307\n\tfor ;\n\tThu, 4 Feb 2021 00:18:02 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BE866510;\n\tThu, 4 Feb 2021 00:18:01 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vWi2ApxN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612394281;\n\tbh=Wes8HnIA5/uwMcwKLIfUQYN9O3D7prTSxeLiXPVDnIk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vWi2ApxNvizIryCMPNinb9F/MstXkQ6CJ2OjPLa5CYfDY1gwp7O5axUF+85Z/BKbf\n\tuxms7IxfDIRcA94cBOD0e+TPyEyzxijX5hiwOC7gwtwcm6WhE8YeTMQdaRBLBrjaD1\n\tapcJQ1u1dxqs1ieNyVmaZIKfU+259+SzmzY54JPU=","Date":"Thu, 4 Feb 2021 01:17:40 +0200","From":"Laurent Pinchart ","To":"Helen Koike ","Message-ID":"","References":"<20210203142955.1238189-1-helen.koike@collabora.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203142955.1238189-1-helen.koike@collabora.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: v4l2_videodevice: remove\n\tconfusing memory MMAP assignment before QUERYBUF","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org, kernel@collabora.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]