{"id":11116,"url":"https://patchwork.libcamera.org/api/patches/11116/?format=json","web_url":"https://patchwork.libcamera.org/patch/11116/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210203142955.1238189-1-helen.koike@collabora.com>","date":"2021-02-03T14:29:55","name":"[libcamera-devel] libcamera: v4l2_videodevice: remove confusing memory MMAP assignment before QUERYBUF","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"dc37eeb727b73542b6c3c2b67125abe21a1ea02a","submitter":{"id":20,"url":"https://patchwork.libcamera.org/api/people/20/?format=json","name":"Helen Koike","email":"helen.koike@collabora.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11116/mbox/","series":[{"id":1644,"url":"https://patchwork.libcamera.org/api/series/1644/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1644","date":"2021-02-03T14:29:55","name":"[libcamera-devel] libcamera: v4l2_videodevice: remove confusing memory MMAP assignment before QUERYBUF","version":1,"mbox":"https://patchwork.libcamera.org/series/1644/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11116/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11116/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0A317BD160\n\tfor ;\n\tWed, 3 Feb 2021 14:30:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F86F68446;\n\tWed, 3 Feb 2021 15:30:08 +0100 (CET)","from bhuna.collabora.co.uk (bhuna.collabora.co.uk\n\t[IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED64A683FE\n\tfor ;\n\tWed, 3 Feb 2021 15:30:06 +0100 (CET)","from [127.0.0.1] (localhost [127.0.0.1])\n\t(Authenticated sender: koike) with ESMTPSA id 7CA251F44E07"],"From":"Helen Koike ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 3 Feb 2021 11:29:55 -0300","Message-Id":"<20210203142955.1238189-1-helen.koike@collabora.com>","X-Mailer":"git-send-email 2.30.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] libcamera: v4l2_videodevice: remove\n\tconfusing memory MMAP assignment before QUERYBUF","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kernel@collabora.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"QUERYBUF doesn't require the memory field to be pre-filled.\nAlso, V4L2VideoDevice::createBuffer uses dmabuf file descriptors, thus\nusing V4L2_MEMORY_MMAP makes things confusing, so remove it.\n\nSigned-off-by: Helen Koike \n---\n src/libcamera/v4l2_videodevice.cpp | 1 -\n 1 file changed, 1 deletion(-)","diff":"diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex a9509bff..c77e1aff 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1255,7 +1255,6 @@ std::unique_ptr V4L2VideoDevice::createBuffer(unsigned int index)\n \n \tbuf.index = index;\n \tbuf.type = bufferType_;\n-\tbuf.memory = V4L2_MEMORY_MMAP;\n \tbuf.length = std::size(v4l2Planes);\n \tbuf.m.planes = v4l2Planes;\n \n","prefixes":["libcamera-devel"]}