{"id":11114,"url":"https://patchwork.libcamera.org/api/patches/11114/?format=json","web_url":"https://patchwork.libcamera.org/patch/11114/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210203065128.1738003-3-hiroh@chromium.org>","date":"2021-02-03T06:51:28","name":"[libcamera-devel,v3,2/2] meson: Add download_subprojects option","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"42731e8f3c7ac51457289e559a9a69a96d8b1ea3","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11114/mbox/","series":[{"id":1642,"url":"https://patchwork.libcamera.org/api/series/1642/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1642","date":"2021-02-03T06:51:26","name":"Add libyuv to subprojects and download_subprojects option","version":3,"mbox":"https://patchwork.libcamera.org/series/1642/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11114/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11114/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C750FBD160\n\tfor ;\n\tWed, 3 Feb 2021 06:51:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91F3368441;\n\tWed, 3 Feb 2021 07:51:46 +0100 (CET)","from mail-pf1-x436.google.com (mail-pf1-x436.google.com\n\t[IPv6:2607:f8b0:4864:20::436])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24C2268437\n\tfor ;\n\tWed, 3 Feb 2021 07:51:44 +0100 (CET)","by mail-pf1-x436.google.com with SMTP id w18so16013193pfu.9\n\tfor ;\n\tTue, 02 Feb 2021 22:51:44 -0800 (PST)","from hiroh.c.googlers.com.com\n\t(128.141.236.35.bc.googleusercontent.com. [35.236.141.128])\n\tby smtp.gmail.com with ESMTPSA id\n\ti62sm978301pfe.84.2021.02.02.22.51.41\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Feb 2021 22:51:41 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"fwTKTwul\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=9AaFsGlzRKUDJtMI4vxfhqCS520cHdGWPLvIeRFU23s=;\n\tb=fwTKTwulqIhWig8MvrxydxWztVA+cI1QhbogYcTPkmYfD9kvNGVAj3X3LLxqq68gap\n\tApMHGO436tCPB68LTAoMr3qRIMmsClPjOw7ZcT75uRU1A8oCvNPgHjXKdYSE0JNHyw6B\n\tZuTdFBgmIBS1tdeCqLNECBG+2zsN3kgamGt5M=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=9AaFsGlzRKUDJtMI4vxfhqCS520cHdGWPLvIeRFU23s=;\n\tb=OnFQ0eWkHuvv7YoQGSTXC/LdRvVag6EJvEa8b90kGxGf3sArKWe5ZU+bovKYqBXa+X\n\t4LCGRBhhLLxMAp0qZbAazM//UyhwVshLkoKDmiNHAM1q739ctt4J34w80DvgsZhfbGtn\n\trnVRdRNeahQJOmqBuBr21ri3jxxT5rge0wWk5l9Qc+Ewy1GV1u/surlOlSuKFwgGWBga\n\tLhBWkqotU/eQqf4uODpa5Qo7F2lV5Jh7DwBfggWTDTlK350gF71oi2t5CvE+oQ59T5n3\n\tV/Dr9Om7RnvP4BE/tMEc8s7qeN8uL0zqwTO2L3XZ4SFhcHjGT2CDb3UokB1naMOg4V4n\n\t/80w==","X-Gm-Message-State":"AOAM530ojqjf9OwTCB137/yc3ldhImHAHvZq+B88QRVKW8DBZKfTT8y3\n\thcfhNmjVjQxBthAT+PCOX8Ben1cHPhSuDI2k","X-Google-Smtp-Source":"ABdhPJzUiOjni9D2d79lCanIYM+SIGBAw32iGx8kLSb29EKXaNQcm3HdJQcU/0g72xPfjccD2ajdnA==","X-Received":"by 2002:a05:6a00:2127:b029:1bb:b6de:c875 with SMTP id\n\tn7-20020a056a002127b02901bbb6dec875mr1826413pfj.72.1612335102231; \n\tTue, 02 Feb 2021 22:51:42 -0800 (PST)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 3 Feb 2021 06:51:28 +0000","Message-Id":"<20210203065128.1738003-3-hiroh@chromium.org>","X-Mailer":"git-send-email 2.30.0.365.g02bc693789-goog","In-Reply-To":"<20210203065128.1738003-1-hiroh@chromium.org>","References":"<20210203065128.1738003-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 2/2] meson: Add download_subprojects\n\toption","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This adds download_subprojects option. It controls whether a\nlibrary in meson subprojects is downloaded as specified. The\nmotivation of the option is there is an environment where\nthe download is prohibited by \"--wrap-mode nodownload\".\nThe local library code (e.g. libyuv) is built with in such a\nbuild environment if download_subprojects is set to false.\n\nSigned-off-by: Hirokazu Honda \n---\n meson_options.txt | 5 +++++\n src/android/meson.build | 32 ++++++++++++++++++--------------\n 2 files changed, 23 insertions(+), 14 deletions(-)\n\n--\n2.30.0.365.g02bc693789-goog","diff":"diff --git a/meson_options.txt b/meson_options.txt\nindex 53f2675e..bd92475f 100644\n--- a/meson_options.txt\n+++ b/meson_options.txt\n@@ -14,6 +14,11 @@ option('gstreamer',\n value : 'auto',\n description : 'Compile libcamera GStreamer plugin')\n\n+option('download_subprojects',\n+ type : 'boolean',\n+ value : 'true',\n+ description: 'Download subprojects in build')\n+\n option('pipelines',\n type : 'array',\n choices : ['ipu3', 'raspberrypi', 'rkisp1', 'simple', 'uvcvideo', 'vimc'],\ndiff --git a/src/android/meson.build b/src/android/meson.build\nindex 7619517a..03d847ee 100644\n--- a/src/android/meson.build\n+++ b/src/android/meson.build\n@@ -15,20 +15,24 @@ foreach dep : android_deps\n endforeach\n\n if android_enabled\n- cmake = import('cmake')\n-\n- libyuv_vars = cmake.subproject_options()\n- libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n- libyuv_vars.set_override_option('cpp_std', 'c++17')\n- libyuv_vars.append_compile_args('cpp',\n- '-Wno-sign-compare',\n- '-Wno-unused-variable',\n- '-Wno-unused-parameter')\n- libyuv_vars.append_link_args('-ljpeg')\n- libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n- libyuv_dep = libyuv.dependency('yuv')\n-\n- android_deps += [ libyuv_dep, ]\n+ if get_option('download_subprojects')\n+ cmake = import('cmake')\n+\n+ libyuv_vars = cmake.subproject_options()\n+ libyuv_vars.add_cmake_defines({'CMAKE_POSITION_INDEPENDENT_CODE': 'ON'})\n+ libyuv_vars.set_override_option('cpp_std', 'c++17')\n+ libyuv_vars.append_compile_args('cpp',\n+ '-Wno-sign-compare',\n+ '-Wno-unused-variable',\n+ '-Wno-unused-parameter')\n+ libyuv_vars.append_link_args('-ljpeg')\n+ libyuv = cmake.subproject('libyuv', options : libyuv_vars)\n+ libyuv_dep = libyuv.dependency('yuv')\n+\n+ android_deps += [ libyuv_dep, ]\n+ else\n+ android_deps += [ dependency('libyuv') ]\n+ endif\n endif\n\n android_hal_sources = files([\n","prefixes":["libcamera-devel","v3","2/2"]}