[{"id":14919,"web_url":"https://patchwork.libcamera.org/comment/14919/","msgid":"<20210203113108.ch2n6sbtimwipduq@uno.localdomain>","date":"2021-02-03T11:31:08","subject":"Re: [libcamera-devel] [PATCH v4 1/3] cam: event_loop: Rename event_\n\tto base_","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Niklas,\n\nOn Tue, Feb 02, 2021 at 11:10:49PM +0100, Niklas Söderlund wrote:\n> The 'event' variable name is usually used for events added to the base\n> event loop, not the loop itself. Rename the struct event_base member to\n> base_ as a preparation for future work adding events to the loop.\n>\n> There is no functional change.\n>\n\nI would have used eventBase_ as 'event' in name is still relevant.\n\nIt's ok, just tastes\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/cam/event_loop.cpp | 8 ++++----\n> src/cam/event_loop.h | 2 +-\n> 2 files changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/cam/event_loop.cpp b/src/cam/event_loop.cpp\n> index 94c5d1d362455f33..3a2b665abdc063de 100644\n> --- a/src/cam/event_loop.cpp\n> +++ b/src/cam/event_loop.cpp\n> @@ -18,7 +18,7 @@ EventLoop::EventLoop()\n> \tassert(!instance_);\n>\n> \tevthread_use_pthreads();\n> -\tevent_ = event_base_new();\n> +\tbase_ = event_base_new();\n> \tinstance_ = this;\n> }\n>\n> @@ -26,7 +26,7 @@ EventLoop::~EventLoop()\n> {\n> \tinstance_ = nullptr;\n>\n> -\tevent_base_free(event_);\n> +\tevent_base_free(base_);\n> \tlibevent_global_shutdown();\n> }\n>\n> @@ -42,7 +42,7 @@ int EventLoop::exec()\n>\n> \twhile (!exit_.load(std::memory_order_acquire)) {\n> \t\tdispatchCalls();\n> -\t\tevent_base_loop(event_, EVLOOP_NO_EXIT_ON_EMPTY);\n> +\t\tevent_base_loop(base_, EVLOOP_NO_EXIT_ON_EMPTY);\n> \t}\n>\n> \treturn exitCode_;\n> @@ -57,7 +57,7 @@ void EventLoop::exit(int code)\n>\n> void EventLoop::interrupt()\n> {\n> -\tevent_base_loopbreak(event_);\n> +\tevent_base_loopbreak(base_);\n> }\n>\n> void EventLoop::callLater(const std::function &func)\n> diff --git a/src/cam/event_loop.h b/src/cam/event_loop.h\n> index 408073c50594d09d..d0d5b5a53c830670 100644\n> --- a/src/cam/event_loop.h\n> +++ b/src/cam/event_loop.h\n> @@ -30,7 +30,7 @@ public:\n> private:\n> \tstatic EventLoop *instance_;\n>\n> -\tstruct event_base *event_;\n> +\tstruct event_base *base_;\n> \tstd::atomic exit_;\n> \tint exitCode_;\n>\n> --\n> 2.30.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B209BD160\n\tfor ;\n\tWed, 3 Feb 2021 11:30:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1C9868440;\n\tWed, 3 Feb 2021 12:30:49 +0100 (CET)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2ED22683FE\n\tfor ;\n\tWed, 3 Feb 2021 12:30:48 +0100 (CET)","from uno.localdomain (93-34-118-233.ip49.fastwebnet.it\n\t[93.34.118.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 64D4D1C0005;\n\tWed, 3 Feb 2021 11:30:47 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","Date":"Wed, 3 Feb 2021 12:31:08 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"<20210203113108.ch2n6sbtimwipduq@uno.localdomain>","References":"<20210202221051.1740237-1-niklas.soderlund@ragnatech.se>\n\t<20210202221051.1740237-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210202221051.1740237-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v4 1/3] cam: event_loop: Rename event_\n\tto base_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14924,"web_url":"https://patchwork.libcamera.org/comment/14924/","msgid":"","date":"2021-02-03T12:31:26","subject":"Re: [libcamera-devel] [PATCH v4 1/3] cam: event_loop: Rename event_\n\tto base_","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nOn 2021-02-03 12:31:08 +0100, Jacopo Mondi wrote:\n> Hi Niklas,\n> \n> On Tue, Feb 02, 2021 at 11:10:49PM +0100, Niklas Söderlund wrote:\n> > The 'event' variable name is usually used for events added to the base\n> > event loop, not the loop itself. Rename the struct event_base member to\n> > base_ as a preparation for future work adding events to the loop.\n> >\n> > There is no functional change.\n> >\n> \n> I would have used eventBase_ as 'event' in name is still relevant.\n\nI used base as that what's used in the libevent documentation, but I \nagree it's just taste.\n\n> \n> It's ok, just tastes\n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n> > Signed-off-by: Niklas Söderlund \n> > ---\n> > src/cam/event_loop.cpp | 8 ++++----\n> > src/cam/event_loop.h | 2 +-\n> > 2 files changed, 5 insertions(+), 5 deletions(-)\n> >\n> > diff --git a/src/cam/event_loop.cpp b/src/cam/event_loop.cpp\n> > index 94c5d1d362455f33..3a2b665abdc063de 100644\n> > --- a/src/cam/event_loop.cpp\n> > +++ b/src/cam/event_loop.cpp\n> > @@ -18,7 +18,7 @@ EventLoop::EventLoop()\n> > \tassert(!instance_);\n> >\n> > \tevthread_use_pthreads();\n> > -\tevent_ = event_base_new();\n> > +\tbase_ = event_base_new();\n> > \tinstance_ = this;\n> > }\n> >\n> > @@ -26,7 +26,7 @@ EventLoop::~EventLoop()\n> > {\n> > \tinstance_ = nullptr;\n> >\n> > -\tevent_base_free(event_);\n> > +\tevent_base_free(base_);\n> > \tlibevent_global_shutdown();\n> > }\n> >\n> > @@ -42,7 +42,7 @@ int EventLoop::exec()\n> >\n> > \twhile (!exit_.load(std::memory_order_acquire)) {\n> > \t\tdispatchCalls();\n> > -\t\tevent_base_loop(event_, EVLOOP_NO_EXIT_ON_EMPTY);\n> > +\t\tevent_base_loop(base_, EVLOOP_NO_EXIT_ON_EMPTY);\n> > \t}\n> >\n> > \treturn exitCode_;\n> > @@ -57,7 +57,7 @@ void EventLoop::exit(int code)\n> >\n> > void EventLoop::interrupt()\n> > {\n> > -\tevent_base_loopbreak(event_);\n> > +\tevent_base_loopbreak(base_);\n> > }\n> >\n> > void EventLoop::callLater(const std::function &func)\n> > diff --git a/src/cam/event_loop.h b/src/cam/event_loop.h\n> > index 408073c50594d09d..d0d5b5a53c830670 100644\n> > --- a/src/cam/event_loop.h\n> > +++ b/src/cam/event_loop.h\n> > @@ -30,7 +30,7 @@ public:\n> > private:\n> > \tstatic EventLoop *instance_;\n> >\n> > -\tstruct event_base *event_;\n> > +\tstruct event_base *base_;\n> > \tstd::atomic exit_;\n> > \tint exitCode_;\n> >\n> > --\n> > 2.30.0\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2A97BD160\n\tfor ;\n\tWed, 3 Feb 2021 12:31:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8493968444;\n\tWed, 3 Feb 2021 13:31:30 +0100 (CET)","from mail-ed1-x534.google.com (mail-ed1-x534.google.com\n\t[IPv6:2a00:1450:4864:20::534])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B0395683FE\n\tfor ;\n\tWed, 3 Feb 2021 13:31:28 +0100 (CET)","by mail-ed1-x534.google.com with SMTP id y8so11474404ede.6\n\tfor ;\n\tWed, 03 Feb 2021 04:31:28 -0800 (PST)","from localhost (p4fca2458.dip0.t-ipconnect.de. [79.202.36.88])\n\tby smtp.gmail.com with ESMTPSA id\n\tp25sm359339ejz.64.2021.02.03.04.31.27\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 03 Feb 2021 04:31:27 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"uw5WMgnd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=eQxe2NjFB1fvfNVmVEGy551EHZJ5p2HTdiTqp+hqlJY=;\n\tb=uw5WMgnd2ABRh/28zLQ6FpHG0YJGZq0fYKNwK4VwKHNOzQHVxa/gisBxVJv6oHDIz3\n\te2/xjb3xFnDhLeb0ntAygywq86WAHN42RC6QhCF9s/wPwdxPFD8EVhViXiACyp9k9b9c\n\tWXGOTm5ptCguHigj/6F2qhJd4oSQZH1dx8Foq7ZbKii3BBaaUotkGdURg5dQ0Jv0S5dI\n\tuLgpc9lfWxCs+mH/8+zpqHiJs0vyfqnjOJHTn92XBMJEdEFBaDzl9q6axuTDyEN/vGoT\n\tFv27pMP4ZfwsgM+PcEucFfkBkwJmCIhUcVOGjE6/GyRPBSeQ3sHEq1f0mNVbFTI3+UMX\n\teE0A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=eQxe2NjFB1fvfNVmVEGy551EHZJ5p2HTdiTqp+hqlJY=;\n\tb=KCx7I2dVHqHwU5372G8mgbJJ3CSdKftsv2+GZe1zlcG9lAE5J5Rgk5FqbqMYtdWEkO\n\t8MhT3BfvIHEA53EGJf5P29jD4IwdFmI+25reSs2UHYZP544lRVuc3rVzUEyqUBSR8zbo\n\tFtsb3NXBq/aZ+jTCKEWTwp3p5uXypewP7nt7J2rYtvGM3by54nUmXLLydqHlcicuqY73\n\t1gs6mf25KzhiBgLmpXa/Gp7QA/kfDwE8vLDaibEu9bIDbFIEjU17MZkFiL1BIRUF/vxp\n\t6b/LZZb7x3hSU1oj51y1sV8AUYxQ4EjaZ4WFXYfWdiwhebVOOprdkQea/V4KhFjwiDAq\n\tuI1w==","X-Gm-Message-State":"AOAM531/cbC8bHhq0PI/QpgcNyR3wvESZ305DQXEKcjelkIFHd+5QwoS\n\tOr/hD+mnUqPPyEKjzCPe52/W/AHmsLhl4Lm5","X-Google-Smtp-Source":"ABdhPJys0BmV+GGmI7aT/V4q9vfV1I8E0xnEVM222sHKUq+Mu8r5Ag6sDHD7DIXocjLYijHGPo30bg==","X-Received":"by 2002:a05:6402:3514:: with SMTP id\n\tb20mr2616973edd.100.1612355488247; \n\tWed, 03 Feb 2021 04:31:28 -0800 (PST)","Date":"Wed, 3 Feb 2021 13:31:26 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210202221051.1740237-1-niklas.soderlund@ragnatech.se>\n\t<20210202221051.1740237-2-niklas.soderlund@ragnatech.se>\n\t<20210203113108.ch2n6sbtimwipduq@uno.localdomain>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210203113108.ch2n6sbtimwipduq@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH v4 1/3] cam: event_loop: Rename event_\n\tto base_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14938,"web_url":"https://patchwork.libcamera.org/comment/14938/","msgid":"","date":"2021-02-03T23:47:03","subject":"Re: [libcamera-devel] [PATCH v4 1/3] cam: event_loop: Rename event_\n\tto base_","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Tue, Feb 02, 2021 at 11:10:49PM +0100, Niklas Söderlund wrote:\n> The 'event' variable name is usually used for events added to the base\n> event loop, not the loop itself. Rename the struct event_base member to\n> base_ as a preparation for future work adding events to the loop.\n> \n> There is no functional change.\n> \n> Signed-off-by: Niklas Söderlund \n\nAs Jacopo mentioned, this is a matter of taste, so\n\nReviewed-by: Laurent Pinchart \n\nI however wonder if this patch is still needed or if it was only\nrequired for previous versions of the series, as you don't introduce any\nevent_ variable in 2/3 or 3/3.\n\n> ---\n> src/cam/event_loop.cpp | 8 ++++----\n> src/cam/event_loop.h | 2 +-\n> 2 files changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/cam/event_loop.cpp b/src/cam/event_loop.cpp\n> index 94c5d1d362455f33..3a2b665abdc063de 100644\n> --- a/src/cam/event_loop.cpp\n> +++ b/src/cam/event_loop.cpp\n> @@ -18,7 +18,7 @@ EventLoop::EventLoop()\n> \tassert(!instance_);\n> \n> \tevthread_use_pthreads();\n> -\tevent_ = event_base_new();\n> +\tbase_ = event_base_new();\n> \tinstance_ = this;\n> }\n> \n> @@ -26,7 +26,7 @@ EventLoop::~EventLoop()\n> {\n> \tinstance_ = nullptr;\n> \n> -\tevent_base_free(event_);\n> +\tevent_base_free(base_);\n> \tlibevent_global_shutdown();\n> }\n> \n> @@ -42,7 +42,7 @@ int EventLoop::exec()\n> \n> \twhile (!exit_.load(std::memory_order_acquire)) {\n> \t\tdispatchCalls();\n> -\t\tevent_base_loop(event_, EVLOOP_NO_EXIT_ON_EMPTY);\n> +\t\tevent_base_loop(base_, EVLOOP_NO_EXIT_ON_EMPTY);\n> \t}\n> \n> \treturn exitCode_;\n> @@ -57,7 +57,7 @@ void EventLoop::exit(int code)\n> \n> void EventLoop::interrupt()\n> {\n> -\tevent_base_loopbreak(event_);\n> +\tevent_base_loopbreak(base_);\n> }\n> \n> void EventLoop::callLater(const std::function &func)\n> diff --git a/src/cam/event_loop.h b/src/cam/event_loop.h\n> index 408073c50594d09d..d0d5b5a53c830670 100644\n> --- a/src/cam/event_loop.h\n> +++ b/src/cam/event_loop.h\n> @@ -30,7 +30,7 @@ public:\n> private:\n> \tstatic EventLoop *instance_;\n> \n> -\tstruct event_base *event_;\n> +\tstruct event_base *base_;\n> \tstd::atomic exit_;\n> \tint exitCode_;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D4E7BD160\n\tfor ;\n\tWed, 3 Feb 2021 23:47:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1693613E0;\n\tThu, 4 Feb 2021 00:47:26 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F211E60307\n\tfor ;\n\tThu, 4 Feb 2021 00:47:25 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 75BB751B;\n\tThu, 4 Feb 2021 00:47:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fr4JSvtf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612396045;\n\tbh=PJUWlaJlc3f+waLn1cdXDQQ3CnXxDDQldJSaOdapJ6c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Fr4JSvtfhT+9kilMcqv8yFeygkz+/h7ErGbduG7h3dbHkj0RHssb9m+6h/t0SpPET\n\twJSH91PCkb7daKDs0xqHKHm7qWDaVForPstCrDmd9GPrmn1jfgqEtz+IYljoPkv9le\n\tD4NJejwK8fjwHNT+kMa7twY+PrgmiYVrnoRbrQgU=","Date":"Thu, 4 Feb 2021 01:47:03 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Message-ID":"","References":"<20210202221051.1740237-1-niklas.soderlund@ragnatech.se>\n\t<20210202221051.1740237-2-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210202221051.1740237-2-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH v4 1/3] cam: event_loop: Rename event_\n\tto base_","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]