[{"id":14908,"web_url":"https://patchwork.libcamera.org/comment/14908/","msgid":"<20210202174606.cslahrs6eijot7b4@uno.localdomain>","date":"2021-02-02T17:46:06","subject":"Re: [libcamera-devel] [PATCH] test: buffer-import: Fix\n\tfalse-positive failure","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Kieran,\n\nOn Tue, Feb 02, 2021 at 05:34:05PM +0000, Kieran Bingham wrote:\n> Running the tests failed with the following error on buffer import:\n> \"Failed to capture enough frames (got 8 expected at least 8)\"\n>\n> This indicates that the test did in fact capture enough frames as\n> desired by the test. Update the comparison on both buffer-import and\n> capture tests accordingly.\n>\n> Signed-off-by: Kieran Bingham \n\nHow come we didn't notice ? Don't we run tests frequently enough :) ?\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> test/camera/buffer_import.cpp | 2 +-\n> test/camera/capture.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 7ff628269c47..61f4eb92ae95 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -138,7 +138,7 @@ protected:\n> \t\twhile (timer.isRunning())\n> \t\t\tdispatcher->processEvents();\n>\n> -\t\tif (completeRequestsCount_ <= cfg.bufferCount * 2) {\n> +\t\tif (completeRequestsCount_ < cfg.bufferCount * 2) {\n> \t\t\tstd::cout << \"Failed to capture enough frames (got \"\n> \t\t\t\t << completeRequestsCount_ << \" expected at least \"\n> \t\t\t\t << cfg.bufferCount * 2 << \")\" << std::endl;\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index 6d564fe453ac..c4bc21100777 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -142,7 +142,7 @@ protected:\n>\n> \t\tunsigned int nbuffers = allocator_->buffers(stream).size();\n>\n> -\t\tif (completeRequestsCount_ <= nbuffers * 2) {\n> +\t\tif (completeRequestsCount_ < nbuffers * 2) {\n> \t\t\tcout << \"Failed to capture enough frames (got \"\n> \t\t\t << completeRequestsCount_ << \" expected at least \"\n> \t\t\t << nbuffers * 2 << \")\" << endl;\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6344FBD160\n\tfor ;\n\tTue, 2 Feb 2021 17:45:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F009F6842D;\n\tTue, 2 Feb 2021 18:45:46 +0100 (CET)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A98C360307\n\tfor ;\n\tTue, 2 Feb 2021 18:45:45 +0100 (CET)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 259DB60002;\n\tTue, 2 Feb 2021 17:45:44 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Tue, 2 Feb 2021 18:46:06 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Message-ID":"<20210202174606.cslahrs6eijot7b4@uno.localdomain>","References":"<20210202173405.1688089-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210202173405.1688089-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: buffer-import: Fix\n\tfalse-positive failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14912,"web_url":"https://patchwork.libcamera.org/comment/14912/","msgid":"","date":"2021-02-02T22:06:50","subject":"Re: [libcamera-devel] [PATCH] test: buffer-import: Fix\n\tfalse-positive failure","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nOn 2021-02-02 17:34:05 +0000, Kieran Bingham wrote:\n> Running the tests failed with the following error on buffer import:\n> \"Failed to capture enough frames (got 8 expected at least 8)\"\n> \n> This indicates that the test did in fact capture enough frames as\n> desired by the test. Update the comparison on both buffer-import and\n> capture tests accordingly.\n> \n> Signed-off-by: Kieran Bingham \n\nFirst off I agree with the change,\n\nReviewed-by: Niklas Söderlund \n\nSecond is this finding not telling us we are cutting the test criteria \nquiet close? I think we should in a follow up patch either increase the \ntime the capture loop is allowed to run or do something more clever as \ncapture N frames but fail if FPS drops bellow ~2 or something.\n\nOut of curiosity what device was this observed on?\n\n> ---\n> test/camera/buffer_import.cpp | 2 +-\n> test/camera/capture.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 7ff628269c47..61f4eb92ae95 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -138,7 +138,7 @@ protected:\n> \t\twhile (timer.isRunning())\n> \t\t\tdispatcher->processEvents();\n> \n> -\t\tif (completeRequestsCount_ <= cfg.bufferCount * 2) {\n> +\t\tif (completeRequestsCount_ < cfg.bufferCount * 2) {\n> \t\t\tstd::cout << \"Failed to capture enough frames (got \"\n> \t\t\t\t << completeRequestsCount_ << \" expected at least \"\n> \t\t\t\t << cfg.bufferCount * 2 << \")\" << std::endl;\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index 6d564fe453ac..c4bc21100777 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -142,7 +142,7 @@ protected:\n> \n> \t\tunsigned int nbuffers = allocator_->buffers(stream).size();\n> \n> -\t\tif (completeRequestsCount_ <= nbuffers * 2) {\n> +\t\tif (completeRequestsCount_ < nbuffers * 2) {\n> \t\t\tcout << \"Failed to capture enough frames (got \"\n> \t\t\t << completeRequestsCount_ << \" expected at least \"\n> \t\t\t << nbuffers * 2 << \")\" << endl;\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 699D3BD160\n\tfor ;\n\tTue, 2 Feb 2021 22:06:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE9D668433;\n\tTue, 2 Feb 2021 23:06:52 +0100 (CET)","from mail-lj1-x229.google.com (mail-lj1-x229.google.com\n\t[IPv6:2a00:1450:4864:20::229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29B6860307\n\tfor ;\n\tTue, 2 Feb 2021 23:06:52 +0100 (CET)","by mail-lj1-x229.google.com with SMTP id t8so25844692ljk.10\n\tfor ;\n\tTue, 02 Feb 2021 14:06:52 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id k8sm29794lfg.41.2021.02.02.14.06.50\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Feb 2021 14:06:50 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"cDZnPOtB\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=cy9EKJMK74/peAi1+Mly5+edTagvdXLlgqwFZWvJGWc=;\n\tb=cDZnPOtB/ubODcENxv4NjfL9uA2EoTjRSf7X+97ce5LeEW9Dos+OFfNMt/jUYwCNQA\n\tO1cKLzUQAdgHg0DVNlkIOHgGSP20bTa9ejgABt4jf+5IXCGIzOWXUM9Kz/Ws8aMWzztl\n\tu9cvjw4CxwuRb8RN6chCoY9ErZY0WVCJQugFdjL9Xu9UtjYPxK+WIAcLcSYlhDlGkl4p\n\tvwwxGt9UDZ0dZmGGFMtXAsWBGPwOI8LcFsKHBes2t7vTHsTG5totf3a9N+Gu9x1hWt35\n\t1wyQjIHdG7aOehMrCqqo7nXhs2AmKPKd8S2k0t2uGLD+R13W+fNey7KP1dk42m033Tf6\n\tIN4A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=cy9EKJMK74/peAi1+Mly5+edTagvdXLlgqwFZWvJGWc=;\n\tb=eHBsYROMniYsSueVGYWmyFszKKX0VPbWDG2YFBnSAfYAC+BWaldu94FuFfBKywiuMG\n\t32hSWjBG74waZkPLmAsiXquvdvcXWEnpSCzpka2TW1shWaZUXz/uDCj3rSmWmzu8uLhg\n\tmdnCuXGdOGPtwSgo6hzJ1/6C/01nu5In4QNtITcxgNT4Uf+j9ZQO/vfn8BssPoVCUCiW\n\tOg3VVMZCKVNkbfjxgnTYZZ47Kw85l49cU2VncXF7VZ3S25+mGh4tL4VlvNQug+Qy5J6e\n\tcL2TdJYRyE79PVAomnLj+vu36ZkqsIjGC3pVZQWyPuYrytcxarDcPaHpq3x1bgqYdX02\n\tgIHQ==","X-Gm-Message-State":"AOAM531dT7MYeu3wMprclsha8wkEnJbRGimy6WF7DTfoD0UkKb/bsWhZ\n\t5z54a2Q+BIZK5b9m3m5z8/efEwG+sMptsA==","X-Google-Smtp-Source":"ABdhPJzU+DOXrVKzmW/poKkX8rv0VwyPZAlZ+pWPg5/Lxv0HaJcWruUc9G+6Mb5N3UKln1XlO+eVVg==","X-Received":"by 2002:a2e:85ca:: with SMTP id\n\th10mr14856677ljj.474.1612303611373; \n\tTue, 02 Feb 2021 14:06:51 -0800 (PST)","Date":"Tue, 2 Feb 2021 23:06:50 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Message-ID":"","References":"<20210202173405.1688089-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210202173405.1688089-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: buffer-import: Fix\n\tfalse-positive failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14914,"web_url":"https://patchwork.libcamera.org/comment/14914/","msgid":"<20210203031011.GC42962@pyrite.rasen.tech>","date":"2021-02-03T03:10:11","subject":"Re: [libcamera-devel] [PATCH] test: buffer-import: Fix\n\tfalse-positive failure","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Tue, Feb 02, 2021 at 05:34:05PM +0000, Kieran Bingham wrote:\n> Running the tests failed with the following error on buffer import:\n> \"Failed to capture enough frames (got 8 expected at least 8)\"\n> \n> This indicates that the test did in fact capture enough frames as\n> desired by the test. Update the comparison on both buffer-import and\n> capture tests accordingly.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> ---\n> test/camera/buffer_import.cpp | 2 +-\n> test/camera/capture.cpp | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n> index 7ff628269c47..61f4eb92ae95 100644\n> --- a/test/camera/buffer_import.cpp\n> +++ b/test/camera/buffer_import.cpp\n> @@ -138,7 +138,7 @@ protected:\n> \t\twhile (timer.isRunning())\n> \t\t\tdispatcher->processEvents();\n> \n> -\t\tif (completeRequestsCount_ <= cfg.bufferCount * 2) {\n> +\t\tif (completeRequestsCount_ < cfg.bufferCount * 2) {\n> \t\t\tstd::cout << \"Failed to capture enough frames (got \"\n> \t\t\t\t << completeRequestsCount_ << \" expected at least \"\n> \t\t\t\t << cfg.bufferCount * 2 << \")\" << std::endl;\n> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n> index 6d564fe453ac..c4bc21100777 100644\n> --- a/test/camera/capture.cpp\n> +++ b/test/camera/capture.cpp\n> @@ -142,7 +142,7 @@ protected:\n> \n> \t\tunsigned int nbuffers = allocator_->buffers(stream).size();\n> \n> -\t\tif (completeRequestsCount_ <= nbuffers * 2) {\n> +\t\tif (completeRequestsCount_ < nbuffers * 2) {\n> \t\t\tcout << \"Failed to capture enough frames (got \"\n> \t\t\t << completeRequestsCount_ << \" expected at least \"\n> \t\t\t << nbuffers * 2 << \")\" << endl;\n> -- \n> 2.25.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81986BD160\n\tfor ;\n\tWed, 3 Feb 2021 03:10:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F2E1F68435;\n\tWed, 3 Feb 2021 04:10:20 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8944D60304\n\tfor ;\n\tWed, 3 Feb 2021 04:10:19 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EFF51580;\n\tWed, 3 Feb 2021 04:10:17 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"OSALRhLp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612321819;\n\tbh=K1Zxfsl+TU6CUnu06KK6nbTiDqG9hy5nNaN20n3uDt0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=OSALRhLpOV3fb5xnBfMw6ocJMEzsFhN3NJM5mSIUDLg8e5j13YGJwOaJxq9UZQMMi\n\tx6+INJEwqoqP+8utuU41YBGuUit4zTlAcM+yC2UtzbINMkwmZMGdabjwB36rQZ0t7C\n\tjIGVHI9PNGX/WuonHMZtUMXa+PSR1VUhuxMV1QWM=","Date":"Wed, 3 Feb 2021 12:10:11 +0900","From":"paul.elder@ideasonboard.com","To":"Kieran Bingham ","Message-ID":"<20210203031011.GC42962@pyrite.rasen.tech>","References":"<20210202173405.1688089-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210202173405.1688089-1-kieran.bingham@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] test: buffer-import: Fix\n\tfalse-positive failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14965,"web_url":"https://patchwork.libcamera.org/comment/14965/","msgid":"<9d3f94bd-8886-5cc5-4664-debe3924b512@ideasonboard.com>","date":"2021-02-04T14:15:02","subject":"Re: [libcamera-devel] [PATCH] test: buffer-import: Fix\n\tfalse-positive failure","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 02/02/2021 17:46, Jacopo Mondi wrote:\n> Hi Kieran,\n> \n> On Tue, Feb 02, 2021 at 05:34:05PM +0000, Kieran Bingham wrote:\n>> Running the tests failed with the following error on buffer import:\n>> \"Failed to capture enough frames (got 8 expected at least 8)\"\n>>\n>> This indicates that the test did in fact capture enough frames as\n>> desired by the test. Update the comparison on both buffer-import and\n>> capture tests accordingly.\n>>\n>> Signed-off-by: Kieran Bingham \n> \n> How come we didn't notice ? Don't we run tests frequently enough :) ?\n\nI'm not sure - perhaps this was just a close race, and normally more\nframes run - but for some reason this just about captured enough in time\n- but failed because of the check?\n\nI saw the failure on buffer-import, and investigated because at first I\nassumed it was the kernel regression (which is fixed in my running\nkernel) so I feared that had come back.\n\nBut alas then I saw the message ...\n--\nKieran\n\n\n\n\n> \n> Reviewed-by: Jacopo Mondi \n> \n> Thanks\n> j\n> \n>> ---\n>> test/camera/buffer_import.cpp | 2 +-\n>> test/camera/capture.cpp | 2 +-\n>> 2 files changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n>> index 7ff628269c47..61f4eb92ae95 100644\n>> --- a/test/camera/buffer_import.cpp\n>> +++ b/test/camera/buffer_import.cpp\n>> @@ -138,7 +138,7 @@ protected:\n>> \t\twhile (timer.isRunning())\n>> \t\t\tdispatcher->processEvents();\n>>\n>> -\t\tif (completeRequestsCount_ <= cfg.bufferCount * 2) {\n>> +\t\tif (completeRequestsCount_ < cfg.bufferCount * 2) {\n>> \t\t\tstd::cout << \"Failed to capture enough frames (got \"\n>> \t\t\t\t << completeRequestsCount_ << \" expected at least \"\n>> \t\t\t\t << cfg.bufferCount * 2 << \")\" << std::endl;\n>> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n>> index 6d564fe453ac..c4bc21100777 100644\n>> --- a/test/camera/capture.cpp\n>> +++ b/test/camera/capture.cpp\n>> @@ -142,7 +142,7 @@ protected:\n>>\n>> \t\tunsigned int nbuffers = allocator_->buffers(stream).size();\n>>\n>> -\t\tif (completeRequestsCount_ <= nbuffers * 2) {\n>> +\t\tif (completeRequestsCount_ < nbuffers * 2) {\n>> \t\t\tcout << \"Failed to capture enough frames (got \"\n>> \t\t\t << completeRequestsCount_ << \" expected at least \"\n>> \t\t\t << nbuffers * 2 << \")\" << endl;\n>> --\n>> 2.25.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 758C2BD160\n\tfor ;\n\tThu, 4 Feb 2021 14:15:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED9C661412;\n\tThu, 4 Feb 2021 15:15:07 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6DE6C60305\n\tfor ;\n\tThu, 4 Feb 2021 15:15:06 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACD72440;\n\tThu, 4 Feb 2021 15:15:05 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jJQpYcYP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612448106;\n\tbh=c6AJv0qt7twbbxkMurav8lEy6ZbWnEpWsVaEx1wIrj0=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=jJQpYcYPtCK7n1ZLYGh23wXweWu6vuA5rakyJcsM/hRzSA75/5h3aSufo+fqiWPBs\n\tfwsEcYuksmK6tx11noLEpzZ+gUWh73QHUqeP783GdIZ4ZecQ5GwSYIxyTbSnvyqhdE\n\tLw3MIOphj+a8G4SqvmaO2T0ecFKeQFX3oCn6GeiE=","To":"Jacopo Mondi ","References":"<20210202173405.1688089-1-kieran.bingham@ideasonboard.com>\n\t<20210202174606.cslahrs6eijot7b4@uno.localdomain>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<9d3f94bd-8886-5cc5-4664-debe3924b512@ideasonboard.com>","Date":"Thu, 4 Feb 2021 14:15:02 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210202174606.cslahrs6eijot7b4@uno.localdomain>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] test: buffer-import: Fix\n\tfalse-positive failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14966,"web_url":"https://patchwork.libcamera.org/comment/14966/","msgid":"","date":"2021-02-04T14:16:24","subject":"Re: [libcamera-devel] [PATCH] test: buffer-import: Fix\n\tfalse-positive failure","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Niklas,\n\nOn 02/02/2021 22:06, Niklas Söderlund wrote:\n> Hi Kieran,\n> \n> On 2021-02-02 17:34:05 +0000, Kieran Bingham wrote:\n>> Running the tests failed with the following error on buffer import:\n>> \"Failed to capture enough frames (got 8 expected at least 8)\"\n>>\n>> This indicates that the test did in fact capture enough frames as\n>> desired by the test. Update the comparison on both buffer-import and\n>> capture tests accordingly.\n>>\n>> Signed-off-by: Kieran Bingham \n> \n> First off I agree with the change,\n> \n> Reviewed-by: Niklas Söderlund \n> \n> Second is this finding not telling us we are cutting the test criteria \n> quiet close? I think we should in a follow up patch either increase the \n> time the capture loop is allowed to run or do something more clever as \n> capture N frames but fail if FPS drops bellow ~2 or something.\n> \n> Out of curiosity what device was this observed on?\n\n\nMaybe, it was running on my HP Spectre development laptop. It may have\nbeen loaded doing other things at the time, I'm unsure - The issue\noccurred while building my daily libcamera which runs the tests after.\n\n--\nKieran\n\n\n> \n>> ---\n>> test/camera/buffer_import.cpp | 2 +-\n>> test/camera/capture.cpp | 2 +-\n>> 2 files changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/test/camera/buffer_import.cpp b/test/camera/buffer_import.cpp\n>> index 7ff628269c47..61f4eb92ae95 100644\n>> --- a/test/camera/buffer_import.cpp\n>> +++ b/test/camera/buffer_import.cpp\n>> @@ -138,7 +138,7 @@ protected:\n>> \t\twhile (timer.isRunning())\n>> \t\t\tdispatcher->processEvents();\n>> \n>> -\t\tif (completeRequestsCount_ <= cfg.bufferCount * 2) {\n>> +\t\tif (completeRequestsCount_ < cfg.bufferCount * 2) {\n>> \t\t\tstd::cout << \"Failed to capture enough frames (got \"\n>> \t\t\t\t << completeRequestsCount_ << \" expected at least \"\n>> \t\t\t\t << cfg.bufferCount * 2 << \")\" << std::endl;\n>> diff --git a/test/camera/capture.cpp b/test/camera/capture.cpp\n>> index 6d564fe453ac..c4bc21100777 100644\n>> --- a/test/camera/capture.cpp\n>> +++ b/test/camera/capture.cpp\n>> @@ -142,7 +142,7 @@ protected:\n>> \n>> \t\tunsigned int nbuffers = allocator_->buffers(stream).size();\n>> \n>> -\t\tif (completeRequestsCount_ <= nbuffers * 2) {\n>> +\t\tif (completeRequestsCount_ < nbuffers * 2) {\n>> \t\t\tcout << \"Failed to capture enough frames (got \"\n>> \t\t\t << completeRequestsCount_ << \" expected at least \"\n>> \t\t\t << nbuffers * 2 << \")\" << endl;\n>> -- \n>> 2.25.1\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A37A2BD160\n\tfor ;\n\tThu, 4 Feb 2021 14:16:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7255B61412;\n\tThu, 4 Feb 2021 15:16:28 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C849360305\n\tfor ;\n\tThu, 4 Feb 2021 15:16:26 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 649B0440;\n\tThu, 4 Feb 2021 15:16:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ovKS2JQ6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612448186;\n\tbh=aqKausbRryi1JsOVSxDZByN8xzm2CZtpbmabDtJphmQ=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=ovKS2JQ6kv7TvwgfNxv38XbfVIq9aVTyzSy7OfCiccYIROUMgZ8ep5GaUiFdtRMRb\n\tQUM6qjy7IGc2vORoJkfwcUHaBSXvTR8hCzaGXDVBPJjwUYUzzi7lp/I3vuGF/D2jBS\n\tsaoqdEwBsFcwLX8muAwyC+OUyl4QQmtUva2ahMG8=","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","References":"<20210202173405.1688089-1-kieran.bingham@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 4 Feb 2021 14:16:24 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] test: buffer-import: Fix\n\tfalse-positive failure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]