[{"id":14878,"web_url":"https://patchwork.libcamera.org/comment/14878/","msgid":"<20210201105610.tused542li7t23bv@uno.localdomain>","date":"2021-02-01T10:56:10","subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Set default\n\tmax frame duration","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Paul,\n\nOn Mon, Feb 01, 2021 at 05:56:51PM +0900, Paul Elder wrote:\n> Set the max frame duration in the static metadata to 1 second.\n>\n> This allows the following CTS test to pass:\n> - android.hardware.camera2.cts.SurfaceViewPreviewTest#testPreviewFpsRange\n\nSee:\n[PATCH v2 3/6] android: camera_device: Compute frame durations\n\nwhere MAX_FRAME_DURATION is instantiate using the frameDuration value\nreturned by pipeline handler.\n\nCould you have a look at the series and see if it helps ?\n\nThanks\n j\n\n>\n> Signed-off-by: Paul Elder \n> ---\n> src/android/camera_device.cpp | 11 ++++++++---\n> 1 file changed, 8 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index c1025e81..a71af540 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -705,10 +705,10 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> {\n> \t/*\n> \t * \\todo Keep this in sync with the actual number of entries.\n> -\t * Currently: 53 entries, 782 bytes of static metadata\n> +\t * Currently: 54 entries, 794 bytes of static metadata\n> \t */\n> -\tuint32_t numEntries = 53;\n> -\tuint32_t byteSize = 810;\n> +\tuint32_t numEntries = 54;\n> +\tuint32_t byteSize = 822;\n>\n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -932,6 +932,10 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\t\t\t\t &exposureTimeRange, 2);\n> \t}\n>\n> +\tint64_t maxFrameDuration = 1000000000;\n> +\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n> +\t\t\t\t &maxFrameDuration, 1);\n> +\n> \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, &orientation_, 1);\n>\n> \tstd::vector testPatterModes = {\n> @@ -1179,6 +1183,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n> \t\tANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> \t\tANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n> +\t\tANDROID_SENSOR_INFO_MAX_FRAME_DURATION,\n> \t\tANDROID_SENSOR_ORIENTATION,\n> \t\tANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n> \t\tANDROID_SENSOR_INFO_PHYSICAL_SIZE,\n> --\n> 2.27.0\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 91E19BD808\n\tfor ;\n\tMon, 1 Feb 2021 10:55:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2AD6B683FF;\n\tMon, 1 Feb 2021 11:55:50 +0100 (CET)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A663760307\n\tfor ;\n\tMon, 1 Feb 2021 11:55:48 +0100 (CET)","from uno.localdomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 3197720014;\n\tMon, 1 Feb 2021 10:55:47 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","Date":"Mon, 1 Feb 2021 11:56:10 +0100","From":"Jacopo Mondi ","To":"Paul Elder ","Message-ID":"<20210201105610.tused542li7t23bv@uno.localdomain>","References":"<20210201085651.21281-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210201085651.21281-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] android: camera_device: Set default\n\tmax frame duration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]