{"id":1110,"url":"https://patchwork.libcamera.org/api/patches/1110/?format=json","web_url":"https://patchwork.libcamera.org/patch/1110/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190426150155.18652-5-laurent.pinchart@ideasonboard.com>","date":"2019-04-26T15:01:51","name":"[libcamera-devel,4/8] libcamera: Mark overridden functions with override","commit_ref":"1ec73e9ad5008824c80e3b7577437699e9bac898","pull_url":null,"state":"accepted","archived":false,"hash":"3ff21ab381d67ac816a4b640075b8cfbcb724410","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1110/mbox/","series":[{"id":271,"url":"https://patchwork.libcamera.org/api/series/271/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=271","date":"2019-04-26T15:01:47","name":"Fix clang compilation warnings and errors","version":1,"mbox":"https://patchwork.libcamera.org/series/271/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1110/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1110/checks/","tags":{},"headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F74B60E9D\n\tfor ;\n\tFri, 26 Apr 2019 17:02:10 +0200 (CEST)","from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3CD42337\n\tfor ;\n\tFri, 26 Apr 2019 17:02:10 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556290930;\n\tbh=+g7XL9MkRgmi1wnuS4mDMwSVtS3hzVZ9wR64ST7p3wI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=jHBW37JEFfpK5Micm8928y1SEAfyXGJ8+iXcPYH7XOdbTVn3T6GNP2KHptszW9c/C\n\tcgh5tUeI3lSYkJ6rKcgm2G7qz1wsJ8C2MQQUFUl5TJ2zb1K/8aUIFTmeimQ0g8TuW1\n\th8ss+CmpI3YMtL5W0B6UsJgKLDmDByC8YFz4FTmQ=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 26 Apr 2019 18:01:51 +0300","Message-Id":"<20190426150155.18652-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>","References":"<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 4/8] libcamera: Mark overridden functions\n\twith override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 26 Apr 2019 15:02:10 -0000"},"content":"Several overridden virtual functions are not marked with override. Fix\nit.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n src/libcamera/pipeline/uvcvideo.cpp | 2 +-\n src/libcamera/pipeline/vimc.cpp | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 2c2929207d35..97a309207621 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -167,7 +167,7 @@ public:\n \n \tint queueRequest(Camera *camera, Request *request) override;\n \n-\tbool match(DeviceEnumerator *enumerator);\n+\tbool match(DeviceEnumerator *enumerator) override;\n \n private:\n \tclass IPU3CameraData : public CameraData\ndiff --git a/src/libcamera/pipeline/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo.cpp\nindex b8f634d88b46..2f9b5e0fdc08 100644\n--- a/src/libcamera/pipeline/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo.cpp\n@@ -42,7 +42,7 @@ public:\n \n \tint queueRequest(Camera *camera, Request *request) override;\n \n-\tbool match(DeviceEnumerator *enumerator);\n+\tbool match(DeviceEnumerator *enumerator) override;\n \n private:\n \tclass UVCCameraData : public CameraData\ndiff --git a/src/libcamera/pipeline/vimc.cpp b/src/libcamera/pipeline/vimc.cpp\nindex 22449e47bc2d..f70b4d3c6bab 100644\n--- a/src/libcamera/pipeline/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc.cpp\n@@ -42,7 +42,7 @@ public:\n \n \tint queueRequest(Camera *camera, Request *request) override;\n \n-\tbool match(DeviceEnumerator *enumerator);\n+\tbool match(DeviceEnumerator *enumerator) override;\n \n private:\n \tclass VimcCameraData : public CameraData\n","prefixes":["libcamera-devel","4/8"]}