[{"id":15391,"web_url":"https://patchwork.libcamera.org/comment/15391/","msgid":"<20210302055130.GB35047@pyrite.rasen.tech>","date":"2021-03-02T05:51:30","subject":"Re: [libcamera-devel] [PATCH 16/20] libcamera: pipeline: simple:\n\tMove converter data to camera data","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Mon, Feb 01, 2021 at 12:46:58AM +0200, Laurent Pinchart wrote:\n> Converter usage is a per-camera property, move its data to the\n> SimpleCameraData class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 46 ++++++++++++------------\n> 1 file changed, 23 insertions(+), 23 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 6a8253101a61..9dffe64ee870 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -170,6 +170,10 @@ public:\n> \n> \tstd::vector configs_;\n> \tstd::map formats_;\n> +\n> +\tstd::vector> converterBuffers_;\n> +\tbool useConverter_;\n> +\tstd::queue converterQueue_;\n> };\n> \n> class SimpleCameraConfiguration : public CameraConfiguration\n> @@ -239,9 +243,6 @@ private:\n> \tstd::map subdevs_;\n> \n> \tstd::unique_ptr converter_;\n> -\tbool useConverter_;\n> -\tstd::vector> converterBuffers_;\n> -\tstd::queue converterQueue_;\n> \n> \tCamera *activeCamera_;\n> };\n> @@ -692,9 +693,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \t}\n> \n> \t/* Configure the converter if required. */\n> -\tuseConverter_ = config->needConversion();\n> -\n> -\tif (useConverter_) {\n> +\tdata->useConverter_ = config->needConversion();\n> +\tif (data->useConverter_) {\n> \t\tStreamConfiguration inputCfg;\n> \t\tinputCfg.pixelFormat = pipeConfig->captureFormat;\n> \t\tinputCfg.size = pipeConfig->captureSize;\n> @@ -726,7 +726,7 @@ int SimplePipelineHandler::exportFrameBuffers(Camera *camera, Stream *stream,\n> \t * Export buffers on the converter or capture video node, depending on\n> \t * whether the converter is used or not.\n> \t */\n> -\tif (useConverter_)\n> +\tif (data->useConverter_)\n> \t\treturn converter_->exportBuffers(0, count, buffers);\n> \telse\n> \t\treturn data->video_->exportBuffers(count, buffers);\n> @@ -739,8 +739,8 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] ControlList *c\n> \tunsigned int count = data->streams_[0].configuration().bufferCount;\n> \tint ret;\n> \n> -\tif (useConverter_)\n> -\t\tret = video->allocateBuffers(count, &converterBuffers_);\n> +\tif (data->useConverter_)\n> +\t\tret = video->allocateBuffers(count, &data->converterBuffers_);\n> \telse\n> \t\tret = video->importBuffers(count);\n> \tif (ret < 0)\n> @@ -752,7 +752,7 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] ControlList *c\n> \t\treturn ret;\n> \t}\n> \n> -\tif (useConverter_) {\n> +\tif (data->useConverter_) {\n> \t\tret = converter_->start();\n> \t\tif (ret < 0) {\n> \t\t\tstop(camera);\n> @@ -760,7 +760,7 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] ControlList *c\n> \t\t}\n> \n> \t\t/* Queue all internal buffers for capture. */\n> -\t\tfor (std::unique_ptr &buffer : converterBuffers_)\n> +\t\tfor (std::unique_ptr &buffer : data->converterBuffers_)\n> \t\t\tvideo->queueBuffer(buffer.get());\n> \t}\n> \n> @@ -774,13 +774,13 @@ void SimplePipelineHandler::stop(Camera *camera)\n> \tSimpleCameraData *data = cameraData(camera);\n> \tV4L2VideoDevice *video = data->video_;\n> \n> -\tif (useConverter_)\n> +\tif (data->useConverter_)\n> \t\tconverter_->stop();\n> \n> \tvideo->streamOff();\n> \tvideo->releaseBuffers();\n> \n> -\tconverterBuffers_.clear();\n> +\tdata->converterBuffers_.clear();\n> \tactiveCamera_ = nullptr;\n> }\n> \n> @@ -800,8 +800,8 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n> \t * If conversion is needed, push the buffer to the converter queue, it\n> \t * will be handed to the converter in the capture completion handler.\n> \t */\n> -\tif (useConverter_) {\n> -\t\tconverterQueue_.push(buffer);\n> +\tif (data->useConverter_) {\n> +\t\tdata->converterQueue_.push(buffer);\n> \t\treturn 0;\n> \t}\n> \n> @@ -977,7 +977,7 @@ void SimplePipelineHandler::bufferReady(FrameBuffer *buffer)\n> \t * point converting an erroneous buffer.\n> \t */\n> \tif (buffer->metadata().status != FrameMetadata::FrameSuccess) {\n> -\t\tif (useConverter_) {\n> +\t\tif (data->useConverter_) {\n> \t\t\t/* Requeue the buffer for capture. */\n> \t\t\tdata->video_->queueBuffer(buffer);\n> \n> @@ -985,11 +985,11 @@ void SimplePipelineHandler::bufferReady(FrameBuffer *buffer)\n> \t\t\t * Get the next user-facing buffer to complete the\n> \t\t\t * request.\n> \t\t\t */\n> -\t\t\tif (converterQueue_.empty())\n> +\t\t\tif (data->converterQueue_.empty())\n> \t\t\t\treturn;\n> \n> -\t\t\tbuffer = converterQueue_.front();\n> -\t\t\tconverterQueue_.pop();\n> +\t\t\tbuffer = data->converterQueue_.front();\n> +\t\t\tdata->converterQueue_.pop();\n> \t\t}\n> \n> \t\tRequest *request = buffer->request();\n> @@ -1003,14 +1003,14 @@ void SimplePipelineHandler::bufferReady(FrameBuffer *buffer)\n> \t * conversion is needed. If there's no queued request, just requeue the\n> \t * captured buffer for capture.\n> \t */\n> -\tif (useConverter_) {\n> -\t\tif (converterQueue_.empty()) {\n> +\tif (data->useConverter_) {\n> +\t\tif (data->converterQueue_.empty()) {\n> \t\t\tdata->video_->queueBuffer(buffer);\n> \t\t\treturn;\n> \t\t}\n> \n> -\t\tFrameBuffer *output = converterQueue_.front();\n> -\t\tconverterQueue_.pop();\n> +\t\tFrameBuffer *output = data->converterQueue_.front();\n> +\t\tdata->converterQueue_.pop();\n> \n> \t\tconverter_->queueBuffers(buffer, { { 0, output } });\n> \t\treturn;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 51924BD1F1\n\tfor ;\n\tTue, 2 Mar 2021 05:51:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF52F68A92;\n\tTue, 2 Mar 2021 06:51:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B98DB60522\n\tfor ;\n\tTue, 2 Mar 2021 06:51:38 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4CB145D;\n\tTue, 2 Mar 2021 06:51:36 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UPrPCvjt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614664298;\n\tbh=4F6Jy7OIOpnZAMJDIrI5wIAutcOQo7F7U4dDMJCdtyA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UPrPCvjtbm1rv3JfcDhABcLntBgLr6zgwZCkbV2Dqcy12khTSUTIGHh7RFIqus+EE\n\t8FD4bfsIWVdxNfoa0cVgzzxklBGjwXrRX82TYI7/0yd++hXZa9dyEWUkY9bZakq9TH\n\tbWO//Q9xMtEt6bo7D9HZkezvio/19+XAiJa4UdKU=","Date":"Tue, 2 Mar 2021 14:51:30 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210302055130.GB35047@pyrite.rasen.tech>","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>\n\t<20210131224702.8838-17-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210131224702.8838-17-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 16/20] libcamera: pipeline: simple:\n\tMove converter data to camera data","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Phi-Bang Nguyen ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15404,"web_url":"https://patchwork.libcamera.org/comment/15404/","msgid":"","date":"2021-03-02T10:24:19","subject":"Re: [libcamera-devel] [PATCH 16/20] libcamera: pipeline: simple:\n\tMove converter data to camera data","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 31/01/2021 22:46, Laurent Pinchart wrote:\n> Converter usage is a per-camera property, move its data to the\n> SimpleCameraData class.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 46 ++++++++++++------------\n> 1 file changed, 23 insertions(+), 23 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 6a8253101a61..9dffe64ee870 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -170,6 +170,10 @@ public:\n> \n> \tstd::vector configs_;\n> \tstd::map formats_;\n> +\n> +\tstd::vector> converterBuffers_;\n> +\tbool useConverter_;\n> +\tstd::queue converterQueue_;\n> };\n> \n> class SimpleCameraConfiguration : public CameraConfiguration\n> @@ -239,9 +243,6 @@ private:\n> \tstd::map subdevs_;\n> \n> \tstd::unique_ptr converter_;\n> -\tbool useConverter_;\n> -\tstd::vector> converterBuffers_;\n> -\tstd::queue converterQueue_;\n> \n> \tCamera *activeCamera_;\n> };\n> @@ -692,9 +693,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \t}\n> \n> \t/* Configure the converter if required. */\n> -\tuseConverter_ = config->needConversion();\n> -\n> -\tif (useConverter_) {\n> +\tdata->useConverter_ = config->needConversion();\n> +\tif (data->useConverter_) {\n> \t\tStreamConfiguration inputCfg;\n> \t\tinputCfg.pixelFormat = pipeConfig->captureFormat;\n> \t\tinputCfg.size = pipeConfig->captureSize;\n> @@ -726,7 +726,7 @@ int SimplePipelineHandler::exportFrameBuffers(Camera *camera, Stream *stream,\n> \t * Export buffers on the converter or capture video node, depending on\n> \t * whether the converter is used or not.\n> \t */\n> -\tif (useConverter_)\n> +\tif (data->useConverter_)\n> \t\treturn converter_->exportBuffers(0, count, buffers);\n> \telse\n> \t\treturn data->video_->exportBuffers(count, buffers);\n> @@ -739,8 +739,8 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] ControlList *c\n> \tunsigned int count = data->streams_[0].configuration().bufferCount;\n> \tint ret;\n> \n> -\tif (useConverter_)\n> -\t\tret = video->allocateBuffers(count, &converterBuffers_);\n> +\tif (data->useConverter_)\n> +\t\tret = video->allocateBuffers(count, &data->converterBuffers_);\n> \telse\n> \t\tret = video->importBuffers(count);\n> \tif (ret < 0)\n> @@ -752,7 +752,7 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] ControlList *c\n> \t\treturn ret;\n> \t}\n> \n> -\tif (useConverter_) {\n> +\tif (data->useConverter_) {\n> \t\tret = converter_->start();\n> \t\tif (ret < 0) {\n> \t\t\tstop(camera);\n> @@ -760,7 +760,7 @@ int SimplePipelineHandler::start(Camera *camera, [[maybe_unused]] ControlList *c\n> \t\t}\n> \n> \t\t/* Queue all internal buffers for capture. */\n> -\t\tfor (std::unique_ptr &buffer : converterBuffers_)\n> +\t\tfor (std::unique_ptr &buffer : data->converterBuffers_)\n> \t\t\tvideo->queueBuffer(buffer.get());\n> \t}\n> \n> @@ -774,13 +774,13 @@ void SimplePipelineHandler::stop(Camera *camera)\n> \tSimpleCameraData *data = cameraData(camera);\n> \tV4L2VideoDevice *video = data->video_;\n> \n> -\tif (useConverter_)\n> +\tif (data->useConverter_)\n> \t\tconverter_->stop();\n> \n> \tvideo->streamOff();\n> \tvideo->releaseBuffers();\n> \n> -\tconverterBuffers_.clear();\n> +\tdata->converterBuffers_.clear();\n> \tactiveCamera_ = nullptr;\n> }\n> \n> @@ -800,8 +800,8 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n> \t * If conversion is needed, push the buffer to the converter queue, it\n> \t * will be handed to the converter in the capture completion handler.\n> \t */\n> -\tif (useConverter_) {\n> -\t\tconverterQueue_.push(buffer);\n> +\tif (data->useConverter_) {\n> +\t\tdata->converterQueue_.push(buffer);\n> \t\treturn 0;\n> \t}\n> \n> @@ -977,7 +977,7 @@ void SimplePipelineHandler::bufferReady(FrameBuffer *buffer)\n> \t * point converting an erroneous buffer.\n> \t */\n> \tif (buffer->metadata().status != FrameMetadata::FrameSuccess) {\n> -\t\tif (useConverter_) {\n> +\t\tif (data->useConverter_) {\n> \t\t\t/* Requeue the buffer for capture. */\n> \t\t\tdata->video_->queueBuffer(buffer);\n> \n> @@ -985,11 +985,11 @@ void SimplePipelineHandler::bufferReady(FrameBuffer *buffer)\n> \t\t\t * Get the next user-facing buffer to complete the\n> \t\t\t * request.\n> \t\t\t */\n> -\t\t\tif (converterQueue_.empty())\n> +\t\t\tif (data->converterQueue_.empty())\n> \t\t\t\treturn;\n> \n> -\t\t\tbuffer = converterQueue_.front();\n> -\t\t\tconverterQueue_.pop();\n> +\t\t\tbuffer = data->converterQueue_.front();\n> +\t\t\tdata->converterQueue_.pop();\n> \t\t}\n> \n> \t\tRequest *request = buffer->request();\n> @@ -1003,14 +1003,14 @@ void SimplePipelineHandler::bufferReady(FrameBuffer *buffer)\n> \t * conversion is needed. If there's no queued request, just requeue the\n> \t * captured buffer for capture.\n> \t */\n> -\tif (useConverter_) {\n> -\t\tif (converterQueue_.empty()) {\n> +\tif (data->useConverter_) {\n> +\t\tif (data->converterQueue_.empty()) {\n> \t\t\tdata->video_->queueBuffer(buffer);\n> \t\t\treturn;\n> \t\t}\n> \n> -\t\tFrameBuffer *output = converterQueue_.front();\n> -\t\tconverterQueue_.pop();\n> +\t\tFrameBuffer *output = data->converterQueue_.front();\n> +\t\tdata->converterQueue_.pop();\n> \n> \t\tconverter_->queueBuffers(buffer, { { 0, output } });\n> \t\treturn;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7DDDDBD808\n\tfor ;\n\tTue, 2 Mar 2021 10:24:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0E00268A95;\n\tTue, 2 Mar 2021 11:24:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2313160106\n\tfor ;\n\tTue, 2 Mar 2021 11:24:23 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8734545D;\n\tTue, 2 Mar 2021 11:24:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"c8P2FB+V\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614680662;\n\tbh=bqy6C/HqIQXlumsHeluAA82CxBcQIw/fd7gtGRP8Z5A=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=c8P2FB+VEfXTvzxIv/bLb+ZjdvtIr8eUV10hexn3uOXrkON+wJwTGqiavVgV8JUdK\n\tB0eFitwu0hQAEXdarj9PA8w3LE8XX+25OcrA1Nc5fbCQGH1dM/8NTyDXMCQ7CDKtR4\n\tMSVoVN7Jg7j1Ck+Q7aK0gVQA+37ObG+/hHWPu/xk=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>\n\t<20210131224702.8838-17-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 2 Mar 2021 10:24:19 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210131224702.8838-17-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 16/20] libcamera: pipeline: simple:\n\tMove converter data to camera data","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"Phi-Bang Nguyen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]