[{"id":15362,"web_url":"https://patchwork.libcamera.org/comment/15362/","msgid":"","date":"2021-03-01T20:28:36","subject":"Re: [libcamera-devel] [PATCH 13/20] libcamera: pipeline: simple:\n\tRename Configuration::pixelFormat","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 31/01/2021 22:46, Laurent Pinchart wrote:\n> The Configuration::pixelFormat field stores the pixel format at the\n> output of the capture part of the pipeline. Rename it to captureFormat,\n> to match the related captureSize field.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 7c5a56a2f395..72a18cc0b97f 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -157,7 +157,7 @@ public:\n> \n> \tstruct Configuration {\n> \t\tuint32_t code;\n> -\t\tPixelFormat pixelFormat;\n> +\t\tPixelFormat captureFormat;\n> \t\tSize captureSize;\n> \t\tSizeRange outputSizes;\n> \t};\n> @@ -379,7 +379,7 @@ int SimpleCameraData::init()\n> \n> \t\t\tConfiguration config;\n> \t\t\tconfig.code = code;\n> -\t\t\tconfig.pixelFormat = pixelFormat;\n> +\t\t\tconfig.captureFormat = pixelFormat;\n> \t\t\tconfig.captureSize = format.size;\n> \n> \t\t\tif (!converter) {\n> @@ -551,7 +551,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n> \t\tstatus = Adjusted;\n> \t}\n> \n> -\tneedConversion_ = cfg.pixelFormat != pipeConfig.pixelFormat\n> +\tneedConversion_ = cfg.pixelFormat != pipeConfig.captureFormat\n> \t\t\t|| cfg.size != pipeConfig.captureSize;\n\nShould a 'format' and a 'size' be a wrapped type, to be able to express:\n \tneedsConversion_ = cfg.ImageFormat != pipeConfig.ImageFormat?\n\nProbably not, but seeing captureFormat and captureSize, along with a\nbatched comparison makes me wonder if this would be a common grouping.\n\nOverkill for now unless it's used frequently, or needs 'multiple' stored\nequivalent groupings.\n\n\nAnyway, that's not required here.\n\nReviewed-by: Kieran Bingham \n\n> \n> \tcfg.bufferCount = 3;\n> @@ -656,7 +656,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \t\treturn ret;\n> \n> \t/* Configure the video node. */\n> -\tV4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig.pixelFormat);\n> +\tV4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig.captureFormat);\n> \n> \tV4L2DeviceFormat captureFormat;\n> \tcaptureFormat.fourcc = videoFormat;\n> @@ -686,7 +686,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \n> \tif (useConverter_) {\n> \t\tStreamConfiguration inputCfg;\n> -\t\tinputCfg.pixelFormat = pipeConfig.pixelFormat;\n> +\t\tinputCfg.pixelFormat = pipeConfig.captureFormat;\n> \t\tinputCfg.size = pipeConfig.captureSize;\n> \t\tinputCfg.stride = captureFormat.planes[0].bpl;\n> \t\tinputCfg.bufferCount = cfg.bufferCount;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C17F9BD808\n\tfor ;\n\tMon, 1 Mar 2021 20:28:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4394768A8D;\n\tMon, 1 Mar 2021 21:28:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF7CC60521\n\tfor ;\n\tMon, 1 Mar 2021 21:28:39 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0963341;\n\tMon, 1 Mar 2021 21:28:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BnAZzD5/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614630519;\n\tbh=o1wJeJQxhBU5DX7UkfsF8GYVNSqjzmMfqTUWcLZEkJM=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=BnAZzD5/ERYQt4UxtES+rhaFifU2f/9YbGVn/+34lC3iKJinb/qeEviApB8BAsyS9\n\tl8N935lWfJyIB3o7sDkfNEsZwQqaSNONgRi4i98oKo4jco63igMh3SQ6rTu+ZUi/Lz\n\tAnVxNxcF5nQcqTdNsfonVDBxxf3man5lX4W12kT4=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>\n\t<20210131224702.8838-14-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Mon, 1 Mar 2021 20:28:36 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210131224702.8838-14-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 13/20] libcamera: pipeline: simple:\n\tRename Configuration::pixelFormat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"Phi-Bang Nguyen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15366,"web_url":"https://patchwork.libcamera.org/comment/15366/","msgid":"","date":"2021-03-01T23:00:01","subject":"Re: [libcamera-devel] [PATCH 13/20] libcamera: pipeline: simple:\n\tRename Configuration::pixelFormat","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Mon, Mar 01, 2021 at 08:28:36PM +0000, Kieran Bingham wrote:\n> On 31/01/2021 22:46, Laurent Pinchart wrote:\n> > The Configuration::pixelFormat field stores the pixel format at the\n> > output of the capture part of the pipeline. Rename it to captureFormat,\n> > to match the related captureSize field.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/pipeline/simple/simple.cpp | 10 +++++-----\n> > 1 file changed, 5 insertions(+), 5 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index 7c5a56a2f395..72a18cc0b97f 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -157,7 +157,7 @@ public:\n> > \n> > \tstruct Configuration {\n> > \t\tuint32_t code;\n> > -\t\tPixelFormat pixelFormat;\n> > +\t\tPixelFormat captureFormat;\n> > \t\tSize captureSize;\n> > \t\tSizeRange outputSizes;\n> > \t};\n> > @@ -379,7 +379,7 @@ int SimpleCameraData::init()\n> > \n> > \t\t\tConfiguration config;\n> > \t\t\tconfig.code = code;\n> > -\t\t\tconfig.pixelFormat = pixelFormat;\n> > +\t\t\tconfig.captureFormat = pixelFormat;\n> > \t\t\tconfig.captureSize = format.size;\n> > \n> > \t\t\tif (!converter) {\n> > @@ -551,7 +551,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n> > \t\tstatus = Adjusted;\n> > \t}\n> > \n> > -\tneedConversion_ = cfg.pixelFormat != pipeConfig.pixelFormat\n> > +\tneedConversion_ = cfg.pixelFormat != pipeConfig.captureFormat\n> > \t\t\t|| cfg.size != pipeConfig.captureSize;\n> \n> Should a 'format' and a 'size' be a wrapped type, to be able to express:\n> \tneedsConversion_ = cfg.ImageFormat != pipeConfig.ImageFormat?\n\nAbsolutely, I've been thinking about this a few times already, in\nvarious places. I'll add a todo comment to remember.\n\n> Probably not, but seeing captureFormat and captureSize, along with a\n> batched comparison makes me wonder if this would be a common grouping.\n> \n> Overkill for now unless it's used frequently, or needs 'multiple' stored\n> equivalent groupings.\n> \n> \n> Anyway, that's not required here.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > \n> > \tcfg.bufferCount = 3;\n> > @@ -656,7 +656,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> > \t\treturn ret;\n> > \n> > \t/* Configure the video node. */\n> > -\tV4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig.pixelFormat);\n> > +\tV4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig.captureFormat);\n> > \n> > \tV4L2DeviceFormat captureFormat;\n> > \tcaptureFormat.fourcc = videoFormat;\n> > @@ -686,7 +686,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> > \n> > \tif (useConverter_) {\n> > \t\tStreamConfiguration inputCfg;\n> > -\t\tinputCfg.pixelFormat = pipeConfig.pixelFormat;\n> > +\t\tinputCfg.pixelFormat = pipeConfig.captureFormat;\n> > \t\tinputCfg.size = pipeConfig.captureSize;\n> > \t\tinputCfg.stride = captureFormat.planes[0].bpl;\n> > \t\tinputCfg.bufferCount = cfg.bufferCount;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE75FBD808\n\tfor ;\n\tMon, 1 Mar 2021 23:00:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1ED1468A45;\n\tTue, 2 Mar 2021 00:00:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D53568A45\n\tfor ;\n\tTue, 2 Mar 2021 00:00:29 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4D4345D;\n\tTue, 2 Mar 2021 00:00:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hQle3yse\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614639629;\n\tbh=jKqNaK8oXkhJEhjt4/QJFW831B7QWnWCfuoTbNSmzV4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hQle3yseRO+wVYk0agaKpxSKWwhjkLs2ZlNoHBDVyEvzjiLRwI7w8DgrZZNTo5JMI\n\tS7nyVdgd97tUwOES1dYA6pnh0YKCXUVyf+RLUdEaI4w0jGUhxh/GkTrRG/iyFozv/Y\n\t21J58K7kTy43jiZXMJGJ9ESj5Xt7QjFPGZTFqBo4=","Date":"Tue, 2 Mar 2021 01:00:01 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>\n\t<20210131224702.8838-14-laurent.pinchart@ideasonboard.com>\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 13/20] libcamera: pipeline: simple:\n\tRename Configuration::pixelFormat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Phi-Bang Nguyen ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15384,"web_url":"https://patchwork.libcamera.org/comment/15384/","msgid":"<20210302012127.GM3084@pyrite.rasen.tech>","date":"2021-03-02T01:21:27","subject":"Re: [libcamera-devel] [PATCH 13/20] libcamera: pipeline: simple:\n\tRename Configuration::pixelFormat","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent and Kieran,\n\nOn Tue, Mar 02, 2021 at 01:00:01AM +0200, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Mon, Mar 01, 2021 at 08:28:36PM +0000, Kieran Bingham wrote:\n> > On 31/01/2021 22:46, Laurent Pinchart wrote:\n> > > The Configuration::pixelFormat field stores the pixel format at the\n> > > output of the capture part of the pipeline. Rename it to captureFormat,\n> > > to match the related captureSize field.\n> > > \n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > src/libcamera/pipeline/simple/simple.cpp | 10 +++++-----\n> > > 1 file changed, 5 insertions(+), 5 deletions(-)\n> > > \n> > > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > > index 7c5a56a2f395..72a18cc0b97f 100644\n> > > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > > @@ -157,7 +157,7 @@ public:\n> > > \n> > > \tstruct Configuration {\n> > > \t\tuint32_t code;\n> > > -\t\tPixelFormat pixelFormat;\n> > > +\t\tPixelFormat captureFormat;\n> > > \t\tSize captureSize;\n> > > \t\tSizeRange outputSizes;\n> > > \t};\n> > > @@ -379,7 +379,7 @@ int SimpleCameraData::init()\n> > > \n> > > \t\t\tConfiguration config;\n> > > \t\t\tconfig.code = code;\n> > > -\t\t\tconfig.pixelFormat = pixelFormat;\n> > > +\t\t\tconfig.captureFormat = pixelFormat;\n> > > \t\t\tconfig.captureSize = format.size;\n> > > \n> > > \t\t\tif (!converter) {\n> > > @@ -551,7 +551,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n> > > \t\tstatus = Adjusted;\n> > > \t}\n> > > \n> > > -\tneedConversion_ = cfg.pixelFormat != pipeConfig.pixelFormat\n> > > +\tneedConversion_ = cfg.pixelFormat != pipeConfig.captureFormat\n> > > \t\t\t|| cfg.size != pipeConfig.captureSize;\n> > \n> > Should a 'format' and a 'size' be a wrapped type, to be able to express:\n> > \tneedsConversion_ = cfg.ImageFormat != pipeConfig.ImageFormat?\n> \n> Absolutely, I've been thinking about this a few times already, in\n> various places. I'll add a todo comment to remember.\n\nI remember thinking about this too.\n\n> > Probably not, but seeing captureFormat and captureSize, along with a\n> > batched comparison makes me wonder if this would be a common grouping.\n> > \n> > Overkill for now unless it's used frequently, or needs 'multiple' stored\n> > equivalent groupings.\n> > \n> > \n> > Anyway, that's not required here.\n> > \n> > Reviewed-by: Kieran Bingham \n\nReviewed-by: Paul Elder \n\n> > > \n> > > \tcfg.bufferCount = 3;\n> > > @@ -656,7 +656,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> > > \t\treturn ret;\n> > > \n> > > \t/* Configure the video node. */\n> > > -\tV4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig.pixelFormat);\n> > > +\tV4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig.captureFormat);\n> > > \n> > > \tV4L2DeviceFormat captureFormat;\n> > > \tcaptureFormat.fourcc = videoFormat;\n> > > @@ -686,7 +686,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> > > \n> > > \tif (useConverter_) {\n> > > \t\tStreamConfiguration inputCfg;\n> > > -\t\tinputCfg.pixelFormat = pipeConfig.pixelFormat;\n> > > +\t\tinputCfg.pixelFormat = pipeConfig.captureFormat;\n> > > \t\tinputCfg.size = pipeConfig.captureSize;\n> > > \t\tinputCfg.stride = captureFormat.planes[0].bpl;\n> > > \t\tinputCfg.bufferCount = cfg.bufferCount;\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8BB9ABD1F1\n\tfor ;\n\tTue, 2 Mar 2021 01:21:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 152AA68A8F;\n\tTue, 2 Mar 2021 02:21:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EF1E0602E9\n\tfor ;\n\tTue, 2 Mar 2021 02:21:34 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0683845D;\n\tTue, 2 Mar 2021 02:21:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AUBqLvER\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1614648094;\n\tbh=BBK44j2WQHm1+rNhka94jCF7kI2bN/36+8KW3YxlUDs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=AUBqLvERkqxvtajWq56iAH7EvEbJoaLN/hSginxeR/l93NbT+gSGNUyr2fiIisAaf\n\tsCQj/fMSffwoXb2mbPVXN15cwz7tMzGv5xug7AtfXFsGistRWg9+zbEkSlQL1k78Gg\n\t5OLRCMsw5WwwJSmlBds2TGPLHKgChk0QrJwDy3oU=","Date":"Tue, 2 Mar 2021 10:21:27 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210302012127.GM3084@pyrite.rasen.tech>","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>\n\t<20210131224702.8838-14-laurent.pinchart@ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 13/20] libcamera: pipeline: simple:\n\tRename Configuration::pixelFormat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Phi-Bang Nguyen ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]