{"id":11090,"url":"https://patchwork.libcamera.org/api/patches/11090/?format=json","web_url":"https://patchwork.libcamera.org/patch/11090/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210131224702.8838-12-laurent.pinchart@ideasonboard.com>","date":"2021-01-31T22:46:53","name":"[libcamera-devel,11/20] libcamera: pipeline: simple: Drop unused members of configuration","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"fd958e72c494c27727694b8b19743462ec738f3a","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11090/mbox/","series":[{"id":1633,"url":"https://patchwork.libcamera.org/api/series/1633/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1633","date":"2021-01-31T22:46:42","name":"[libcamera-devel,01/20] libcamera: pipeline: simple: Manage converter with std::unique_ptr<>","version":1,"mbox":"https://patchwork.libcamera.org/series/1633/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11090/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11090/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 037B8BD808\n\tfor ;\n\tSun, 31 Jan 2021 22:47:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B40DE683F5;\n\tSun, 31 Jan 2021 23:47:41 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D61A683EF\n\tfor ;\n\tSun, 31 Jan 2021 23:47:32 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CC8EA163D; \n\tSun, 31 Jan 2021 23:47:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"SBMdySvR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612133252;\n\tbh=SU9OhxbM7NK3Aw7pyUS4R74PWXHV4+VAjU78cMSDa2c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=SBMdySvRL5HXlyH6AERnTZGMlTHQDEnPX0F4uArhmI2H9+PBRIv5fTfhCQDc+SALs\n\tS4sepfwyeo7rJne7EsQcEt2Wlj7ZPVv7MleaRN+wN04kFjbH1Jjg6YoVtRg/hJNcBZ\n\tKp9JTmqzXJ38mRtBb+IeXgrfYx1L0rxpAmK449OY=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 1 Feb 2021 00:46:53 +0200","Message-Id":"<20210131224702.8838-12-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 11/20] libcamera: pipeline: simple: Drop\n\tunused members of configuration","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Phi-Bang Nguyen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The SimpleCameraConfiguration class has a sensorFormat_ member variable\nand a corresponding accessor that are never used. Drop them.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/simple/simple.cpp | 3 ---\n 1 file changed, 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 390c87ba74d8..f072e0f1fa81 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -94,8 +94,6 @@ public:\n \n \tStatus validate() override;\n \n-\tconst V4L2SubdeviceFormat &sensorFormat() { return sensorFormat_; }\n-\n \tbool needConversion() const { return needConversion_; }\n \n private:\n@@ -107,7 +105,6 @@ private:\n \tstd::shared_ptr camera_;\n \tconst SimpleCameraData *data_;\n \n-\tV4L2SubdeviceFormat sensorFormat_;\n \tbool needConversion_;\n };\n \n","prefixes":["libcamera-devel","11/20"]}