[{"id":15253,"web_url":"https://patchwork.libcamera.org/comment/15253/","msgid":"<5774eb3d-3ad6-107d-d796-29e536c5deb0@ideasonboard.com>","date":"2021-02-19T17:27:50","subject":"Re: [libcamera-devel] [PATCH 07/20] libcamera: pipeline: simple:\n\tconverter: Replace open() with isValid()","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 31/01/2021 22:46, Laurent Pinchart wrote:\n> Simplify the SimpleConverter interface by opening the M2M device in the\n> constructor. The explicit call to open() is replaced by a check through\n> a new isValid() function, and the unused close() function is removed.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/pipeline/simple/converter.cpp | 20 ++++++--------------\n> src/libcamera/pipeline/simple/converter.h | 3 +--\n> src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n> 3 files changed, 9 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 6b3249ea92b0..f782fbc63b09 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -39,24 +39,16 @@ SimpleConverter::SimpleConverter(MediaDevice *media)\n> \n> \tm2m_ = std::make_unique((*it)->deviceNode());\n> \n> +\tint ret = m2m_->open();\n> +\tif (ret < 0) {\n> +\t\tm2m_.reset();\n> +\t\treturn;\n> +\t}\n> +\n> \tm2m_->output()->bufferReady.connect(this, &SimpleConverter::outputBufferReady);\n> \tm2m_->capture()->bufferReady.connect(this, &SimpleConverter::captureBufferReady);\n> }\n> \n> -int SimpleConverter::open()\n> -{\n> -\tif (!m2m_)\n> -\t\treturn -ENODEV;\n> -\n> -\treturn m2m_->open();\n> -}\n> -\n> -void SimpleConverter::close()\n> -{\n> -\tif (m2m_)\n> -\t\tm2m_->close();\n> -}\n> -\n> std::vector SimpleConverter::formats(PixelFormat input)\n> {\n> \tif (!m2m_)\n> diff --git a/src/libcamera/pipeline/simple/converter.h b/src/libcamera/pipeline/simple/converter.h\n> index a1503a6099ff..780bfa8f7832 100644\n> --- a/src/libcamera/pipeline/simple/converter.h\n> +++ b/src/libcamera/pipeline/simple/converter.h\n> @@ -30,8 +30,7 @@ class SimpleConverter\n> public:\n> \tSimpleConverter(MediaDevice *media);\n> \n> -\tint open();\n> -\tvoid close();\n> +\tbool isValid() const { return m2m_ != nullptr; }\n> \n> \tstd::vector formats(PixelFormat input);\n> \tSizeRange sizes(const Size &input);\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 8c0bca36bbfb..20a4ebca94fd 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -763,9 +763,9 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t/* Open the converter, if any. */\n> \tif (converter) {\n> \t\tconverter_ = std::make_unique(converter);\n> -\t\tif (converter_->open() < 0) {\n> +\t\tif (!converter_->isValid()) {\n> \t\t\tLOG(SimplePipeline, Warning)\n> -\t\t\t\t<< \"Failed to open converter, disabling format conversion\";\n> +\t\t\t\t<< \"Failed to create converter, disabling format conversion\";\n> \t\t\tconverter_.reset();\n> \t\t} else {\n> \t\t\tconverter_->bufferReady.connect(this, &SimplePipelineHandler::converterDone);\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8FEB9BD1F1\n\tfor ;\n\tFri, 19 Feb 2021 17:27:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21A5B689DF;\n\tFri, 19 Feb 2021 18:27:55 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 00800689DB\n\tfor ;\n\tFri, 19 Feb 2021 18:27:52 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 63050596;\n\tFri, 19 Feb 2021 18:27:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YJ+pytzZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613755672;\n\tbh=9jyCktbA3oNkRmYuETCklu5B6odI0qhUU6JwSLEbP/k=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=YJ+pytzZMqtAmse3Bz3a4doIVzAchvusgFsaF5vsviSeJ9oBIh5XS8QyZiK93hCuM\n\tDyCkop+KFUt00R3b6EfICLRXchZA5Pe3g5AWjURKkhs7jWKh9ulYD558BuXPhs5AOP\n\tfyiiiECDNuIy7IWeY+DhJBIoG7iITgS1+jyoggDc=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>\n\t<20210131224702.8838-8-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5774eb3d-3ad6-107d-d796-29e536c5deb0@ideasonboard.com>","Date":"Fri, 19 Feb 2021 17:27:50 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210131224702.8838-8-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 07/20] libcamera: pipeline: simple:\n\tconverter: Replace open() with isValid()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"Phi-Bang Nguyen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15279,"web_url":"https://patchwork.libcamera.org/comment/15279/","msgid":"<20210222101136.GB50254@pyrite.rasen.tech>","date":"2021-02-22T10:11:36","subject":"Re: [libcamera-devel] [PATCH 07/20] libcamera: pipeline: simple:\n\tconverter: Replace open() with isValid()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Mon, Feb 01, 2021 at 12:46:49AM +0200, Laurent Pinchart wrote:\n> Simplify the SimpleConverter interface by opening the M2M device in the\n> constructor. The explicit call to open() is replaced by a check through\n> a new isValid() function, and the unused close() function is removed.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/simple/converter.cpp | 20 ++++++--------------\n> src/libcamera/pipeline/simple/converter.h | 3 +--\n> src/libcamera/pipeline/simple/simple.cpp | 4 ++--\n> 3 files changed, 9 insertions(+), 18 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 6b3249ea92b0..f782fbc63b09 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -39,24 +39,16 @@ SimpleConverter::SimpleConverter(MediaDevice *media)\n> \n> \tm2m_ = std::make_unique((*it)->deviceNode());\n> \n> +\tint ret = m2m_->open();\n> +\tif (ret < 0) {\n> +\t\tm2m_.reset();\n> +\t\treturn;\n> +\t}\n> +\n> \tm2m_->output()->bufferReady.connect(this, &SimpleConverter::outputBufferReady);\n> \tm2m_->capture()->bufferReady.connect(this, &SimpleConverter::captureBufferReady);\n> }\n> \n> -int SimpleConverter::open()\n> -{\n> -\tif (!m2m_)\n> -\t\treturn -ENODEV;\n> -\n> -\treturn m2m_->open();\n> -}\n> -\n> -void SimpleConverter::close()\n> -{\n> -\tif (m2m_)\n> -\t\tm2m_->close();\n> -}\n> -\n> std::vector SimpleConverter::formats(PixelFormat input)\n> {\n> \tif (!m2m_)\n> diff --git a/src/libcamera/pipeline/simple/converter.h b/src/libcamera/pipeline/simple/converter.h\n> index a1503a6099ff..780bfa8f7832 100644\n> --- a/src/libcamera/pipeline/simple/converter.h\n> +++ b/src/libcamera/pipeline/simple/converter.h\n> @@ -30,8 +30,7 @@ class SimpleConverter\n> public:\n> \tSimpleConverter(MediaDevice *media);\n> \n> -\tint open();\n> -\tvoid close();\n> +\tbool isValid() const { return m2m_ != nullptr; }\n> \n> \tstd::vector formats(PixelFormat input);\n> \tSizeRange sizes(const Size &input);\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 8c0bca36bbfb..20a4ebca94fd 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -763,9 +763,9 @@ bool SimplePipelineHandler::match(DeviceEnumerator *enumerator)\n> \t/* Open the converter, if any. */\n> \tif (converter) {\n> \t\tconverter_ = std::make_unique(converter);\n> -\t\tif (converter_->open() < 0) {\n> +\t\tif (!converter_->isValid()) {\n> \t\t\tLOG(SimplePipeline, Warning)\n> -\t\t\t\t<< \"Failed to open converter, disabling format conversion\";\n> +\t\t\t\t<< \"Failed to create converter, disabling format conversion\";\n> \t\t\tconverter_.reset();\n> \t\t} else {\n> \t\t\tconverter_->bufferReady.connect(this, &SimplePipelineHandler::converterDone);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78190BD1F1\n\tfor ;\n\tMon, 22 Feb 2021 10:11:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E61DF68A02;\n\tMon, 22 Feb 2021 11:11:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 01F2E602F3\n\tfor ;\n\tMon, 22 Feb 2021 11:11:44 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B36AF344;\n\tMon, 22 Feb 2021 11:11:42 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CrvqPrME\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613988704;\n\tbh=YNKjQ8dqh8AFH6IKY6OG8IpDz4CSq471uHFyO0MkDLo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CrvqPrME7xCMlx44HcTAF5qJiKk+qi0lj/naNEcv7gb1CV/AhZ+QWb7/jKViJf/A9\n\t9iLLM+W6ikO1qE7tyfUfzDO4msvB5+KLyKyDgfIXdKcAnDqE/Do9mvm31h+435BoAE\n\tRhqAXHBNogFpWw+xXH0aqNI6kkCIuWMGxRVqDu00=","Date":"Mon, 22 Feb 2021 19:11:36 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210222101136.GB50254@pyrite.rasen.tech>","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>\n\t<20210131224702.8838-8-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210131224702.8838-8-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 07/20] libcamera: pipeline: simple:\n\tconverter: Replace open() with isValid()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Phi-Bang Nguyen ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]