[{"id":15200,"web_url":"https://patchwork.libcamera.org/comment/15200/","msgid":"<20210217101040.GF17707@pyrite.rasen.tech>","date":"2021-02-17T10:10:40","subject":"Re: [libcamera-devel] [PATCH 05/20] libcamera: pipeline: simple:\n\tconverter: Configure input stride","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Mon, Feb 01, 2021 at 12:46:47AM +0200, Laurent Pinchart wrote:\n> Use the stride of the video capture device to configure the converter\n> input. This ensures that no stride mismatch occurs inadvertently along\n> the pipeline.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/simple/converter.cpp | 5 ++++-\n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 2 files changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 6f4e41db2e00..550b2bcfb001 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -159,6 +159,8 @@ int SimpleConverter::configure(const StreamConfiguration &inputCfg,\n> \tV4L2DeviceFormat format;\n> \tformat.fourcc = videoFormat;\n> \tformat.size = inputCfg.size;\n> +\tformat.planesCount = 1;\n> +\tformat.planes[0].bpl = inputCfg.stride;\n> \n> \tret = m2m_->output()->setFormat(&format);\n> \tif (ret < 0) {\n> @@ -167,7 +169,8 @@ int SimpleConverter::configure(const StreamConfiguration &inputCfg,\n> \t\treturn ret;\n> \t}\n> \n> -\tif (format.fourcc != videoFormat || format.size != inputCfg.size) {\n> +\tif (format.fourcc != videoFormat || format.size != inputCfg.size ||\n> +\t format.planes[0].bpl != inputCfg.stride) {\n> \t\tLOG(SimplePipeline, Error)\n> \t\t\t<< \"Input format not supported\";\n> \t\treturn -EINVAL;\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 0a53fa934261..1ed67bcec490 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -606,6 +606,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \t\tStreamConfiguration inputCfg;\n> \t\tinputCfg.pixelFormat = pipeConfig.pixelFormat;\n> \t\tinputCfg.size = pipeConfig.captureSize;\n> +\t\tinputCfg.stride = captureFormat.planes[0].bpl;\n> \n> \t\tret = converter_->configure(inputCfg, cfg);\n> \t\tif (ret < 0) {\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1066FBD1F1\n\tfor ;\n\tWed, 17 Feb 2021 10:10:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B6766380B;\n\tWed, 17 Feb 2021 11:10:49 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71D88637F2\n\tfor ;\n\tWed, 17 Feb 2021 11:10:48 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AD098C4;\n\tWed, 17 Feb 2021 11:10:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UuW5Djnr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613556648;\n\tbh=w5IeKwBnvMcj3XlMSuy9xtPB5ZDjQGF1qugmspivB5Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UuW5Djnr8RAcuqRUsrU0kZH+AbPFhtCKt9iWsvo3G48N8IUdpBh2ry60rgDvN2+XM\n\tWXWCYfnNhUuuT/ti2G0+YiM8ADSdiaj6SUVKBuIWwiwX8ighp8Tuu4X1K1od3Re7Ay\n\tnRt0dBlhciB7Hs6fi+KA2zudCisiMSD6/V8o9cNs=","Date":"Wed, 17 Feb 2021 19:10:40 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210217101040.GF17707@pyrite.rasen.tech>","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>\n\t<20210131224702.8838-6-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210131224702.8838-6-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 05/20] libcamera: pipeline: simple:\n\tconverter: Configure input stride","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Phi-Bang Nguyen ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15250,"web_url":"https://patchwork.libcamera.org/comment/15250/","msgid":"<9b21595e-fac5-de7b-5b5d-2a5b4419d007@ideasonboard.com>","date":"2021-02-19T17:19:14","subject":"Re: [libcamera-devel] [PATCH 05/20] libcamera: pipeline: simple:\n\tconverter: Configure input stride","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 31/01/2021 22:46, Laurent Pinchart wrote:\n> Use the stride of the video capture device to configure the converter\n> input. This ensures that no stride mismatch occurs inadvertently along\n> the pipeline.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/pipeline/simple/converter.cpp | 5 ++++-\n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 2 files changed, 5 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> index 6f4e41db2e00..550b2bcfb001 100644\n> --- a/src/libcamera/pipeline/simple/converter.cpp\n> +++ b/src/libcamera/pipeline/simple/converter.cpp\n> @@ -159,6 +159,8 @@ int SimpleConverter::configure(const StreamConfiguration &inputCfg,\n> \tV4L2DeviceFormat format;\n> \tformat.fourcc = videoFormat;\n> \tformat.size = inputCfg.size;\n> +\tformat.planesCount = 1;\n> +\tformat.planes[0].bpl = inputCfg.stride;\n\nAre we lacking multiple plane description in the StreamConfiguration or\nsuch ?\n\nI guess it doesn't matter if this only supports a single planar format\nanyway, given the hardcoded planesCount.\n\nReviewed-by: Kieran Bingham \n\n> \n> \tret = m2m_->output()->setFormat(&format);\n> \tif (ret < 0) {\n> @@ -167,7 +169,8 @@ int SimpleConverter::configure(const StreamConfiguration &inputCfg,\n> \t\treturn ret;\n> \t}\n> \n> -\tif (format.fourcc != videoFormat || format.size != inputCfg.size) {\n> +\tif (format.fourcc != videoFormat || format.size != inputCfg.size ||\n> +\t format.planes[0].bpl != inputCfg.stride) {\n> \t\tLOG(SimplePipeline, Error)\n> \t\t\t<< \"Input format not supported\";\n> \t\treturn -EINVAL;\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index 0a53fa934261..1ed67bcec490 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -606,6 +606,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> \t\tStreamConfiguration inputCfg;\n> \t\tinputCfg.pixelFormat = pipeConfig.pixelFormat;\n> \t\tinputCfg.size = pipeConfig.captureSize;\n> +\t\tinputCfg.stride = captureFormat.planes[0].bpl;\n> \n> \t\tret = converter_->configure(inputCfg, cfg);\n> \t\tif (ret < 0) {\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 824E0BD1F1\n\tfor ;\n\tFri, 19 Feb 2021 17:19:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 10D56689CD;\n\tFri, 19 Feb 2021 18:19:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 80315689CD\n\tfor ;\n\tFri, 19 Feb 2021 18:19:17 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF0B1596;\n\tFri, 19 Feb 2021 18:19:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HM+fuEXf\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613755157;\n\tbh=QpEsiaFZNRFZJ0cBNaLFX58sxuokg80JAbQvApS2rcg=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=HM+fuEXfl6njpS/Ad2VCJmvZ4LFZ6Al7TA7NKTH02ty9KUi50QKVMKvYiDVPqSDyV\n\tKuOqydiBxXhO5D9asR15CrYlgZvMhhCQ6RkEyYu144StdIt5KDUmk5LbJpllLvy61A\n\tSzLMu2Ohp9KeCCTCoYRIXIle6cGwZscpvRPYu5JY=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>\n\t<20210131224702.8838-6-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<9b21595e-fac5-de7b-5b5d-2a5b4419d007@ideasonboard.com>","Date":"Fri, 19 Feb 2021 17:19:14 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210131224702.8838-6-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH 05/20] libcamera: pipeline: simple:\n\tconverter: Configure input stride","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"Phi-Bang Nguyen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":15255,"web_url":"https://patchwork.libcamera.org/comment/15255/","msgid":"","date":"2021-02-21T13:06:30","subject":"Re: [libcamera-devel] [PATCH 05/20] libcamera: pipeline: simple:\n\tconverter: Configure input stride","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Fri, Feb 19, 2021 at 05:19:14PM +0000, Kieran Bingham wrote:\n> On 31/01/2021 22:46, Laurent Pinchart wrote:\n> > Use the stride of the video capture device to configure the converter\n> > input. This ensures that no stride mismatch occurs inadvertently along\n> > the pipeline.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/pipeline/simple/converter.cpp | 5 ++++-\n> > src/libcamera/pipeline/simple/simple.cpp | 1 +\n> > 2 files changed, 5 insertions(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\n> > index 6f4e41db2e00..550b2bcfb001 100644\n> > --- a/src/libcamera/pipeline/simple/converter.cpp\n> > +++ b/src/libcamera/pipeline/simple/converter.cpp\n> > @@ -159,6 +159,8 @@ int SimpleConverter::configure(const StreamConfiguration &inputCfg,\n> > \tV4L2DeviceFormat format;\n> > \tformat.fourcc = videoFormat;\n> > \tformat.size = inputCfg.size;\n> > +\tformat.planesCount = 1;\n> > +\tformat.planes[0].bpl = inputCfg.stride;\n> \n> Are we lacking multiple plane description in the StreamConfiguration or\n> such ?\n\nYes, we're not doing great when it comes to multi-planar formats. This\nis something we need to fix.\n\n> I guess it doesn't matter if this only supports a single planar format\n> anyway, given the hardcoded planesCount.\n> \n> Reviewed-by: Kieran Bingham \n> \n> > \n> > \tret = m2m_->output()->setFormat(&format);\n> > \tif (ret < 0) {\n> > @@ -167,7 +169,8 @@ int SimpleConverter::configure(const StreamConfiguration &inputCfg,\n> > \t\treturn ret;\n> > \t}\n> > \n> > -\tif (format.fourcc != videoFormat || format.size != inputCfg.size) {\n> > +\tif (format.fourcc != videoFormat || format.size != inputCfg.size ||\n> > +\t format.planes[0].bpl != inputCfg.stride) {\n> > \t\tLOG(SimplePipeline, Error)\n> > \t\t\t<< \"Input format not supported\";\n> > \t\treturn -EINVAL;\n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index 0a53fa934261..1ed67bcec490 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -606,6 +606,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n> > \t\tStreamConfiguration inputCfg;\n> > \t\tinputCfg.pixelFormat = pipeConfig.pixelFormat;\n> > \t\tinputCfg.size = pipeConfig.captureSize;\n> > +\t\tinputCfg.stride = captureFormat.planes[0].bpl;\n> > \n> > \t\tret = converter_->configure(inputCfg, cfg);\n> > \t\tif (ret < 0) {\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69482BD1F6\n\tfor ;\n\tSun, 21 Feb 2021 13:06:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E8B4689E0;\n\tSun, 21 Feb 2021 14:06:58 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29121689C2\n\tfor ;\n\tSun, 21 Feb 2021 14:06:57 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55096344;\n\tSun, 21 Feb 2021 14:06:56 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ONfMw3Id\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1613912816;\n\tbh=bhtHEU7tNbQJlvXX/ZkMdpOoaMBUIgkFbuNQymCMo4U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ONfMw3IdBcj38h0tFf2Q3hVoliZyVITMEyAXddwMlYI695zafsz6JUs27H0LX8UF5\n\tkcF2m8YzuBcnYRAJuaw9r040l/3ScRI6xirhXksu7TB0XmVAhX4r1+/HoYmobcqDuI\n\t4YJBbyJDofiCzmcRRZ+4bYMzl5nMLrVsX6MSG9s4=","Date":"Sun, 21 Feb 2021 15:06:30 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Message-ID":"","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>\n\t<20210131224702.8838-6-laurent.pinchart@ideasonboard.com>\n\t<9b21595e-fac5-de7b-5b5d-2a5b4419d007@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<9b21595e-fac5-de7b-5b5d-2a5b4419d007@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 05/20] libcamera: pipeline: simple:\n\tconverter: Configure input stride","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Phi-Bang Nguyen ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]