{"id":11084,"url":"https://patchwork.libcamera.org/api/patches/11084/?format=json","web_url":"https://patchwork.libcamera.org/patch/11084/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210131224702.8838-6-laurent.pinchart@ideasonboard.com>","date":"2021-01-31T22:46:47","name":"[libcamera-devel,05/20] libcamera: pipeline: simple: converter: Configure input stride","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"60dfd096c755f2b447bcf906b2921598220adb64","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11084/mbox/","series":[{"id":1633,"url":"https://patchwork.libcamera.org/api/series/1633/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1633","date":"2021-01-31T22:46:42","name":"[libcamera-devel,01/20] libcamera: pipeline: simple: Manage converter with std::unique_ptr<>","version":1,"mbox":"https://patchwork.libcamera.org/series/1633/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11084/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11084/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F381BD808\n\tfor ;\n\tSun, 31 Jan 2021 22:47:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B09E268401;\n\tSun, 31 Jan 2021 23:47:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 950DB683D9\n\tfor ;\n\tSun, 31 Jan 2021 23:47:29 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1D7D88F1;\n\tSun, 31 Jan 2021 23:47:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i2MHfw5g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612133249;\n\tbh=H1qIVCyOhiIrEzzsoNBN34FbiBDaspLhH6VLpFXQn9w=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=i2MHfw5gUx9ax9q/Lf1eJrZq4Wlhr7zuid4kg2R9Ovj03oINy5Q1zEXOamYMJ3d32\n\tElIdly5Ss3WKGA7e8mdWCWDfOasAvHEq2fDTSblcuf11n6AZw1enUTORTstxhiTvwm\n\ttydHXeiqIzLxLYDnG76lzzN0rMv1183VXx0i6ZhI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 1 Feb 2021 00:46:47 +0200","Message-Id":"<20210131224702.8838-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>","References":"<20210131224702.8838-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 05/20] libcamera: pipeline: simple:\n\tconverter: Configure input stride","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Phi-Bang Nguyen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Use the stride of the video capture device to configure the converter\ninput. This ensures that no stride mismatch occurs inadvertently along\nthe pipeline.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/pipeline/simple/converter.cpp | 5 ++++-\n src/libcamera/pipeline/simple/simple.cpp | 1 +\n 2 files changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\nindex 6f4e41db2e00..550b2bcfb001 100644\n--- a/src/libcamera/pipeline/simple/converter.cpp\n+++ b/src/libcamera/pipeline/simple/converter.cpp\n@@ -159,6 +159,8 @@ int SimpleConverter::configure(const StreamConfiguration &inputCfg,\n \tV4L2DeviceFormat format;\n \tformat.fourcc = videoFormat;\n \tformat.size = inputCfg.size;\n+\tformat.planesCount = 1;\n+\tformat.planes[0].bpl = inputCfg.stride;\n \n \tret = m2m_->output()->setFormat(&format);\n \tif (ret < 0) {\n@@ -167,7 +169,8 @@ int SimpleConverter::configure(const StreamConfiguration &inputCfg,\n \t\treturn ret;\n \t}\n \n-\tif (format.fourcc != videoFormat || format.size != inputCfg.size) {\n+\tif (format.fourcc != videoFormat || format.size != inputCfg.size ||\n+\t format.planes[0].bpl != inputCfg.stride) {\n \t\tLOG(SimplePipeline, Error)\n \t\t\t<< \"Input format not supported\";\n \t\treturn -EINVAL;\ndiff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 0a53fa934261..1ed67bcec490 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -606,6 +606,7 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \t\tStreamConfiguration inputCfg;\n \t\tinputCfg.pixelFormat = pipeConfig.pixelFormat;\n \t\tinputCfg.size = pipeConfig.captureSize;\n+\t\tinputCfg.stride = captureFormat.planes[0].bpl;\n \n \t\tret = converter_->configure(inputCfg, cfg);\n \t\tif (ret < 0) {\n","prefixes":["libcamera-devel","05/20"]}