[{"id":14886,"web_url":"https://patchwork.libcamera.org/comment/14886/","msgid":"","date":"2021-02-01T16:20:15","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: formats: Add RGB565_BE\n\tformat","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2021-01-31 20:43:52 +0200, Laurent Pinchart wrote:\n> This new format corresponds to the V4L2 V4L2_PIX_FMT_RGB565X format, and\n> is the big-endian version of the DRM_FORMAT_RGB565 format.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/formats.cpp | 10 ++++++++++\n> src/libcamera/formats.yaml | 3 +++\n> src/libcamera/v4l2_pixelformat.cpp | 1 +\n> 3 files changed, 14 insertions(+)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 14940bee3724..4f70e47e0c97 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -155,6 +155,16 @@ const std::map pixelFormatInfo{\n> \t\t.pixelsPerGroup = 1,\n> \t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> \t} },\n> +\t{ formats::RGB565_BE, {\n> +\t\t.name = \"RGB565_BE\",\n> +\t\t.format = formats::RGB565_BE,\n> +\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGB565X),\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n> +\t\t.packed = false,\n> +\t\t.pixelsPerGroup = 1,\n> +\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n> +\t} },\n> \t{ formats::BGR888, {\n> \t\t.name = \"BGR888\",\n> \t\t.format = formats::BGR888,\n> diff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\n> index de4254df9334..c3adef54ca0f 100644\n> --- a/src/libcamera/formats.yaml\n> +++ b/src/libcamera/formats.yaml\n> @@ -10,6 +10,9 @@ formats:\n> \n> - RGB565:\n> fourcc: DRM_FORMAT_RGB565\n> + - RGB565_BE:\n> + fourcc: DRM_FORMAT_RGB565\n> + big_endian: true\n> \n> - RGB888:\n> fourcc: DRM_FORMAT_RGB888\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index 2665d5a7af08..abb1824c5673 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -47,6 +47,7 @@ namespace {\n> const std::map vpf2pf{\n> \t/* RGB formats. */\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565), formats::RGB565 },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565X), formats::RGB565_BE },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B74A3C33BB\n\tfor ;\n\tMon, 1 Feb 2021 16:20:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 83AE66840E;\n\tMon, 1 Feb 2021 17:20:18 +0100 (CET)","from mail-lf1-x130.google.com (mail-lf1-x130.google.com\n\t[IPv6:2a00:1450:4864:20::130])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C9FC4683FF\n\tfor ;\n\tMon, 1 Feb 2021 17:20:16 +0100 (CET)","by mail-lf1-x130.google.com with SMTP id u25so23519223lfc.2\n\tfor ;\n\tMon, 01 Feb 2021 08:20:16 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty4sm2994599lfg.55.2021.02.01.08.20.15\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 01 Feb 2021 08:20:15 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"Vf1ihCOn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=Mzv8jn9dlBm07UBm6KjFqDKKxYtgFSRCyvNcMAntYKA=;\n\tb=Vf1ihCOnsfn0pNGlrgkmv1m1W1/8Z0NZVIK4Tu+bd7aDC7bE3IFrZ9wphhn/r4qGLZ\n\trEZJ5Uk+pz0ODrNIHTEc1i+VZyA2V4bGqAtrtlYAiBoe5/BL6zb2YHo+XzBMOr/AIvVA\n\tj569cHz1/YHGptbNP8aEVfUFGVb55IpYWu3aYANqgiP0ZgFX6ysAQkYbKnvJDnWwOtnN\n\t108cMV0v0Sn5JuyQsPh2b+WFRQFlxCEhJ8vN0YBxKPfiVREdbjJpT9L40wsztVeUO69T\n\to8RdwWD3M5BgDxnF49PBJ70Vza9A/nITbyfaBdP23rl6ZU4Go3inhgr4b6Tp4zAZsT4x\n\tGJzg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=Mzv8jn9dlBm07UBm6KjFqDKKxYtgFSRCyvNcMAntYKA=;\n\tb=jD0j3sIGXAOxUdN6LwJRZvVYJ1kcwEh2qMI79nsqhqwBg2HaqlIjSKOa2DoZMtecP+\n\tiSX59gGnGE2faQrrHKxFlIY9+OhPrTbrWjcVVLprrzPO3QGLnanD+4FwJ0IfRO2VW4DE\n\ts2Xy261ONOFY6YeMRtNvvxb/q0wGG4JFT7nZsHACPAHBvOLyWwzdtWxok20idYYch3wx\n\tLkFUgnNhZ1YClgdGD4HXzg8JvPFrHki5BBKmKKKucgTQPtbmHmAYLxiYUN6dHIBEUc5r\n\t3iATJVJKbBoIU4Vf1b1Ey4gic9BKB95eSh6GN28uIlmk13O7oqcrS+5D2CItQbxk/4bO\n\tdnHA==","X-Gm-Message-State":"AOAM532qLDVjHVYKJ8zK/BV8ePDfvHcO6ryrDoQeSclQe0uoinhTxqiy\n\tlxLSY05WYyMBcJMNqQx93mQBBg==","X-Google-Smtp-Source":"ABdhPJy8qAU7eia4iwN+7yMz8WBM1YAMotez4Kx+r+NAEAxCQOVwkRtGmcJufnxnlinhAv6GphF68g==","X-Received":"by 2002:a05:6512:22c3:: with SMTP id\n\tg3mr8264235lfu.376.1612196416325; \n\tMon, 01 Feb 2021 08:20:16 -0800 (PST)","Date":"Mon, 1 Feb 2021 17:20:15 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210131184352.10635-1-laurent.pinchart@ideasonboard.com>\n\t<20210131184352.10635-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210131184352.10635-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: formats: Add RGB565_BE\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]