{"id":11078,"url":"https://patchwork.libcamera.org/api/patches/11078/?format=json","web_url":"https://patchwork.libcamera.org/patch/11078/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210131184352.10635-3-laurent.pinchart@ideasonboard.com>","date":"2021-01-31T18:43:52","name":"[libcamera-devel,2/2] libcamera: formats: Add RGB565_BE format","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7abccd69948ff36a14b8574e4e5438ae082a3055","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/11078/mbox/","series":[{"id":1632,"url":"https://patchwork.libcamera.org/api/series/1632/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1632","date":"2021-01-31T18:43:50","name":"libcamera: Add support for RGB565X format","version":1,"mbox":"https://patchwork.libcamera.org/series/1632/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11078/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11078/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8D81C33BB\n\tfor ;\n\tSun, 31 Jan 2021 18:44:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78728683E2;\n\tSun, 31 Jan 2021 19:44:19 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6624683D4\n\tfor ;\n\tSun, 31 Jan 2021 19:44:16 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44565813\n\tfor ;\n\tSun, 31 Jan 2021 19:44:16 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T4RsSQZ9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612118656;\n\tbh=sWpBZbJgyDjawkzl3wtsHOH5nxPIOt34YwkjRbcOAME=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=T4RsSQZ9Ci9tJbNEhcXn4IgoicC9nciLuaZDAYthTkVR543IBUuAyoPcbfkHILX15\n\t7EZEU0uluV7zhaYuQOClXJSUfrWb7nauB8Ay3OJXYoklwJmL34jIkCnl6r4hKROoNc\n\tUUAFl1i60IN1pOEimqysGx8OXq9r8/U6o8hNmOsE=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 31 Jan 2021 20:43:52 +0200","Message-Id":"<20210131184352.10635-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20210131184352.10635-1-laurent.pinchart@ideasonboard.com>","References":"<20210131184352.10635-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/2] libcamera: formats: Add RGB565_BE\n\tformat","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"This new format corresponds to the V4L2 V4L2_PIX_FMT_RGB565X format, and\nis the big-endian version of the DRM_FORMAT_RGB565 format.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/formats.cpp | 10 ++++++++++\n src/libcamera/formats.yaml | 3 +++\n src/libcamera/v4l2_pixelformat.cpp | 1 +\n 3 files changed, 14 insertions(+)","diff":"diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 14940bee3724..4f70e47e0c97 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -155,6 +155,16 @@ const std::map pixelFormatInfo{\n \t\t.pixelsPerGroup = 1,\n \t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n \t} },\n+\t{ formats::RGB565_BE, {\n+\t\t.name = \"RGB565_BE\",\n+\t\t.format = formats::RGB565_BE,\n+\t\t.v4l2Format = V4L2PixelFormat(V4L2_PIX_FMT_RGB565X),\n+\t\t.bitsPerPixel = 16,\n+\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRGB,\n+\t\t.packed = false,\n+\t\t.pixelsPerGroup = 1,\n+\t\t.planes = {{ { 3, 1 }, { 0, 0 }, { 0, 0 } }},\n+\t} },\n \t{ formats::BGR888, {\n \t\t.name = \"BGR888\",\n \t\t.format = formats::BGR888,\ndiff --git a/src/libcamera/formats.yaml b/src/libcamera/formats.yaml\nindex de4254df9334..c3adef54ca0f 100644\n--- a/src/libcamera/formats.yaml\n+++ b/src/libcamera/formats.yaml\n@@ -10,6 +10,9 @@ formats:\n \n - RGB565:\n fourcc: DRM_FORMAT_RGB565\n+ - RGB565_BE:\n+ fourcc: DRM_FORMAT_RGB565\n+ big_endian: true\n \n - RGB888:\n fourcc: DRM_FORMAT_RGB888\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 2665d5a7af08..abb1824c5673 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -47,6 +47,7 @@ namespace {\n const std::map vpf2pf{\n \t/* RGB formats. */\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565), formats::RGB565 },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB565X), formats::RGB565_BE },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_RGB24), formats::BGR888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_BGR24), formats::RGB888 },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_XBGR32), formats::XRGB8888 },\n","prefixes":["libcamera-devel","2/2"]}