[{"id":14991,"web_url":"https://patchwork.libcamera.org/comment/14991/","msgid":"","date":"2021-02-04T21:33:59","subject":"Re: [libcamera-devel] [PATCH v5 3/6] uapi: raspberrypi: Update the\n\tbcm2835-isp header definition","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Fri, Jan 29, 2021 at 03:11:51PM +0000, Naushir Patuck wrote:\n> Update the bcm2835-isp.h file with the latest version available in the\n> downstream Raspberry Pi linux repo.\n\nCould you please mention the commit ID ? With this,\n\nReviewed-by: Laurent Pinchart \n\n> This change adds support for colour denoise processing, and the\n> following downstream kernel changes must be available:\n> https://github.com/raspberrypi/linux/pull/4069\n> https://github.com/raspberrypi/linux/pull/4083\n> \n> The Raspberry Pi image must also be running the latest firmware,\n> obtained by running rpi-update.\n> \n> Signed-off-by: Naushir Patuck \n> Reviewed-by: David Plowman \n> Acked-by: Kieran Bingham \n> ---\n> include/linux/bcm2835-isp.h | 32 +++++++++++++++++++++++++++++---\n> 1 file changed, 29 insertions(+), 3 deletions(-)\n> \n> diff --git a/include/linux/bcm2835-isp.h b/include/linux/bcm2835-isp.h\n> index 45abb681517e..94c3af947883 100644\n> --- a/include/linux/bcm2835-isp.h\n> +++ b/include/linux/bcm2835-isp.h\n> @@ -31,7 +31,8 @@\n> \t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0007)\n> #define V4L2_CID_USER_BCM2835_ISP_DPC\t\t\\\n> \t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0008)\n> -\n> +#define V4L2_CID_USER_BCM2835_ISP_CDN \\\n> +\t\t\t\t(V4L2_CID_USER_BCM2835_ISP_BASE + 0x0009)\n\nYou could send a patch to the kernel to add the missing blank line here\n;-)\n\n> /*\n> * All structs below are directly mapped onto the equivalent structs in\n> * drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h\n> @@ -46,7 +47,7 @@\n> */\n> struct bcm2835_isp_rational {\n> \t__s32 num;\n> -\t__s32 den;\n> +\t__u32 den;\n> };\n> \n> /**\n> @@ -140,7 +141,7 @@ struct bcm2835_isp_black_level {\n> \t__u16 black_level_r;\n> \t__u16 black_level_g;\n> \t__u16 black_level_b;\n> -\t__u8 pad_[2]; /* Unused */\n> +\t__u8 padding[2]; /* Unused */\n> };\n> \n> /**\n> @@ -175,6 +176,31 @@ struct bcm2835_isp_gamma {\n> \t__u16 y[BCM2835_NUM_GAMMA_PTS];\n> };\n> \n> +/**\n> + * enum bcm2835_isp_cdn_mode - Mode of operation for colour denoise.\n> + *\n> + * @CDN_MODE_FAST:\t\tFast (but lower quality) colour denoise\n\nAnd to remove the extra space.\n\n> + *\t\t\t\talgorithm, typically used for video recording.\n> + * @CDN_HIGH_QUALITY:\t\tHigh quality (but slower) colour denoise\n> + *\t\t\t\talgorithm, typically used for stills capture.\n> + */\n> +enum bcm2835_isp_cdn_mode {\n> +\tCDN_MODE_FAST = 0,\n> +\tCDN_MODE_HIGH_QUALITY = 1,\n> +};\n> +\n> +/**\n> + * struct bcm2835_isp_cdn - Colour denoise parameters set with the\n> + *\t\t\t V4L2_CID_USER_BCM2835_ISP_CDN ctrl.\n> + *\n> + * @enabled:\tEnable colour denoise.\n> + * @cdn_mode:\tColour denoise operating mode (see enum &bcm2835_isp_cdn_mode)\n> + */\n> +struct bcm2835_isp_cdn {\n> +\t__u32 enabled;\n> +\t__u32 mode;\n> +};\n> +\n> /**\n> * struct bcm2835_isp_denoise - Denoise parameters set with the\n> *\t\t\t\tV4L2_CID_USER_BCM2835_ISP_DENOISE ctrl.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E051BD162\n\tfor ;\n\tThu, 4 Feb 2021 21:34:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 018AA61467;\n\tThu, 4 Feb 2021 22:34:24 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9AFA661430\n\tfor ;\n\tThu, 4 Feb 2021 22:34:22 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1217245D;\n\tThu, 4 Feb 2021 22:34:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"vfJEbgxW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612474462;\n\tbh=4jCcxPHkGm49Kw2Sot/npvZnvVtlqehWEa1UH8jYc70=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vfJEbgxWvgRNF4XlBnjppJldq0GBNUlYIckX2IPq6XszMF/YjnPVUc3gXI2by7gqR\n\t0uRzn99DcrIHEKycRT0G036wsfTZr/hwK+YlV2HilCAYviH2ErwFuY3hGac1pnAEoj\n\tSMaQ5Z3FO+JX1d8xBx3N5ZlhBSHFqroa+IRRUC48=","Date":"Thu, 4 Feb 2021 23:33:59 +0200","From":"Laurent Pinchart ","To":"Naushir Patuck ","Message-ID":"","References":"<20210129151154.1051163-1-naush@raspberrypi.com>\n\t<20210129151154.1051163-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210129151154.1051163-4-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH v5 3/6] uapi: raspberrypi: Update the\n\tbcm2835-isp header definition","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]