[{"id":14860,"web_url":"https://patchwork.libcamera.org/comment/14860/","msgid":"","date":"2021-01-29T23:15:23","subject":"Re: [libcamera-devel] [PATCH 2/3] android: camera_device: Add\n\tmissing request keys","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hello Jacopo,\n\nThanks for your patch.\n\nOn 2021-01-29 15:26:14 +0100, Jacopo Mondi wrote:\n> The Camera HAL does not report all the Request keys which are\n> mandatory for the advertised BACKWARD_COMPATIBLE capabilities\n> level. Add them.\n> \n> This fixes the CTS test:\n> android.hardware.camera2.cts.StaticMetadataTest#testCapabilities\n> \n> Signed-off-by: Jacopo Mondi \n\nI trust your byteSize calculation,\n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 13 +++++++++++--\n> 1 file changed, 11 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 83e2734541e3..b66e7c71884a 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -705,10 +705,10 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> {\n> \t/*\n> \t * \\todo Keep this in sync with the actual number of entries.\n> -\t * Currently: 53 entries, 782 bytes of static metadata\n> +\t * Currently: 53 entries, 846 bytes of static metadata\n> \t */\n> \tuint32_t numEntries = 53;\n> -\tuint32_t byteSize = 810;\n> +\tuint32_t byteSize = 846;\n> \n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -1218,15 +1218,24 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_CONTROL_AE_MODE,\n> \t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> \t\tANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n> +\t\tANDROID_CONTROL_AF_MODE,\n> \t\tANDROID_CONTROL_AF_TRIGGER,\n> \t\tANDROID_CONTROL_AWB_LOCK,\n> \t\tANDROID_CONTROL_AWB_MODE,\n> \t\tANDROID_CONTROL_CAPTURE_INTENT,\n> +\t\tANDROID_CONTROL_EFFECT_MODE,\n> \t\tANDROID_CONTROL_MODE,\n> +\t\tANDROID_CONTROL_SCENE_MODE,\n> +\t\tANDROID_CONTROL_VIDEO_STABILIZATION_MODE,\n> \t\tANDROID_FLASH_MODE,\n> +\t\tANDROID_JPEG_ORIENTATION,\n> +\t\tANDROID_JPEG_QUALITY,\n> +\t\tANDROID_JPEG_THUMBNAIL_QUALITY,\n> +\t\tANDROID_JPEG_THUMBNAIL_SIZE,\n> \t\tANDROID_LENS_APERTURE,\n> \t\tANDROID_LENS_OPTICAL_STABILIZATION_MODE,\n> \t\tANDROID_NOISE_REDUCTION_MODE,\n> +\t\tANDROID_SCALER_CROP_REGION,\n> \t\tANDROID_STATISTICS_FACE_DETECT_MODE\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_REQUEST_KEYS,\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DAA4CBD808\n\tfor ;\n\tFri, 29 Jan 2021 23:15:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4F5BE683BE;\n\tSat, 30 Jan 2021 00:15:27 +0100 (CET)","from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com\n\t[IPv6:2a00:1450:4864:20::12d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A412F6030A\n\tfor ;\n\tSat, 30 Jan 2021 00:15:25 +0100 (CET)","by mail-lf1-x12d.google.com with SMTP id a8so14739255lfi.8\n\tfor ;\n\tFri, 29 Jan 2021 15:15:25 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tw13sm2176892lfu.299.2021.01.29.15.15.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 29 Jan 2021 15:15:24 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"u2b9MRGr\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=9UhAP7CHWXc3mn7WxHczcoYrEDnEHYuGOciiT87A8Oo=;\n\tb=u2b9MRGr2J6sJk/66xeJ5pRuX6beSPI+CP1iYTa+P2Mkb3ZJqClhZublAre56s11OJ\n\trudcNhj2EkWj+AEZgnbZ+SZSD/xzt+npknhExwQNPkzMt8uwHutjs5ncTbC5yMw4/Sqf\n\tR22aqH7zZ9s1vdgIMY1QIUT/uJPgumM8Ulv540kzUEuNUtmzpF9hGEHtiOcdnUc+GDRU\n\tIQbqRU2cS1SrQ51McS3CA/X6qIyTLpIP35pJP7ZeKpkdYQgD8KvW/Z8Q9CeAvAevut1R\n\txfG36vmp3J90YVqbxeoysmhZvk2IG28tPtd1oFOBOjtK0YmGfw2IP1N76qtrRlCTyG5x\n\tGZXg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=9UhAP7CHWXc3mn7WxHczcoYrEDnEHYuGOciiT87A8Oo=;\n\tb=OxnPSh+YwbFTsP9Z5lbwue7KCaz1OEZr7LgdGS3R7FD2/BkEw4qkMwN8kMMkikcZye\n\tyY/jLFKa2fv1cpI/n1BGe7qoawv/PBcw25aj2iNaanuGqgG+LZ5ZnsEM9ih3B7R7ydie\n\tgXTPuu5sz73m+W16ithFDUzu6Kk1xO0O8FDzqWhvzwELk0jpDjzAFOsoP/EYPzOR/SvU\n\tCJh8QeNzXdxh3O9qhO2X/Jx08Gavu/NYa87gwt7/yq/NPVB2AveBwL9QJDyI+b2K7sF5\n\tLPlx03RU7qP+YjD31n8s4Zt/O+pcoQ3SSkmh/Y4Zv/C5YI3WaaBPH5mJxS6NwYE7f9kw\n\t4FYw==","X-Gm-Message-State":"AOAM530MZKJjAIwmPEJjWXZZpgZMljO+ICXdkt23nx62gtJOftSbI3/k\n\tIbJH4IidjInb1tlxVLBI7mMuBg==","X-Google-Smtp-Source":"ABdhPJzecJlw3WAxDfW2IXIMOdTGupE/IDoQonBMh1GTby2w/sMWmQc1iO4mTjWtBSi+nWbB6O8HpA==","X-Received":"by 2002:ac2:44b1:: with SMTP id\n\tc17mr3068400lfm.556.1611962125086; \n\tFri, 29 Jan 2021 15:15:25 -0800 (PST)","Date":"Sat, 30 Jan 2021 00:15:23 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210129142615.669464-1-jacopo@jmondi.org>\n\t<20210129142615.669464-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210129142615.669464-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/3] android: camera_device: Add\n\tmissing request keys","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14868,"web_url":"https://patchwork.libcamera.org/comment/14868/","msgid":"<20210201023935.GB3415@pyrite.rasen.tech>","date":"2021-02-01T02:39:35","subject":"Re: [libcamera-devel] [PATCH 2/3] android: camera_device: Add\n\tmissing request keys","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Jan 29, 2021 at 03:26:14PM +0100, Jacopo Mondi wrote:\n> The Camera HAL does not report all the Request keys which are\n> mandatory for the advertised BACKWARD_COMPATIBLE capabilities\n> level. Add them.\n> \n> This fixes the CTS test:\n> android.hardware.camera2.cts.StaticMetadataTest#testCapabilities\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_device.cpp | 13 +++++++++++--\n> 1 file changed, 11 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 83e2734541e3..b66e7c71884a 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -705,10 +705,10 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n> {\n> \t/*\n> \t * \\todo Keep this in sync with the actual number of entries.\n> -\t * Currently: 53 entries, 782 bytes of static metadata\n> +\t * Currently: 53 entries, 846 bytes of static metadata\n> \t */\n> \tuint32_t numEntries = 53;\n> -\tuint32_t byteSize = 810;\n> +\tuint32_t byteSize = 846;\n> \n> \t/*\n> \t * Calculate space occupation in bytes for dynamically built metadata\n> @@ -1218,15 +1218,24 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_CONTROL_AE_MODE,\n> \t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> \t\tANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n> +\t\tANDROID_CONTROL_AF_MODE,\n> \t\tANDROID_CONTROL_AF_TRIGGER,\n> \t\tANDROID_CONTROL_AWB_LOCK,\n> \t\tANDROID_CONTROL_AWB_MODE,\n> \t\tANDROID_CONTROL_CAPTURE_INTENT,\n> +\t\tANDROID_CONTROL_EFFECT_MODE,\n> \t\tANDROID_CONTROL_MODE,\n> +\t\tANDROID_CONTROL_SCENE_MODE,\n> +\t\tANDROID_CONTROL_VIDEO_STABILIZATION_MODE,\n> \t\tANDROID_FLASH_MODE,\n> +\t\tANDROID_JPEG_ORIENTATION,\n> +\t\tANDROID_JPEG_QUALITY,\n> +\t\tANDROID_JPEG_THUMBNAIL_QUALITY,\n> +\t\tANDROID_JPEG_THUMBNAIL_SIZE,\n> \t\tANDROID_LENS_APERTURE,\n> \t\tANDROID_LENS_OPTICAL_STABILIZATION_MODE,\n> \t\tANDROID_NOISE_REDUCTION_MODE,\n> +\t\tANDROID_SCALER_CROP_REGION,\n> \t\tANDROID_STATISTICS_FACE_DETECT_MODE\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_REQUEST_KEYS,\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8DBF5C33BB\n\tfor ;\n\tMon, 1 Feb 2021 02:39:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 24877683DE;\n\tMon, 1 Feb 2021 03:39:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D475560107\n\tfor ;\n\tMon, 1 Feb 2021 03:39:42 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 56F0D556;\n\tMon, 1 Feb 2021 03:39:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mPUCgrJq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612147182;\n\tbh=jOr/ePXznzR+QB9BTEC0+xhhccPHL+8VumK48wDkYQY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mPUCgrJq3rzcqMrcm0ggNHExHAWdh8JS33k/snJAK8F8YIZaSHXVHZo8j/dTquucQ\n\tjlJ7JJ9VZyZyoQXTAA9WWydGfVdd3ax1VzynwFJyuNoCPutrN8qFTtjLU0CXJfLWcz\n\tgUVaX3Fw8gHV3SJ0pnBXpNvgtmbwmW1F5i/Mj8N8=","Date":"Mon, 1 Feb 2021 11:39:35 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210201023935.GB3415@pyrite.rasen.tech>","References":"<20210129142615.669464-1-jacopo@jmondi.org>\n\t<20210129142615.669464-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210129142615.669464-3-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 2/3] android: camera_device: Add\n\tmissing request keys","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]