[{"id":14859,"web_url":"https://patchwork.libcamera.org/comment/14859/","msgid":"","date":"2021-01-29T23:12:39","subject":"Re: [libcamera-devel] [PATCH 1/3] android: camera_device:\n\tAlphabetically sort keys","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Jacopo,\n\nThanks for your work.\n\nOn 2021-01-29 15:26:13 +0100, Jacopo Mondi wrote:\n> The vectors of available characteristics, request and result keys\n> are not sorted. This makes more complex than necessary spotting\n> duplication of keys.\n> \n> Re-sort the vector initializer lists alphabetically.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/android/camera_device.cpp | 100 +++++++++++++++++-----------------\n> 1 file changed, 50 insertions(+), 50 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 741dc8cfa635..83e2734541e3 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1162,72 +1162,72 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_CONTROL_AE_AVAILABLE_TARGET_FPS_RANGES,\n> \t\tANDROID_CONTROL_AE_COMPENSATION_RANGE,\n> \t\tANDROID_CONTROL_AE_COMPENSATION_STEP,\n> +\t\tANDROID_CONTROL_AE_LOCK_AVAILABLE,\n> \t\tANDROID_CONTROL_AF_AVAILABLE_MODES,\n> \t\tANDROID_CONTROL_AVAILABLE_EFFECTS,\n> +\t\tANDROID_CONTROL_AVAILABLE_MODES,\n> \t\tANDROID_CONTROL_AVAILABLE_SCENE_MODES,\n> \t\tANDROID_CONTROL_AVAILABLE_VIDEO_STABILIZATION_MODES,\n> \t\tANDROID_CONTROL_AWB_AVAILABLE_MODES,\n> +\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> \t\tANDROID_CONTROL_MAX_REGIONS,\n> \t\tANDROID_CONTROL_SCENE_MODE_OVERRIDES,\n> -\t\tANDROID_CONTROL_AE_LOCK_AVAILABLE,\n> -\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> -\t\tANDROID_CONTROL_AVAILABLE_MODES,\n> +\t\tANDROID_FLASH_INFO_AVAILABLE,\n> +\t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n> \t\tANDROID_JPEG_AVAILABLE_THUMBNAIL_SIZES,\n> \t\tANDROID_JPEG_MAX_SIZE,\n> -\t\tANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n> -\t\tANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> -\t\tANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n> -\t\tANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> -\t\tANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n> -\t\tANDROID_SENSOR_ORIENTATION,\n> -\t\tANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n> -\t\tANDROID_SENSOR_INFO_PHYSICAL_SIZE,\n> -\t\tANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,\n> -\t\tANDROID_STATISTICS_INFO_AVAILABLE_FACE_DETECT_MODES,\n> -\t\tANDROID_STATISTICS_INFO_MAX_FACE_COUNT,\n> -\t\tANDROID_SYNC_MAX_LATENCY,\n> -\t\tANDROID_FLASH_INFO_AVAILABLE,\n> -\t\tANDROID_LENS_INFO_AVAILABLE_APERTURES,\n> \t\tANDROID_LENS_FACING,\n> +\t\tANDROID_LENS_INFO_AVAILABLE_APERTURES,\n> \t\tANDROID_LENS_INFO_AVAILABLE_FOCAL_LENGTHS,\n> \t\tANDROID_LENS_INFO_AVAILABLE_OPTICAL_STABILIZATION,\n> \t\tANDROID_LENS_INFO_HYPERFOCAL_DISTANCE,\n> \t\tANDROID_LENS_INFO_MINIMUM_FOCUS_DISTANCE,\n> \t\tANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n> +\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> +\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> +\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> +\t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> +\t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> \t\tANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n> -\t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> -\t\tANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n> \t\tANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,\n> +\t\tANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n> +\t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> \t\tANDROID_SCALER_CROPPING_TYPE,\n> -\t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n> -\t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> -\t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> -\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> -\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> -\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> +\t\tANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n> +\t\tANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> +\t\tANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> +\t\tANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n> +\t\tANDROID_SENSOR_INFO_PHYSICAL_SIZE,\n> +\t\tANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n> +\t\tANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n> +\t\tANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,\n> +\t\tANDROID_SENSOR_ORIENTATION,\n> +\t\tANDROID_STATISTICS_INFO_AVAILABLE_FACE_DETECT_MODES,\n> +\t\tANDROID_STATISTICS_INFO_MAX_FACE_COUNT,\n> +\t\tANDROID_SYNC_MAX_LATENCY,\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CHARACTERISTICS_KEYS,\n> \t\t\t\t availableCharacteristicsKeys.data(),\n> \t\t\t\t availableCharacteristicsKeys.size());\n> \n> \tstd::vector availableRequestKeys = {\n> -\t\tANDROID_CONTROL_AE_MODE,\n> +\t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE,\n> +\t\tANDROID_CONTROL_AE_ANTIBANDING_MODE,\n> \t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> +\t\tANDROID_CONTROL_AE_LOCK,\n> +\t\tANDROID_CONTROL_AE_MODE,\n> \t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> \t\tANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n> -\t\tANDROID_CONTROL_AE_ANTIBANDING_MODE,\n> -\t\tANDROID_CONTROL_AE_LOCK,\n> \t\tANDROID_CONTROL_AF_TRIGGER,\n> -\t\tANDROID_CONTROL_AWB_MODE,\n> \t\tANDROID_CONTROL_AWB_LOCK,\n> +\t\tANDROID_CONTROL_AWB_MODE,\n> +\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> +\t\tANDROID_CONTROL_MODE,\n> \t\tANDROID_FLASH_MODE,\n> -\t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> -\t\tANDROID_NOISE_REDUCTION_MODE,\n> -\t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE,\n> \t\tANDROID_LENS_APERTURE,\n> \t\tANDROID_LENS_OPTICAL_STABILIZATION_MODE,\n> -\t\tANDROID_CONTROL_MODE,\n> -\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> +\t\tANDROID_NOISE_REDUCTION_MODE,\n> +\t\tANDROID_STATISTICS_FACE_DETECT_MODE\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_REQUEST_KEYS,\n> \t\t\t\t availableRequestKeys.data(),\n> @@ -1237,14 +1237,14 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_CONTROL_AE_ANTIBANDING_MODE,\n> \t\tANDROID_CONTROL_AE_LOCK,\n> \t\tANDROID_CONTROL_AE_MODE,\n> -\t\tANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n> \t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> \t\tANDROID_CONTROL_AE_STATE,\n> +\t\tANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n> \t\tANDROID_CONTROL_AF_MODE,\n> \t\tANDROID_CONTROL_AF_STATE,\n> \t\tANDROID_CONTROL_AF_TRIGGER,\n> -\t\tANDROID_CONTROL_AWB_MODE,\n> \t\tANDROID_CONTROL_AWB_LOCK,\n> +\t\tANDROID_CONTROL_AWB_MODE,\n> \t\tANDROID_CONTROL_AWB_STATE,\n> \t\tANDROID_CONTROL_CAPTURE_INTENT,\n> \t\tANDROID_CONTROL_EFFECT_MODE,\n> @@ -1253,27 +1253,27 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_CONTROL_VIDEO_STABILIZATION_MODE,\n> \t\tANDROID_FLASH_MODE,\n> \t\tANDROID_FLASH_STATE,\n> +\t\tANDROID_JPEG_GPS_COORDINATES,\n> +\t\tANDROID_JPEG_GPS_PROCESSING_METHOD,\n> +\t\tANDROID_JPEG_GPS_TIMESTAMP,\n> +\t\tANDROID_JPEG_ORIENTATION,\n> +\t\tANDROID_JPEG_QUALITY,\n> +\t\tANDROID_JPEG_SIZE,\n> +\t\tANDROID_JPEG_THUMBNAIL_QUALITY,\n> +\t\tANDROID_JPEG_THUMBNAIL_SIZE,\n> \t\tANDROID_LENS_APERTURE,\n> \t\tANDROID_LENS_FOCAL_LENGTH,\n> -\t\tANDROID_LENS_STATE,\n> \t\tANDROID_LENS_OPTICAL_STABILIZATION_MODE,\n> -\t\tANDROID_SENSOR_TIMESTAMP,\n> -\t\tANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> +\t\tANDROID_LENS_STATE,\n> +\t\tANDROID_NOISE_REDUCTION_MODE,\n> +\t\tANDROID_REQUEST_PIPELINE_DEPTH,\n> +\t\tANDROID_SCALER_CROP_REGION,\n> \t\tANDROID_SENSOR_EXPOSURE_TIME,\n> +\t\tANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> +\t\tANDROID_SENSOR_TIMESTAMP,\n> \t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> \t\tANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n> \t\tANDROID_STATISTICS_SCENE_FLICKER,\n> -\t\tANDROID_NOISE_REDUCTION_MODE,\n> -\t\tANDROID_REQUEST_PIPELINE_DEPTH,\n> -\t\tANDROID_SCALER_CROP_REGION,\n> -\t\tANDROID_JPEG_GPS_COORDINATES,\n> -\t\tANDROID_JPEG_GPS_PROCESSING_METHOD,\n> -\t\tANDROID_JPEG_GPS_TIMESTAMP,\n> -\t\tANDROID_JPEG_SIZE,\n> -\t\tANDROID_JPEG_QUALITY,\n> -\t\tANDROID_JPEG_ORIENTATION,\n> -\t\tANDROID_JPEG_THUMBNAIL_QUALITY,\n> -\t\tANDROID_JPEG_THUMBNAIL_SIZE,\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_RESULT_KEYS,\n> \t\t\t\t availableResultKeys.data(),\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F0CA0C33BB\n\tfor ;\n\tFri, 29 Jan 2021 23:12:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DD9C683BD;\n\tSat, 30 Jan 2021 00:12:44 +0100 (CET)","from mail-lf1-x129.google.com (mail-lf1-x129.google.com\n\t[IPv6:2a00:1450:4864:20::129])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 314066030A\n\tfor ;\n\tSat, 30 Jan 2021 00:12:42 +0100 (CET)","by mail-lf1-x129.google.com with SMTP id u25so14722790lfc.2\n\tfor ;\n\tFri, 29 Jan 2021 15:12:42 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tb24sm2195564lff.204.2021.01.29.15.12.40\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 29 Jan 2021 15:12:40 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"KC/oIiFu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=AH4ycaBPC2fZ1otc4x0uysJjxCFIj502S84csH/xTM0=;\n\tb=KC/oIiFuJ/a7EpnWpwcNCqTjlfnjgIXmeYGg00P+vxzBSfO8rE7mRMFqsR0gzxn8zw\n\tMcajgaK6D4G8uW9tW2v4ecaice3HonAmugGGvsedn6K/yHVnnHZ5dJO3mH5UaxXYJnpM\n\tMcwZvpE821Gmc7YuuPVOPJLyvb0OffGZek0gnkHiiI0vfhclSH8mDYGYVYAg76nUkoeh\n\tf1eq3Iu+LaAMh9tby5/KUF31AaWakNN/19N2xPvYoRMpRfqHL9neu53NijxsLUd7EDFM\n\ts+dXlwgFI1MEmV9S8mFXksGnQi6hJHAIl4GGqjlUjrDuWR3IsCXuRggcEehGkAp70IWQ\n\tiNtw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=AH4ycaBPC2fZ1otc4x0uysJjxCFIj502S84csH/xTM0=;\n\tb=KVoaQ1vUsfHUjSKL/H8e3spxmrJYVX0KAKiRUaNGM7GoJlBTbw8o+//JIdYNeH7xUx\n\tsJICFzX62loeCpAbLnjMFGpKZYgEQtQzbGSkklq60OrYcG3KiNwEWn6V+8eNoipJOq/Z\n\tX/Sfqh6V/RaM6qT7D3Lvq4f2sK/w/7kVbuHc29SFN6aK3CLZrwtIrKkz0+otswibOFV1\n\tQYKVWY9FCbj0/0uC/1OO0zirLF0mEXFAdwO9YL+lVMGg1eBhE07MPkr1se9OgV1L1eoB\n\tJubJMokyoS6SvzvbAtnwd5EN484Hd9lMbr2ny0WI6o2LoI7HOEsXWOKZ1iLIrdNBhtBo\n\tZl1g==","X-Gm-Message-State":"AOAM531idkq0h5vcoEuBsmYdL09ubLvhZkfa2QgDUJ2stF44NDeX3EUY\n\tjHk56ngfnHNX8dn8+mP7z5il6PsfZqOfaw==","X-Google-Smtp-Source":"ABdhPJwjxhH1ot9L9RXW4V47fsrfDNy52MnRKYj/vh4Y1Hu8v4TFTWjkKlCMuDaSus/aPPlsNohFnA==","X-Received":"by 2002:a05:6512:3cd:: with SMTP id\n\tw13mr3174214lfp.565.1611961961497; \n\tFri, 29 Jan 2021 15:12:41 -0800 (PST)","Date":"Sat, 30 Jan 2021 00:12:39 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Jacopo Mondi ","Message-ID":"","References":"<20210129142615.669464-1-jacopo@jmondi.org>\n\t<20210129142615.669464-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210129142615.669464-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 1/3] android: camera_device:\n\tAlphabetically sort keys","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14867,"web_url":"https://patchwork.libcamera.org/comment/14867/","msgid":"<20210201023651.GA3415@pyrite.rasen.tech>","date":"2021-02-01T02:36:51","subject":"Re: [libcamera-devel] [PATCH 1/3] android: camera_device:\n\tAlphabetically sort keys","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Fri, Jan 29, 2021 at 03:26:13PM +0100, Jacopo Mondi wrote:\n> The vectors of available characteristics, request and result keys\n> are not sorted. This makes more complex than necessary spotting\n> duplication of keys.\n> \n> Re-sort the vector initializer lists alphabetically.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/android/camera_device.cpp | 100 +++++++++++++++++-----------------\n> 1 file changed, 50 insertions(+), 50 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 741dc8cfa635..83e2734541e3 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -1162,72 +1162,72 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_CONTROL_AE_AVAILABLE_TARGET_FPS_RANGES,\n> \t\tANDROID_CONTROL_AE_COMPENSATION_RANGE,\n> \t\tANDROID_CONTROL_AE_COMPENSATION_STEP,\n> +\t\tANDROID_CONTROL_AE_LOCK_AVAILABLE,\n> \t\tANDROID_CONTROL_AF_AVAILABLE_MODES,\n> \t\tANDROID_CONTROL_AVAILABLE_EFFECTS,\n> +\t\tANDROID_CONTROL_AVAILABLE_MODES,\n> \t\tANDROID_CONTROL_AVAILABLE_SCENE_MODES,\n> \t\tANDROID_CONTROL_AVAILABLE_VIDEO_STABILIZATION_MODES,\n> \t\tANDROID_CONTROL_AWB_AVAILABLE_MODES,\n> +\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> \t\tANDROID_CONTROL_MAX_REGIONS,\n> \t\tANDROID_CONTROL_SCENE_MODE_OVERRIDES,\n> -\t\tANDROID_CONTROL_AE_LOCK_AVAILABLE,\n> -\t\tANDROID_CONTROL_AWB_LOCK_AVAILABLE,\n> -\t\tANDROID_CONTROL_AVAILABLE_MODES,\n> +\t\tANDROID_FLASH_INFO_AVAILABLE,\n> +\t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n> \t\tANDROID_JPEG_AVAILABLE_THUMBNAIL_SIZES,\n> \t\tANDROID_JPEG_MAX_SIZE,\n> -\t\tANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n> -\t\tANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> -\t\tANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n> -\t\tANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> -\t\tANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n> -\t\tANDROID_SENSOR_ORIENTATION,\n> -\t\tANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n> -\t\tANDROID_SENSOR_INFO_PHYSICAL_SIZE,\n> -\t\tANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,\n> -\t\tANDROID_STATISTICS_INFO_AVAILABLE_FACE_DETECT_MODES,\n> -\t\tANDROID_STATISTICS_INFO_MAX_FACE_COUNT,\n> -\t\tANDROID_SYNC_MAX_LATENCY,\n> -\t\tANDROID_FLASH_INFO_AVAILABLE,\n> -\t\tANDROID_LENS_INFO_AVAILABLE_APERTURES,\n> \t\tANDROID_LENS_FACING,\n> +\t\tANDROID_LENS_INFO_AVAILABLE_APERTURES,\n> \t\tANDROID_LENS_INFO_AVAILABLE_FOCAL_LENGTHS,\n> \t\tANDROID_LENS_INFO_AVAILABLE_OPTICAL_STABILIZATION,\n> \t\tANDROID_LENS_INFO_HYPERFOCAL_DISTANCE,\n> \t\tANDROID_LENS_INFO_MINIMUM_FOCUS_DISTANCE,\n> \t\tANDROID_NOISE_REDUCTION_AVAILABLE_NOISE_REDUCTION_MODES,\n> +\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> +\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> +\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> +\t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> +\t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> \t\tANDROID_SCALER_AVAILABLE_MAX_DIGITAL_ZOOM,\n> -\t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> -\t\tANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n> \t\tANDROID_SCALER_AVAILABLE_MIN_FRAME_DURATIONS,\n> +\t\tANDROID_SCALER_AVAILABLE_STALL_DURATIONS,\n> +\t\tANDROID_SCALER_AVAILABLE_STREAM_CONFIGURATIONS,\n> \t\tANDROID_SCALER_CROPPING_TYPE,\n> -\t\tANDROID_INFO_SUPPORTED_HARDWARE_LEVEL,\n> -\t\tANDROID_REQUEST_PARTIAL_RESULT_COUNT,\n> -\t\tANDROID_REQUEST_PIPELINE_MAX_DEPTH,\n> -\t\tANDROID_REQUEST_MAX_NUM_OUTPUT_STREAMS,\n> -\t\tANDROID_REQUEST_MAX_NUM_INPUT_STREAMS,\n> -\t\tANDROID_REQUEST_AVAILABLE_CAPABILITIES,\n> +\t\tANDROID_SENSOR_AVAILABLE_TEST_PATTERN_MODES,\n> +\t\tANDROID_SENSOR_INFO_ACTIVE_ARRAY_SIZE,\n> +\t\tANDROID_SENSOR_INFO_COLOR_FILTER_ARRANGEMENT,\n> +\t\tANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n> +\t\tANDROID_SENSOR_INFO_PHYSICAL_SIZE,\n> +\t\tANDROID_SENSOR_INFO_PIXEL_ARRAY_SIZE,\n> +\t\tANDROID_SENSOR_INFO_SENSITIVITY_RANGE,\n> +\t\tANDROID_SENSOR_INFO_TIMESTAMP_SOURCE,\n> +\t\tANDROID_SENSOR_ORIENTATION,\n> +\t\tANDROID_STATISTICS_INFO_AVAILABLE_FACE_DETECT_MODES,\n> +\t\tANDROID_STATISTICS_INFO_MAX_FACE_COUNT,\n> +\t\tANDROID_SYNC_MAX_LATENCY,\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_CHARACTERISTICS_KEYS,\n> \t\t\t\t availableCharacteristicsKeys.data(),\n> \t\t\t\t availableCharacteristicsKeys.size());\n> \n> \tstd::vector availableRequestKeys = {\n> -\t\tANDROID_CONTROL_AE_MODE,\n> +\t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE,\n> +\t\tANDROID_CONTROL_AE_ANTIBANDING_MODE,\n> \t\tANDROID_CONTROL_AE_EXPOSURE_COMPENSATION,\n> +\t\tANDROID_CONTROL_AE_LOCK,\n> +\t\tANDROID_CONTROL_AE_MODE,\n> \t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> \t\tANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n> -\t\tANDROID_CONTROL_AE_ANTIBANDING_MODE,\n> -\t\tANDROID_CONTROL_AE_LOCK,\n> \t\tANDROID_CONTROL_AF_TRIGGER,\n> -\t\tANDROID_CONTROL_AWB_MODE,\n> \t\tANDROID_CONTROL_AWB_LOCK,\n> +\t\tANDROID_CONTROL_AWB_MODE,\n> +\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> +\t\tANDROID_CONTROL_MODE,\n> \t\tANDROID_FLASH_MODE,\n> -\t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> -\t\tANDROID_NOISE_REDUCTION_MODE,\n> -\t\tANDROID_COLOR_CORRECTION_ABERRATION_MODE,\n> \t\tANDROID_LENS_APERTURE,\n> \t\tANDROID_LENS_OPTICAL_STABILIZATION_MODE,\n> -\t\tANDROID_CONTROL_MODE,\n> -\t\tANDROID_CONTROL_CAPTURE_INTENT,\n> +\t\tANDROID_NOISE_REDUCTION_MODE,\n> +\t\tANDROID_STATISTICS_FACE_DETECT_MODE\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_REQUEST_KEYS,\n> \t\t\t\t availableRequestKeys.data(),\n> @@ -1237,14 +1237,14 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_CONTROL_AE_ANTIBANDING_MODE,\n> \t\tANDROID_CONTROL_AE_LOCK,\n> \t\tANDROID_CONTROL_AE_MODE,\n> -\t\tANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n> \t\tANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n> \t\tANDROID_CONTROL_AE_STATE,\n> +\t\tANDROID_CONTROL_AE_TARGET_FPS_RANGE,\n> \t\tANDROID_CONTROL_AF_MODE,\n> \t\tANDROID_CONTROL_AF_STATE,\n> \t\tANDROID_CONTROL_AF_TRIGGER,\n> -\t\tANDROID_CONTROL_AWB_MODE,\n> \t\tANDROID_CONTROL_AWB_LOCK,\n> +\t\tANDROID_CONTROL_AWB_MODE,\n> \t\tANDROID_CONTROL_AWB_STATE,\n> \t\tANDROID_CONTROL_CAPTURE_INTENT,\n> \t\tANDROID_CONTROL_EFFECT_MODE,\n> @@ -1253,27 +1253,27 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n> \t\tANDROID_CONTROL_VIDEO_STABILIZATION_MODE,\n> \t\tANDROID_FLASH_MODE,\n> \t\tANDROID_FLASH_STATE,\n> +\t\tANDROID_JPEG_GPS_COORDINATES,\n> +\t\tANDROID_JPEG_GPS_PROCESSING_METHOD,\n> +\t\tANDROID_JPEG_GPS_TIMESTAMP,\n> +\t\tANDROID_JPEG_ORIENTATION,\n> +\t\tANDROID_JPEG_QUALITY,\n> +\t\tANDROID_JPEG_SIZE,\n> +\t\tANDROID_JPEG_THUMBNAIL_QUALITY,\n> +\t\tANDROID_JPEG_THUMBNAIL_SIZE,\n> \t\tANDROID_LENS_APERTURE,\n> \t\tANDROID_LENS_FOCAL_LENGTH,\n> -\t\tANDROID_LENS_STATE,\n> \t\tANDROID_LENS_OPTICAL_STABILIZATION_MODE,\n> -\t\tANDROID_SENSOR_TIMESTAMP,\n> -\t\tANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> +\t\tANDROID_LENS_STATE,\n> +\t\tANDROID_NOISE_REDUCTION_MODE,\n> +\t\tANDROID_REQUEST_PIPELINE_DEPTH,\n> +\t\tANDROID_SCALER_CROP_REGION,\n> \t\tANDROID_SENSOR_EXPOSURE_TIME,\n> +\t\tANDROID_SENSOR_ROLLING_SHUTTER_SKEW,\n> +\t\tANDROID_SENSOR_TIMESTAMP,\n> \t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n> \t\tANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n> \t\tANDROID_STATISTICS_SCENE_FLICKER,\n> -\t\tANDROID_NOISE_REDUCTION_MODE,\n> -\t\tANDROID_REQUEST_PIPELINE_DEPTH,\n> -\t\tANDROID_SCALER_CROP_REGION,\n> -\t\tANDROID_JPEG_GPS_COORDINATES,\n> -\t\tANDROID_JPEG_GPS_PROCESSING_METHOD,\n> -\t\tANDROID_JPEG_GPS_TIMESTAMP,\n> -\t\tANDROID_JPEG_SIZE,\n> -\t\tANDROID_JPEG_QUALITY,\n> -\t\tANDROID_JPEG_ORIENTATION,\n> -\t\tANDROID_JPEG_THUMBNAIL_QUALITY,\n> -\t\tANDROID_JPEG_THUMBNAIL_SIZE,\n> \t};\n> \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_RESULT_KEYS,\n> \t\t\t\t availableResultKeys.data(),\n> -- \n> 2.30.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F2F68C33BB\n\tfor ;\n\tMon, 1 Feb 2021 02:37:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 66DA1683F5;\n\tMon, 1 Feb 2021 03:37:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DD26C60107\n\tfor ;\n\tMon, 1 Feb 2021 03:36:59 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B756556;\n\tMon, 1 Feb 2021 03:36:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iap/JDBg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612147019;\n\tbh=GG75/MP/vy4GKRPoukB7B4A2QIZIbo3pXnkHA6Dtxho=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=iap/JDBg3Few0Mvrgb/CFoTtL+z6kgi/IoKVw79eg0V3a0/dk3C5OiEqujMDa/8HV\n\tzwtuaWV4t7o4vNF5x39J669zMZ8ooeewrr9E4oZ+EsZiU+JlyE5ijfWOo/XoEVL1A8\n\thpdnxYWnKgchC8Kbtt5e9w+S+pK0vP0TdxJ3p7sA=","Date":"Mon, 1 Feb 2021 11:36:51 +0900","From":"paul.elder@ideasonboard.com","To":"Jacopo Mondi ","Message-ID":"<20210201023651.GA3415@pyrite.rasen.tech>","References":"<20210129142615.669464-1-jacopo@jmondi.org>\n\t<20210129142615.669464-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210129142615.669464-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH 1/3] android: camera_device:\n\tAlphabetically sort keys","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]