[{"id":14863,"web_url":"https://patchwork.libcamera.org/comment/14863/","msgid":"","date":"2021-01-29T23:28:05","subject":"Re: [libcamera-devel] [PATCH v2] android: camera_device: Fix\n\texposure time tag in exif and android","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Paul,\n\nThanks for your work.\n\nOn 2021-01-29 15:01:49 +0900, Paul Elder wrote:\n> The ExposureTime libcamera control is in microseconds while android and\n> our exif component use nanoseconds. Convert it appropriately.\n> \n> CTS also expects the ExposureTime exif tag to match the ExposureTime set\n> in the android result metadata. Fix it.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Jacopo Mondi \n> Reviewed-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> \n> ---\n> Changes in v2:\n> - remove todo to get the information from libcamera::Request::metadata\n> - fix potential overflow\n> ---\n> src/android/camera_device.cpp | 2 +-\n> src/android/jpeg/post_processor_jpeg.cpp | 4 ++--\n> 2 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index 741dc8cf..c1025e81 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -2058,7 +2058,7 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n> \t}\n> \n> \tif (metadata.contains(controls::ExposureTime)) {\n> -\t\tint32_t exposure = metadata.get(controls::ExposureTime);\n> +\t\tint64_t exposure = metadata.get(controls::ExposureTime) * 1000ULL;\n> \t\tresultMetadata->addEntry(ANDROID_SENSOR_EXPOSURE_TIME,\n> \t\t\t\t\t &exposure, 1);\n> \t}\n> diff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\n> index cac0087b..1cbab30c 100644\n> --- a/src/android/jpeg/post_processor_jpeg.cpp\n> +++ b/src/android/jpeg/post_processor_jpeg.cpp\n> @@ -112,8 +112,8 @@ int PostProcessorJpeg::process(const FrameBuffer &source,\n> \t */\n> \texif.setTimestamp(std::time(nullptr), 0ms);\n> \n> -\t/* \\todo Get this information from libcamera::Request::metadata */\n> -\texif.setExposureTime(0);\n> +\tret = resultMetadata->getEntry(ANDROID_SENSOR_EXPOSURE_TIME, &entry);\n> +\texif.setExposureTime(ret ? *entry.data.i64 : 0);\n> \tret = requestMetadata.getEntry(ANDROID_LENS_APERTURE, &entry);\n> \tif (ret)\n> \t\texif.setAperture(*entry.data.f);\n> -- \n> 2.27.0\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 35636C33BB\n\tfor ;\n\tFri, 29 Jan 2021 23:28:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 04053683C4;\n\tSat, 30 Jan 2021 00:28:08 +0100 (CET)","from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com\n\t[IPv6:2a00:1450:4864:20::22a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B60A66030A\n\tfor ;\n\tSat, 30 Jan 2021 00:28:06 +0100 (CET)","by mail-lj1-x22a.google.com with SMTP id t8so12365943ljk.10\n\tfor ;\n\tFri, 29 Jan 2021 15:28:06 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\tc16sm2713475ljk.13.2021.01.29.15.28.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 29 Jan 2021 15:28:05 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"SeKqNcQL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=2sbN+7JkiIkoMHfqgAy9XJeJyvXJ5F6IFI1Rs1/GZR8=;\n\tb=SeKqNcQLbuW5Po5OzGjr5vhGK4LCkPPPT+Pi1nxw3giCdwp8mDvP6lqhsZEnTj7Ywj\n\tWNBzm+huvcSTGmaY1G0SE8c0P3MJ/JaxdikH2MCXlNskDxkdXK3CdXFXilW3qDE1/yqW\n\tLFBwOAPhyM9bdEvaeE2qAaB/lxiQXKEKxyiD1ANqv2wkKlFQl2NixIer7DdYjWtDDRn+\n\tAOGH/7TQjYy/owDfZx9oQna+jbNeYc3VkJLrL2mzSOGEhQIBI2W9ILfu7HutJ5U62fSc\n\tAV3KvdP5cfYq1vQ6yPff5qhijuLnCL/kf/RO+dqFhLl8YhZSA5xuOfbPrx7LXPRX86ru\n\tGaWA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=2sbN+7JkiIkoMHfqgAy9XJeJyvXJ5F6IFI1Rs1/GZR8=;\n\tb=oP5KS/p+WR7T7z4zw9nDcBJFUWoBD+No4V2ECQdfKVNT2rmBUkmf5WDtolocRo7zE5\n\tKKdoqHa5UKRzef6pUVlf1Qm4PeXj4B4gXB6NyDEjkALYAC2cK5g9Q84r6n+CEizFXjDg\n\tKkI816ZyGz8nGIrp3oJ02jyaPCIdUSbP650qbrBhYNTiZWGQ/NRCcIXFiAqA5bk7tU86\n\t8evHFU1l/Ep3mG0b+JKgdUfeERaxkWTllv2kfnFL54frTQeEwzgV0WXEJK80oYdHIcSh\n\tNsA1ZR0F6SRzQ3pjxYsH6w8vanhhRbb0utnpQzVRu/b3pA84s+m71dbhn11kPVFjcVJt\n\tq+1A==","X-Gm-Message-State":"AOAM532oO2Ee0l/hgqe41KaYXlzmYCXyLW7RjEBL9LqBREmTLXgIgVUY\n\tEOmMPVeSbzNtkYfQY3P5QJzLOhc5PGYQyA==","X-Google-Smtp-Source":"ABdhPJx8SLVqghTyB+C3ihj6qfqxPYAXqB5lYX90AqnrwzmEHhSFsEIQebdxXp7chQSLOFrYLQZTOQ==","X-Received":"by 2002:a2e:8654:: with SMTP id\n\ti20mr3710472ljj.362.1611962886217; \n\tFri, 29 Jan 2021 15:28:06 -0800 (PST)","Date":"Sat, 30 Jan 2021 00:28:05 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Paul Elder ","Message-ID":"","References":"<20210129060149.13462-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210129060149.13462-1-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2] android: camera_device: Fix\n\texposure time tag in exif and android","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]