{"id":11032,"url":"https://patchwork.libcamera.org/api/patches/11032/?format=json","web_url":"https://patchwork.libcamera.org/patch/11032/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210127101435.3903-1-paul.elder@ideasonboard.com>","date":"2021-01-27T10:14:35","name":"[libcamera-devel] android: camera_device: Set AE precapture trigger according to request","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ec3f624e8f8f792ad55c9d5fd6f297c89e1a7232","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11032/mbox/","series":[{"id":1615,"url":"https://patchwork.libcamera.org/api/series/1615/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1615","date":"2021-01-27T10:14:35","name":"[libcamera-devel] android: camera_device: Set AE precapture trigger according to request","version":1,"mbox":"https://patchwork.libcamera.org/series/1615/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11032/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11032/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55ACDC0F2B\n\tfor ;\n\tWed, 27 Jan 2021 10:14:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C7AD268363;\n\tWed, 27 Jan 2021 11:14:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9044D6835B\n\tfor ;\n\tWed, 27 Jan 2021 11:14:46 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F1BFE240;\n\tWed, 27 Jan 2021 11:14:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FLFEfxfh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611742486;\n\tbh=ly4L31I6sfNfl0fnT/g6AbGSPpC1TxN9YEGPR0cues4=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=FLFEfxfhBjO/p8kVuckglZnnOSMHLnHMKfFmf7SEnKRHC0BQ5k+XPAzX+VwjDXJO6\n\twwkhxwx3AZEM8xURLvk5OgROf9D+x39RnKwua33ehr/VlLoyGYuHwHMD9Gs6LKxHxh\n\tKe4Qk05DjkX5h6F36BHYWCaUqdcWFUsigf2/bhhQ=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 27 Jan 2021 19:14:35 +0900","Message-Id":"<20210127101435.3903-1-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] android: camera_device: Set AE precapture\n\ttrigger according to request","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Set the AE precapture triggler tag in the android result metadata\naccording to what was passed in the request metadata.\n\nThis allows the following CTS test to pass:\n- android.hardware.camera2.cts.StillCaptureTest#testAePrecaptureTriggerCancelJpegCapture\n\nSigned-off-by: Paul Elder \n---\n src/android/camera_device.cpp | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 82bf0d3a..941e89a8 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1806,6 +1806,13 @@ void CameraDevice::requestComplete(Request *request)\n \tuint64_t timestamp = buffers.begin()->second->metadata().timestamp;\n \tresultMetadata = getResultMetadata(descriptor, timestamp);\n \n+\tcamera_metadata_ro_entry_t entry;\n+\t/* \\todo Handle IPA appropriately */\n+\tint ret = descriptor->settings_.getEntry(ANDROID_CONTROL_AE_PRECAPTURE_TRIGGER, &entry);\n+\tif (ret)\n+\t\tresultMetadata->updateEntry(ANDROID_CONTROL_AE_PRECAPTURE_TRIGGER,\n+\t\t\t\t\t entry.data.u8, 1);\n+\n \t/* Handle any JPEG compression. */\n \tfor (unsigned int i = 0; i < descriptor->numBuffers_; ++i) {\n \t\tCameraStream *cameraStream =\n@@ -1832,9 +1839,9 @@ void CameraDevice::requestComplete(Request *request)\n \t\t\tcontinue;\n \t\t}\n \n-\t\tint ret = cameraStream->process(*buffer, &mapped,\n-\t\t\t\t\t\tdescriptor->settings_,\n-\t\t\t\t\t\tresultMetadata.get());\n+\t\tret = cameraStream->process(*buffer, &mapped,\n+\t\t\t\t\t descriptor->settings_,\n+\t\t\t\t\t resultMetadata.get());\n \t\tif (ret) {\n \t\t\tstatus = CAMERA3_BUFFER_STATUS_ERROR;\n \t\t\tcontinue;\n","prefixes":["libcamera-devel"]}