[{"id":14793,"web_url":"https://patchwork.libcamera.org/comment/14793/","msgid":"","date":"2021-01-26T21:22:06","subject":"Re: [libcamera-devel] [PATCH v2 1/2] Revert \"libcamera: span:\n\tProvide and use helper variable templates for type traits\"","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jean-Michel,\n\nThank you for the patch.\n\nOn Tue, Jan 26, 2021 at 02:04:14PM +0100, Jean-Michel Hautbois wrote:\n> This reverts commit 8e42c2feb7ff7c350ffbbf97dd963dfd54e21faa.\n\nMissing Signed-off-by. Same for the next patch. Could you provide them\nin an e-mail reply ?\n\n> ---\n> include/libcamera/controls.h | 12 ++++++------\n> include/libcamera/span.h | 22 ++++++++--------------\n> 2 files changed, 14 insertions(+), 20 deletions(-)\n> \n> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n> index 3634dc43..dc549a92 100644\n> --- a/include/libcamera/controls.h\n> +++ b/include/libcamera/controls.h\n> @@ -96,7 +96,7 @@ public:\n> \tControlValue();\n> \n> #ifndef __DOXYGEN__\n> -\ttemplate &&\n> +\ttemplate::value &&\n> \t\t\t\t\t\t details::control_type::value &&\n> \t\t\t\t\t\t !std::is_same_v>,\n> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n> @@ -107,7 +107,7 @@ public:\n> \t\t &value, 1, sizeof(T));\n> \t}\n> \n> -\ttemplate ||\n> +\ttemplate::value ||\n> \t\t\t\t\t\t std::is_same_v>,\n> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n> #else\n> @@ -141,7 +141,7 @@ public:\n> \t}\n> \n> #ifndef __DOXYGEN__\n> -\ttemplate &&\n> +\ttemplate::value &&\n> \t\t\t\t\t\t !std::is_same_v>,\n> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n> \tT get() const\n> @@ -152,7 +152,7 @@ public:\n> \t\treturn *reinterpret_cast(data().data());\n> \t}\n> \n> -\ttemplate ||\n> +\ttemplate::value ||\n> \t\t\t\t\t\t std::is_same_v>,\n> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n> #else\n> @@ -169,7 +169,7 @@ public:\n> \t}\n> \n> #ifndef __DOXYGEN__\n> -\ttemplate &&\n> +\ttemplate::value &&\n> \t\t\t\t\t\t !std::is_same_v>,\n> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n> \tvoid set(const T &value)\n> @@ -178,7 +178,7 @@ public:\n> \t\t reinterpret_cast(&value), 1, sizeof(T));\n> \t}\n> \n> -\ttemplate ||\n> +\ttemplate::value ||\n> \t\t\t\t\t\t std::is_same_v>,\n> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n> #else\n> diff --git a/include/libcamera/span.h b/include/libcamera/span.h\n> index e7ffef12..d720adb8 100644\n> --- a/include/libcamera/span.h\n> +++ b/include/libcamera/span.h\n> @@ -31,9 +31,6 @@ template\n> struct is_array> : public std::true_type {\n> };\n> \n> -template\n> -inline constexpr bool is_array_v = is_array::value;\n> -\n> template\n> struct is_span : public std::false_type {\n> };\n> @@ -42,9 +39,6 @@ template\n> struct is_span> : public std::true_type {\n> };\n> \n> -template\n> -inline constexpr bool is_span_v = is_span::value;\n> -\n> } /* namespace details */\n> \n> namespace utils {\n> @@ -161,8 +155,8 @@ public:\n> \n> \ttemplate\n> \texplicit constexpr Span(Container &cont,\n> -\t\t\t\tstd::enable_if_t &&\n> -\t\t\t\t\t\t !details::is_array_v &&\n> +\t\t\t\tstd::enable_if_t::value &&\n> +\t\t\t\t\t\t !details::is_array::value &&\n> \t\t\t\t\t\t !std::is_array_v &&\n> \t\t\t\t\t\t std::is_convertible_v (*)[],\n> \t\t\t\t\t\t\t\t element_type (*)[]>,\n> @@ -173,8 +167,8 @@ public:\n> \n> \ttemplate\n> \texplicit constexpr Span(const Container &cont,\n> -\t\t\t\tstd::enable_if_t &&\n> -\t\t\t\t\t\t !details::is_array_v &&\n> +\t\t\t\tstd::enable_if_t::value &&\n> +\t\t\t\t\t\t !details::is_array::value &&\n> \t\t\t\t\t\t !std::is_array_v &&\n> \t\t\t\t\t\t std::is_convertible_v (*)[],\n> \t\t\t\t\t\t\t\t element_type (*)[]>,\n> @@ -323,8 +317,8 @@ public:\n> \n> \ttemplate\n> \tconstexpr Span(Container &cont,\n> -\t\t std::enable_if_t &&\n> -\t\t\t\t\t!details::is_array_v &&\n> +\t\t std::enable_if_t::value &&\n> +\t\t\t\t\t!details::is_array::value &&\n> \t\t\t\t\t!std::is_array_v &&\n> \t\t\t\t\tstd::is_convertible_v (*)[],\n> \t\t\t\t\t\t\t element_type (*)[]>,\n> @@ -335,8 +329,8 @@ public:\n> \n> \ttemplate\n> \tconstexpr Span(const Container &cont,\n> -\t\t std::enable_if_t &&\n> -\t\t\t\t\t!details::is_array_v &&\n> +\t\t std::enable_if_t::value &&\n> +\t\t\t\t\t!details::is_array::value &&\n> \t\t\t\t\t!std::is_array_v &&\n> \t\t\t\t\tstd::is_convertible_v (*)[],\n> \t\t\t\t\t\t\t element_type (*)[]>,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 943E5BD808\n\tfor ;\n\tTue, 26 Jan 2021 21:22:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09B9F6831F;\n\tTue, 26 Jan 2021 22:22:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A7B516831A\n\tfor ;\n\tTue, 26 Jan 2021 22:22:29 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 15B282C1;\n\tTue, 26 Jan 2021 22:22:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"uzdnrn4S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611696149;\n\tbh=N5u6J7GggDnZc3DIvH56yHDScm5DhWW87IvawIOp6so=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uzdnrn4S+2NlNW77+mcf81EQgcvq5pYpyUInN/tlxfFr8YfTuspiiYod65s7QE0HS\n\t6QY76c8AEXEsvTqodWA9UbVyGUTTrpcKha+Huzz1Q8kyXnH38EQ2OCDDJbwm707If9\n\ta8R6LTF3ZaQ47vuckfOFMdQ4jnDIiP8X4DPDPouU=","Date":"Tue, 26 Jan 2021 23:22:06 +0200","From":"Laurent Pinchart ","To":"Jean-Michel Hautbois ","Message-ID":"","References":"<20210126130415.26849-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210126130415.26849-2-jeanmichel.hautbois@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210126130415.26849-2-jeanmichel.hautbois@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] Revert \"libcamera: span:\n\tProvide and use helper variable templates for type traits\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14865,"web_url":"https://patchwork.libcamera.org/comment/14865/","msgid":"","date":"2021-01-31T14:41:45","subject":"Re: [libcamera-devel] [PATCH v2 1/2] Revert \"libcamera: span:\n\tProvide and use helper variable templates for type traits\"","submitter":{"id":75,"url":"https://patchwork.libcamera.org/api/people/75/","name":"Jean-Michel Hautbois","email":"jeanmichel.hautbois@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 26/01/2021 22:22, Laurent Pinchart wrote:\n> Hi Jean-Michel,\n> \n> Thank you for the patch.\n> \n> On Tue, Jan 26, 2021 at 02:04:14PM +0100, Jean-Michel Hautbois wrote:\n>> This reverts commit 8e42c2feb7ff7c350ffbbf97dd963dfd54e21faa.\n> \n> Missing Signed-off-by. Same for the next patch. Could you provide them\n> in an e-mail reply ?\n\nSure :-)\nSigned-off-by: Jean-Michel Hautbois \n\n>> ---\n>> include/libcamera/controls.h | 12 ++++++------\n>> include/libcamera/span.h | 22 ++++++++--------------\n>> 2 files changed, 14 insertions(+), 20 deletions(-)\n>>\n>> diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\n>> index 3634dc43..dc549a92 100644\n>> --- a/include/libcamera/controls.h\n>> +++ b/include/libcamera/controls.h\n>> @@ -96,7 +96,7 @@ public:\n>> \tControlValue();\n>> \n>> #ifndef __DOXYGEN__\n>> -\ttemplate &&\n>> +\ttemplate::value &&\n>> \t\t\t\t\t\t details::control_type::value &&\n>> \t\t\t\t\t\t !std::is_same_v>,\n>> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n>> @@ -107,7 +107,7 @@ public:\n>> \t\t &value, 1, sizeof(T));\n>> \t}\n>> \n>> -\ttemplate ||\n>> +\ttemplate::value ||\n>> \t\t\t\t\t\t std::is_same_v>,\n>> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n>> #else\n>> @@ -141,7 +141,7 @@ public:\n>> \t}\n>> \n>> #ifndef __DOXYGEN__\n>> -\ttemplate &&\n>> +\ttemplate::value &&\n>> \t\t\t\t\t\t !std::is_same_v>,\n>> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n>> \tT get() const\n>> @@ -152,7 +152,7 @@ public:\n>> \t\treturn *reinterpret_cast(data().data());\n>> \t}\n>> \n>> -\ttemplate ||\n>> +\ttemplate::value ||\n>> \t\t\t\t\t\t std::is_same_v>,\n>> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n>> #else\n>> @@ -169,7 +169,7 @@ public:\n>> \t}\n>> \n>> #ifndef __DOXYGEN__\n>> -\ttemplate &&\n>> +\ttemplate::value &&\n>> \t\t\t\t\t\t !std::is_same_v>,\n>> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n>> \tvoid set(const T &value)\n>> @@ -178,7 +178,7 @@ public:\n>> \t\t reinterpret_cast(&value), 1, sizeof(T));\n>> \t}\n>> \n>> -\ttemplate ||\n>> +\ttemplate::value ||\n>> \t\t\t\t\t\t std::is_same_v>,\n>> \t\t\t\t\t\t std::nullptr_t> = nullptr>\n>> #else\n>> diff --git a/include/libcamera/span.h b/include/libcamera/span.h\n>> index e7ffef12..d720adb8 100644\n>> --- a/include/libcamera/span.h\n>> +++ b/include/libcamera/span.h\n>> @@ -31,9 +31,6 @@ template\n>> struct is_array> : public std::true_type {\n>> };\n>> \n>> -template\n>> -inline constexpr bool is_array_v = is_array::value;\n>> -\n>> template\n>> struct is_span : public std::false_type {\n>> };\n>> @@ -42,9 +39,6 @@ template\n>> struct is_span> : public std::true_type {\n>> };\n>> \n>> -template\n>> -inline constexpr bool is_span_v = is_span::value;\n>> -\n>> } /* namespace details */\n>> \n>> namespace utils {\n>> @@ -161,8 +155,8 @@ public:\n>> \n>> \ttemplate\n>> \texplicit constexpr Span(Container &cont,\n>> -\t\t\t\tstd::enable_if_t &&\n>> -\t\t\t\t\t\t !details::is_array_v &&\n>> +\t\t\t\tstd::enable_if_t::value &&\n>> +\t\t\t\t\t\t !details::is_array::value &&\n>> \t\t\t\t\t\t !std::is_array_v &&\n>> \t\t\t\t\t\t std::is_convertible_v (*)[],\n>> \t\t\t\t\t\t\t\t element_type (*)[]>,\n>> @@ -173,8 +167,8 @@ public:\n>> \n>> \ttemplate\n>> \texplicit constexpr Span(const Container &cont,\n>> -\t\t\t\tstd::enable_if_t &&\n>> -\t\t\t\t\t\t !details::is_array_v &&\n>> +\t\t\t\tstd::enable_if_t::value &&\n>> +\t\t\t\t\t\t !details::is_array::value &&\n>> \t\t\t\t\t\t !std::is_array_v &&\n>> \t\t\t\t\t\t std::is_convertible_v (*)[],\n>> \t\t\t\t\t\t\t\t element_type (*)[]>,\n>> @@ -323,8 +317,8 @@ public:\n>> \n>> \ttemplate\n>> \tconstexpr Span(Container &cont,\n>> -\t\t std::enable_if_t &&\n>> -\t\t\t\t\t!details::is_array_v &&\n>> +\t\t std::enable_if_t::value &&\n>> +\t\t\t\t\t!details::is_array::value &&\n>> \t\t\t\t\t!std::is_array_v &&\n>> \t\t\t\t\tstd::is_convertible_v (*)[],\n>> \t\t\t\t\t\t\t element_type (*)[]>,\n>> @@ -335,8 +329,8 @@ public:\n>> \n>> \ttemplate\n>> \tconstexpr Span(const Container &cont,\n>> -\t\t std::enable_if_t &&\n>> -\t\t\t\t\t!details::is_array_v &&\n>> +\t\t std::enable_if_t::value &&\n>> +\t\t\t\t\t!details::is_array::value &&\n>> \t\t\t\t\t!std::is_array_v &&\n>> \t\t\t\t\tstd::is_convertible_v (*)[],\n>> \t\t\t\t\t\t\t element_type (*)[]>,\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3F100C33BB\n\tfor ;\n\tSun, 31 Jan 2021 14:41:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B4E51683D0;\n\tSun, 31 Jan 2021 15:41:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A751760309\n\tfor ;\n\tSun, 31 Jan 2021 15:41:46 +0100 (CET)","from [IPv6:2a01:e0a:169:7140:7f92:560f:391a:d89] (unknown\n\t[IPv6:2a01:e0a:169:7140:7f92:560f:391a:d89])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2F67C813;\n\tSun, 31 Jan 2021 15:41:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QLmwfniK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1612104106;\n\tbh=et6vjXumlW45Ol7SmTpseQKTdqno9pGI5gjD0IggKRE=;\n\th=Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=QLmwfniKXjb4cpbwmHFl83foFXRQUWbyQ3PhNEAaujI95DcCvG6245OuWUBS+inkM\n\tS5OuzvpYGKj5Gu4n+o/JkqhwlWUnitAcHlnau6uam4IvQjUeKM8v4ZQynw0lNtQLrj\n\t2icI4ElSyme681WUjZDWn8BTjwbuk/TLZlBNob/o=","To":"Laurent Pinchart ,\n\tJean-Michel Hautbois ","References":"<20210126130415.26849-1-jeanmichel.hautbois@ideasonboard.com>\n\t<20210126130415.26849-2-jeanmichel.hautbois@ideasonboard.com>\n\t","From":"Jean-Michel Hautbois ","Message-ID":"","Date":"Sun, 31 Jan 2021 15:41:45 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101\n\tThunderbird/78.6.1","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-US","Subject":"Re: [libcamera-devel] [PATCH v2 1/2] Revert \"libcamera: span:\n\tProvide and use helper variable templates for type traits\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]