{"id":10994,"url":"https://patchwork.libcamera.org/api/patches/10994/?format=json","web_url":"https://patchwork.libcamera.org/patch/10994/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210125184858.16339-6-david.plowman@raspberrypi.com>","date":"2021-01-25T18:48:58","name":"[libcamera-devel,v2,5/5] ipa: raspberrypi: Remove legacy Rasberry Pi logging","commit_ref":"a258aa4615e0dec756ec77cd940744c536e56f44","pull_url":null,"state":"accepted","archived":false,"hash":"e60fcd020d7ce699b891608f46b3ac1d35d51d52","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10994/mbox/","series":[{"id":1606,"url":"https://patchwork.libcamera.org/api/series/1606/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1606","date":"2021-01-25T18:48:53","name":"Remove Raspberry Pi logging","version":2,"mbox":"https://patchwork.libcamera.org/series/1606/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10994/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10994/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 249EBBD808\n\tfor ;\n\tMon, 25 Jan 2021 18:49:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DBD3E682E9;\n\tMon, 25 Jan 2021 19:49:11 +0100 (CET)","from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com\n\t[IPv6:2a00:1450:4864:20::62e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 90D93682DB\n\tfor ;\n\tMon, 25 Jan 2021 19:49:09 +0100 (CET)","by mail-ej1-x62e.google.com with SMTP id w1so19496185ejf.11\n\tfor ;\n\tMon, 25 Jan 2021 10:49:09 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\ty59sm11601836ede.59.2021.01.25.10.49.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 25 Jan 2021 10:49:07 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"rfyGemDy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=F7wNUmeRHs2H3iF0z3YYd6je6FUdDFpLYC0hRKeo0Qw=;\n\tb=rfyGemDy/s5ZR6URTGLr74XfRFH+AAd1sgUps7EQsSMAjQL/jaizWwxfJQbkkcWWkl\n\toVBeurqrYPAWNanBlmnm4nGdlVMvR3K1M2pLHy3mTEpmn8q8jAu0ZuUoa3r09Wqqzfbz\n\ttBJUBBJvopmGJTYnODCkcoT3djv38JVZY8d9PsQQzyrgTjNCG31yXl09WEPhfDzYBAu8\n\t3fu7BiiVA44rg2/PeAvVrs3iPoX6P4h20K981FY5QmxvB8XOs5uKyJd5N8DLTV6GESyQ\n\tVkIKWZbP2gfhXxsJJn5NrIM/4V3IDfEOwGL2E0bIzcLcDP7eXquGoNC7WitFTHaxZHcW\n\tedHg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=F7wNUmeRHs2H3iF0z3YYd6je6FUdDFpLYC0hRKeo0Qw=;\n\tb=kIs6wJp5he/uE0fxBQpInZYOzAclIkwGiTakJ27hhkneXWdqckYzvieil6al7eEaLy\n\tsMYkyQreRRLnIobsKvmxlhaH6XtkwPeeN8T5YJDOT+cQelW4udCMxOcVYrt1TkQ3EsdW\n\tHIrYxlmrPxCDwaXmbutlAy82K07VN04vCqYZmtNFwMVI9LlzP326iC7kthPnR8Cq7d5b\n\t7as4qipCO/SWp5HF7WyLFZ/QUsuXfN7FLHCf4JfOyeECsG4FgMAoxAixS0h2AAfxfxNY\n\tUinE6Q3wRFwKxGcJQ652+z7aSuRkFNDjcrk3b2C7ImaVVeVQcuVdub8vUR7NLZHWg1d0\n\tg17A==","X-Gm-Message-State":"AOAM531/4Bleu4b7eDegGolIfBw1EdFVcOfYA5KxlJG2Xr6v+zzamSvb\n\tzPxSL07p6Dlj546xz3hfWuumpNIExfmZqdzH","X-Google-Smtp-Source":"ABdhPJyjqPgfPjzunQjzQ0+po6BhXi4O0iQU4tYtHoa2QcODmwrZNt22RBWwg+4UWB1sfD7mByk7yA==","X-Received":"by 2002:a17:907:9879:: with SMTP id\n\tko25mr1243130ejc.524.1611600548654; \n\tMon, 25 Jan 2021 10:49:08 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 25 Jan 2021 18:48:58 +0000","Message-Id":"<20210125184858.16339-6-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20210125184858.16339-1-david.plowman@raspberrypi.com>","References":"<20210125184858.16339-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 5/5] ipa: raspberrypi: Remove legacy\n\tRasberry Pi logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Signed-off-by: David Plowman \nReviewed-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \n---\n src/ipa/raspberrypi/controller/algorithm.hpp | 1 -\n src/ipa/raspberrypi/controller/logging.hpp | 30 --------------------\n 2 files changed, 31 deletions(-)\n delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp","diff":"diff --git a/src/ipa/raspberrypi/controller/algorithm.hpp b/src/ipa/raspberrypi/controller/algorithm.hpp\nindex 17423f23..e9b040c7 100644\n--- a/src/ipa/raspberrypi/controller/algorithm.hpp\n+++ b/src/ipa/raspberrypi/controller/algorithm.hpp\n@@ -14,7 +14,6 @@\n #include \n #include \n \n-#include \"logging.hpp\"\n #include \"controller.hpp\"\n \n #include \ndiff --git a/src/ipa/raspberrypi/controller/logging.hpp b/src/ipa/raspberrypi/controller/logging.hpp\ndeleted file mode 100644\nindex f0d306b6..00000000\n--- a/src/ipa/raspberrypi/controller/logging.hpp\n+++ /dev/null\n@@ -1,30 +0,0 @@\n-/* SPDX-License-Identifier: BSD-2-Clause */\n-/*\n- * Copyright (C) 2019-2020, Raspberry Pi (Trading) Limited\n- *\n- * logging.hpp - logging macros\n- */\n-#pragma once\n-\n-#include \n-\n-#ifndef RPI_LOGGING_ENABLE\n-#define RPI_LOGGING_ENABLE 0\n-#endif\n-\n-#ifndef RPI_WARNING_ENABLE\n-#define RPI_WARNING_ENABLE 1\n-#endif\n-\n-#define RPI_LOG(stuff) \\\n-\tdo { \\\n-\t\tif (RPI_LOGGING_ENABLE) \\\n-\t\t\tstd::cout << __FUNCTION__ << \": \" << stuff << \"\\n\"; \\\n-\t} while (0)\n-\n-#define RPI_WARN(stuff) \\\n-\tdo { \\\n-\t\tif (RPI_WARNING_ENABLE) \\\n-\t\t\tstd::cout << __FUNCTION__ << \" ***WARNING*** \" \\\n-\t\t\t\t << stuff << \"\\n\"; \\\n-\t} while (0)\n","prefixes":["libcamera-devel","v2","5/5"]}