{"id":10972,"url":"https://patchwork.libcamera.org/api/patches/10972/?format=json","web_url":"https://patchwork.libcamera.org/patch/10972/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210123051704.188117-8-paul.elder@ideasonboard.com>","date":"2021-01-23T05:17:03","name":"[libcamera-devel,v3,7/8] android: camera_device: Cache request metadata","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a785c3e74d0947574fba5aec99c5c05bd1183503","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10972/mbox/","series":[{"id":1601,"url":"https://patchwork.libcamera.org/api/series/1601/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1601","date":"2021-01-23T05:16:56","name":"Fill in android result metadata and EXIF tabs","version":3,"mbox":"https://patchwork.libcamera.org/series/1601/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10972/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10972/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5149C0F2B\n\tfor ;\n\tSat, 23 Jan 2021 05:17:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7188B68293;\n\tSat, 23 Jan 2021 06:17:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 61F9B68274\n\tfor ;\n\tSat, 23 Jan 2021 06:17:29 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E4E53813;\n\tSat, 23 Jan 2021 06:17:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lUPJd02V\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611379049;\n\tbh=bjAMJMHw0pf2CPqW4NrUeO2uoPeGXlYDjheFYUHFoTs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=lUPJd02VTVYyLbov9FwsgW1+BVehQRzAIkzg/h02MXd0hfuQfjfVy53gMbDSV8rwC\n\tdxSq0E+jz30EGxbdiym0rRlxYFOgHSn396v/ndzfHd941hAM0Xk9fWi2KlrV+GfeU1\n\tKAN1Tuds8lcfxbfyO9F2ahREZu4IZYazcTUhJZwg=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Sat, 23 Jan 2021 14:17:03 +0900","Message-Id":"<20210123051704.188117-8-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210123051704.188117-1-paul.elder@ideasonboard.com>","References":"<20210123051704.188117-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 7/8] android: camera_device: Cache\n\trequest metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The settings in an android capture request may be null, in which case\nthe settings from the most recently submitted capture request should be\nused. Cache the request settings to achieve this.\n\nSigned-off-by: Paul Elder \n\n---\nChanges in v3:\n- rebase on \"android: camera device and metatada improvements\", so it's\n a bit cleaner\n\nNew in v2\n---\n src/android/camera_device.cpp | 9 ++++++---\n src/android/camera_device.h | 2 ++\n 2 files changed, 8 insertions(+), 3 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex d0922db7..a2484fdd 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -343,7 +343,8 @@ CameraDevice::Camera3RequestDescriptor::~Camera3RequestDescriptor()\n \n CameraDevice::CameraDevice(unsigned int id, const std::shared_ptr &camera)\n \t: id_(id), running_(false), camera_(camera), staticMetadata_(nullptr),\n-\t facing_(CAMERA_FACING_FRONT), orientation_(0)\n+\t facing_(CAMERA_FACING_FRONT), orientation_(0),\n+\t lastSettings_(CameraMetadata(0, 0))\n {\n \tcamera_->requestCompleted.connect(this, &CameraDevice::requestComplete);\n \n@@ -1688,10 +1689,12 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \t * The descriptor and the associated memory reserved here are freed\n \t * at request complete time.\n \t */\n-\t/* \\todo Handle null request settings */\n-\tCameraMetadata settings(camera3Request->settings);\n \tCamera3RequestDescriptor *descriptor =\n \t\tnew Camera3RequestDescriptor(camera_.get(), camera3Request);\n+\tif (camera3Request->settings)\n+\t\tlastSettings_ = camera3Request->settings;\n+\telse\n+\t\tdescriptor->settings_ = lastSettings_;\n \n \tLOG(HAL, Debug) << \"Queueing Request to libcamera with \"\n \t\t\t<< descriptor->numBuffers_ << \" HAL streams\";\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 058a3f9a..fa4fb544 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -134,6 +134,8 @@ private:\n \tint orientation_;\n \n \tunsigned int maxJpegBufferSize_;\n+\n+\tCameraMetadata lastSettings_;\n };\n \n #endif /* __ANDROID_CAMERA_DEVICE_H__ */\n","prefixes":["libcamera-devel","v3","7/8"]}