[{"id":14716,"web_url":"https://patchwork.libcamera.org/comment/14716/","msgid":"","date":"2021-01-22T15:07:09","subject":"Re: [libcamera-devel] [PATCH] libcamera: Rename wrong header guards\n\tfor internal includes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 22/01/2021 14:58, Laurent Pinchart wrote:\n> Some internals includes that used to be public still have the public\n> header guard. Rename it.\n> \n> Signed-off-by: Laurent Pinchart \n\nSimple enough.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/event_dispatcher.h | 6 +++---\n> include/libcamera/internal/event_notifier.h | 6 +++---\n> include/libcamera/internal/timer.h | 6 +++---\n> 3 files changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/include/libcamera/internal/event_dispatcher.h b/include/libcamera/internal/event_dispatcher.h\n> index cb06bf208e12..e6a8ad65ce0a 100644\n> --- a/include/libcamera/internal/event_dispatcher.h\n> +++ b/include/libcamera/internal/event_dispatcher.h\n> @@ -4,8 +4,8 @@\n> *\n> * event_dispatcher.h - Event dispatcher\n> */\n> -#ifndef __LIBCAMERA_EVENT_DISPATCHER_H__\n> -#define __LIBCAMERA_EVENT_DISPATCHER_H__\n> +#ifndef __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__\n> +#define __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__\n> \n> #include \n> \n> @@ -32,4 +32,4 @@ public:\n> \n> } /* namespace libcamera */\n> \n> -#endif /* __LIBCAMERA_EVENT_DISPATCHER_H__ */\n> +#endif /* __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__ */\n> diff --git a/include/libcamera/internal/event_notifier.h b/include/libcamera/internal/event_notifier.h\n> index a37b02eee4b7..cc3495c024f0 100644\n> --- a/include/libcamera/internal/event_notifier.h\n> +++ b/include/libcamera/internal/event_notifier.h\n> @@ -4,8 +4,8 @@\n> *\n> * event_notifier.h - File descriptor event notifier\n> */\n> -#ifndef __LIBCAMERA_EVENT_NOTIFIER_H__\n> -#define __LIBCAMERA_EVENT_NOTIFIER_H__\n> +#ifndef __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__\n> +#define __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__\n> \n> #include \n> #include \n> @@ -45,4 +45,4 @@ private:\n> \n> } /* namespace libcamera */\n> \n> -#endif /* __LIBCAMERA_EVENT_NOTIFIER_H__ */\n> +#endif /* __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__ */\n> diff --git a/include/libcamera/internal/timer.h b/include/libcamera/internal/timer.h\n> index f55fe3c09660..013e93c0b4e6 100644\n> --- a/include/libcamera/internal/timer.h\n> +++ b/include/libcamera/internal/timer.h\n> @@ -4,8 +4,8 @@\n> *\n> * timer.h - Generic timer\n> */\n> -#ifndef __LIBCAMERA_TIMER_H__\n> -#define __LIBCAMERA_TIMER_H__\n> +#ifndef __LIBCAMERA_INTERNAL_TIMER_H__\n> +#define __LIBCAMERA_INTERNAL_TIMER_H__\n> \n> #include \n> #include \n> @@ -46,4 +46,4 @@ private:\n> \n> } /* namespace libcamera */\n> \n> -#endif /* __LIBCAMERA_TIMER_H__ */\n> +#endif /* __LIBCAMERA_INTERNAL_TIMER_H__ */\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3FF85C0F2A\n\tfor ;\n\tFri, 22 Jan 2021 15:07:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB4946828D;\n\tFri, 22 Jan 2021 16:07:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8213F68274\n\tfor ;\n\tFri, 22 Jan 2021 16:07:14 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B4BA34FD;\n\tFri, 22 Jan 2021 16:07:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"njPP6E7z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611328034;\n\tbh=VpHnpnyFYsH/ri5HHIuKn4zFFQj/MlLFLeD2xHWDRuM=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=njPP6E7zoChN63z5Bkk1VIncKj6ziJw0hPFbcEltLkRERYs1/GGs1c/MZqvC8tNjU\n\taWsIxOggWPtW3HHE9uBhZNSEaOXZkh4dAOa39mE7QVXJ2OZ+VP9u1nufdM5TX7eLvm\n\tRl5+mTtWHvfDTR+CBnIhr4fCTcOSQUIl6JGlOSZ8=","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210122145852.5568-1-laurent.pinchart@ideasonboard.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 22 Jan 2021 15:07:09 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210122145852.5568-1-laurent.pinchart@ideasonboard.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Rename wrong header guards\n\tfor internal includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14719,"web_url":"https://patchwork.libcamera.org/comment/14719/","msgid":"","date":"2021-01-22T21:58:01","subject":"Re: [libcamera-devel] [PATCH] libcamera: Rename wrong header guards\n\tfor internal includes","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2021-01-22 16:58:52 +0200, Laurent Pinchart wrote:\n> Some internals includes that used to be public still have the public\n> header guard. Rename it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> include/libcamera/internal/event_dispatcher.h | 6 +++---\n> include/libcamera/internal/event_notifier.h | 6 +++---\n> include/libcamera/internal/timer.h | 6 +++---\n> 3 files changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/include/libcamera/internal/event_dispatcher.h b/include/libcamera/internal/event_dispatcher.h\n> index cb06bf208e12..e6a8ad65ce0a 100644\n> --- a/include/libcamera/internal/event_dispatcher.h\n> +++ b/include/libcamera/internal/event_dispatcher.h\n> @@ -4,8 +4,8 @@\n> *\n> * event_dispatcher.h - Event dispatcher\n> */\n> -#ifndef __LIBCAMERA_EVENT_DISPATCHER_H__\n> -#define __LIBCAMERA_EVENT_DISPATCHER_H__\n> +#ifndef __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__\n> +#define __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__\n> \n> #include \n> \n> @@ -32,4 +32,4 @@ public:\n> \n> } /* namespace libcamera */\n> \n> -#endif /* __LIBCAMERA_EVENT_DISPATCHER_H__ */\n> +#endif /* __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__ */\n> diff --git a/include/libcamera/internal/event_notifier.h b/include/libcamera/internal/event_notifier.h\n> index a37b02eee4b7..cc3495c024f0 100644\n> --- a/include/libcamera/internal/event_notifier.h\n> +++ b/include/libcamera/internal/event_notifier.h\n> @@ -4,8 +4,8 @@\n> *\n> * event_notifier.h - File descriptor event notifier\n> */\n> -#ifndef __LIBCAMERA_EVENT_NOTIFIER_H__\n> -#define __LIBCAMERA_EVENT_NOTIFIER_H__\n> +#ifndef __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__\n> +#define __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__\n> \n> #include \n> #include \n> @@ -45,4 +45,4 @@ private:\n> \n> } /* namespace libcamera */\n> \n> -#endif /* __LIBCAMERA_EVENT_NOTIFIER_H__ */\n> +#endif /* __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__ */\n> diff --git a/include/libcamera/internal/timer.h b/include/libcamera/internal/timer.h\n> index f55fe3c09660..013e93c0b4e6 100644\n> --- a/include/libcamera/internal/timer.h\n> +++ b/include/libcamera/internal/timer.h\n> @@ -4,8 +4,8 @@\n> *\n> * timer.h - Generic timer\n> */\n> -#ifndef __LIBCAMERA_TIMER_H__\n> -#define __LIBCAMERA_TIMER_H__\n> +#ifndef __LIBCAMERA_INTERNAL_TIMER_H__\n> +#define __LIBCAMERA_INTERNAL_TIMER_H__\n> \n> #include \n> #include \n> @@ -46,4 +46,4 @@ private:\n> \n> } /* namespace libcamera */\n> \n> -#endif /* __LIBCAMERA_TIMER_H__ */\n> +#endif /* __LIBCAMERA_INTERNAL_TIMER_H__ */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 93E33C0F2B\n\tfor ;\n\tFri, 22 Jan 2021 21:58:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2E566826A;\n\tFri, 22 Jan 2021 22:58:04 +0100 (CET)","from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com\n\t[IPv6:2a00:1450:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AEA7F6824E\n\tfor ;\n\tFri, 22 Jan 2021 22:58:03 +0100 (CET)","by mail-lj1-x22b.google.com with SMTP id f2so3023184ljp.11\n\tfor ;\n\tFri, 22 Jan 2021 13:58:03 -0800 (PST)","from localhost (h-209-203.A463.priv.bahnhof.se. [155.4.209.203])\n\tby smtp.gmail.com with ESMTPSA id\n\ty5sm1040502lfl.100.2021.01.22.13.58.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 22 Jan 2021 13:58:02 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ragnatech-se.20150623.gappssmtp.com\n\theader.i=@ragnatech-se.20150623.gappssmtp.com\n\theader.b=\"D2kAd1pa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=dGx7EJbqDkWAiJ9sZ2zUCl5n9phBVAAoVp1/k3ZHwYA=;\n\tb=D2kAd1patQ8dlaftjY/9iJJNzPlgz2n83vti0ch5o6hv/JImVJUfeLdg+mpaAUkIxL\n\tPQjHcgLq7CHnl9boCsW20IXUCLuPDsvwtC1Lnk/OhJf6Kn0tyeTjrsvM59LL1Hj2I0wV\n\t8b8VwKJGfVK0jMdyzkk1YN3uGVXJr0Rh/+3j/pLLawYGANeAHUmOOx3BPqSpnEL1ZQcW\n\tzwRJKt8S4qfu69SZhKsfjOEGhK5C2Kyyvo4YbdKq1t9aZ4jnySN3meMGKA+DpCIKnozi\n\tm8A5XnFy9BOX7g2K5ubAM0y6OGhHqw2LV/Qc+zAKOWR3Aq9e2OqJFw9kMsnpqnm8vwMq\n\tNuVA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=dGx7EJbqDkWAiJ9sZ2zUCl5n9phBVAAoVp1/k3ZHwYA=;\n\tb=e5OC0eDVkVDyrqoby+F7giHC648sfEdtikWvAGk04sngJOapfQO7XNZMzY+3AL4zZw\n\tZq3HJrZ/dvK+pxh0DJ1LUojeN73npktk/lewvTb6251DbhF5d/asrmc4UANwPTNed0mi\n\tmXKziJznZLgGFWMxznI8oDphWBoEAVYu3uqIdCApYag5EB/EdUCNxDxYXJIS09SEgYdB\n\t2Z3t6cqiW6sqNlOmvuVH5/Hj4RU0qoaQhYK47slpMmurATp4LAmgS+gb9y8JoZrl6gvO\n\taudIX0tsXbcPZyaDXqfh3hDSf+J6jbWBzh0KUUZ6P53M7BkowEOeybj64dtQdFFPDQPy\n\tfGCw==","X-Gm-Message-State":"AOAM531TpXQVVTIOfPOm3uUkv7hR5LrQkkmfVWfYAUXhFFQWhalhQVLK\n\tTH2QrsxqPCzPT2rMrTzY6/0IP/OB7msFhQ==","X-Google-Smtp-Source":"ABdhPJwfal4xTlHXeuv5mz/U0Zc9hALyp9lv49R14U0EqMGLzlI6gw4MOaMQAbw5qG6xSUCz+qIEoQ==","X-Received":"by 2002:a2e:2405:: with SMTP id k5mr196944ljk.185.1611352682891; \n\tFri, 22 Jan 2021 13:58:02 -0800 (PST)","Date":"Fri, 22 Jan 2021 22:58:01 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Message-ID":"","References":"<20210122145852.5568-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210122145852.5568-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Rename wrong header guards\n\tfor internal includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"iso-8859-1\"","Content-Transfer-Encoding":"quoted-printable","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14720,"web_url":"https://patchwork.libcamera.org/comment/14720/","msgid":"<20210123031245.GA142070@pyrite.rasen.tech>","date":"2021-01-23T03:12:45","subject":"Re: [libcamera-devel] [PATCH] libcamera: Rename wrong header guards\n\tfor internal includes","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nOn Fri, Jan 22, 2021 at 04:58:52PM +0200, Laurent Pinchart wrote:\n> Some internals includes that used to be public still have the public\n> header guard. Rename it.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Paul Elder \n\n> ---\n> include/libcamera/internal/event_dispatcher.h | 6 +++---\n> include/libcamera/internal/event_notifier.h | 6 +++---\n> include/libcamera/internal/timer.h | 6 +++---\n> 3 files changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/include/libcamera/internal/event_dispatcher.h b/include/libcamera/internal/event_dispatcher.h\n> index cb06bf208e12..e6a8ad65ce0a 100644\n> --- a/include/libcamera/internal/event_dispatcher.h\n> +++ b/include/libcamera/internal/event_dispatcher.h\n> @@ -4,8 +4,8 @@\n> *\n> * event_dispatcher.h - Event dispatcher\n> */\n> -#ifndef __LIBCAMERA_EVENT_DISPATCHER_H__\n> -#define __LIBCAMERA_EVENT_DISPATCHER_H__\n> +#ifndef __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__\n> +#define __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__\n> \n> #include \n> \n> @@ -32,4 +32,4 @@ public:\n> \n> } /* namespace libcamera */\n> \n> -#endif /* __LIBCAMERA_EVENT_DISPATCHER_H__ */\n> +#endif /* __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__ */\n> diff --git a/include/libcamera/internal/event_notifier.h b/include/libcamera/internal/event_notifier.h\n> index a37b02eee4b7..cc3495c024f0 100644\n> --- a/include/libcamera/internal/event_notifier.h\n> +++ b/include/libcamera/internal/event_notifier.h\n> @@ -4,8 +4,8 @@\n> *\n> * event_notifier.h - File descriptor event notifier\n> */\n> -#ifndef __LIBCAMERA_EVENT_NOTIFIER_H__\n> -#define __LIBCAMERA_EVENT_NOTIFIER_H__\n> +#ifndef __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__\n> +#define __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__\n> \n> #include \n> #include \n> @@ -45,4 +45,4 @@ private:\n> \n> } /* namespace libcamera */\n> \n> -#endif /* __LIBCAMERA_EVENT_NOTIFIER_H__ */\n> +#endif /* __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__ */\n> diff --git a/include/libcamera/internal/timer.h b/include/libcamera/internal/timer.h\n> index f55fe3c09660..013e93c0b4e6 100644\n> --- a/include/libcamera/internal/timer.h\n> +++ b/include/libcamera/internal/timer.h\n> @@ -4,8 +4,8 @@\n> *\n> * timer.h - Generic timer\n> */\n> -#ifndef __LIBCAMERA_TIMER_H__\n> -#define __LIBCAMERA_TIMER_H__\n> +#ifndef __LIBCAMERA_INTERNAL_TIMER_H__\n> +#define __LIBCAMERA_INTERNAL_TIMER_H__\n> \n> #include \n> #include \n> @@ -46,4 +46,4 @@ private:\n> \n> } /* namespace libcamera */\n> \n> -#endif /* __LIBCAMERA_TIMER_H__ */\n> +#endif /* __LIBCAMERA_INTERNAL_TIMER_H__ */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 888AEBD808\n\tfor ;\n\tSat, 23 Jan 2021 03:12:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED83E68273;\n\tSat, 23 Jan 2021 04:12:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 21D836030D\n\tfor ;\n\tSat, 23 Jan 2021 04:12:52 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8ADD6813;\n\tSat, 23 Jan 2021 04:12:50 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FlUKoZCl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611371571;\n\tbh=3n7cMDfDQguWRVthZXjYV+Hy6lSSc1z2CxB2mVHpRB8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FlUKoZClL3ZlKln8HUqC+38ectyHo0tk7dKqWAevhhluLehxqd92h8T0d/QRI4UxD\n\tY/AEWVDzMKnOY9I8A6JCNM1u5InM3K6IDxhmNPsk2EFs18VjDC+GIsVC0qccBAh8uD\n\tWhvcvwDPaUl9RjroffrehKnGUREuuIz/TT0f+Tio=","Date":"Sat, 23 Jan 2021 12:12:45 +0900","From":"paul.elder@ideasonboard.com","To":"Laurent Pinchart ","Message-ID":"<20210123031245.GA142070@pyrite.rasen.tech>","References":"<20210122145852.5568-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210122145852.5568-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: Rename wrong header guards\n\tfor internal includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]