{"id":10964,"url":"https://patchwork.libcamera.org/api/patches/10964/?format=json","web_url":"https://patchwork.libcamera.org/patch/10964/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210122145852.5568-1-laurent.pinchart@ideasonboard.com>","date":"2021-01-22T14:58:52","name":"[libcamera-devel] libcamera: Rename wrong header guards for internal includes","commit_ref":"992442df9a747ef72871e7a66453b67bb0e305ed","pull_url":null,"state":"accepted","archived":false,"hash":"6108277f730ca98fcbcef1bcbb657bf29c729c17","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10964/mbox/","series":[{"id":1600,"url":"https://patchwork.libcamera.org/api/series/1600/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1600","date":"2021-01-22T14:58:52","name":"[libcamera-devel] libcamera: Rename wrong header guards for internal includes","version":1,"mbox":"https://patchwork.libcamera.org/series/1600/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10964/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10964/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 616B8BD808\n\tfor ;\n\tFri, 22 Jan 2021 14:59:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E095268287;\n\tFri, 22 Jan 2021 15:59:17 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 64FE968287\n\tfor ;\n\tFri, 22 Jan 2021 15:59:16 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D53504FD\n\tfor ;\n\tFri, 22 Jan 2021 15:59:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mAi6YROz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611327556;\n\tbh=+fciy+HsXxBvzSOPra0HIGWDB9KWRwvqaLGPjLkGU8Y=;\n\th=From:To:Subject:Date:From;\n\tb=mAi6YROznBdE34h2Fdcuz3B+DIcozUlT0XtjbLTnjA0n2+01jLe11soviqfhJ4x2j\n\tkY4dOndZuoOshTLBJQsRaTKgJdqGjgow5mqZ6cgJqEyaWHrL4/lNkR5Qf3vhMB8JbS\n\tLH0QxClYcnArECX7W3WK4LWMV1t/ngs43NNUnIcw=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 22 Jan 2021 16:58:52 +0200","Message-Id":"<20210122145852.5568-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.28.0","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] libcamera: Rename wrong header guards for\n\tinternal includes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Some internals includes that used to be public still have the public\nheader guard. Rename it.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/internal/event_dispatcher.h | 6 +++---\n include/libcamera/internal/event_notifier.h | 6 +++---\n include/libcamera/internal/timer.h | 6 +++---\n 3 files changed, 9 insertions(+), 9 deletions(-)","diff":"diff --git a/include/libcamera/internal/event_dispatcher.h b/include/libcamera/internal/event_dispatcher.h\nindex cb06bf208e12..e6a8ad65ce0a 100644\n--- a/include/libcamera/internal/event_dispatcher.h\n+++ b/include/libcamera/internal/event_dispatcher.h\n@@ -4,8 +4,8 @@\n *\n * event_dispatcher.h - Event dispatcher\n */\n-#ifndef __LIBCAMERA_EVENT_DISPATCHER_H__\n-#define __LIBCAMERA_EVENT_DISPATCHER_H__\n+#ifndef __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__\n+#define __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__\n \n #include \n \n@@ -32,4 +32,4 @@ public:\n \n } /* namespace libcamera */\n \n-#endif /* __LIBCAMERA_EVENT_DISPATCHER_H__ */\n+#endif /* __LIBCAMERA_INTERNAL_EVENT_DISPATCHER_H__ */\ndiff --git a/include/libcamera/internal/event_notifier.h b/include/libcamera/internal/event_notifier.h\nindex a37b02eee4b7..cc3495c024f0 100644\n--- a/include/libcamera/internal/event_notifier.h\n+++ b/include/libcamera/internal/event_notifier.h\n@@ -4,8 +4,8 @@\n *\n * event_notifier.h - File descriptor event notifier\n */\n-#ifndef __LIBCAMERA_EVENT_NOTIFIER_H__\n-#define __LIBCAMERA_EVENT_NOTIFIER_H__\n+#ifndef __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__\n+#define __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__\n \n #include \n #include \n@@ -45,4 +45,4 @@ private:\n \n } /* namespace libcamera */\n \n-#endif /* __LIBCAMERA_EVENT_NOTIFIER_H__ */\n+#endif /* __LIBCAMERA_INTERNAL_EVENT_NOTIFIER_H__ */\ndiff --git a/include/libcamera/internal/timer.h b/include/libcamera/internal/timer.h\nindex f55fe3c09660..013e93c0b4e6 100644\n--- a/include/libcamera/internal/timer.h\n+++ b/include/libcamera/internal/timer.h\n@@ -4,8 +4,8 @@\n *\n * timer.h - Generic timer\n */\n-#ifndef __LIBCAMERA_TIMER_H__\n-#define __LIBCAMERA_TIMER_H__\n+#ifndef __LIBCAMERA_INTERNAL_TIMER_H__\n+#define __LIBCAMERA_INTERNAL_TIMER_H__\n \n #include \n #include \n@@ -46,4 +46,4 @@ private:\n \n } /* namespace libcamera */\n \n-#endif /* __LIBCAMERA_TIMER_H__ */\n+#endif /* __LIBCAMERA_INTERNAL_TIMER_H__ */\n","prefixes":["libcamera-devel"]}