[{"id":14713,"web_url":"https://patchwork.libcamera.org/comment/14713/","msgid":"<402d17ea-80d6-d86a-1d43-64ca1d366f95@ideasonboard.com>","date":"2021-01-22T13:25:11","subject":"Re: [libcamera-devel] [PATCH v3 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 22/01/2021 13:14, Naushir Patuck wrote:\n> The application provided noise reduction mode gets passed into the\n> denoise controller. The denoise controller in turn returns the mode to\n> the IPA which now sets up the colour denoise processing appropriately.\n> \n> Signed-off-by: Naushir Patuck \n\nThis was on v2, and I htnik it still stands\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 47 ++++++++++++++++++++++++++++-\n> 1 file changed, 46 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 220cf174aa4f..8f80bb80c129 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -43,6 +43,7 @@\n> #include \"contrast_algorithm.hpp\"\n> #include \"contrast_status.h\"\n> #include \"controller.hpp\"\n> +#include \"denoise_algorithm.hpp\"\n> #include \"denoise_status.h\"\n> #include \"dpc_status.h\"\n> #include \"focus_status.h\"\n> @@ -565,6 +566,7 @@ bool IPARPi::validateIspControls()\n> \t\tV4L2_CID_USER_BCM2835_ISP_SHARPEN,\n> \t\tV4L2_CID_USER_BCM2835_ISP_DPC,\n> \t\tV4L2_CID_USER_BCM2835_ISP_LENS_SHADING,\n> +\t\tV4L2_CID_USER_BCM2835_ISP_CDN,\n> \t};\n> \n> \tfor (auto c : ctrls) {\n> @@ -614,6 +616,14 @@ static const std::map AwbModeTable = {\n> \t{ controls::AwbCustom, \"custom\" },\n> };\n> \n> +static const std::map DenoiseModeTable = {\n> +\t{ controls::draft::NoiseReductionModeOff, RPiController::DenoiseMode::Off },\n> +\t{ controls::draft::NoiseReductionModeFast, RPiController::DenoiseMode::ColourFast },\n> +\t{ controls::draft::NoiseReductionModeHighQuality, RPiController::DenoiseMode::ColourHighQuality },\n> +\t{ controls::draft::NoiseReductionModeMinimal, RPiController::DenoiseMode::ColourOff },\n> +\t{ controls::draft::NoiseReductionModeZSL, RPiController::DenoiseMode::ColourHighQuality },\n> +};\n> +\n> void IPARPi::queueRequest(const ControlList &controls)\n> {\n> \t/* Clear the return metadata buffer. */\n> @@ -836,6 +846,22 @@ void IPARPi::queueRequest(const ControlList &controls)\n> \t\t\tbreak;\n> \t\t}\n> \n> +\t\tcase controls::NOISE_REDUCTION_MODE: {\n> +\t\t\tRPiController::DenoiseAlgorithm *sdn = dynamic_cast(\n> +\t\t\t\tcontroller_.GetAlgorithm(\"SDN\"));\n> +\t\t\tASSERT(sdn);\n> +\n> +\t\t\tint32_t idx = ctrl.second.get();\n> +\t\t\tif (DenoiseModeTable.count(idx)) {\n> +\t\t\t\tsdn->SetMode(DenoiseModeTable.at(idx));\n> +\t\t\t\tlibcameraMetadata_.set(controls::draft::NoiseReductionMode, idx);\n> +\t\t\t} else {\n> +\t\t\t\tLOG(IPARPI, Error) << \"Noise reduction mode \" << idx\n> +\t\t\t\t\t\t << \" not recognised\";\n> +\t\t\t}\n> +\t\t\tbreak;\n> +\t\t}\n> +\n> \t\tdefault:\n> \t\t\tLOG(IPARPI, Warning)\n> \t\t\t\t<< \"Ctrl \" << controls::controls.at(ctrl.first)->name()\n> @@ -1087,16 +1113,35 @@ void IPARPi::applyDenoise(const struct DenoiseStatus *denoiseStatus, ControlList\n> {\n> \tbcm2835_isp_denoise denoise;\n> \n> -\tdenoise.enabled = 1;\n> +\tdenoise.enabled = denoiseStatus->mode == RPiController::DenoiseMode::Off ? 0 : 1;\n> \tdenoise.constant = denoiseStatus->noise_constant;\n> \tdenoise.slope.num = 1000 * denoiseStatus->noise_slope;\n> \tdenoise.slope.den = 1000;\n> \tdenoise.strength.num = 1000 * denoiseStatus->strength;\n> \tdenoise.strength.den = 1000;\n> \n> +\t/* Set the CDN mode to match the SDN operating mode. */\n> +\tbcm2835_isp_cdn cdn;\n> +\tswitch (denoiseStatus->mode) {\n> +\tcase RPiController::DenoiseMode::ColourFast:\n> +\t\tcdn.enabled = 1;\n> +\t\tcdn.mode = CDN_MODE_FAST;\n> +\t\tbreak;\n> +\tcase RPiController::DenoiseMode::ColourHighQuality:\n> +\t\tcdn.enabled = 1;\n> +\t\tcdn.mode = CDN_MODE_HIGH_QUALITY;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tcdn.enabled = 0;\n> +\t}\n> +\n> \tControlValue c(Span{ reinterpret_cast(&denoise),\n> \t\t\t\t\t sizeof(denoise) });\n> \tctrls.set(V4L2_CID_USER_BCM2835_ISP_DENOISE, c);\n> +\n> +\tc = ControlValue(Span{ reinterpret_cast(&cdn),\n> +\t\t\t\t\t sizeof(cdn) });\n> +\tctrls.set(V4L2_CID_USER_BCM2835_ISP_CDN, c);\n> }\n> \n> void IPARPi::applySharpen(const struct SharpenStatus *sharpenStatus, ControlList &ctrls)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B9C4AC0F2A\n\tfor ;\n\tFri, 22 Jan 2021 13:25:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 84C1C6827A;\n\tFri, 22 Jan 2021 14:25:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1EE2468274\n\tfor ;\n\tFri, 22 Jan 2021 14:25:14 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B20444FB;\n\tFri, 22 Jan 2021 14:25:13 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M98mydiL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611321913;\n\tbh=wrtJKCg2kNhhCh6ZoXdaKqPGaaPjM9uR1oUDMFFb8QI=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=M98mydiLpGQaWzwmZsWAFvgyuNjc5rr1kPYg6GiAWNHnJflN2PeOwyTT3rh3zPMWM\n\tKzB79XNqL50EE2AJSwhhyihDq/u9mz1ZNAIa9SeRzg7VvASjls764w6TK+2z7Z9xO3\n\t5JPPcuczclNLYVlkj1va8OSM84iCBjUUfggpjcwY=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210122131451.726584-1-naush@raspberrypi.com>\n\t<20210122131451.726584-6-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<402d17ea-80d6-d86a-1d43-64ca1d366f95@ideasonboard.com>","Date":"Fri, 22 Jan 2021 13:25:11 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210122131451.726584-6-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v3 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14714,"web_url":"https://patchwork.libcamera.org/comment/14714/","msgid":"","date":"2021-01-22T13:28:57","subject":"Re: [libcamera-devel] [PATCH v3 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Fri, 22 Jan 2021 at 13:25, Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> On 22/01/2021 13:14, Naushir Patuck wrote:\n> > The application provided noise reduction mode gets passed into the\n> > denoise controller. The denoise controller in turn returns the mode to\n> > the IPA which now sets up the colour denoise processing appropriately.\n> >\n> > Signed-off-by: Naushir Patuck \n>\n> This was on v2, and I htnik it still stands\n>\n> Reviewed-by: Kieran Bingham \n>\n\nOops, my bad. I thought I added your tag. David also had a tag on this\ncommit:\n\n> Reviewed-by: David Plowman \n\nI blame my fingers and git!\n\n\n\n>\n> > ---\n> > src/ipa/raspberrypi/raspberrypi.cpp | 47 ++++++++++++++++++++++++++++-\n> > 1 file changed, 46 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 220cf174aa4f..8f80bb80c129 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -43,6 +43,7 @@\n> > #include \"contrast_algorithm.hpp\"\n> > #include \"contrast_status.h\"\n> > #include \"controller.hpp\"\n> > +#include \"denoise_algorithm.hpp\"\n> > #include \"denoise_status.h\"\n> > #include \"dpc_status.h\"\n> > #include \"focus_status.h\"\n> > @@ -565,6 +566,7 @@ bool IPARPi::validateIspControls()\n> > V4L2_CID_USER_BCM2835_ISP_SHARPEN,\n> > V4L2_CID_USER_BCM2835_ISP_DPC,\n> > V4L2_CID_USER_BCM2835_ISP_LENS_SHADING,\n> > + V4L2_CID_USER_BCM2835_ISP_CDN,\n> > };\n> >\n> > for (auto c : ctrls) {\n> > @@ -614,6 +616,14 @@ static const std::map\n> AwbModeTable = {\n> > { controls::AwbCustom, \"custom\" },\n> > };\n> >\n> > +static const std::map\n> DenoiseModeTable = {\n> > + { controls::draft::NoiseReductionModeOff,\n> RPiController::DenoiseMode::Off },\n> > + { controls::draft::NoiseReductionModeFast,\n> RPiController::DenoiseMode::ColourFast },\n> > + { controls::draft::NoiseReductionModeHighQuality,\n> RPiController::DenoiseMode::ColourHighQuality },\n> > + { controls::draft::NoiseReductionModeMinimal,\n> RPiController::DenoiseMode::ColourOff },\n> > + { controls::draft::NoiseReductionModeZSL,\n> RPiController::DenoiseMode::ColourHighQuality },\n> > +};\n> > +\n> > void IPARPi::queueRequest(const ControlList &controls)\n> > {\n> > /* Clear the return metadata buffer. */\n> > @@ -836,6 +846,22 @@ void IPARPi::queueRequest(const ControlList\n> &controls)\n> > break;\n> > }\n> >\n> > + case controls::NOISE_REDUCTION_MODE: {\n> > + RPiController::DenoiseAlgorithm *sdn =\n> dynamic_cast(\n> > + controller_.GetAlgorithm(\"SDN\"));\n> > + ASSERT(sdn);\n> > +\n> > + int32_t idx = ctrl.second.get();\n> > + if (DenoiseModeTable.count(idx)) {\n> > + sdn->SetMode(DenoiseModeTable.at(idx));\n> > +\n> libcameraMetadata_.set(controls::draft::NoiseReductionMode, idx);\n> > + } else {\n> > + LOG(IPARPI, Error) << \"Noise reduction\n> mode \" << idx\n> > + << \" not recognised\";\n> > + }\n> > + break;\n> > + }\n> > +\n> > default:\n> > LOG(IPARPI, Warning)\n> > << \"Ctrl \" << controls::controls.at\n> (ctrl.first)->name()\n> > @@ -1087,16 +1113,35 @@ void IPARPi::applyDenoise(const struct\n> DenoiseStatus *denoiseStatus, ControlList\n> > {\n> > bcm2835_isp_denoise denoise;\n> >\n> > - denoise.enabled = 1;\n> > + denoise.enabled = denoiseStatus->mode ==\n> RPiController::DenoiseMode::Off ? 0 : 1;\n> > denoise.constant = denoiseStatus->noise_constant;\n> > denoise.slope.num = 1000 * denoiseStatus->noise_slope;\n> > denoise.slope.den = 1000;\n> > denoise.strength.num = 1000 * denoiseStatus->strength;\n> > denoise.strength.den = 1000;\n> >\n> > + /* Set the CDN mode to match the SDN operating mode. */\n> > + bcm2835_isp_cdn cdn;\n> > + switch (denoiseStatus->mode) {\n> > + case RPiController::DenoiseMode::ColourFast:\n> > + cdn.enabled = 1;\n> > + cdn.mode = CDN_MODE_FAST;\n> > + break;\n> > + case RPiController::DenoiseMode::ColourHighQuality:\n> > + cdn.enabled = 1;\n> > + cdn.mode = CDN_MODE_HIGH_QUALITY;\n> > + break;\n> > + default:\n> > + cdn.enabled = 0;\n> > + }\n> > +\n> > ControlValue c(Span{ reinterpret_cast *>(&denoise),\n> > sizeof(denoise) });\n> > ctrls.set(V4L2_CID_USER_BCM2835_ISP_DENOISE, c);\n> > +\n> > + c = ControlValue(Span{ reinterpret_cast *>(&cdn),\n> > + sizeof(cdn) });\n> > + ctrls.set(V4L2_CID_USER_BCM2835_ISP_CDN, c);\n> > }\n> >\n> > void IPARPi::applySharpen(const struct SharpenStatus *sharpenStatus,\n> ControlList &ctrls)\n> >\n>\n> --\n> Regards\n> --\n> Kieran\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0D25BBD808\n\tfor ;\n\tFri, 22 Jan 2021 13:29:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89E3168288;\n\tFri, 22 Jan 2021 14:29:16 +0100 (CET)","from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com\n\t[IPv6:2a00:1450:4864:20::12a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4DD5868274\n\tfor ;\n\tFri, 22 Jan 2021 14:29:14 +0100 (CET)","by mail-lf1-x12a.google.com with SMTP id v24so7525237lfr.7\n\tfor ;\n\tFri, 22 Jan 2021 05:29:14 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"pZTJzRyu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=csMQvrQUwHs9aIy4Iw0aXxsYrcBtI6yNnGvHA3kO7tE=;\n\tb=pZTJzRyu4YAvJXcTmxgNiuH83eBe1wzgQHRZGjYeAWGQs1MfEvnyZ1fwmaXHIhDxgI\n\twH9xL2a/1lZUf0LSdPZSFjmVBz6WR6xj7PHdXWSNHGvhX/MBT7PF6g7fQb99pS103VC+\n\t4dm6lRClaP7RPvV3a7Qriqia5+eyI2CIfGZtVZnx+WI/ewWNPY+mB6fuqDc5ofAqNnFM\n\tG06eFiJEYazZfEJnVruODVSh+BCP7Kfu9lDf9T7b3orgCxAC+FSFjZDDLQMYUY8EGmiA\n\tlr/bwKlkJ+W0snxyMppcLepLjBQJEoyqmCUZ8ZSpTXfC5y+BEj22kOVuskoQgbBhQ+le\n\tOdmg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=csMQvrQUwHs9aIy4Iw0aXxsYrcBtI6yNnGvHA3kO7tE=;\n\tb=qdTFD7oHDA/W1nXBNfrfzZmGELiY/qwoDNugrZci+fzsyz7VbSMegDmzats+Y4UVv9\n\tgXVYa3ukkX3sznNQ3psoZ9xvvYAdgxGLvp8VIDP5l4k5FkKS4n2Jj5xVXevd9qeXRE2N\n\tiVGw1tf8RNeU4Sp+e7yNCDaYE5FjwTEAW0RywefcmY99xPSmGG5nZXZYkH+pivBmM02y\n\tKWNh1WjsGw7VV+FDOPZMm0y37mf4gvPo0C6tvdThWF5M5e8K6H1PJRwTrCANMpps85JD\n\tUPU4qfYUUprTpI9DwFFNFzre+yqLeNan0eKycoG7tLO55ZOFr4UvTRkD+7M6b6YOHgiZ\n\tPxgA==","X-Gm-Message-State":"AOAM532eDpBIGSx+PTApYy0AN9OjtqYg+1vP7pYNCvFaGOme7OguqXqw\n\tXbYM7xRTa1/pwp2QbImp16KK8apCmv6WPRc8T993FSbHj6zWuA==","X-Google-Smtp-Source":"ABdhPJxFnuY9SCeI+/pf8CadkD/ML+q7L7Xt110B2WT1OFQDrvNy56j4rGAHcEwy96QB+SUwofJBK6UQNNSpUc1QeiU=","X-Received":"by 2002:a19:8805:: with SMTP id k5mr900131lfd.567.1611322153696; \n\tFri, 22 Jan 2021 05:29:13 -0800 (PST)","MIME-Version":"1.0","References":"<20210122131451.726584-1-naush@raspberrypi.com>\n\t<20210122131451.726584-6-naush@raspberrypi.com>\n\t<402d17ea-80d6-d86a-1d43-64ca1d366f95@ideasonboard.com>","In-Reply-To":"<402d17ea-80d6-d86a-1d43-64ca1d366f95@ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 22 Jan 2021 13:28:57 +0000","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH v3 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============1834693863104692648==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]