[{"id":1493,"web_url":"https://patchwork.libcamera.org/comment/1493/","msgid":"<20190422211501.GA4805@pendragon.ideasonboard.com>","date":"2019-04-22T21:15:01","subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Check requests\n\tbefore queueing them","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Mon, Apr 22, 2019 at 08:07:40PM +0200, Niklas Söderlund wrote:\n> Make sure all requests queued to a camera only contains streams which\n\ns/contains/contain/\n\n> have been configured and belongs to the camera.\n\ns/belongs/belong/\n\n> \n> Signed-off-by: Niklas Söderlund \n> ---\n> src/libcamera/camera.cpp | 9 +++++++++\n> 1 file changed, 9 insertions(+)\n> \n> diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\n> index 655996f26224ef49..36c7584e823eb580 100644\n> --- a/src/libcamera/camera.cpp\n> +++ b/src/libcamera/camera.cpp\n> @@ -747,6 +747,15 @@ int Camera::queueRequest(Request *request)\n> \t\treturn ret;\n> \t}\n> \n> +\tfor (auto const &it : request->buffers()) {\n> +\t\tStream *stream = it.first;\n> +\t\tif (activeStreams_.find(stream) == activeStreams_.end()) {\n> +\t\t\tLOG(Camera, Error)\n> +\t\t\t\t<< \"Attempt to queue request with invalid stream\";\n> +\t\t\treturn -EINVAL;\n\nYou should document the -EINVAL error code in the return values of\nCamera::queueRequest().\n\n> +\t\t}\n> +\t}\n> +\n\nShould this be done before calling Request::prepare() ? There's no point\nin preparing the request if the streams are not valid.\n\n> \treturn pipe_->queueRequest(this, request);\n> }\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1BD62600F9\n\tfor ;\n\tMon, 22 Apr 2019 23:15:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AD5F5F;\n\tMon, 22 Apr 2019 23:15:10 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1555967710;\n\tbh=Lqo7D3B4X1gC7/RnNWNzW+qY7321qFns86rO5RrcbRc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=phK3b0zXxTMYDjKDmoWNMHMJT7Dk7dGgzFwmCFIdPNPbinvJ40/eyM9GdWbylhbML\n\toCl5cU89kX7kXm1//2vD/bzyvVIh+R6VIA4H5Cv0YaujnpQjehqCk41z1aTBZgNL/I\n\tGw6gkNrE1yffFm05AynWlcIYWNxwq9JImwDrU0gA=","Date":"Tue, 23 Apr 2019 00:15:01 +0300","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190422211501.GA4805@pendragon.ideasonboard.com>","References":"<20190422180740.21878-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190422180740.21878-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: camera: Check requests\n\tbefore queueing them","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 22 Apr 2019 21:15:11 -0000"}}]