[{"id":14731,"web_url":"https://patchwork.libcamera.org/comment/14731/","msgid":"","date":"2021-01-23T11:15:47","subject":"Re: [libcamera-devel] [PATCH 5/5] ipa: raspberrypi: Remove legacy\n\tRasberry Pi logging","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Fri, Jan 22, 2021 at 10:22:11AM +0000, David Plowman wrote:\n> Signed-off-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/algorithm.hpp | 1 -\n> src/ipa/raspberrypi/controller/logging.hpp | 30 --------------------\n> 2 files changed, 31 deletions(-)\n> delete mode 100644 src/ipa/raspberrypi/controller/logging.hpp\n> \n> diff --git a/src/ipa/raspberrypi/controller/algorithm.hpp b/src/ipa/raspberrypi/controller/algorithm.hpp\n> index 17423f23..e9b040c7 100644\n> --- a/src/ipa/raspberrypi/controller/algorithm.hpp\n> +++ b/src/ipa/raspberrypi/controller/algorithm.hpp\n> @@ -14,7 +14,6 @@\n> #include \n> #include \n> \n> -#include \"logging.hpp\"\n> #include \"controller.hpp\"\n> \n> #include \n> diff --git a/src/ipa/raspberrypi/controller/logging.hpp b/src/ipa/raspberrypi/controller/logging.hpp\n> deleted file mode 100644\n> index f0d306b6..00000000\n> --- a/src/ipa/raspberrypi/controller/logging.hpp\n> +++ /dev/null\n> @@ -1,30 +0,0 @@\n> -/* SPDX-License-Identifier: BSD-2-Clause */\n> -/*\n> - * Copyright (C) 2019-2020, Raspberry Pi (Trading) Limited\n> - *\n> - * logging.hpp - logging macros\n> - */\n> -#pragma once\n> -\n> -#include \n> -\n> -#ifndef RPI_LOGGING_ENABLE\n> -#define RPI_LOGGING_ENABLE 0\n> -#endif\n> -\n> -#ifndef RPI_WARNING_ENABLE\n> -#define RPI_WARNING_ENABLE 1\n> -#endif\n> -\n> -#define RPI_LOG(stuff) \\\n> -\tdo { \\\n> -\t\tif (RPI_LOGGING_ENABLE) \\\n> -\t\t\tstd::cout << __FUNCTION__ << \": \" << stuff << \"\\n\"; \\\n> -\t} while (0)\n> -\n> -#define RPI_WARN(stuff) \\\n> -\tdo { \\\n> -\t\tif (RPI_WARNING_ENABLE) \\\n> -\t\t\tstd::cout << __FUNCTION__ << \" ***WARNING*** \" \\\n> -\t\t\t\t << stuff << \"\\n\"; \\\n> -\t} while (0)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F5DDBD808\n\tfor ;\n\tSat, 23 Jan 2021 11:16:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B690C682A2;\n\tSat, 23 Jan 2021 12:16:08 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BFAF681DC\n\tfor ;\n\tSat, 23 Jan 2021 12:16:07 +0100 (CET)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FBBD8AE;\n\tSat, 23 Jan 2021 12:16:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dp1JCxJL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611400566;\n\tbh=ussG/1BJmblP/K/cr1rkig0av0yKUJh26RBAUdCrOJo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dp1JCxJLBdWAeBIP02AJdE3aaCPf8lnEVKfKaohfWc4rj8f8CNKSQrgE0VUagjG61\n\tovcTLZIjl9XWZ/ZX2D3yXAHI+50cyopTCCLDc94c2YJBfcTWWULwxvi3YHj6NlkqF6\n\tcvRfB8gPyTItWyplKppTIlLUKP6N7yBBzn92BC4w=","Date":"Sat, 23 Jan 2021 13:15:47 +0200","From":"Laurent Pinchart ","To":"David Plowman ","Message-ID":"","References":"<20210122102211.12768-1-david.plowman@raspberrypi.com>\n\t<20210122102211.12768-6-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Disposition":"inline","In-Reply-To":"<20210122102211.12768-6-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 5/5] ipa: raspberrypi: Remove legacy\n\tRasberry Pi logging","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]