[{"id":14697,"web_url":"https://patchwork.libcamera.org/comment/14697/","msgid":"","date":"2021-01-22T11:58:59","subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for this patch. It all looks good to me now. Only one small\nquestion, do we need to be quite sure that rpi-update is sufficiently\nup-to-date before merging this set? (wouldn't want to create a\nheadache for people who are just trying our libcamera apps for the\nfirst time!)\n\nReviewed-by: David Plowman \n\nBest regards\nDavid\n\nOn Fri, 22 Jan 2021 at 09:25, Naushir Patuck wrote:\n>\n> The application provided noise reduction mode gets passed into the\n> denoise controller. The denoise controller in turn returns the mode to\n> the IPA which now sets up the colour denoise processing appropriately.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 47 ++++++++++++++++++++++++++++-\n> 1 file changed, 46 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 220cf174aa4f..8f80bb80c129 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -43,6 +43,7 @@\n> #include \"contrast_algorithm.hpp\"\n> #include \"contrast_status.h\"\n> #include \"controller.hpp\"\n> +#include \"denoise_algorithm.hpp\"\n> #include \"denoise_status.h\"\n> #include \"dpc_status.h\"\n> #include \"focus_status.h\"\n> @@ -565,6 +566,7 @@ bool IPARPi::validateIspControls()\n> V4L2_CID_USER_BCM2835_ISP_SHARPEN,\n> V4L2_CID_USER_BCM2835_ISP_DPC,\n> V4L2_CID_USER_BCM2835_ISP_LENS_SHADING,\n> + V4L2_CID_USER_BCM2835_ISP_CDN,\n> };\n>\n> for (auto c : ctrls) {\n> @@ -614,6 +616,14 @@ static const std::map AwbModeTable = {\n> { controls::AwbCustom, \"custom\" },\n> };\n>\n> +static const std::map DenoiseModeTable = {\n> + { controls::draft::NoiseReductionModeOff, RPiController::DenoiseMode::Off },\n> + { controls::draft::NoiseReductionModeFast, RPiController::DenoiseMode::ColourFast },\n> + { controls::draft::NoiseReductionModeHighQuality, RPiController::DenoiseMode::ColourHighQuality },\n> + { controls::draft::NoiseReductionModeMinimal, RPiController::DenoiseMode::ColourOff },\n> + { controls::draft::NoiseReductionModeZSL, RPiController::DenoiseMode::ColourHighQuality },\n> +};\n> +\n> void IPARPi::queueRequest(const ControlList &controls)\n> {\n> /* Clear the return metadata buffer. */\n> @@ -836,6 +846,22 @@ void IPARPi::queueRequest(const ControlList &controls)\n> break;\n> }\n>\n> + case controls::NOISE_REDUCTION_MODE: {\n> + RPiController::DenoiseAlgorithm *sdn = dynamic_cast(\n> + controller_.GetAlgorithm(\"SDN\"));\n> + ASSERT(sdn);\n> +\n> + int32_t idx = ctrl.second.get();\n> + if (DenoiseModeTable.count(idx)) {\n> + sdn->SetMode(DenoiseModeTable.at(idx));\n> + libcameraMetadata_.set(controls::draft::NoiseReductionMode, idx);\n> + } else {\n> + LOG(IPARPI, Error) << \"Noise reduction mode \" << idx\n> + << \" not recognised\";\n> + }\n> + break;\n> + }\n> +\n> default:\n> LOG(IPARPI, Warning)\n> << \"Ctrl \" << controls::controls.at(ctrl.first)->name()\n> @@ -1087,16 +1113,35 @@ void IPARPi::applyDenoise(const struct DenoiseStatus *denoiseStatus, ControlList\n> {\n> bcm2835_isp_denoise denoise;\n>\n> - denoise.enabled = 1;\n> + denoise.enabled = denoiseStatus->mode == RPiController::DenoiseMode::Off ? 0 : 1;\n> denoise.constant = denoiseStatus->noise_constant;\n> denoise.slope.num = 1000 * denoiseStatus->noise_slope;\n> denoise.slope.den = 1000;\n> denoise.strength.num = 1000 * denoiseStatus->strength;\n> denoise.strength.den = 1000;\n>\n> + /* Set the CDN mode to match the SDN operating mode. */\n> + bcm2835_isp_cdn cdn;\n> + switch (denoiseStatus->mode) {\n> + case RPiController::DenoiseMode::ColourFast:\n> + cdn.enabled = 1;\n> + cdn.mode = CDN_MODE_FAST;\n> + break;\n> + case RPiController::DenoiseMode::ColourHighQuality:\n> + cdn.enabled = 1;\n> + cdn.mode = CDN_MODE_HIGH_QUALITY;\n> + break;\n> + default:\n> + cdn.enabled = 0;\n> + }\n> +\n> ControlValue c(Span{ reinterpret_cast(&denoise),\n> sizeof(denoise) });\n> ctrls.set(V4L2_CID_USER_BCM2835_ISP_DENOISE, c);\n> +\n> + c = ControlValue(Span{ reinterpret_cast(&cdn),\n> + sizeof(cdn) });\n> + ctrls.set(V4L2_CID_USER_BCM2835_ISP_CDN, c);\n> }\n>\n> void IPARPi::applySharpen(const struct SharpenStatus *sharpenStatus, ControlList &ctrls)\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6154BD808\n\tfor ;\n\tFri, 22 Jan 2021 11:59:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 704776824C;\n\tFri, 22 Jan 2021 12:59:12 +0100 (CET)","from mail-oi1-x229.google.com (mail-oi1-x229.google.com\n\t[IPv6:2607:f8b0:4864:20::229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F310768248\n\tfor ;\n\tFri, 22 Jan 2021 12:59:10 +0100 (CET)","by mail-oi1-x229.google.com with SMTP id q25so5679470oij.10\n\tfor ;\n\tFri, 22 Jan 2021 03:59:10 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ow3/PnZo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=DSGCbbOCVFSt6iu/eg3sbV3I16cdR0tB54Ift8hh0sU=;\n\tb=ow3/PnZoAd1PoOvVfSEnpP7LMkHburCazAXAW1gaJ9ZQfSlj+USj1VQC+e9wr07+K9\n\tyqF7JO6qXN4Guv8u4xyhKt+6WDdGykcQY1pBHLxVyt6zZl0nfOmNhrO19Bbv8TzRxbtw\n\ttC9uGQW7qxbs5kk7l3FyfJuDMXmnOkUNi2ZU8OIttcFSkpT+Jm9SD6gmKfwD5taoMCTn\n\tMjIthzjBPeAAEY9kSJUv40V+oJqWms0Qf1o4fQqS9J9UzronHTySkbDIVVYa1+bps+o5\n\tr6SExzQTwejJrH6GA8zNEgT9tTx6UDzwVJo6vx6hNqtMdKrH2qkIWNGtiC9Rhy3NsLSk\n\tjKpw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=DSGCbbOCVFSt6iu/eg3sbV3I16cdR0tB54Ift8hh0sU=;\n\tb=nZr/ET2TuISqnCQxEh0zDWRT6L4yz6xvG+erj6ZV+D4qDKr10iHbDcpWPIQowli0jb\n\tKTpvaOjZU2sUWeU8MohE1RxN2rIfBj/jWRyPru29DrzM/14M+58mvlHTNScsFT8NMsv9\n\tZgOMDsPLO3W5766qD5dkiAXlw4zTpjYx+xunxG7E15mUbfugYO7PgXmVu6vcIibnxM6p\n\tKCo+8/sOG1xVlYHd0LUyS46sLBnublVgA5pP4l1nDaj8cMfagm/gqRWc/SphxG05ipVM\n\tTL55usAUpHmGqAwPpizgxRDsOeS8kcQOdgqAk2okI394zkyjG/am58LxbDm0toRn4BTl\n\tvftQ==","X-Gm-Message-State":"AOAM532Ml/vHzIqoHiUOjT0GEtBYpu+kS6xoFg85kr/KdL+sOgCUjdks\n\tVzu95Bg6+5Xxv7kI5hXfL3eeRt8b/jPYiUvPZzNqpRMw5gS+TA==","X-Google-Smtp-Source":"ABdhPJxi12AFpM6RgeT7LT2HwKu40fSwR0o/fcs4Oykro5TpbbRYNL6Ei9XUyGcCpGjrqokMEm3A6uQ3mtyGB9Bvp74=","X-Received":"by 2002:aca:4d93:: with SMTP id\n\ta141mr2881239oib.107.1611316749958; \n\tFri, 22 Jan 2021 03:59:09 -0800 (PST)","MIME-Version":"1.0","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-7-naush@raspberrypi.com>","In-Reply-To":"<20210122092537.708375-7-naush@raspberrypi.com>","From":"David Plowman ","Date":"Fri, 22 Jan 2021 11:58:59 +0000","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14700,"web_url":"https://patchwork.libcamera.org/comment/14700/","msgid":"","date":"2021-01-22T12:03:50","subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your review.\n\nOn Fri, 22 Jan 2021 at 11:59, David Plowman \nwrote:\n\n> Hi Naush\n>\n> Thanks for this patch. It all looks good to me now. Only one small\n> question, do we need to be quite sure that rpi-update is sufficiently\n> up-to-date before merging this set? (wouldn't want to create a\n> headache for people who are just trying our libcamera apps for the\n> first time!)\n>\n\nI've already confirmed that the rpi-update firmware does have the necessary\nchanges for colour denoise to work. So all should be good.\n\nRegards,\nNaush\n\n\n\n>\n> Reviewed-by: David Plowman \n>\n> Best regards\n> David\n>\n> On Fri, 22 Jan 2021 at 09:25, Naushir Patuck \n> wrote:\n> >\n> > The application provided noise reduction mode gets passed into the\n> > denoise controller. The denoise controller in turn returns the mode to\n> > the IPA which now sets up the colour denoise processing appropriately.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/ipa/raspberrypi/raspberrypi.cpp | 47 ++++++++++++++++++++++++++++-\n> > 1 file changed, 46 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 220cf174aa4f..8f80bb80c129 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -43,6 +43,7 @@\n> > #include \"contrast_algorithm.hpp\"\n> > #include \"contrast_status.h\"\n> > #include \"controller.hpp\"\n> > +#include \"denoise_algorithm.hpp\"\n> > #include \"denoise_status.h\"\n> > #include \"dpc_status.h\"\n> > #include \"focus_status.h\"\n> > @@ -565,6 +566,7 @@ bool IPARPi::validateIspControls()\n> > V4L2_CID_USER_BCM2835_ISP_SHARPEN,\n> > V4L2_CID_USER_BCM2835_ISP_DPC,\n> > V4L2_CID_USER_BCM2835_ISP_LENS_SHADING,\n> > + V4L2_CID_USER_BCM2835_ISP_CDN,\n> > };\n> >\n> > for (auto c : ctrls) {\n> > @@ -614,6 +616,14 @@ static const std::map\n> AwbModeTable = {\n> > { controls::AwbCustom, \"custom\" },\n> > };\n> >\n> > +static const std::map\n> DenoiseModeTable = {\n> > + { controls::draft::NoiseReductionModeOff,\n> RPiController::DenoiseMode::Off },\n> > + { controls::draft::NoiseReductionModeFast,\n> RPiController::DenoiseMode::ColourFast },\n> > + { controls::draft::NoiseReductionModeHighQuality,\n> RPiController::DenoiseMode::ColourHighQuality },\n> > + { controls::draft::NoiseReductionModeMinimal,\n> RPiController::DenoiseMode::ColourOff },\n> > + { controls::draft::NoiseReductionModeZSL,\n> RPiController::DenoiseMode::ColourHighQuality },\n> > +};\n> > +\n> > void IPARPi::queueRequest(const ControlList &controls)\n> > {\n> > /* Clear the return metadata buffer. */\n> > @@ -836,6 +846,22 @@ void IPARPi::queueRequest(const ControlList\n> &controls)\n> > break;\n> > }\n> >\n> > + case controls::NOISE_REDUCTION_MODE: {\n> > + RPiController::DenoiseAlgorithm *sdn =\n> dynamic_cast(\n> > + controller_.GetAlgorithm(\"SDN\"));\n> > + ASSERT(sdn);\n> > +\n> > + int32_t idx = ctrl.second.get();\n> > + if (DenoiseModeTable.count(idx)) {\n> > + sdn->SetMode(DenoiseModeTable.at(idx));\n> > +\n> libcameraMetadata_.set(controls::draft::NoiseReductionMode, idx);\n> > + } else {\n> > + LOG(IPARPI, Error) << \"Noise reduction\n> mode \" << idx\n> > + << \" not recognised\";\n> > + }\n> > + break;\n> > + }\n> > +\n> > default:\n> > LOG(IPARPI, Warning)\n> > << \"Ctrl \" << controls::controls.at\n> (ctrl.first)->name()\n> > @@ -1087,16 +1113,35 @@ void IPARPi::applyDenoise(const struct\n> DenoiseStatus *denoiseStatus, ControlList\n> > {\n> > bcm2835_isp_denoise denoise;\n> >\n> > - denoise.enabled = 1;\n> > + denoise.enabled = denoiseStatus->mode ==\n> RPiController::DenoiseMode::Off ? 0 : 1;\n> > denoise.constant = denoiseStatus->noise_constant;\n> > denoise.slope.num = 1000 * denoiseStatus->noise_slope;\n> > denoise.slope.den = 1000;\n> > denoise.strength.num = 1000 * denoiseStatus->strength;\n> > denoise.strength.den = 1000;\n> >\n> > + /* Set the CDN mode to match the SDN operating mode. */\n> > + bcm2835_isp_cdn cdn;\n> > + switch (denoiseStatus->mode) {\n> > + case RPiController::DenoiseMode::ColourFast:\n> > + cdn.enabled = 1;\n> > + cdn.mode = CDN_MODE_FAST;\n> > + break;\n> > + case RPiController::DenoiseMode::ColourHighQuality:\n> > + cdn.enabled = 1;\n> > + cdn.mode = CDN_MODE_HIGH_QUALITY;\n> > + break;\n> > + default:\n> > + cdn.enabled = 0;\n> > + }\n> > +\n> > ControlValue c(Span{ reinterpret_cast *>(&denoise),\n> > sizeof(denoise) });\n> > ctrls.set(V4L2_CID_USER_BCM2835_ISP_DENOISE, c);\n> > +\n> > + c = ControlValue(Span{ reinterpret_cast *>(&cdn),\n> > + sizeof(cdn) });\n> > + ctrls.set(V4L2_CID_USER_BCM2835_ISP_CDN, c);\n> > }\n> >\n> > void IPARPi::applySharpen(const struct SharpenStatus *sharpenStatus,\n> ControlList &ctrls)\n> > --\n> > 2.25.1\n> >\n> > _______________________________________________\n> > libcamera-devel mailing list\n> > libcamera-devel@lists.libcamera.org\n> > https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A416EC0F2A\n\tfor ;\n\tFri, 22 Jan 2021 12:04:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7147A6825E;\n\tFri, 22 Jan 2021 13:04:08 +0100 (CET)","from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com\n\t[IPv6:2a00:1450:4864:20::12d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 245A568252\n\tfor ;\n\tFri, 22 Jan 2021 13:04:07 +0100 (CET)","by mail-lf1-x12d.google.com with SMTP id h7so7191364lfc.6\n\tfor ;\n\tFri, 22 Jan 2021 04:04:07 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"nZKSJJvJ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=AcfW6Q3Wrqoz99PM4bJrj3Yp5RF1KFioZNBO+OrUbPc=;\n\tb=nZKSJJvJcUPOiThVJo5g9yHbWQqHPuO/r+AuYi6hW4vHAUbJ27LVeN9dRlxeXLz7lc\n\tb0XFMFQ7Dtf59vwcBDKm0gw4D9d8KDz8kIM6Az7UsVBYgzxTaN87w+K10DHMtRsdzbIb\n\tTLFh9HwcLA1Ggt8ox8vTT0xbB5U6wIppyfnY0TjCMEobBThFDJovedSfDV11bAjn12u1\n\tzDglirmAdUl+MUtJ7QImv+SasKaTXMrkt32ekq6HVF9UibXaE85PwV2Qbb44s80gCn8n\n\tO58fMEqN0L3RcasmGsaJRDaBObS/noGjG9EGPvmXDZ+UBfBIvcu0zoR7Zh1/AbS/2Iwx\n\tFyiQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=AcfW6Q3Wrqoz99PM4bJrj3Yp5RF1KFioZNBO+OrUbPc=;\n\tb=Ed6ddb8osIBS23IQGRpshtssFDE4GtQ47W0p/k58wlu0ZceKEt1Jys3iYAoAzH8NJ2\n\tNGpGt2BCqGRolaK1d3MDVcLkN6GZ88e014KiC9CNeL3ioCYK6Hop9oE3xR+IAMs+f4Ft\n\tLf40fmFW6ry/MRhySy+XivH25EjHapWW8dHRetKtEURTyVV+1Y8NhTfWYyx9E0hV3+Mp\n\t74rk15Nwl3dxDyYdZV/CzwFpL+t1AYbOapjr7yFak1hdjJaIN3rltVRM1cxfMokIy2rA\n\t7DqEnXurPYDi2R77WBiEgWvNwFCoj8lGMnTZy9waIkzeLrL+CSDEwT8pWNd9lvHHyZg4\n\t1wfQ==","X-Gm-Message-State":"AOAM5330WhdBoyIki/FG4+C4LNoHGte48ay7Zm1TyxgysbbtW2Q+rSbp\n\tGgb6EWlnKLg/CI1bK7XaBULl5jqWeWSVGJD8PvNHpZRw3m4=","X-Google-Smtp-Source":"ABdhPJwND4XDbn6NyxFYlaiFFsbQihsLdfk4j1qxP4hL4nPoZkBJpNTpwOxShQWtfAEsFzrvDteTzO1bgD9BrkO6dXQ=","X-Received":"by 2002:a19:ee09:: with SMTP id g9mr738210lfb.272.1611317046603; \n\tFri, 22 Jan 2021 04:04:06 -0800 (PST)","MIME-Version":"1.0","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-7-naush@raspberrypi.com>\n\t","In-Reply-To":"","From":"Naushir Patuck ","Date":"Fri, 22 Jan 2021 12:03:50 +0000","Message-ID":"","To":"David Plowman ","Subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============3789432540328868953==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14702,"web_url":"https://patchwork.libcamera.org/comment/14702/","msgid":"<5798d19d-4d04-1376-3000-4d226b47129d@ideasonboard.com>","date":"2021-01-22T12:07:51","subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 22/01/2021 09:25, Naushir Patuck wrote:\n> The application provided noise reduction mode gets passed into the\n> denoise controller. The denoise controller in turn returns the mode to\n> the IPA which now sets up the colour denoise processing appropriately.\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/raspberrypi.cpp | 47 ++++++++++++++++++++++++++++-\n> 1 file changed, 46 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 220cf174aa4f..8f80bb80c129 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -43,6 +43,7 @@\n> #include \"contrast_algorithm.hpp\"\n> #include \"contrast_status.h\"\n> #include \"controller.hpp\"\n> +#include \"denoise_algorithm.hpp\"\n> #include \"denoise_status.h\"\n> #include \"dpc_status.h\"\n> #include \"focus_status.h\"\n> @@ -565,6 +566,7 @@ bool IPARPi::validateIspControls()\n> \t\tV4L2_CID_USER_BCM2835_ISP_SHARPEN,\n> \t\tV4L2_CID_USER_BCM2835_ISP_DPC,\n> \t\tV4L2_CID_USER_BCM2835_ISP_LENS_SHADING,\n> +\t\tV4L2_CID_USER_BCM2835_ISP_CDN,\n> \t};\n> \n> \tfor (auto c : ctrls) {\n> @@ -614,6 +616,14 @@ static const std::map AwbModeTable = {\n> \t{ controls::AwbCustom, \"custom\" },\n> };\n> \n> +static const std::map DenoiseModeTable = {\n> +\t{ controls::draft::NoiseReductionModeOff, RPiController::DenoiseMode::Off },\n> +\t{ controls::draft::NoiseReductionModeFast, RPiController::DenoiseMode::ColourFast },\n> +\t{ controls::draft::NoiseReductionModeHighQuality, RPiController::DenoiseMode::ColourHighQuality },\n> +\t{ controls::draft::NoiseReductionModeMinimal, RPiController::DenoiseMode::ColourOff },\n> +\t{ controls::draft::NoiseReductionModeZSL, RPiController::DenoiseMode::ColourHighQuality },\n> +};\n> +\n> void IPARPi::queueRequest(const ControlList &controls)\n> {\n> \t/* Clear the return metadata buffer. */\n> @@ -836,6 +846,22 @@ void IPARPi::queueRequest(const ControlList &controls)\n> \t\t\tbreak;\n> \t\t}\n> \n> +\t\tcase controls::NOISE_REDUCTION_MODE: {\n> +\t\t\tRPiController::DenoiseAlgorithm *sdn = dynamic_cast(\n> +\t\t\t\tcontroller_.GetAlgorithm(\"SDN\"));\n> +\t\t\tASSERT(sdn);\n\nI assume the assert means that it's (expected to be) guaranteed to get\nthe algorithm, so we don't need to handle that gracefully.\n\nIn which case assert is just fine ;-)\n\n\n> +\n> +\t\t\tint32_t idx = ctrl.second.get();\n\nMy usual screams at how I dislike std::pair ;-) But that's a rant at\nC++, not this patch.\n\n\n> +\t\t\tif (DenoiseModeTable.count(idx)) {\n> +\t\t\t\tsdn->SetMode(DenoiseModeTable.at(idx));\n> +\t\t\t\tlibcameraMetadata_.set(controls::draft::NoiseReductionMode, idx);\n> +\t\t\t} else {\n> +\t\t\t\tLOG(IPARPI, Error) << \"Noise reduction mode \" << idx\n> +\t\t\t\t\t\t << \" not recognised\";\n> +\t\t\t}\n> +\t\t\tbreak;\n> +\t\t}\n> +\n> \t\tdefault:\n> \t\t\tLOG(IPARPI, Warning)\n> \t\t\t\t<< \"Ctrl \" << controls::controls.at(ctrl.first)->name()\n> @@ -1087,16 +1113,35 @@ void IPARPi::applyDenoise(const struct DenoiseStatus *denoiseStatus, ControlList\n> {\n> \tbcm2835_isp_denoise denoise;\n> \n> -\tdenoise.enabled = 1;\n> +\tdenoise.enabled = denoiseStatus->mode == RPiController::DenoiseMode::Off ? 0 : 1;\n\nIs the ternary required? Isn't\n (denoiseStatus->mode == RPiController::DenoiseMode::Off) sufficient?\n\nHrm, it's assigned to a __u32, so I guess in someways it's good to be\nexplicit.\n\nReviewed-by: Kieran Bingham \n\n> \tdenoise.constant = denoiseStatus->noise_constant;\n> \tdenoise.slope.num = 1000 * denoiseStatus->noise_slope;\n> \tdenoise.slope.den = 1000;\n> \tdenoise.strength.num = 1000 * denoiseStatus->strength;\n> \tdenoise.strength.den = 1000;\n> \n> +\t/* Set the CDN mode to match the SDN operating mode. */\n> +\tbcm2835_isp_cdn cdn;\n> +\tswitch (denoiseStatus->mode) {\n> +\tcase RPiController::DenoiseMode::ColourFast:\n> +\t\tcdn.enabled = 1;\n> +\t\tcdn.mode = CDN_MODE_FAST;\n> +\t\tbreak;\n> +\tcase RPiController::DenoiseMode::ColourHighQuality:\n> +\t\tcdn.enabled = 1;\n> +\t\tcdn.mode = CDN_MODE_HIGH_QUALITY;\n> +\t\tbreak;\n> +\tdefault:\n> +\t\tcdn.enabled = 0;\n> +\t}\n> +\n> \tControlValue c(Span{ reinterpret_cast(&denoise),\n> \t\t\t\t\t sizeof(denoise) });\n> \tctrls.set(V4L2_CID_USER_BCM2835_ISP_DENOISE, c);\n> +\n> +\tc = ControlValue(Span{ reinterpret_cast(&cdn),\n> +\t\t\t\t\t sizeof(cdn) });\n> +\tctrls.set(V4L2_CID_USER_BCM2835_ISP_CDN, c);\n> }\n> \n> void IPARPi::applySharpen(const struct SharpenStatus *sharpenStatus, ControlList &ctrls)\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2117CBD808\n\tfor ;\n\tFri, 22 Jan 2021 12:07:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A40556825F;\n\tFri, 22 Jan 2021 13:07:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8316E6825B\n\tfor ;\n\tFri, 22 Jan 2021 13:07:55 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 078114FB;\n\tFri, 22 Jan 2021 13:07:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ksHxCQlE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611317275;\n\tbh=gnRWHEJUmOVnsyFZ/OilSTns7sMAAjvuV6PlFW+hqgw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=ksHxCQlEeu3hk8QAw40sWZinIP+7VcPEiTAesXE45hsu3mphQIkmVzlLr478Gh3nC\n\tvuD+oVvj7KnPA7S7/EPFzvlPbHfCNLVP26UN7uTzsxwztBgo6sq+mXg+ETrWpeIpjO\n\tEGeG6PF9gAc+tNj5Ei41GqWAE0WHTarmnYRR6n3w=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-7-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<5798d19d-4d04-1376-3000-4d226b47129d@ideasonboard.com>","Date":"Fri, 22 Jan 2021 12:07:51 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210122092537.708375-7-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14710,"web_url":"https://patchwork.libcamera.org/comment/14710/","msgid":"","date":"2021-01-22T13:14:34","subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\n\nOn Fri, 22 Jan 2021 at 12:07, Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Hi Naush,\n>\n> On 22/01/2021 09:25, Naushir Patuck wrote:\n> > The application provided noise reduction mode gets passed into the\n> > denoise controller. The denoise controller in turn returns the mode to\n> > the IPA which now sets up the colour denoise processing appropriately.\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/ipa/raspberrypi/raspberrypi.cpp | 47 ++++++++++++++++++++++++++++-\n> > 1 file changed, 46 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 220cf174aa4f..8f80bb80c129 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -43,6 +43,7 @@\n> > #include \"contrast_algorithm.hpp\"\n> > #include \"contrast_status.h\"\n> > #include \"controller.hpp\"\n> > +#include \"denoise_algorithm.hpp\"\n> > #include \"denoise_status.h\"\n> > #include \"dpc_status.h\"\n> > #include \"focus_status.h\"\n> > @@ -565,6 +566,7 @@ bool IPARPi::validateIspControls()\n> > V4L2_CID_USER_BCM2835_ISP_SHARPEN,\n> > V4L2_CID_USER_BCM2835_ISP_DPC,\n> > V4L2_CID_USER_BCM2835_ISP_LENS_SHADING,\n> > + V4L2_CID_USER_BCM2835_ISP_CDN,\n> > };\n> >\n> > for (auto c : ctrls) {\n> > @@ -614,6 +616,14 @@ static const std::map\n> AwbModeTable = {\n> > { controls::AwbCustom, \"custom\" },\n> > };\n> >\n> > +static const std::map\n> DenoiseModeTable = {\n> > + { controls::draft::NoiseReductionModeOff,\n> RPiController::DenoiseMode::Off },\n> > + { controls::draft::NoiseReductionModeFast,\n> RPiController::DenoiseMode::ColourFast },\n> > + { controls::draft::NoiseReductionModeHighQuality,\n> RPiController::DenoiseMode::ColourHighQuality },\n> > + { controls::draft::NoiseReductionModeMinimal,\n> RPiController::DenoiseMode::ColourOff },\n> > + { controls::draft::NoiseReductionModeZSL,\n> RPiController::DenoiseMode::ColourHighQuality },\n> > +};\n> > +\n> > void IPARPi::queueRequest(const ControlList &controls)\n> > {\n> > /* Clear the return metadata buffer. */\n> > @@ -836,6 +846,22 @@ void IPARPi::queueRequest(const ControlList\n> &controls)\n> > break;\n> > }\n> >\n> > + case controls::NOISE_REDUCTION_MODE: {\n> > + RPiController::DenoiseAlgorithm *sdn =\n> dynamic_cast(\n> > + controller_.GetAlgorithm(\"SDN\"));\n> > + ASSERT(sdn);\n>\n> I assume the assert means that it's (expected to be) guaranteed to get\n> the algorithm, so we don't need to handle that gracefully.\n>\n> In which case assert is just fine ;-)\n>\n\nYes, for now, we guarantee that sdn should be available. David and I do\nneed to work out mechanisms where they may eventually be absent, but we are\nnot there yet.\n\n\n>\n>\n> > +\n> > + int32_t idx = ctrl.second.get();\n>\n> My usual screams at how I dislike std::pair ;-) But that's a rant at\n> C++, not this patch.\n>\n>\n> > + if (DenoiseModeTable.count(idx)) {\n> > + sdn->SetMode(DenoiseModeTable.at(idx));\n> > +\n> libcameraMetadata_.set(controls::draft::NoiseReductionMode, idx);\n> > + } else {\n> > + LOG(IPARPI, Error) << \"Noise reduction\n> mode \" << idx\n> > + << \" not recognised\";\n> > + }\n> > + break;\n> > + }\n> > +\n> > default:\n> > LOG(IPARPI, Warning)\n> > << \"Ctrl \" << controls::controls.at\n> (ctrl.first)->name()\n> > @@ -1087,16 +1113,35 @@ void IPARPi::applyDenoise(const struct\n> DenoiseStatus *denoiseStatus, ControlList\n> > {\n> > bcm2835_isp_denoise denoise;\n> >\n> > - denoise.enabled = 1;\n> > + denoise.enabled = denoiseStatus->mode ==\n> RPiController::DenoiseMode::Off ? 0 : 1;\n>\n> Is the ternary required? Isn't\n> (denoiseStatus->mode == RPiController::DenoiseMode::Off) sufficient?\n>\n\nI think you mean \"!=\" there :-)\n\n\n>\n> Hrm, it's assigned to a __u32, so I guess in someways it's good to be\n> explicit.\n>\n\nNo, this is not strictly required, but I do prefer to be explicit purely as\na matter of style. Hope that is ok.\n\nRegards,\nNaush\n\n\n\n>\n> Reviewed-by: Kieran Bingham \n>\n> > denoise.constant = denoiseStatus->noise_constant;\n> > denoise.slope.num = 1000 * denoiseStatus->noise_slope;\n> > denoise.slope.den = 1000;\n> > denoise.strength.num = 1000 * denoiseStatus->strength;\n> > denoise.strength.den = 1000;\n> >\n> > + /* Set the CDN mode to match the SDN operating mode. */\n> > + bcm2835_isp_cdn cdn;\n> > + switch (denoiseStatus->mode) {\n> > + case RPiController::DenoiseMode::ColourFast:\n> > + cdn.enabled = 1;\n> > + cdn.mode = CDN_MODE_FAST;\n> > + break;\n> > + case RPiController::DenoiseMode::ColourHighQuality:\n> > + cdn.enabled = 1;\n> > + cdn.mode = CDN_MODE_HIGH_QUALITY;\n> > + break;\n> > + default:\n> > + cdn.enabled = 0;\n> > + }\n> > +\n> > ControlValue c(Span{ reinterpret_cast *>(&denoise),\n> > sizeof(denoise) });\n> > ctrls.set(V4L2_CID_USER_BCM2835_ISP_DENOISE, c);\n> > +\n> > + c = ControlValue(Span{ reinterpret_cast *>(&cdn),\n> > + sizeof(cdn) });\n> > + ctrls.set(V4L2_CID_USER_BCM2835_ISP_CDN, c);\n> > }\n> >\n> > void IPARPi::applySharpen(const struct SharpenStatus *sharpenStatus,\n> ControlList &ctrls)\n> >\n>\n> --\n> Regards\n> --\n> Kieran\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 348EEBD808\n\tfor ;\n\tFri, 22 Jan 2021 13:14:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B8F7B6826F;\n\tFri, 22 Jan 2021 14:14:52 +0100 (CET)","from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com\n\t[IPv6:2a00:1450:4864:20::22a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C63168265\n\tfor ;\n\tFri, 22 Jan 2021 14:14:51 +0100 (CET)","by mail-lj1-x22a.google.com with SMTP id e7so6434653ljg.10\n\tfor ;\n\tFri, 22 Jan 2021 05:14:51 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"HIfKUZZs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=PiDrLg/11/zAFrNHyTdif2DC+R61287KsBo/Kh0p5sU=;\n\tb=HIfKUZZsinKXvCHTzCMeCyBhtrp/x3SklUEYF6IOT6NFiZp2Um6U0mlWepwCin7zX7\n\tRXlr+/Y7rrONvwlPRsrVU47NPnZGt+T+x76GLkb8bx99x6zYMlA4hG0leZARvts7rP3T\n\tlr8mw08oXW51GTamt5mURsv3TPG/nNwxVGAU6oNMcz7tjMj42IZDRKHcmTmVzlp2g9Jk\n\tdQPWt0FpKdDJwFzR23PG2SZBApcrpMVfmx4iX/V8hr2LlPHzC5/YUf2GYzkVZf2iwAOG\n\tWpQ0tt71uAkLN7Scp0DFJxaVE9Qgl2J97gIJOkgypZpHyTUw6t54NkVBqe8NlJ5yjsX2\n\tQmKw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=PiDrLg/11/zAFrNHyTdif2DC+R61287KsBo/Kh0p5sU=;\n\tb=q/u+ZqdEp3rMz7FqVgAMjkso1UirTfisLmObb9Kf/JhYs99/iAixOIpzI+auftwZkW\n\tSGV/pu5ejur+/J+aB6yV9uI938JaBXvaxpLXokchl89JQALGjT8B4JeVewX2xMXI2gEq\n\tResYZLDr20MBW1Zb+O/Lz6ijAvCO/2le8Upx1rWdoX0quX3AjVUg7Cnz1dSov1MuAfYf\n\tp+v24mTiqVOl4jOSoR2JDgscn0GG3rpLRgkyW3g04gVJvQbCBNQcapp/EH70BAaxq+xm\n\t/75JJfCddI2ctCn2DdvXqOWfY8WXvuqAaW6UbEAIkLk3735kSDx8qgpI47DiWXcFNrvt\n\t43ew==","X-Gm-Message-State":"AOAM531jpSZNTlh7AI6lRfs2LWYZkp/a9s+cLYG9QdffKKm0kDQ5dznS\n\tZiGb6n54Y1PYkRCKdrOuBKX24CrmmwrXyVTPnhDCFZfW/Gs=","X-Google-Smtp-Source":"ABdhPJzLmawyr2sNHY8JztGClaM8ZbUVsh7EoMvZ334l3yfv4xhWNHCkH3u/ltvc2AlbYicqpwm3EKPCUd9Dl/TheH4=","X-Received":"by 2002:a2e:7605:: with SMTP id r5mr450621ljc.299.1611321290667; \n\tFri, 22 Jan 2021 05:14:50 -0800 (PST)","MIME-Version":"1.0","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-7-naush@raspberrypi.com>\n\t<5798d19d-4d04-1376-3000-4d226b47129d@ideasonboard.com>","In-Reply-To":"<5798d19d-4d04-1376-3000-4d226b47129d@ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 22 Jan 2021 13:14:34 +0000","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============1577214139279752919==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14711,"web_url":"https://patchwork.libcamera.org/comment/14711/","msgid":"<7fc277ae-cb35-c76b-16c1-087c00a07fc5@ideasonboard.com>","date":"2021-01-22T13:17:27","subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"On 22/01/2021 13:14, Naushir Patuck wrote:\n> Hi Kieran,\n> \n> \n> On Fri, 22 Jan 2021 at 12:07, Kieran Bingham\n> > wrote:\n> \n> Hi Naush,\n> \n> On 22/01/2021 09:25, Naushir Patuck wrote:\n> > The application provided noise reduction mode gets passed into the\n> > denoise controller.  The denoise controller in turn returns the\n> mode to\n> > the IPA which now sets up the colour denoise processing appropriately.\n> >\n> > Signed-off-by: Naushir Patuck >\n> > ---\n> >  src/ipa/raspberrypi/raspberrypi.cpp | 47\n> ++++++++++++++++++++++++++++-\n> >  1 file changed, 46 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 220cf174aa4f..8f80bb80c129 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -43,6 +43,7 @@\n> >  #include \"contrast_algorithm.hpp\"\n> >  #include \"contrast_status.h\"\n> >  #include \"controller.hpp\"\n> > +#include \"denoise_algorithm.hpp\"\n> >  #include \"denoise_status.h\"\n> >  #include \"dpc_status.h\"\n> >  #include \"focus_status.h\"\n> > @@ -565,6 +566,7 @@ bool IPARPi::validateIspControls()\n> >               V4L2_CID_USER_BCM2835_ISP_SHARPEN,\n> >               V4L2_CID_USER_BCM2835_ISP_DPC,\n> >               V4L2_CID_USER_BCM2835_ISP_LENS_SHADING,\n> > +             V4L2_CID_USER_BCM2835_ISP_CDN,\n> >       };\n> > \n> >       for (auto c : ctrls) {\n> > @@ -614,6 +616,14 @@ static const std::map\n> AwbModeTable = {\n> >       { controls::AwbCustom, \"custom\" },\n> >  };\n> > \n> > +static const std::map\n> DenoiseModeTable = {\n> > +     { controls::draft::NoiseReductionModeOff,\n> RPiController::DenoiseMode::Off },\n> > +     { controls::draft::NoiseReductionModeFast,\n> RPiController::DenoiseMode::ColourFast },\n> > +     { controls::draft::NoiseReductionModeHighQuality,\n> RPiController::DenoiseMode::ColourHighQuality },\n> > +     { controls::draft::NoiseReductionModeMinimal,\n> RPiController::DenoiseMode::ColourOff },\n> > +     { controls::draft::NoiseReductionModeZSL,\n> RPiController::DenoiseMode::ColourHighQuality },\n> > +};\n> > +\n> >  void IPARPi::queueRequest(const ControlList &controls)\n> >  {\n> >       /* Clear the return metadata buffer. */\n> > @@ -836,6 +846,22 @@ void IPARPi::queueRequest(const ControlList\n> &controls)\n> >                       break;\n> >               }\n> > \n> > +             case controls::NOISE_REDUCTION_MODE: {\n> > +                     RPiController::DenoiseAlgorithm *sdn =\n> dynamic_cast(\n> > +                             controller_.GetAlgorithm(\"SDN\"));\n> > +                     ASSERT(sdn);\n> \n> I assume the assert means that it's (expected to be) guaranteed to get\n> the algorithm, so we don't need to handle that gracefully.\n> \n> In which case assert is just fine ;-)\n> \n> \n> Yes, for now, we guarantee that sdn should be available.  David and I do\n> need to work out mechanisms where they may eventually be absent, but we\n> are not there yet.\n>  \n> \n> \n> \n> > +\n> > +                     int32_t idx = ctrl.second.get();\n> \n> My usual screams at how I dislike std::pair ;-) But that's a rant at\n> C++, not this patch.\n> \n> \n> > +                     if (DenoiseModeTable.count(idx)) {\n> > +                             sdn->SetMode(DenoiseModeTable.at(idx));\n> > +                           \n>  libcameraMetadata_.set(controls::draft::NoiseReductionMode, idx);\n> > +                     } else {\n> > +                             LOG(IPARPI, Error) << \"Noise\n> reduction mode \" << idx\n> > +                                                << \" not recognised\";\n> > +                     }\n> > +                     break;\n> > +             }\n> > +\n> >               default:\n> >                       LOG(IPARPI, Warning)\n> >                               << \"Ctrl \" << controls::controls.at\n> (ctrl.first)->name()\n> > @@ -1087,16 +1113,35 @@ void IPARPi::applyDenoise(const struct\n> DenoiseStatus *denoiseStatus, ControlList\n> >  {\n> >       bcm2835_isp_denoise denoise;\n> > \n> > -     denoise.enabled = 1;\n> > +     denoise.enabled = denoiseStatus->mode ==\n> RPiController::DenoiseMode::Off ? 0 : 1;\n> \n> Is the ternary required? Isn't\n>  (denoiseStatus->mode == RPiController::DenoiseMode::Off) sufficient?\n> \n> \n> I think you mean \"!=\" there :-)\n\nAha - Just testing ;-) hehe\n\n>  \n> \n> \n> Hrm, it's assigned to a __u32, so I guess in someways it's good to be\n> explicit.\n> \n> \n> No, this is not strictly required, but I do prefer to be explicit purely\n> as a matter of style.  Hope that is ok.\n\nThat's fine with me. Particularly as it's not storing in a boolean.\n\n> \n> Regards,\n> Naush\n> \n>  \n> \n> \n> Reviewed-by: Kieran Bingham >\n> \n> >       denoise.constant = denoiseStatus->noise_constant;\n> >       denoise.slope.num = 1000 * denoiseStatus->noise_slope;\n> >       denoise.slope.den = 1000;\n> >       denoise.strength.num = 1000 * denoiseStatus->strength;\n> >       denoise.strength.den = 1000;\n> > \n> > +     /* Set the CDN mode to match the SDN operating mode. */\n> > +     bcm2835_isp_cdn cdn;\n> > +     switch (denoiseStatus->mode) {\n> > +     case RPiController::DenoiseMode::ColourFast:\n> > +             cdn.enabled = 1;\n> > +             cdn.mode = CDN_MODE_FAST;\n> > +             break;\n> > +     case RPiController::DenoiseMode::ColourHighQuality:\n> > +             cdn.enabled = 1;\n> > +             cdn.mode = CDN_MODE_HIGH_QUALITY;\n> > +             break;\n> > +     default:\n> > +             cdn.enabled = 0;\n> > +     }\n> > +\n> >       ControlValue c(Span{ reinterpret_cast *>(&denoise),\n> >                                           sizeof(denoise) });\n> >       ctrls.set(V4L2_CID_USER_BCM2835_ISP_DENOISE, c);\n> > +\n> > +     c = ControlValue(Span{\n> reinterpret_cast(&cdn),\n> > +                                           sizeof(cdn) });\n> > +     ctrls.set(V4L2_CID_USER_BCM2835_ISP_CDN, c);\n> >  }\n> > \n> >  void IPARPi::applySharpen(const struct SharpenStatus\n> *sharpenStatus, ControlList &ctrls)\n> >\n> \n> -- \n> Regards\n> --\n> Kieran\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B1152BD808\n\tfor ;\n\tFri, 22 Jan 2021 13:17:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B48D6827A;\n\tFri, 22 Jan 2021 14:17:31 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7E34A68273\n\tfor ;\n\tFri, 22 Jan 2021 14:17:30 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 124614FB;\n\tFri, 22 Jan 2021 14:17:30 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ppKSDk+Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611321450;\n\tbh=z9QXNBdd0E+weFAYVxrMFrgR3j84YNBuxYpje/QqcJI=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=ppKSDk+Qq16OAdZdQQz8ZzwzzghzINrTHyBFahItI36WnKNiO37pMhfyfxuqNHwyG\n\tckWpUxXFOuAb05vkUUv/cliUQsHNy1M218/hbv7jMHGiAixGN34n0zWR7SrAXz4OoY\n\t645Th8zVWTY530W/qsU0EpZ80C8xnt41fffwzVO4=","To":"Naushir Patuck ","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-7-naush@raspberrypi.com>\n\t<5798d19d-4d04-1376-3000-4d226b47129d@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<7fc277ae-cb35-c76b-16c1-087c00a07fc5@ideasonboard.com>","Date":"Fri, 22 Jan 2021 13:17:27 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 6/6] ipa: raspberrypi: Handle\n\tcontrol::NoiseReductionMode in the controller","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]