[{"id":14689,"web_url":"https://patchwork.libcamera.org/comment/14689/","msgid":"","date":"2021-01-22T11:00:05","subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: raspberrypi: Rename\n\tSdnStatus to DenoiseStatus","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nThanks for this patch. No complaints from me, so:\n\nReviewed-by: David Plowman \n\nDavid\n\nOn Fri, 22 Jan 2021 at 09:25, Naushir Patuck wrote:\n>\n> This change is in anticipation of the addition of a DenoiseAlgorithm\n> base class which the SDN class will derive from. We want to match the\n> metadata object name with the base class algorithm name.\n>\n> This renames:\n> - SdnStatus metadata object to DenoiseStatus\n> - \"sdn.status\" metadata string key to \"denoise.status\"\n> - sdn_status.h header file to denoise_status.h\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> .../controller/{sdn_status.h => denoise_status.h} | 6 +++---\n> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 6 +++---\n> src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n> 3 files changed, 10 insertions(+), 10 deletions(-)\n> rename src/ipa/raspberrypi/controller/{sdn_status.h => denoise_status.h} (65%)\n>\n> diff --git a/src/ipa/raspberrypi/controller/sdn_status.h b/src/ipa/raspberrypi/controller/denoise_status.h\n> similarity index 65%\n> rename from src/ipa/raspberrypi/controller/sdn_status.h\n> rename to src/ipa/raspberrypi/controller/denoise_status.h\n> index 871e0b62af1f..06d7cfb91ae8 100644\n> --- a/src/ipa/raspberrypi/controller/sdn_status.h\n> +++ b/src/ipa/raspberrypi/controller/denoise_status.h\n> @@ -1,8 +1,8 @@\n> /* SPDX-License-Identifier: BSD-2-Clause */\n> /*\n> - * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n> + * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited\n> *\n> - * sdn_status.h - SDN (spatial denoise) control algorithm status\n> + * denoise_status.h - Spatial Denoise control algorithm status\n> */\n> #pragma once\n>\n> @@ -12,7 +12,7 @@\n> extern \"C\" {\n> #endif\n>\n> -struct SdnStatus {\n> +struct DenoiseStatus {\n> double noise_constant;\n> double noise_slope;\n> double strength;\n> diff --git a/src/ipa/raspberrypi/controller/rpi/sdn.cpp b/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> index aa82830b02b4..d8c1521a6633 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> @@ -5,8 +5,8 @@\n> * sdn.cpp - SDN (spatial denoise) control algorithm\n> */\n>\n> +#include \"../denoise_status.h\"\n> #include \"../noise_status.h\"\n> -#include \"../sdn_status.h\"\n>\n> #include \"sdn.hpp\"\n>\n> @@ -44,11 +44,11 @@ void Sdn::Prepare(Metadata *image_metadata)\n> RPI_LOG(\"Noise profile: constant \" << noise_status.noise_constant\n> << \" slope \"\n> << noise_status.noise_slope);\n> - struct SdnStatus status;\n> + struct DenoiseStatus status;\n> status.noise_constant = noise_status.noise_constant * deviation_;\n> status.noise_slope = noise_status.noise_slope * deviation_;\n> status.strength = strength_;\n> - image_metadata->Set(\"sdn.status\", status);\n> + image_metadata->Set(\"denoise.status\", status);\n> RPI_LOG(\"Sdn: programmed constant \" << status.noise_constant\n> << \" slope \" << status.noise_slope\n> << \" strength \"\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 5ccc7a6551f5..220cf174aa4f 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -43,13 +43,13 @@\n> #include \"contrast_algorithm.hpp\"\n> #include \"contrast_status.h\"\n> #include \"controller.hpp\"\n> +#include \"denoise_status.h\"\n> #include \"dpc_status.h\"\n> #include \"focus_status.h\"\n> #include \"geq_status.h\"\n> #include \"lux_status.h\"\n> #include \"metadata.hpp\"\n> #include \"noise_status.h\"\n> -#include \"sdn_status.h\"\n> #include \"sharpen_algorithm.hpp\"\n> #include \"sharpen_status.h\"\n>\n> @@ -109,7 +109,7 @@ private:\n> void applyBlackLevel(const struct BlackLevelStatus *blackLevelStatus, ControlList &ctrls);\n> void applyGamma(const struct ContrastStatus *contrastStatus, ControlList &ctrls);\n> void applyGEQ(const struct GeqStatus *geqStatus, ControlList &ctrls);\n> - void applyDenoise(const struct SdnStatus *denoiseStatus, ControlList &ctrls);\n> + void applyDenoise(const struct DenoiseStatus *denoiseStatus, ControlList &ctrls);\n> void applySharpen(const struct SharpenStatus *sharpenStatus, ControlList &ctrls);\n> void applyDPC(const struct DpcStatus *dpcStatus, ControlList &ctrls);\n> void applyLS(const struct AlscStatus *lsStatus, ControlList &ctrls);\n> @@ -899,7 +899,7 @@ void IPARPi::prepareISP(unsigned int bufferId)\n> if (geqStatus)\n> applyGEQ(geqStatus, ctrls);\n>\n> - SdnStatus *denoiseStatus = rpiMetadata_.GetLocked(\"sdn.status\");\n> + DenoiseStatus *denoiseStatus = rpiMetadata_.GetLocked(\"denoise.status\");\n> if (denoiseStatus)\n> applyDenoise(denoiseStatus, ctrls);\n>\n> @@ -1083,7 +1083,7 @@ void IPARPi::applyGEQ(const struct GeqStatus *geqStatus, ControlList &ctrls)\n> ctrls.set(V4L2_CID_USER_BCM2835_ISP_GEQ, c);\n> }\n>\n> -void IPARPi::applyDenoise(const struct SdnStatus *denoiseStatus, ControlList &ctrls)\n> +void IPARPi::applyDenoise(const struct DenoiseStatus *denoiseStatus, ControlList &ctrls)\n> {\n> bcm2835_isp_denoise denoise;\n>\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A69FCBD808\n\tfor ;\n\tFri, 22 Jan 2021 11:00:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C9D16823F;\n\tFri, 22 Jan 2021 12:00:18 +0100 (CET)","from mail-oi1-x233.google.com (mail-oi1-x233.google.com\n\t[IPv6:2607:f8b0:4864:20::233])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 69CF1681D8\n\tfor ;\n\tFri, 22 Jan 2021 12:00:17 +0100 (CET)","by mail-oi1-x233.google.com with SMTP id 9so5565692oiq.3\n\tfor ;\n\tFri, 22 Jan 2021 03:00:17 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"FnQpXqSG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=kARzHzI/qlpyJvwNuFf1XZNM44Rnopu3be8xAgShM/c=;\n\tb=FnQpXqSGi252vW23CSRWeBPqYQrKQUfLpzzq1AY2skKx94jdPQAai1D5U0uRO7a+W3\n\tDICi/O08Q7xiWDfUAYxEy8RLjKU4AU5PvgmfBgp7KFstadJnXLNBgRy9PODjB6lQpuVk\n\tSZx6HORM6aagzdvcmgtp6gcip+DQQQ2/5rP0eNXPQUjcsidXw4tWCl4ns34FMU8O6c7q\n\tRlm10SPdTLTJaDuS7Yce8PzgCEEhmgRhuhJalQuE43mJwwmxdVJimm68XCL1JzWBzS9N\n\t4EMBXoLE8fV9Ya3TN/4sePSLGzXx0k81YypIB2FWPi/bfexAzJiGQu05TZp3Lia3KFu5\n\toWfw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=kARzHzI/qlpyJvwNuFf1XZNM44Rnopu3be8xAgShM/c=;\n\tb=Ewyuefq+sVGfroULprlqj0nG+Thi4KTq4ncg8ALwXx9iS/TYa8XEQF9Yoe2/JrLi8R\n\tZyIlyLXVRJ6GFdDxujRSbTOIvNIkD8U/y2Xo/nTVJRWPab6YDydo4GiFNUgKJAd5/HbR\n\tSipZhOY0rgsn/tbbKRP00f1FOA1Im7T8u2NaEBkM/XWcLiE2ppXK4G+UVu9o9/KBpuu1\n\tnCTK2jqtaVN1tfptHxKiSUx1sNLV250GZ2I9zAt9cd3rsedp0m2IW1gdNKeskog73fJb\n\t07Cp+LsHTsxjEgEx3ShX5GRzjVUSmYWFtXJyyryKrIP+S0xzcjjAWKjcn4KdA89Y81d9\n\tWv6w==","X-Gm-Message-State":"AOAM533o009jQcg6JkO9SDzNCAUTV4P42jnt+ErF5BvwdKe1sBLi+EVC\n\tzkRKT7WFLuZDNrtui81Bqe++mauZgaZFXVVYaJ/onQ==","X-Google-Smtp-Source":"ABdhPJyzsgCSqatr05NTqzvyCWTkrFtvphzBqsKUeV8Vk6lxY8p2pZ0pfP4Of3c5JzfNKJrvIegM1QM5HU9axJjvP+k=","X-Received":"by 2002:aca:5c0a:: with SMTP id q10mr2873912oib.55.1611313216399;\n\tFri, 22 Jan 2021 03:00:16 -0800 (PST)","MIME-Version":"1.0","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-5-naush@raspberrypi.com>","In-Reply-To":"<20210122092537.708375-5-naush@raspberrypi.com>","From":"David Plowman ","Date":"Fri, 22 Jan 2021 11:00:05 +0000","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: raspberrypi: Rename\n\tSdnStatus to DenoiseStatus","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14693,"web_url":"https://patchwork.libcamera.org/comment/14693/","msgid":"<043c48b2-f2ce-0a6d-84d5-4d33621c6228@ideasonboard.com>","date":"2021-01-22T11:46:16","subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: raspberrypi: Rename\n\tSdnStatus to DenoiseStatus","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 22/01/2021 09:25, Naushir Patuck wrote:\n> This change is in anticipation of the addition of a DenoiseAlgorithm\n> base class which the SDN class will derive from. We want to match the\n> metadata object name with the base class algorithm name.\n> \n> This renames:\n> - SdnStatus metadata object to DenoiseStatus\n> - \"sdn.status\" metadata string key to \"denoise.status\"\n> - sdn_status.h header file to denoise_status.h\n> \n> Signed-off-by: Naushir Patuck \n> ---\n> .../controller/{sdn_status.h => denoise_status.h} | 6 +++---\n> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 6 +++---\n> src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n> 3 files changed, 10 insertions(+), 10 deletions(-)\n> rename src/ipa/raspberrypi/controller/{sdn_status.h => denoise_status.h} (65%)\n> \n> diff --git a/src/ipa/raspberrypi/controller/sdn_status.h b/src/ipa/raspberrypi/controller/denoise_status.h\n> similarity index 65%\n> rename from src/ipa/raspberrypi/controller/sdn_status.h\n> rename to src/ipa/raspberrypi/controller/denoise_status.h\n> index 871e0b62af1f..06d7cfb91ae8 100644\n> --- a/src/ipa/raspberrypi/controller/sdn_status.h\n> +++ b/src/ipa/raspberrypi/controller/denoise_status.h\n> @@ -1,8 +1,8 @@\n> /* SPDX-License-Identifier: BSD-2-Clause */\n> /*\n> - * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n> + * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited\n> *\n> - * sdn_status.h - SDN (spatial denoise) control algorithm status\n> + * denoise_status.h - Spatial Denoise control algorithm status\n> */\n> #pragma once\n> \n> @@ -12,7 +12,7 @@\n> extern \"C\" {\n> #endif\n> \n> -struct SdnStatus {\n> +struct DenoiseStatus {\n> \tdouble noise_constant;\n> \tdouble noise_slope;\n> \tdouble strength;\n> diff --git a/src/ipa/raspberrypi/controller/rpi/sdn.cpp b/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n\nThis is just the status rename then, so I guess no need to do a full\nrename of all SDN->denoise?\n\nAnyway, it's just a query.\n\nReviewed-by: Kieran Bingham \n\n\n> index aa82830b02b4..d8c1521a6633 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> @@ -5,8 +5,8 @@\n> * sdn.cpp - SDN (spatial denoise) control algorithm\n> */\n> \n> +#include \"../denoise_status.h\"\n> #include \"../noise_status.h\"\n> -#include \"../sdn_status.h\"\n> \n> #include \"sdn.hpp\"\n> \n> @@ -44,11 +44,11 @@ void Sdn::Prepare(Metadata *image_metadata)\n> \tRPI_LOG(\"Noise profile: constant \" << noise_status.noise_constant\n> \t\t\t\t\t << \" slope \"\n> \t\t\t\t\t << noise_status.noise_slope);\n> -\tstruct SdnStatus status;\n> +\tstruct DenoiseStatus status;\n> \tstatus.noise_constant = noise_status.noise_constant * deviation_;\n> \tstatus.noise_slope = noise_status.noise_slope * deviation_;\n> \tstatus.strength = strength_;\n> -\timage_metadata->Set(\"sdn.status\", status);\n> +\timage_metadata->Set(\"denoise.status\", status);\n> \tRPI_LOG(\"Sdn: programmed constant \" << status.noise_constant\n> \t\t\t\t\t << \" slope \" << status.noise_slope\n> \t\t\t\t\t << \" strength \"\n> diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\n> index 5ccc7a6551f5..220cf174aa4f 100644\n> --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> @@ -43,13 +43,13 @@\n> #include \"contrast_algorithm.hpp\"\n> #include \"contrast_status.h\"\n> #include \"controller.hpp\"\n> +#include \"denoise_status.h\"\n> #include \"dpc_status.h\"\n> #include \"focus_status.h\"\n> #include \"geq_status.h\"\n> #include \"lux_status.h\"\n> #include \"metadata.hpp\"\n> #include \"noise_status.h\"\n> -#include \"sdn_status.h\"\n> #include \"sharpen_algorithm.hpp\"\n> #include \"sharpen_status.h\"\n> \n> @@ -109,7 +109,7 @@ private:\n> \tvoid applyBlackLevel(const struct BlackLevelStatus *blackLevelStatus, ControlList &ctrls);\n> \tvoid applyGamma(const struct ContrastStatus *contrastStatus, ControlList &ctrls);\n> \tvoid applyGEQ(const struct GeqStatus *geqStatus, ControlList &ctrls);\n> -\tvoid applyDenoise(const struct SdnStatus *denoiseStatus, ControlList &ctrls);\n> +\tvoid applyDenoise(const struct DenoiseStatus *denoiseStatus, ControlList &ctrls);\n> \tvoid applySharpen(const struct SharpenStatus *sharpenStatus, ControlList &ctrls);\n> \tvoid applyDPC(const struct DpcStatus *dpcStatus, ControlList &ctrls);\n> \tvoid applyLS(const struct AlscStatus *lsStatus, ControlList &ctrls);\n> @@ -899,7 +899,7 @@ void IPARPi::prepareISP(unsigned int bufferId)\n> \t\tif (geqStatus)\n> \t\t\tapplyGEQ(geqStatus, ctrls);\n> \n> -\t\tSdnStatus *denoiseStatus = rpiMetadata_.GetLocked(\"sdn.status\");\n> +\t\tDenoiseStatus *denoiseStatus = rpiMetadata_.GetLocked(\"denoise.status\");\n> \t\tif (denoiseStatus)\n> \t\t\tapplyDenoise(denoiseStatus, ctrls);\n> \n> @@ -1083,7 +1083,7 @@ void IPARPi::applyGEQ(const struct GeqStatus *geqStatus, ControlList &ctrls)\n> \tctrls.set(V4L2_CID_USER_BCM2835_ISP_GEQ, c);\n> }\n> \n> -void IPARPi::applyDenoise(const struct SdnStatus *denoiseStatus, ControlList &ctrls)\n> +void IPARPi::applyDenoise(const struct DenoiseStatus *denoiseStatus, ControlList &ctrls)\n> {\n> \tbcm2835_isp_denoise denoise;\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2EE15BD808\n\tfor ;\n\tFri, 22 Jan 2021 11:46:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8FC7868240;\n\tFri, 22 Jan 2021 12:46:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33FCC681D8\n\tfor ;\n\tFri, 22 Jan 2021 12:46:20 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 913D24FB;\n\tFri, 22 Jan 2021 12:46:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dJOz+9+Z\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611315979;\n\tbh=q1gbPbGYLLP+ufOZwb7BIytfCRTQYT9LVPHvqUGm+58=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=dJOz+9+ZSlR3McyO/mTdeEmum1vIcRD6o97yZClCvmvGWIm/NeOL7WQw3nvHKNvUv\n\tv45fLEZlTgkYzP/9E2pAjmJwhSxJdSnRrNjyWDBGRTFfKn8DZ6MMGz/26LCount4oH\n\t9bFLn6oXDYYqVxKb7XCyU6Xkisb0eIfLscB/hGP8=","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-5-naush@raspberrypi.com>","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"<043c48b2-f2ce-0a6d-84d5-4d33621c6228@ideasonboard.com>","Date":"Fri, 22 Jan 2021 11:46:16 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"<20210122092537.708375-5-naush@raspberrypi.com>","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: raspberrypi: Rename\n\tSdnStatus to DenoiseStatus","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14699,"web_url":"https://patchwork.libcamera.org/comment/14699/","msgid":"","date":"2021-01-22T12:02:52","subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: raspberrypi: Rename\n\tSdnStatus to DenoiseStatus","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Kieran,\n\nThank you for your review feedback.\n\nOn Fri, 22 Jan 2021 at 11:46, Kieran Bingham <\nkieran.bingham@ideasonboard.com> wrote:\n\n> Hi Naush,\n>\n> On 22/01/2021 09:25, Naushir Patuck wrote:\n> > This change is in anticipation of the addition of a DenoiseAlgorithm\n> > base class which the SDN class will derive from. We want to match the\n> > metadata object name with the base class algorithm name.\n> >\n> > This renames:\n> > - SdnStatus metadata object to DenoiseStatus\n> > - \"sdn.status\" metadata string key to \"denoise.status\"\n> > - sdn_status.h header file to denoise_status.h\n> >\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > .../controller/{sdn_status.h => denoise_status.h} | 6 +++---\n> > src/ipa/raspberrypi/controller/rpi/sdn.cpp | 6 +++---\n> > src/ipa/raspberrypi/raspberrypi.cpp | 8 ++++----\n> > 3 files changed, 10 insertions(+), 10 deletions(-)\n> > rename src/ipa/raspberrypi/controller/{sdn_status.h =>\n> denoise_status.h} (65%)\n> >\n> > diff --git a/src/ipa/raspberrypi/controller/sdn_status.h\n> b/src/ipa/raspberrypi/controller/denoise_status.h\n> > similarity index 65%\n> > rename from src/ipa/raspberrypi/controller/sdn_status.h\n> > rename to src/ipa/raspberrypi/controller/denoise_status.h\n> > index 871e0b62af1f..06d7cfb91ae8 100644\n> > --- a/src/ipa/raspberrypi/controller/sdn_status.h\n> > +++ b/src/ipa/raspberrypi/controller/denoise_status.h\n> > @@ -1,8 +1,8 @@\n> > /* SPDX-License-Identifier: BSD-2-Clause */\n> > /*\n> > - * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n> > + * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited\n> > *\n> > - * sdn_status.h - SDN (spatial denoise) control algorithm status\n> > + * denoise_status.h - Spatial Denoise control algorithm status\n> > */\n> > #pragma once\n> >\n> > @@ -12,7 +12,7 @@\n> > extern \"C\" {\n> > #endif\n> >\n> > -struct SdnStatus {\n> > +struct DenoiseStatus {\n> > double noise_constant;\n> > double noise_slope;\n> > double strength;\n> > diff --git a/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> b/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n>\n> This is just the status rename then, so I guess no need to do a full\n> rename of all SDN->denoise?\n>\n> Anyway, it's just a query.\n>\n\nNo, we do not want a wholesale rename. David and I did discuss this\nseparately. The goal is to mach the name \"Denoise\" with the\n\"DenoiseAlgorithm\" class in the next patch set. SDN as a controller is\ncurrently the only derived denoise controller, but that may not be the case\nin the future, if that makes sense?\n\nRegards,\nNaush\n\n\n\n>\n> Reviewed-by: Kieran Bingham \n>\n>\n> > index aa82830b02b4..d8c1521a6633 100644\n> > --- a/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> > +++ b/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> > @@ -5,8 +5,8 @@\n> > * sdn.cpp - SDN (spatial denoise) control algorithm\n> > */\n> >\n> > +#include \"../denoise_status.h\"\n> > #include \"../noise_status.h\"\n> > -#include \"../sdn_status.h\"\n> >\n> > #include \"sdn.hpp\"\n> >\n> > @@ -44,11 +44,11 @@ void Sdn::Prepare(Metadata *image_metadata)\n> > RPI_LOG(\"Noise profile: constant \" << noise_status.noise_constant\n> > << \" slope \"\n> > << noise_status.noise_slope);\n> > - struct SdnStatus status;\n> > + struct DenoiseStatus status;\n> > status.noise_constant = noise_status.noise_constant * deviation_;\n> > status.noise_slope = noise_status.noise_slope * deviation_;\n> > status.strength = strength_;\n> > - image_metadata->Set(\"sdn.status\", status);\n> > + image_metadata->Set(\"denoise.status\", status);\n> > RPI_LOG(\"Sdn: programmed constant \" << status.noise_constant\n> > << \" slope \" <<\n> status.noise_slope\n> > << \" strength \"\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 5ccc7a6551f5..220cf174aa4f 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -43,13 +43,13 @@\n> > #include \"contrast_algorithm.hpp\"\n> > #include \"contrast_status.h\"\n> > #include \"controller.hpp\"\n> > +#include \"denoise_status.h\"\n> > #include \"dpc_status.h\"\n> > #include \"focus_status.h\"\n> > #include \"geq_status.h\"\n> > #include \"lux_status.h\"\n> > #include \"metadata.hpp\"\n> > #include \"noise_status.h\"\n> > -#include \"sdn_status.h\"\n> > #include \"sharpen_algorithm.hpp\"\n> > #include \"sharpen_status.h\"\n> >\n> > @@ -109,7 +109,7 @@ private:\n> > void applyBlackLevel(const struct BlackLevelStatus\n> *blackLevelStatus, ControlList &ctrls);\n> > void applyGamma(const struct ContrastStatus *contrastStatus,\n> ControlList &ctrls);\n> > void applyGEQ(const struct GeqStatus *geqStatus, ControlList\n> &ctrls);\n> > - void applyDenoise(const struct SdnStatus *denoiseStatus,\n> ControlList &ctrls);\n> > + void applyDenoise(const struct DenoiseStatus *denoiseStatus,\n> ControlList &ctrls);\n> > void applySharpen(const struct SharpenStatus *sharpenStatus,\n> ControlList &ctrls);\n> > void applyDPC(const struct DpcStatus *dpcStatus, ControlList\n> &ctrls);\n> > void applyLS(const struct AlscStatus *lsStatus, ControlList\n> &ctrls);\n> > @@ -899,7 +899,7 @@ void IPARPi::prepareISP(unsigned int bufferId)\n> > if (geqStatus)\n> > applyGEQ(geqStatus, ctrls);\n> >\n> > - SdnStatus *denoiseStatus =\n> rpiMetadata_.GetLocked(\"sdn.status\");\n> > + DenoiseStatus *denoiseStatus =\n> rpiMetadata_.GetLocked(\"denoise.status\");\n> > if (denoiseStatus)\n> > applyDenoise(denoiseStatus, ctrls);\n> >\n> > @@ -1083,7 +1083,7 @@ void IPARPi::applyGEQ(const struct GeqStatus\n> *geqStatus, ControlList &ctrls)\n> > ctrls.set(V4L2_CID_USER_BCM2835_ISP_GEQ, c);\n> > }\n> >\n> > -void IPARPi::applyDenoise(const struct SdnStatus *denoiseStatus,\n> ControlList &ctrls)\n> > +void IPARPi::applyDenoise(const struct DenoiseStatus *denoiseStatus,\n> ControlList &ctrls)\n> > {\n> > bcm2835_isp_denoise denoise;\n> >\n> >\n>\n> --\n> Regards\n> --\n> Kieran\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B549C0F2A\n\tfor ;\n\tFri, 22 Jan 2021 12:03:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09EEA6824C;\n\tFri, 22 Jan 2021 13:03:11 +0100 (CET)","from mail-lf1-x135.google.com (mail-lf1-x135.google.com\n\t[IPv6:2a00:1450:4864:20::135])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5CB0C6824C\n\tfor ;\n\tFri, 22 Jan 2021 13:03:09 +0100 (CET)","by mail-lf1-x135.google.com with SMTP id u25so7207747lfc.2\n\tfor ;\n\tFri, 22 Jan 2021 04:03:09 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"bPHCFwsF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=e3VsxKAv4u217rosTcDPCtgucuLYewbIcsNlZz4a06o=;\n\tb=bPHCFwsFNnsrMEDaTk9guFgOFSnlUU4aQ9bBu2nLF2Cn1tCYqasCa1c8P7GbpJirwX\n\tWIRUP1tFkvEwo2EIzAeIY4zRYk2LMnWQMuWXFtSxiTDmZ/Jz9Xq8K6Lrkh+O5SGI+g/5\n\tWJe+t5uvTQm1ppNE4S7V4lsZp7Z7w622AxvQJEUzCn0EdhKSYYhsiSoSAl2wZYzQO+tO\n\tKBKeBpTvihWg2P5X7u+IH9MCbXApg5TqYsjScsBvZAXqkqwCJWiZoA6F+IHfYJI+/Hi5\n\tTElq4SCxK1RoWhKrBNj3gOsJyRp8DihxbZ047Jne2HVKvWigmASpH5PGzsxe+ExkDG80\n\t4DVw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=e3VsxKAv4u217rosTcDPCtgucuLYewbIcsNlZz4a06o=;\n\tb=DCsfzi4sT5oc1dcIO1TpCrGKnoYRFTmSMLhJ5nXr1T7Tt8XyGDYVkKaqyyfiSuK7+f\n\tMksit46ZiXi52D/3IqXf8LW7Yd+A8vtfDO8GrBcnOImNWcZmhjO22hjaWenSlyQJP3F6\n\thda2Qi4oe7vn28tdibmZKSYXgiJBFtz7Z+RKABxtxW9LEoVqRSB1EjgsX6o+3h1pSD/l\n\tOiRnNzdpyAYmowYGG7YK7lRuQHY/R7aRkGI6Nq8wIj+16VR05zW6XiqwMwCMebSihgZ1\n\tYj28Oo0ybEjNb6HVeSQ7MkZRD0PfZlfkQd1axMBtT263KBJi8Rt/tzU9MSYwQg2usGDT\n\tG3UQ==","X-Gm-Message-State":"AOAM530c0e4Anpe5Lc1rKhTlJnIj2yn19dHnqb4ZFTnFt8Lq6S5+SnJy\n\tCNkEhVFkWYFcGc7r+pSgDYniXulDdu7cGq/C4kYHZQ==","X-Google-Smtp-Source":"ABdhPJwkMSr+N+gi8juDDljmK7JAGlfKAybPlUTCAe8HUEBq4+tHQILUwwLXQxFUaDC/00abwyzd3e2KXRm8IPjvgtA=","X-Received":"by 2002:ac2:4daa:: with SMTP id h10mr27366lfe.617.1611316988818; \n\tFri, 22 Jan 2021 04:03:08 -0800 (PST)","MIME-Version":"1.0","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-5-naush@raspberrypi.com>\n\t<043c48b2-f2ce-0a6d-84d5-4d33621c6228@ideasonboard.com>","In-Reply-To":"<043c48b2-f2ce-0a6d-84d5-4d33621c6228@ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 22 Jan 2021 12:02:52 +0000","Message-ID":"","To":"Kieran Bingham ","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: raspberrypi: Rename\n\tSdnStatus to DenoiseStatus","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"multipart/mixed;\n\tboundary=\"===============6957247700658850371==\"","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":14701,"web_url":"https://patchwork.libcamera.org/comment/14701/","msgid":"","date":"2021-01-22T12:04:17","subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: raspberrypi: Rename\n\tSdnStatus to DenoiseStatus","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Naush,\n\nOn 22/01/2021 12:02, Naushir Patuck wrote:\n> Hi Kieran,\n> \n> Thank you for your review feedback.\n> \n> On Fri, 22 Jan 2021 at 11:46, Kieran Bingham\n> > wrote:\n> \n> Hi Naush,\n> \n> On 22/01/2021 09:25, Naushir Patuck wrote:\n> > This change is in anticipation of the addition of a DenoiseAlgorithm\n> > base class which the SDN class will derive from. We want to match the\n> > metadata object name with the base class algorithm name.\n> >\n> > This renames:\n> > - SdnStatus metadata object to DenoiseStatus\n> > - \"sdn.status\" metadata string key to \"denoise.status\"\n> > - sdn_status.h header file to denoise_status.h\n> >\n> > Signed-off-by: Naushir Patuck >\n> > ---\n> >  .../controller/{sdn_status.h => denoise_status.h}         | 6 +++---\n> >  src/ipa/raspberrypi/controller/rpi/sdn.cpp                | 6 +++---\n> >  src/ipa/raspberrypi/raspberrypi.cpp                       | 8\n> ++++----\n> >  3 files changed, 10 insertions(+), 10 deletions(-)\n> >  rename src/ipa/raspberrypi/controller/{sdn_status.h =>\n> denoise_status.h} (65%)\n> >\n> > diff --git a/src/ipa/raspberrypi/controller/sdn_status.h\n> b/src/ipa/raspberrypi/controller/denoise_status.h\n> > similarity index 65%\n> > rename from src/ipa/raspberrypi/controller/sdn_status.h\n> > rename to src/ipa/raspberrypi/controller/denoise_status.h\n> > index 871e0b62af1f..06d7cfb91ae8 100644\n> > --- a/src/ipa/raspberrypi/controller/sdn_status.h\n> > +++ b/src/ipa/raspberrypi/controller/denoise_status.h\n> > @@ -1,8 +1,8 @@\n> >  /* SPDX-License-Identifier: BSD-2-Clause */\n> >  /*\n> > - * Copyright (C) 2019, Raspberry Pi (Trading) Limited\n> > + * Copyright (C) 2019-2021, Raspberry Pi (Trading) Limited\n> >   *\n> > - * sdn_status.h - SDN (spatial denoise) control algorithm status\n> > + * denoise_status.h - Spatial Denoise control algorithm status\n> >   */\n> >  #pragma once\n> > \n> > @@ -12,7 +12,7 @@\n> >  extern \"C\" {\n> >  #endif\n> > \n> > -struct SdnStatus {\n> > +struct DenoiseStatus {\n> >       double noise_constant;\n> >       double noise_slope;\n> >       double strength;\n> > diff --git a/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> b/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> \n> This is just the status rename then, so I guess no need to do a full\n> rename of all SDN->denoise?\n> \n> Anyway, it's just a query.\n> \n> \n> No, we do not want a wholesale rename.  David and I did discuss this\n> separately.  The goal is to mach the name \"Denoise\" with the\n> \"DenoiseAlgorithm\" class in the next patch set.  SDN as a controller is\n> currently the only derived denoise controller, but that may not be the\n> case in the future, if that makes sense?\n\nCertainly, no worries there.\n--\nKieran\n\n\n> \n> Regards,\n> Naush\n> \n>  \n> \n> \n> Reviewed-by: Kieran Bingham >\n> \n> \n> > index aa82830b02b4..d8c1521a6633 100644\n> > --- a/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> > +++ b/src/ipa/raspberrypi/controller/rpi/sdn.cpp\n> > @@ -5,8 +5,8 @@\n> >   * sdn.cpp - SDN (spatial denoise) control algorithm\n> >   */\n> > \n> > +#include \"../denoise_status.h\"\n> >  #include \"../noise_status.h\"\n> > -#include \"../sdn_status.h\"\n> > \n> >  #include \"sdn.hpp\"\n> > \n> > @@ -44,11 +44,11 @@ void Sdn::Prepare(Metadata *image_metadata)\n> >       RPI_LOG(\"Noise profile: constant \" <<\n> noise_status.noise_constant\n> >                                          << \" slope \"\n> >                                          << noise_status.noise_slope);\n> > -     struct SdnStatus status;\n> > +     struct DenoiseStatus status;\n> >       status.noise_constant = noise_status.noise_constant *\n> deviation_;\n> >       status.noise_slope = noise_status.noise_slope * deviation_;\n> >       status.strength = strength_;\n> > -     image_metadata->Set(\"sdn.status\", status);\n> > +     image_metadata->Set(\"denoise.status\", status);\n> >       RPI_LOG(\"Sdn: programmed constant \" << status.noise_constant\n> >                                           << \" slope \" <<\n> status.noise_slope\n> >                                           << \" strength \"\n> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp\n> b/src/ipa/raspberrypi/raspberrypi.cpp\n> > index 5ccc7a6551f5..220cf174aa4f 100644\n> > --- a/src/ipa/raspberrypi/raspberrypi.cpp\n> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp\n> > @@ -43,13 +43,13 @@\n> >  #include \"contrast_algorithm.hpp\"\n> >  #include \"contrast_status.h\"\n> >  #include \"controller.hpp\"\n> > +#include \"denoise_status.h\"\n> >  #include \"dpc_status.h\"\n> >  #include \"focus_status.h\"\n> >  #include \"geq_status.h\"\n> >  #include \"lux_status.h\"\n> >  #include \"metadata.hpp\"\n> >  #include \"noise_status.h\"\n> > -#include \"sdn_status.h\"\n> >  #include \"sharpen_algorithm.hpp\"\n> >  #include \"sharpen_status.h\"\n> > \n> > @@ -109,7 +109,7 @@ private:\n> >       void applyBlackLevel(const struct BlackLevelStatus\n> *blackLevelStatus, ControlList &ctrls);\n> >       void applyGamma(const struct ContrastStatus *contrastStatus,\n> ControlList &ctrls);\n> >       void applyGEQ(const struct GeqStatus *geqStatus, ControlList\n> &ctrls);\n> > -     void applyDenoise(const struct SdnStatus *denoiseStatus,\n> ControlList &ctrls);\n> > +     void applyDenoise(const struct DenoiseStatus *denoiseStatus,\n> ControlList &ctrls);\n> >       void applySharpen(const struct SharpenStatus *sharpenStatus,\n> ControlList &ctrls);\n> >       void applyDPC(const struct DpcStatus *dpcStatus, ControlList\n> &ctrls);\n> >       void applyLS(const struct AlscStatus *lsStatus, ControlList\n> &ctrls);\n> > @@ -899,7 +899,7 @@ void IPARPi::prepareISP(unsigned int bufferId)\n> >               if (geqStatus)\n> >                       applyGEQ(geqStatus, ctrls);\n> > \n> > -             SdnStatus *denoiseStatus =\n> rpiMetadata_.GetLocked(\"sdn.status\");\n> > +             DenoiseStatus *denoiseStatus =\n> rpiMetadata_.GetLocked(\"denoise.status\");\n> >               if (denoiseStatus)\n> >                       applyDenoise(denoiseStatus, ctrls);\n> > \n> > @@ -1083,7 +1083,7 @@ void IPARPi::applyGEQ(const struct GeqStatus\n> *geqStatus, ControlList &ctrls)\n> >       ctrls.set(V4L2_CID_USER_BCM2835_ISP_GEQ, c);\n> >  }\n> > \n> > -void IPARPi::applyDenoise(const struct SdnStatus *denoiseStatus,\n> ControlList &ctrls)\n> > +void IPARPi::applyDenoise(const struct DenoiseStatus\n> *denoiseStatus, ControlList &ctrls)\n> >  {\n> >       bcm2835_isp_denoise denoise;\n> > \n> >\n> \n> -- \n> Regards\n> --\n> Kieran\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 39A04C0F2A\n\tfor ;\n\tFri, 22 Jan 2021 12:04:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 098D56825E;\n\tFri, 22 Jan 2021 13:04:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF3376825B\n\tfor ;\n\tFri, 22 Jan 2021 13:04:19 +0100 (CET)","from [192.168.0.20]\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 618224FB;\n\tFri, 22 Jan 2021 13:04:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qw6C07Z7\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611317059;\n\tbh=hXE5mdDj5QNl+XaoDYUM6Cpth2iKW+YwVdcidwyng9I=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=qw6C07Z7vaE2TbEQFjjJCdOnkDmZAidTA5WuUd86FlM+tP67LFoLEJS8+zl4FAXsx\n\tBqE/+2WH7OlKwbu+IaU0rlM+dk1vNIF6IVVpfS/3JY7JFg2LCBz3MQhdwWLqXSRa/c\n\tB3ZbyqS6N//ysi3eUEnXF6SwX8gZ4kdZH2JNLnqw=","To":"Naushir Patuck ","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-5-naush@raspberrypi.com>\n\t<043c48b2-f2ce-0a6d-84d5-4d33621c6228@ideasonboard.com>\n\t","From":"Kieran Bingham ","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCPAQYAQoAJgIbDBYhBJAt15g/\n\tvSj943LUeqEeRnIQpGH9BQJdizzIBQkLSKZiAAoJEKEeRnIQpGH9eYgQAJpjaWNgqNOnMTmD\n\tMJggbwjIotypzIXfhHNCeTkG7+qCDlSaBPclcPGYrTwCt0YWPU2TgGgJrVhYT20ierN8LUvj\n\t6qOPTd+Uk7NFzL65qkh80ZKNBFddx1AabQpSVQKbdcLb8OFs85kuSvFdgqZwgxA1vl4TFhNz\n\tPZ79NAmXLackAx3sOVFhk4WQaKRshCB7cSl+RIng5S/ThOBlwNlcKG7j7W2MC06BlTbdEkUp\n\tECzuuRBv8wX4OQl+hbWbB/VKIx5HKlLu1eypen/5lNVzSqMMIYkkZcjV2SWQyUGxSwq0O/sx\n\tS0A8/atCHUXOboUsn54qdxrVDaK+6jIAuo8JiRWctP16KjzUM7MO0/+4zllM8EY57rXrj48j\n\tsbEYX0YQnzaj+jO6kJtoZsIaYR7rMMq9aUAjyiaEZpmP1qF/2sYenDx0Fg2BSlLvLvXM0vU8\n\tpQk3kgDu7kb/7PRYrZvBsr21EIQoIjXbZxDz/o7z95frkP71EaICttZ6k9q5oxxA5WC6sTXc\n\tMW8zs8avFNuA9VpXt0YupJd2ijtZy2mpZNG02fFVXhIn4G807G7+9mhuC4XG5rKlBBUXTvPU\n\tAfYnB4JBDLmLzBFavQfvonSfbitgXwCG3vS+9HEwAjU30Bar1PEOmIbiAoMzuKeRm2LVpmq4\n\tWZw01QYHU/GUV/zHJSFk","Organization":"Ideas on Board","Message-ID":"","Date":"Fri, 22 Jan 2021 12:04:17 +0000","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101\n\tThunderbird/68.10.0","MIME-Version":"1.0","In-Reply-To":"","Content-Language":"en-GB","Subject":"Re: [libcamera-devel] [PATCH v2 4/6] ipa: raspberrypi: Rename\n\tSdnStatus to DenoiseStatus","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Reply-To":"kieran.bingham@ideasonboard.com","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]