[{"id":14688,"web_url":"https://patchwork.libcamera.org/comment/14688/","msgid":"","date":"2021-01-22T10:55:28","subject":"Re: [libcamera-devel] [PATCH v2 3/6] uapi: raspberrypi: Update the\n\tbcm2835-isp header definition","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi Naush\n\nI thought I'd already added a tag, but maybe I forgot. Anyway:\n\nReviewed-by: David Plowman \n\nThanks!\nDavid\n\nOn Fri, 22 Jan 2021 at 09:25, Naushir Patuck wrote:\n>\n> Update the bcm2835-isp.h file with the latest version available in the\n> downstream Raspberry Pi linux repo.\n>\n> This change adds support for colour denoise processing, and the\n> following downstream kernel changes must be available:\n> https://github.com/raspberrypi/linux/pull/4069\n> https://github.com/raspberrypi/linux/pull/4083\n>\n> The Raspberry Pi image must also be running the latest firmware,\n> obtained by running rpi-update.\n>\n> Signed-off-by: Naushir Patuck \n> Acked-by: Kieran Bingham \n> ---\n> include/linux/bcm2835-isp.h | 32 +++++++++++++++++++++++++++++---\n> 1 file changed, 29 insertions(+), 3 deletions(-)\n>\n> diff --git a/include/linux/bcm2835-isp.h b/include/linux/bcm2835-isp.h\n> index 45abb681517e..94c3af947883 100644\n> --- a/include/linux/bcm2835-isp.h\n> +++ b/include/linux/bcm2835-isp.h\n> @@ -31,7 +31,8 @@\n> (V4L2_CID_USER_BCM2835_ISP_BASE + 0x0007)\n> #define V4L2_CID_USER_BCM2835_ISP_DPC \\\n> (V4L2_CID_USER_BCM2835_ISP_BASE + 0x0008)\n> -\n> +#define V4L2_CID_USER_BCM2835_ISP_CDN \\\n> + (V4L2_CID_USER_BCM2835_ISP_BASE + 0x0009)\n> /*\n> * All structs below are directly mapped onto the equivalent structs in\n> * drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h\n> @@ -46,7 +47,7 @@\n> */\n> struct bcm2835_isp_rational {\n> __s32 num;\n> - __s32 den;\n> + __u32 den;\n> };\n>\n> /**\n> @@ -140,7 +141,7 @@ struct bcm2835_isp_black_level {\n> __u16 black_level_r;\n> __u16 black_level_g;\n> __u16 black_level_b;\n> - __u8 pad_[2]; /* Unused */\n> + __u8 padding[2]; /* Unused */\n> };\n>\n> /**\n> @@ -175,6 +176,31 @@ struct bcm2835_isp_gamma {\n> __u16 y[BCM2835_NUM_GAMMA_PTS];\n> };\n>\n> +/**\n> + * enum bcm2835_isp_cdn_mode - Mode of operation for colour denoise.\n> + *\n> + * @CDN_MODE_FAST: Fast (but lower quality) colour denoise\n> + * algorithm, typically used for video recording.\n> + * @CDN_HIGH_QUALITY: High quality (but slower) colour denoise\n> + * algorithm, typically used for stills capture.\n> + */\n> +enum bcm2835_isp_cdn_mode {\n> + CDN_MODE_FAST = 0,\n> + CDN_MODE_HIGH_QUALITY = 1,\n> +};\n> +\n> +/**\n> + * struct bcm2835_isp_cdn - Colour denoise parameters set with the\n> + * V4L2_CID_USER_BCM2835_ISP_CDN ctrl.\n> + *\n> + * @enabled: Enable colour denoise.\n> + * @cdn_mode: Colour denoise operating mode (see enum &bcm2835_isp_cdn_mode)\n> + */\n> +struct bcm2835_isp_cdn {\n> + __u32 enabled;\n> + __u32 mode;\n> +};\n> +\n> /**\n> * struct bcm2835_isp_denoise - Denoise parameters set with the\n> * V4L2_CID_USER_BCM2835_ISP_DENOISE ctrl.\n> --\n> 2.25.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F1C49C0F2A\n\tfor ;\n\tFri, 22 Jan 2021 10:55:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 82B286823D;\n\tFri, 22 Jan 2021 11:55:41 +0100 (CET)","from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com\n\t[IPv6:2607:f8b0:4864:20::22b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 113EA68232\n\tfor ;\n\tFri, 22 Jan 2021 11:55:40 +0100 (CET)","by mail-oi1-x22b.google.com with SMTP id h6so4164251oie.5\n\tfor ;\n\tFri, 22 Jan 2021 02:55:39 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"pax6GODa\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=RcU7/5KuFpyvqdHPbKiwqNhdag+NA37jr46vc/M2YHU=;\n\tb=pax6GODaRkoZ/51LFUs2DqXHGRaurYZpEKfz0hnP/ZzMobDEnpiEJpwQHjo9XJChFc\n\t5/aDtDNNUHQ96KEJLLVdoi8mO0etdUE995mVQUa/473sQldciOW5ZbDENXA/cyvPj1kO\n\t18pRwbsPmzFOh6DJG5ruNIr6v9YtlwdPW66Oz3UTN/kMv3RPliDLAe7vwe6SLRJFBeJr\n\tzs+T7YaDdE0X1FSDD0BLlzmMWidtLdtiK9OZFWytpHZlQzSVEQ8qLKghiNj5T2yHT3tA\n\tXZweuXsbARSEM7JSmSqKxrl3eleTzBJ9fNQ2dXMXC4ycam6DdRY0muCpQr30ynkiY+hc\n\tAC9Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=RcU7/5KuFpyvqdHPbKiwqNhdag+NA37jr46vc/M2YHU=;\n\tb=AHWhiJb8ragy7OB567NV3SjMC74VD14ohuXGdN8SZgC9drgx+OVJccYCpShsH8dhoa\n\tBXyxET+POjLc50+da1pj2s8zg/OlimyP1Ej9z7PLmkpmJHbKJPAWiZJm+THhHpEEL6Kg\n\tK5XXV5y79JVuu758QhXXVw/khy1SYL78xbua81gqYH07RXHIhzxayez7g7z9zI+ZBTYA\n\t4iH5289vGx+5niw4eT61y/0qaato9CZ7H7ElB0a30eQlhX/6dbu/lM3lS8lQpgB11LUq\n\tBNIkec6ILm1p4QmsIg7yBAQ08vFcCLxFGftiayYH5XU2Rr2P2Whvk5iMiFT/DIBKdkDB\n\tC2Tg==","X-Gm-Message-State":"AOAM531dA6xakGcgMgslGLEfELH2dD5Zq2rMh7TwGvZSYS1mQN1+AW4X\n\tKAX7/7cohWMYP/6xWrIvAj4eonkwoL6PttZQB4PbBQ==","X-Google-Smtp-Source":"ABdhPJwqvK24a6+KbX2XSgmtPpwWZ4KG6y221xPMwjhRIujEYjuCmjzzWPZr7izS6dC4PDOJrb0JUe6KXVXbsrI86Uo=","X-Received":"by 2002:aca:5c0a:: with SMTP id q10mr2865301oib.55.1611312938888;\n\tFri, 22 Jan 2021 02:55:38 -0800 (PST)","MIME-Version":"1.0","References":"<20210122092537.708375-1-naush@raspberrypi.com>\n\t<20210122092537.708375-4-naush@raspberrypi.com>","In-Reply-To":"<20210122092537.708375-4-naush@raspberrypi.com>","From":"David Plowman ","Date":"Fri, 22 Jan 2021 10:55:28 +0000","Message-ID":"","To":"Naushir Patuck ","Subject":"Re: [libcamera-devel] [PATCH v2 3/6] uapi: raspberrypi: Update the\n\tbcm2835-isp header definition","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"libcamera devel ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]